[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/16393

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 300e055ab6e3ede51de2258c83d9aeab4b7f3701
Blamelist: Anders Broman ,Michael Mann 


BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 30f7434: Squelch some 64-bit-to-32-bit-shortening warnings.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30f743496ea11c63bf0a9b2200a404d9902c6ac4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

30f7434 by Guy Harris (g...@alum.mit.edu):

Squelch some 64-bit-to-32-bit-shortening warnings.

Change-Id: I64f833abd11d3b2511c235bb353cb5fb7b813b7f
Reviewed-on: https://code.wireshark.org/review/16085
Reviewed-by: Guy Harris 


Actions performed:

from  300e055   Qt: Use queued signals+slots for filter actions
adds  30f7434   Squelch some 64-bit-to-32-bit-shortening warnings.


Summary of changes:
 epan/dissectors/packet-http.c |   12 
 1 file changed, 8 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/11307

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] bcae998048190ce70ae9d0cbc05dc61e9e66c3b4
Blamelist: Michael Mann 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 300e055: Qt: Use queued signals+slots for filter actions

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=300e055ab6e3ede51de2258c83d9aeab4b7f3701
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

300e055 by Gerald Combs (ger...@wireshark.org):

Qt: Use queued signals+slots for filter actions

Many of our dialogs can send an "apply this display filter" signal to
the main window. Applying a display filter in turn creates a nested
event loop via cf_read+update_progress_dlg. If the "apply" signal+slot
is directly connected (which is the default, and which means we're
calling into a function table) we can close the dialog while the signal
is firing, which means we return into a deleted object.

Make all of the filterAction signals+slots queued instead of direct.

Bug: 12523
Change-Id: Ica331054c0aa52a7f33bd8df1fa65ecd09fdc292
Reviewed-on: https://code.wireshark.org/review/16080
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  933c079   HTTP: Split URI into path and query. Tokenize parameters.
adds  300e055   Qt: Use queued signals+slots for filter actions


Summary of changes:
 ui/qt/conversation_dialog.cpp |8 
 ui/qt/conversation_dialog.h   |2 +-
 ui/qt/endpoint_dialog.cpp |8 
 ui/qt/expert_info_dialog.h|2 +-
 ui/qt/main_window.cpp |6 ++
 ui/qt/main_window.h   |3 ++-
 ui/qt/main_window_slots.cpp   |   41 +++--
 ui/qt/protocol_hierarchy_dialog.h |2 +-
 ui/qt/tap_parameter_dialog.h  |2 +-
 ui/qt/traffic_table_dialog.h  |4 ++--
 10 files changed, 43 insertions(+), 35 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 7a711e5: Qt: Fix crash in Conversations and Endpoints dialogs

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a711e5c628e19ac8ff4533248c432d005c39969
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

7a711e5 by Gerald Combs (ger...@wireshark.org):

Qt: Fix crash in Conversations and Endpoints dialogs

Don't assume that conv_item_t or hostlist_talker_t pointers never
change. GArrays can reallocate their data, and in our case this can
happen when we have more than 10,000 items (which is the size that the
conversation table code passes to_array_sized_new).

Bug: 12288
Change-Id: I88e58be830e35dde272f81fe9250b054fb87facf
Reviewed-on: https://code.wireshark.org/review/16078
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit f9cf660e6e4fc0e52e6ed7c14ebec4532586eb5e)
Reviewed-on: https://code.wireshark.org/review/16082
Petri-Dish: Michael Mann 
Reviewed-by: Anders Broman 


Actions performed:

from  bbed186   Qt: Clear the packet list selection before freezing it.
adds  7a711e5   Qt: Fix crash in Conversations and Endpoints dialogs


Summary of changes:
 ui/qt/conversation_dialog.cpp |   56 ++---
 ui/qt/endpoint_dialog.cpp |   55 
 2 files changed, 58 insertions(+), 53 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 933c079: HTTP: Split URI into path and query. Tokenize parameters.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=933c079598079e1786b07cda5e1b48684ca0ac3c
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

933c079 by Uli Heilmeier (u...@heilmeier.eu):

HTTP: Split URI into path and query. Tokenize parameters.

Split a HTTP URI into path and query.
Tokenize the parameters of a query.

Bug: 12514
Change-Id: I9892914eba9737c9751936ce62e63497aba61c61
Reviewed-on: https://code.wireshark.org/review/15971
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  fea6e73   RTP player: increase the maximum number of silence frames 
to 30 minutes worth.
adds  933c079   HTTP: Split URI into path and query. Tokenize parameters.


Summary of changes:
 epan/dissectors/packet-http.c |   43 ++---
 1 file changed, 40 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fea6e73: RTP player: increase the maximum number of silence frames to 30 minutes worth.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fea6e738bb843eea7667873b7fc3c7f35ae2b32a
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

fea6e73 by Jeff Morriss (jeff.morriss...@gmail.com):

RTP player: increase the maximum number of silence frames to 30 minutes 
worth.

The BadAlloc X11 crash I reported in bug 4119 (which is why the limit was as
low as it was) has long since been fixed thanks to
bug 2630/I71e1bd2f9a62792db06ce887e2bbe7a96d110e0a so we can now deal with
more silence frames.

Change-Id: I0127381e71e497560e0f23af04f9d96af1ed6335
Ping-Bug: 5902
Ping-Bug: 4119
Ping-Bug: 2270
Reviewed-on: https://code.wireshark.org/review/16003
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  bcae998   Qt: Support the -j, -J, and -l command line flags
adds  fea6e73   RTP player: increase the maximum number of silence frames 
to 30 minutes worth.


Summary of changes:
 ui/gtk/rtp_player.c|1 -
 ui/qt/rtp_audio_stream.cpp |2 +-
 ui/rtp_stream.h|2 ++
 3 files changed, 3 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bcae998: Qt: Support the -j, -J, and -l command line flags

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bcae998048190ce70ae9d0cbc05dc61e9e66c3b4
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

bcae998 by Gerald Combs (ger...@wireshark.org):

Qt: Support the -j, -J, and -l command line flags

Add support for -j, -J, and -l. Mark the -m flag deprecated.

Bug: 12546
Change-Id: Ic44b3997840018e5d571aa1813a1646bce11d4a6
Reviewed-on: https://code.wireshark.org/review/16083
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  18a900f   Editcap: Fix setting of max_packet_number
adds  bcae998   Qt: Support the -j, -J, and -l command line flags


Summary of changes:
 doc/wireshark.pod.template  |   10 ++
 ui/commandline.c|2 +-
 ui/preference_utils.h   |2 +-
 ui/qt/main_window.cpp   |4 ++--
 ui/qt/main_window_slots.cpp |1 +
 wireshark-qt.cpp|   16 
 6 files changed, 27 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 18a900f: Editcap: Fix setting of max_packet_number

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=18a900f19126dead1f039c699b5e48b1c5fd2efd
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

18a900f by John A. Thacker (johnthac...@gmail.com):

Editcap: Fix setting of max_packet_number

editcap -r only sets max_packet_number to the earliest, instead of latest,
packet or end of range selection. This changes it to the proper test.

Bug: 12547
Change-Id: I81772962b00fc6566ccead4fb44c6626a47fff31
Reviewed-on: https://code.wireshark.org/review/16045
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  63027fc   Windows: rename wiretap-${PROJECT_VERSION}.dll to 
libwiretap.dll
adds  18a900f   Editcap: Fix setting of max_packet_number


Summary of changes:
 editcap.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/965

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 63027fce6e11e645865607cf4124eb8cfb4c3609
Blamelist: Michael Mann 

BUILD FAILED: failed compile_4 verify signatures

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 63027fc: Windows: rename wiretap-${PROJECT_VERSION}.dll to libwiretap.dll

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63027fce6e11e645865607cf4124eb8cfb4c3609
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

63027fc by Pascal Quantin (pascal.quan...@gmail.com):

Windows: rename wiretap-${PROJECT_VERSION}.dll to libwiretap.dll

This aligns the name with what is done for other Wireshark shared libraries.
Moreover it allows to compile a wiretap plugin once per major release, 
without
the need to recompile it each time ${PROJECT_VERSION} changes (each nightly
build / official release).

Change-Id: I53c82277223a4f323079cf695168ac85c2fba523
Reviewed-on: https://code.wireshark.org/review/16058
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  a9a306f   Don't close Wireshark (GTK) if user cancels Save on Close.
adds  63027fc   Windows: rename wiretap-${PROJECT_VERSION}.dll to 
libwiretap.dll


Summary of changes:
 image/wiretap.rc.in   |2 +-
 packaging/nsis/CMakeLists.txt |2 --
 packaging/nsis/config.nsh.in  |1 -
 packaging/nsis/wireshark.nsi  |2 +-
 packaging/wix/CMakeLists.txt  |3 ---
 packaging/wix/ComponentGroups.wxi |2 +-
 wiretap/CMakeLists.txt|4 +---
 7 files changed, 4 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a9a306f: Don't close Wireshark (GTK) if user cancels Save on Close.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9a306f0a1fa09cb3f5e72f17524885cd5bf6d95
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

a9a306f by Michael Mann (mman...@netscape.net):

Don't close Wireshark (GTK) if user cancels Save on Close.

Bug: 9635
Change-Id: I4a6e3ca676f1c1096521c0a8147a1459777c92fa
Reviewed-on: https://code.wireshark.org/review/16075
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  92ea291   Don't close Wireshark (Qt) if user cancels Save on Close.
adds  a9a306f   Don't close Wireshark (GTK) if user cancels Save on Close.


Summary of changes:
 ui/gtk/capture_file_dlg.c |   31 ++-
 1 file changed, 18 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 92ea291: Don't close Wireshark (Qt) if user cancels Save on Close.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=92ea29128fe562ebb0b71aeb9d6b9f954dbeb7f0
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

92ea291 by Michael Mann (mman...@netscape.net):

Don't close Wireshark (Qt) if user cancels Save on Close.

Bug: 9635
Change-Id: I8c73c839419cd4bcb850824ffb42bf72eed50b19
Reviewed-on: https://code.wireshark.org/review/16076
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  d9fb7f9   Handle ENAMETOOLONG.
adds  92ea291   Don't close Wireshark (Qt) if user cancels Save on Close.


Summary of changes:
 ui/qt/main_window.cpp |   30 --
 ui/qt/main_window.h   |4 ++--
 2 files changed, 18 insertions(+), 16 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d9fb7f9: Handle ENAMETOOLONG.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d9fb7f9a5e2c08a5323ee7ed88956a0ccf62c634
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

d9fb7f9 by Gerald Combs (ger...@wireshark.org):

Handle ENAMETOOLONG.

g_strerror doesn't appear to handle ENAMETOOLONG. Check for it ourselves.

Change-Id: Icd113a81e8d95bb3c84c91bb420a1a6a19bf5d40
Reviewed-on: https://code.wireshark.org/review/16041
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 
Reviewed-by: Michael Mann 


Actions performed:

from  be303c2   No GeoIP, no need for geoip_none_.
adds  d9fb7f9   Handle ENAMETOOLONG.


Summary of changes:
 wsutil/filesystem.c |8 
 1 file changed, 8 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master be303c2: No GeoIP, no need for geoip_none_.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be303c20e5144756341c564b97b1f3fcd308
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

be303c2 by Guy Harris (g...@alum.mit.edu):

No GeoIP, no need for geoip_none_.

Change-Id: I6fb328d07718d2ff7a7d6008c936b7478ea6db3f
Reviewed-on: https://code.wireshark.org/review/16084
Reviewed-by: Guy Harris 


Actions performed:

from  f9cf660   Qt: Fix crash in Conversations and Endpoints dialogs
adds  be303c2   No GeoIP, no need for geoip_none_.


Summary of changes:
 ui/qt/endpoint_dialog.cpp |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/11303

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] f9cf660e6e4fc0e52e6ed7c14ebec4532586eb5e
Blamelist: Michael Mann 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f9cf660: Qt: Fix crash in Conversations and Endpoints dialogs

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9cf660e6e4fc0e52e6ed7c14ebec4532586eb5e
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

f9cf660 by Gerald Combs (ger...@wireshark.org):

Qt: Fix crash in Conversations and Endpoints dialogs

Don't assume that conv_item_t or hostlist_talker_t pointers never
change. GArrays can reallocate their data, and in our case this can
happen when we have more than 10,000 items (which is the size that the
conversation table code passes to_array_sized_new).

Bug: 12288
Change-Id: I88e58be830e35dde272f81fe9250b054fb87facf
Reviewed-on: https://code.wireshark.org/review/16078
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  692e2b6   SSH: Fix Dead Store (Dead assignement/Dead increment) 
Warning found by Clang
adds  f9cf660   Qt: Fix crash in Conversations and Endpoints dialogs


Summary of changes:
 ui/qt/conversation_dialog.cpp |   56 ++---
 ui/qt/endpoint_dialog.cpp |   55 
 2 files changed, 58 insertions(+), 53 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 692e2b6: SSH: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=692e2b65e6fe42754b58c8020b3b4e48ed739877
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

692e2b6 by Alexis La Goutte (alexis.lagou...@gmail.com):

SSH: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

Change-Id: If084278acfeb82ae7c91aefff9035f156e8f4f15
Reviewed-on: https://code.wireshark.org/review/16079
Petri-Dish: Alexis La Goutte 
Reviewed-by: Kenny Root 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  e82d0ae   Qt: Make the syntax line edit less greedy.
adds  692e2b6   SSH: Fix Dead Store (Dead assignement/Dead increment) 
Warning found by Clang


Summary of changes:
 epan/dissectors/packet-ssh.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 bbed186: Qt: Clear the packet list selection before freezing it.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bbed18623328ec8fcf6be7254d36d6525737a8d8
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

bbed186 by Gerald Combs (ger...@wireshark.org):

Qt: Clear the packet list selection before freezing it.

Call selectionModel()->clear() before removing our model. This will
hopefully make sure we don't end up with an invalid selection in
selectionChanged().

Clear the selection model before clearing the model while we're here.

Change-Id: I1007eeaa480afa0fb31dafc15a49ca6c247b30c8
Reviewed-on: https://code.wireshark.org/review/16062
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Kenny Root 
Reviewed-by: Anders Broman 
(cherry picked from commit c664f72f36ed1ac4e50c020cd3afb1ccf55094c8)
Reviewed-on: https://code.wireshark.org/review/16074
Petri-Dish: Michael Mann 


Actions performed:

from  ea60c82   Qt: Make the syntax line edit less greedy.
adds  bbed186   Qt: Clear the packet list selection before freezing it.


Summary of changes:
 ui/qt/packet_list.cpp |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 ea60c82: Qt: Make the syntax line edit less greedy.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea60c8207063b9b81883ff8750bd98084497d6a2
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

ea60c82 by Gerald Combs (ger...@wireshark.org):

Qt: Make the syntax line edit less greedy.

In SyntaxLineEdit::event, only grab ShortcutOverride events that have
Ctrl+Alt modifiers. When the main window display filter edit has focus
this should let us use text editing shortcuts and most main window
shorcuts as appropriate. "Most" means everything except for time display
formats. We might want to use something other than Ctrl+Alt for their
modifiers.

Bug: 12533
Ping-Bug: 12270
Change-Id: I61eb86b80b4237e6907d5e50262b8f5c291b27a7
Reviewed-on: https://code.wireshark.org/review/16065
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Jeff Morriss 
Reviewed-by: Michael Mann 
(cherry picked from commit e82d0aedec534606b53abf76a4c56781c5c1f83d)
Reviewed-on: https://code.wireshark.org/review/16077
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 


Actions performed:

from  2a5c4b6   NSIS: Pass /install to vcredist_xNN.exe.
adds  ea60c82   Qt: Make the syntax line edit less greedy.


Summary of changes:
 ui/qt/syntax_line_edit.cpp |   35 +++
 1 file changed, 27 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e82d0ae: Qt: Make the syntax line edit less greedy.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e82d0aedec534606b53abf76a4c56781c5c1f83d
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

e82d0ae by Gerald Combs (ger...@wireshark.org):

Qt: Make the syntax line edit less greedy.

In SyntaxLineEdit::event, only grab ShortcutOverride events that have
Ctrl+Alt modifiers. When the main window display filter edit has focus
this should let us use text editing shortcuts and most main window
shorcuts as appropriate. "Most" means everything except for time display
formats. We might want to use something other than Ctrl+Alt for their
modifiers.

Bug: 12533
Ping-Bug: 12270
Change-Id: I61eb86b80b4237e6907d5e50262b8f5c291b27a7
Reviewed-on: https://code.wireshark.org/review/16065
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Jeff Morriss 
Reviewed-by: Michael Mann 


Actions performed:

from  d46daa1   GTK: Keep display filter applied when switching profiles
adds  e82d0ae   Qt: Make the syntax line edit less greedy.


Summary of changes:
 ui/qt/syntax_line_edit.cpp |   35 +++
 1 file changed, 27 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 2a5c4b6: NSIS: Pass /install to vcredist_xNN.exe.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a5c4b664ccc08b3157cbe9fdd5f3cc61cea3fa0
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

2a5c4b6 by Gerald Combs (ger...@wireshark.org):

NSIS: Pass /install to vcredist_xNN.exe.

Explicitly pass /install to the Visual C++ redistributable installer. A
few people have reported issues with missing or incorrect redistributable
files after installing Wireshark but unfortunately haven't provided
much in the way of further detail. Is it possible that the installer
sometimes goes into /repair, /layout, or /uninstall modes?

Remove checks for old, unsupported compilers while we're here.

Change-Id: I4e24dbe562c8aeb6ce63ec98ea1601cba5256806
Reviewed-on: https://code.wireshark.org/review/15120
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Reviewed-by: Graham Bloice 
(cherry picked from commit fc216521850fd5af5bf58ae5e3a90a634d087794)
Reviewed-on: https://code.wireshark.org/review/16072
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 


Actions performed:

from  9458557   Check for negative nanoseconds in io,stat tap.
adds  2a5c4b6   NSIS: Pass /install to vcredist_xNN.exe.


Summary of changes:
 packaging/nsis/wireshark.nsi |8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d46daa1: GTK: Keep display filter applied when switching profiles

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d46daa1177bfd58a7fed7ecc59ee5b0b54c26a3a
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d46daa1 by Balint Reczey (bal...@balintreczey.hu):

GTK: Keep display filter applied when switching profiles

Bug: 6130
Change-Id: I3bcd6aaad33482474e3429e0dcc074973a338fca
Reviewed-on: https://code.wireshark.org/review/15992
Petri-Dish: Balint Reczey 
Tested-by: Balint Reczey 
Reviewed-by: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  0bf1cb2   Add address_to_bytes API.
adds  d46daa1   GTK: Keep display filter applied when switching profiles


Summary of changes:
 ui/gtk/macros_dlg.c |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0bf1cb2: Add address_to_bytes API.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0bf1cb2342e5becdda56be41f0347068549a77fe
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

0bf1cb2 by Michael Mann (mman...@netscape.net):

Add address_to_bytes API.

This will copy an address's "byte format" into a buffer.  The original
intended design is for export_pdu functionality, which tries to do
this "manually" for many address types (and creates undesired dependencies)

The default functionality if a "byte format function" isn't provided
(currently the case for all address types) is a memcpy of the address
data.  Providing "address to byte" functions to aid export PDU
functionality will be provided later.

Change-Id: I3703f9e617a8cef09165ad53a0f98c6372676b9b
Reviewed-on: https://code.wireshark.org/review/16070
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  c664f72   Qt: Clear the packet list selection before freezing it.
adds  0bf1cb2   Add address_to_bytes API.


Summary of changes:
 debian/libwireshark0.symbols|1 +
 epan/address.h  |2 ++
 epan/address_types.c|   44 +--
 epan/address_types.h|3 ++-
 epan/dissectors/packet-arcnet.c |2 +-
 epan/dissectors/packet-atalk.c  |2 +-
 epan/dissectors/packet-devicenet.c  |2 +-
 epan/dissectors/packet-ieee80211.c  |4 ++--
 epan/dissectors/packet-ieee802154.c |2 +-
 epan/dissectors/packet-j1939.c  |2 +-
 epan/dissectors/packet-jxta.c   |2 +-
 epan/dissectors/packet-mp2t.c   |2 +-
 epan/dissectors/packet-mstp.c   |2 +-
 epan/dissectors/packet-mtp3.c   |2 +-
 epan/dissectors/packet-sna.c|2 +-
 epan/dissectors/packet-tipc.c   |2 +-
 epan/dissectors/packet-usb.c|2 +-
 epan/dissectors/packet-vines.c  |2 +-
 epan/osi-utils.c|2 +-
 plugins/irda/packet-irda.c  |2 +-
 20 files changed, 64 insertions(+), 20 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe