[Wireshark-commits] master ee6c1f5: OSPF: Differentiate meaning of N/P bit in NSSA LSA type 7

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee6c1f5d29d6eef80a55222f829c14a2421d1715
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ee6c1f5 by Jaap Keuter (jaap.keu...@xs4all.nl):

OSPF: Differentiate meaning of N/P bit in NSSA LSA type 7

In OSPF v2 the N/P bit in NSSA LSA type 7 messages has to be
interpreted as P-bit (RFC 3101) instead of N-bit. This change
makes it so.

Bug: 12555
Change-Id: I1d4a8978ca42d0472d5967528e72cbfada87b799
Reviewed-on: https://code.wireshark.org/review/16174
Reviewed-by: Alexis La Goutte 


Actions performed:

from  f0e6764   Global, not static.
adds  ee6c1f5   OSPF: Differentiate meaning of N/P bit in NSSA LSA type 7


Summary of changes:
 epan/dissectors/packet-ospf.c |   31 ++-
 1 file changed, 26 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f0e6764: Global, not static.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0e676496d00283242854d4e5d1f3ef852f872ce
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

f0e6764 by Guy Harris (g...@alum.mit.edu):

Global, not static.

Change-Id: I185a1786365f185f18f3ec492a8ef165d61595ed
Reviewed-on: https://code.wireshark.org/review/16185
Reviewed-by: Guy Harris 


Actions performed:

from  3ebac2b   Have commandline_other_options() directly fill in the 
global structure.
adds  f0e6764   Global, not static.


Summary of changes:
 ui/commandline.c |2 ++
 ui/commandline.h |2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3ebac2b: Have commandline_other_options() directly fill in the global structure.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ebac2babbd9af1593b86084214051c4c2da8eb2
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

3ebac2b by Guy Harris (g...@alum.mit.edu):

Have commandline_other_options() directly fill in the global structure.

Other code looks at the global structure, so there won't be other
structures; just fill in the global structure directly.

Change-Id: I4dc87b79168c5a7c9ab1f085aa2d78cc6d2c9019
Reviewed-on: https://code.wireshark.org/review/16184
Reviewed-by: Guy Harris 


Actions performed:

from  ac4ad2b   Don't set quit_after_cap if no pcap, as it's not present.
adds  3ebac2b   Have commandline_other_options() directly fill in the 
global structure.


Summary of changes:
 ui/commandline.c |   64 +++---
 ui/commandline.h |2 +-
 ui/gtk/main.c|2 +-
 wireshark-qt.cpp |2 +-
 4 files changed, 35 insertions(+), 35 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ac4ad2b: Don't set quit_after_cap if no pcap, as it's not present.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac4ad2bd44f2b8f6981581c683d15645bf2e70cc
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

ac4ad2b by Guy Harris (g...@alum.mit.edu):

Don't set quit_after_cap if no pcap, as it's not present.

Change-Id: I871f75394ba66967d7d7be203bd9e235575458e1
Reviewed-on: https://code.wireshark.org/review/16183
Reviewed-by: Guy Harris 


Actions performed:

from  5d019cf   Make quit_after_cap an item in commandline_param_info_t.
adds  ac4ad2b   Don't set quit_after_cap if no pcap, as it's not present.


Summary of changes:
 ui/commandline.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5d019cf: Make quit_after_cap an item in commandline_param_info_t.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5d019cfb13a75663f5fde39163650884208e5791
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

5d019cf by Guy Harris (g...@alum.mit.edu):

Make quit_after_cap an item in commandline_param_info_t.

And make the commandline_info structure global, so all the places that
look at quit_after_cap can get at it.

Change-Id: I006329cf8842c655cca36f024570855d1b16e107
Reviewed-on: https://code.wireshark.org/review/16182
Reviewed-by: Guy Harris 


Actions performed:

from  3f49e89   Pull quit_after_cap out of the global capture options.
adds  5d019cf   Make quit_after_cap an item in commandline_param_info_t.


Summary of changes:
 ui/commandline.c|5 +--
 ui/commandline.h|5 +--
 ui/gtk/main.c   |   91 +--
 ui/qt/main_window.cpp   |4 +-
 ui/qt/main_window_slots.cpp |   10 +++--
 wireshark-qt.cpp|   55 +-
 6 files changed, 84 insertions(+), 86 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

2016-06-27 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/16428

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 3f49e897f674008c27de9833b8ba2d119dc22ef4
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64

2016-06-27 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 14.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2014.04%20x64/builds/6628

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-14.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 3f49e897f674008c27de9833b8ba2d119dc22ef4
Blamelist: Guy Harris 

BUILD FAILED: failed compile

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-06-27 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/11345

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 3f49e897f674008c27de9833b8ba2d119dc22ef4
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-06-27 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/1007

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 3f49e897f674008c27de9833b8ba2d119dc22ef4
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3f49e89: Pull quit_after_cap out of the global capture options.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f49e897f674008c27de9833b8ba2d119dc22ef4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

3f49e89 by Guy Harris (g...@alum.mit.edu):

Pull quit_after_cap out of the global capture options.

Really, all the GUI-related options should be pulled out, so they're not
cluttering up dumpcap and tshark.

Change-Id: I0276dee2be48bae3498a819d8c0c2747fe1352e7
Reviewed-on: https://code.wireshark.org/review/16180
Reviewed-by: Guy Harris 


Actions performed:

from  72d9785   We need global_capture_opts if we have extcap, even without 
pcap.
adds  3f49e89   Pull quit_after_cap out of the global capture options.


Summary of changes:
 capture_opts.c  |2 --
 capture_opts.h  |1 -
 ui/commandline.c|4 
 ui/commandline.h|4 
 ui/gtk/main.c   |6 +++---
 ui/qt/main_welcome.cpp  |7 +++
 ui/qt/main_window.cpp   |4 +++-
 ui/qt/main_window_slots.cpp |   12 
 8 files changed, 29 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 72d9785: We need global_capture_opts if we have extcap, even without pcap.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=72d9785cfc0d1d7e2eeebc05997d0efcec5dfa7f
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

72d9785 by Guy Harris (g...@alum.mit.edu):

We need global_capture_opts if we have extcap, even without pcap.

Change-Id: I16b778064c1cd2bbf281fb5192bf35da252e99dd
Reviewed-on: https://code.wireshark.org/review/16179
Reviewed-by: Guy Harris 


Actions performed:

from  9b91e64   test: ensure temporary directory outside source tree
adds  72d9785   We need global_capture_opts if we have extcap, even without 
pcap.


Summary of changes:
 ui/commandline.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-06-27 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/11343

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 9b91e64fee7dfdbeef3d8602a8af6c8d0d8a788c
Blamelist: Peter Wu 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9b91e64: test: ensure temporary directory outside source tree

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b91e64fee7dfdbeef3d8602a8af6c8d0d8a788c
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

9b91e64 by Peter Wu (pe...@lekensteyn.nl):

test: ensure temporary directory outside source tree

The whole point of using mktemp is to get a temporary directory outside
the source tree. Commit v2.1.0rc0-1027-ge01f8fb tried to fix the
invocation for *BSD (including OS X), but by adding a template it
dropped the implicit --tmpdir option for GNU mktemp on Linux..

Use the GNU mktemp invocation and if it fails (for example, because a
template is expected for BSD/OS X), provide a template.

Change-Id: I77bbc7dc2045e4fa756e102afa080860b0857713
Reviewed-on: https://code.wireshark.org/review/16178
Reviewed-by: Peter Wu 


Actions performed:

from  e69194a   qt: fix linking error with global_capture_opts
adds  9b91e64   test: ensure temporary directory outside source tree


Summary of changes:
 test/test.sh |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e69194a: qt: fix linking error with global_capture_opts

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e69194ae6513aa0bbf2728df09ec9133ae379714
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

e69194a by Peter Wu (pe...@lekensteyn.nl):

qt: fix linking error with global_capture_opts

global_capture_opts is already defined by ui/commandline.c which is also
linked with wireshark-qt.cpp. Remove the duplicate definition to avoid a
build failure with the gold linker.

Fixes regression from v2.1.1rc0-192-g9b5b444.

Change-Id: I4484e2769bf270dee1ec0378fd9c925e01eaf390
Reviewed-on: https://code.wireshark.org/review/16175
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  4add8b6   cmake: add idl2wrs-dissectors target for DCERPC
adds  e69194a   qt: fix linking error with global_capture_opts


Summary of changes:
 wireshark-qt.cpp |4 
 1 file changed, 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4add8b6: cmake: add idl2wrs-dissectors target for DCERPC

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4add8b6b4523db8966c88d69b7f9710859ec3081
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

4add8b6 by Peter Wu (pe...@lekensteyn.nl):

cmake: add idl2wrs-dissectors target for DCERPC

Add a callable target such that dissectors can be generated without the
AUTOGEN_dcerpc option.

Modelled after the pidl CMakeLists.txt file and target. This approach
has the advantage over the previous implementation such that the clean
target does not remove the packet-dcerpc-X.c files.

Change-Id: I3226937eaa76dffa253df9d4f989421d5faa3f3f
Reviewed-on: https://code.wireshark.org/review/15989
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  b0b2540   Qt: Clean up capture file callbacks.
adds  4add8b6   cmake: add idl2wrs-dissectors target for DCERPC


Summary of changes:
 .gitignore|2 ++
 CMakeOptions.txt  |1 -
 epan/dissectors/CMakeLists.txt|   41 +--
 epan/dissectors/dcerpc/CMakeLists.txt |   58 ++---
 4 files changed, 56 insertions(+), 46 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b0b2540: Qt: Clean up capture file callbacks.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b0b2540fbaad26d282a6e335c2b800c056961514
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

b0b2540 by Gerald Combs (ger...@wireshark.org):

Qt: Clean up capture file callbacks.

Mark some callbacks GTK+ only as appropriate. Change a debug message to
an assert since we handle all callbacks.

Change-Id: I4266f0d7134d19a9c0432354ea36de67501275b4
Reviewed-on: https://code.wireshark.org/review/16171
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 


Actions performed:

from  d8ddf84   Fixed tshark pdml output.
adds  b0b2540   Qt: Clean up capture file callbacks.


Summary of changes:
 file.h |   16 
 ui/qt/capture_file.cpp |9 +
 2 files changed, 13 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d8ddf84: Fixed tshark pdml output.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d8ddf84693f335a071982aac5896f86152e91ee5
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master
Repository: wireshark

Commits:

d8ddf84 by Martin Kacer (kacer.mar...@gmail.com):

Fixed tshark pdml output.

Corrected if no protocol filter (-j) specified.

Change-Id: Id20dd255642951633efa935dbb1363e7b9aa9be0
Reviewed-on: https://code.wireshark.org/review/16164
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jaap Keuter 


Actions performed:

from  d90e6e7   There's no need to check the return from g_array_index().
adds  d8ddf84   Fixed tshark pdml output.


Summary of changes:
 epan/print.c |   33 +
 1 file changed, 13 insertions(+), 20 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d90e6e7: There's no need to check the return from g_array_index().

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d90e6e74da5e4766b95545120f259a5565071702
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master
Repository: wireshark

Commits:

d90e6e7 by Jeff Morriss (jeff.morriss...@gmail.com):

There's no need to check the return from g_array_index().

g_array_index() returns an index into an array: we're sure to find
something at that index (whether that something is in bounds is
a-whole-nother question).

This fixes CIDs 1362829 and 1362890/1362830.  There were other CIDs like
this but they've already been fixed.

Change-Id: I94af0931b9adf3abd3bedc969e399cda98bbdd07
Reviewed-on: https://code.wireshark.org/review/16168
Reviewed-by: Jaap Keuter 


Actions performed:

from  2ab4155   tvb_get_string_enc + proto_tree_add_item = 
proto_tree_add_item_ret_string
adds  d90e6e7   There's no need to check the return from g_array_index().


Summary of changes:
 ui/qt/endpoint_dialog.cpp |8 
 1 file changed, 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2ab4155: tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_string

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ab415579491e4bc66ea58627bda504cae833b9e
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2ab4155 by Michael Mann (mman...@netscape.net):

tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_string

Also some other tricks to remove unnecessary tvb_get_string_enc calls.

Change-Id: I2f40d9175b6c0bb0b1364b4089bfaa287edf0914
Reviewed-on: https://code.wireshark.org/review/16158
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
Reviewed-by: Pascal Quantin 


Actions performed:

from  8c37621   CIP: Cleanup info column for MSP packets
adds  2ab4155   tvb_get_string_enc + proto_tree_add_item = 
proto_tree_add_item_ret_string


Summary of changes:
 .../asn1/ansi_map/packet-ansi_map-template.c   |   16 +-
 epan/dissectors/asn1/c1222/packet-c1222-template.c |   10 +-
 epan/dissectors/asn1/gsm_map/gsm_map.cnf   |6 +-
 epan/dissectors/file-pcapng.c  |   51 ++--
 epan/dissectors/packet-aastra-aasp.c   |   11 +-
 epan/dissectors/packet-adb_cs.c|6 +-
 epan/dissectors/packet-alljoyn.c   |  109 +
 epan/dissectors/packet-amqp.c  |  246 ++--
 epan/dissectors/packet-ansi_map.c  |   22 +-
 epan/dissectors/packet-ar_drone.c  |7 +-
 epan/dissectors/packet-artnet.c|   35 ++-
 epan/dissectors/packet-bfd.c   |   23 +-
 epan/dissectors/packet-bitcoin.c   |9 +-
 epan/dissectors/packet-bootp.c |7 +-
 epan/dissectors/packet-btavrcp.c   |5 +-
 epan/dissectors/packet-bthcrp.c|5 +-
 epan/dissectors/packet-btsdp.c |  100 +++-
 epan/dissectors/packet-c1222.c |   16 +-
 epan/dissectors/packet-catapult-dct2000.c  |   12 +-
 epan/dissectors/packet-cell_broadcast.c|8 +-
 epan/dissectors/packet-cmpp.c  |7 +-
 epan/dissectors/packet-coap.c  |6 +-
 epan/dissectors/packet-collectd.c  |   29 ++-
 epan/dissectors/packet-dcerpc-epm.c|   18 +-
 epan/dissectors/packet-dcerpc-fileexp.c|3 +-
 epan/dissectors/packet-dcerpc-fldb.c   |   55 ++---
 epan/dissectors/packet-dcerpc-rpriv.c  |   10 +-
 epan/dissectors/packet-dcerpc-rs_acct.c|   12 +-
 epan/dissectors/packet-dcerpc-rs_misc.c|5 +-
 epan/dissectors/packet-dcerpc-rs_pgo.c |   36 ++-
 epan/dissectors/packet-dcerpc-spoolss.c|   14 +-
 epan/dissectors/packet-dcp-etsi.c  |   10 +-
 epan/dissectors/packet-dhcp-failover.c |   21 +-
 epan/dissectors/packet-diameter_3gpp.c |   16 +-
 epan/dissectors/packet-dis.c   |   10 +-
 epan/dissectors/packet-dmp.c   |5 +-
 epan/dissectors/packet-dnp.c   |9 +-
 epan/dissectors/packet-dns.c   |5 +-
 epan/dissectors/packet-dtn.c   |7 +-
 epan/dissectors/packet-dvbci.c |   29 +--
 epan/dissectors/packet-edonkey.c   |7 +-
 epan/dissectors/packet-epmd.c  |   20 +-
 epan/dissectors/packet-erldp.c |   13 +-
 epan/dissectors/packet-exported_pdu.c  |   18 +-
 epan/dissectors/packet-extreme.c   |   14 +-
 epan/dissectors/packet-foundry.c   |8 +-
 epan/dissectors/packet-gearman.c   |5 +-
 epan/dissectors/packet-gsm_a_dtap.c|4 +-
 epan/dissectors/packet-gsm_map.c   |6 +-
 epan/dissectors/packet-hpfeeds.c   |7 +-
 epan/dissectors/packet-icep.c  |   15 +-
 epan/dissectors/packet-ieee80211-prism.c   |5 +-
 epan/dissectors/packet-ieee80211.c |   41 ++--
 epan/dissectors/packet-imf.c   |   25 +-
 epan/dissectors/packet-irc.c   |   66 +++---
 epan/dissectors/packet-isakmp.c|   54 ++---
 epan/dissectors/packet-m2tp.c  |5 +-
 epan/dissectors/packet-mikey.c |   14 +-
 epan/dissectors/packet-mip6.c  |   24 +-
 epan/dissectors/packet-ms-mms.c|   34 ++-
 epan/dissectors/packet-mswsp.c |   31 ++-
 epan/dissectors/packet-mysql.c |   11 +-
 epan/dissectors/packet-netflow.c   |   12 +-
 epan/dissectors/packet-netlink-route.c

[Wireshark-commits] master 8c37621: CIP: Cleanup info column for MSP packets

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8c37621ca733a24a972e3e069a537c06e650f435
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master
Repository: wireshark

Commits:

8c37621 by D. Ulis (daul...@gmail.com):

CIP: Cleanup info column for MSP packets

1. Skip printing class name in info column when it was an MSP, since it's 
implied.
2. Don't print response status for embedded messages in info column for 
MSP. It makes the line too long.
3. Print the response status for embedded messages in the Service Packet 
tree. This makes it easier to find the packet that may have failed.

Change-Id: I2c60fb9baf113a215ada7301f493cbd51e340dcd
Reviewed-on: https://code.wireshark.org/review/16162
Reviewed-by: Anders Broman 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jaap Keuter 


Actions performed:

from  58ccf8e   endpoint dialog: fix compilation when we don't HAVE_GEOIP.
adds  8c37621   CIP: Cleanup info column for MSP packets


Summary of changes:
 epan/dissectors/packet-cip.c |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 58ccf8e: endpoint dialog: fix compilation when we don't HAVE_GEOIP.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58ccf8e6b65b3911426d08d28997089ce8d611a1
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

58ccf8e by Jeff Morriss (jeff.morriss...@gmail.com):

endpoint dialog: fix compilation when we don't HAVE_GEOIP.

Also fix some indentation and white space.
Remove a break-after-return.

Bug: 12562
Change-Id: I912ccdac62aceaabcffec8f7739da56cc6036abf
Reviewed-on: https://code.wireshark.org/review/16159
Reviewed-by: Pascal Quantin 


Actions performed:

from  010f5bb   LTP: fix indent
adds  58ccf8e   endpoint dialog: fix compilation when we don't HAVE_GEOIP.


Summary of changes:
 ui/qt/endpoint_dialog.cpp |   10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 010f5bb: LTP: fix indent

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=010f5bba636a81db2c0a4ab5a500c7f23e689fde
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

010f5bb by Alexis La Goutte (alexis.lagou...@gmail.com):

LTP: fix indent

replace space by tab

Change-Id: I52d5fefbf795fe6ee2dbdeda087c49280ba47503
Reviewed-on: https://code.wireshark.org/review/16166
Petri-Dish: Alexis La Goutte 
Reviewed-by: Anders Broman 


Actions performed:

from  af26f31   DOCSIS: Fix unknown TLVs in UCD type29 caused parsing 
errors + bugfixes
adds  010f5bb   LTP: fix indent


Summary of changes:
 epan/dissectors/packet-ltp.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 b354ac7: Qt: Handle unhandled filter actions.

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b354ac734e5fb2f3c676fc6c0d1da05a37f11162
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

b354ac7 by Gerald Combs (ger...@wireshark.org):

Qt: Handle unhandled filter actions.

Handle FilterAction::ActionColorize and ::ActionFind. Remove
::ActionConversation since it was unused. Assert when we encounter a
missing FilterAction, similar to what we do in other parts of the code.

Bug: 12363
Change-Id: I5c1ecd488e5bdb9700a80fc70ec7c047311054b6
Reviewed-on: https://code.wireshark.org/review/16131
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 
(cherry picked from commit 60cdee9e307c15928a542adc547f27fd752c4837)
Reviewed-on: https://code.wireshark.org/review/16147
Petri-Dish: Michael Mann 


Actions performed:

from  9971717   radiotap: Fix for the VHT 20MHz MCS 9 data rate not 
displayed
adds  b354ac7   Qt: Handle unhandled filter actions.


Summary of changes:
 ui/qt/filter_action.cpp |5 -
 ui/qt/filter_action.h   |9 -
 ui/qt/main_window.cpp   |8 
 ui/qt/main_window.h |3 ++-
 ui/qt/main_window_slots.cpp |   22 --
 ui/qt/protocol_hierarchy_dialog.cpp |1 +
 ui/qt/search_frame.cpp  |2 ++
 7 files changed, 29 insertions(+), 21 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master af26f31: DOCSIS: Fix unknown TLVs in UCD type29 caused parsing errors + bugfixes

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=af26f31a638264c6450451ce4211a4b5a1b56835
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

af26f31 by Bruno Verstuyft (bruno.verstu...@excentis.com):

DOCSIS: Fix unknown TLVs in UCD type29 caused parsing errors + bugfixes

Change-Id: I9ab56ded7ebf9f087afceed979e451e369eaf1d6
Reviewed-on: https://code.wireshark.org/review/15967
Reviewed-by: Alexis La Goutte 
Tested-by: Alexis La Goutte 
Reviewed-by: Anders Broman 


Actions performed:

from  03adf58   Remove author comments and some accompanying useless code 
comments
adds  af26f31   DOCSIS: Fix unknown TLVs in UCD type29 caused parsing 
errors + bugfixes


Summary of changes:
 plugins/docsis/packet-type29ucd.c |  543 +++--
 1 file changed, 272 insertions(+), 271 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 03adf58: Remove author comments and some accompanying useless code comments

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=03adf586911b315004b00e05addc32bfdf052b80
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

03adf58 by Joerg Mayer (jma...@loplof.de):

Remove author comments and some accompanying useless code comments

This only removes author's names that appear in the AUTHORS* files.
In those cases where a group of people get mentioned, this patch does
not remove any in case at least one name is not found in AUTHORS*

Change-Id: I2259dbda3d4a1250bdc103f3fc5be93df5482489
Reviewed-on: https://code.wireshark.org/review/16154
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  ff9e62a   autotools: Qt 5.7 requires C++11
adds  03adf58   Remove author comments and some accompanying useless code 
comments


Summary of changes:
 epan/dissectors/packet-ieee80211.c |   64 ++--
 1 file changed, 3 insertions(+), 61 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ff9e62a: autotools: Qt 5.7 requires C++11

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff9e62a30b43b1dbe940d623ab8c6b39283bf4b1
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ff9e62a by João Valverde (joao.valve...@tecnico.ulisboa.pt):

autotools: Qt 5.7 requires C++11

Change-Id: Icad622a052a84862ace98a7000f10ccf677f54a5
Reviewed-on: https://code.wireshark.org/review/16138
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  fbb23e2   s7comm: Sinumerik NC file transfer
adds  ff9e62a   autotools: Qt 5.7 requires C++11


Summary of changes:
 acinclude.m4|8 +
 configure.ac|   16 +-
 m4/ax_cxx_compile_stdcxx.m4 |  562 +++
 3 files changed, 578 insertions(+), 8 deletions(-)
 create mode 100644 m4/ax_cxx_compile_stdcxx.m4
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fbb23e2: s7comm: Sinumerik NC file transfer

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fbb23e27dddbc2f05a749df2cd07e5d8dd8335ee
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

fbb23e2 by Thomas Wiens (th.wi...@gmx.de):

s7comm: Sinumerik NC file transfer

Added decoding of up-/downloading files from/to a Sinumerik NC CNC control
machine.

Change-Id: If7939e56e972fc2b8feb12150c4184a880b0cdae
Reviewed-on: https://code.wireshark.org/review/16129
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  76ae2d9   AUTHORS: fix duplicate / wrong name entry
adds  fbb23e2   s7comm: Sinumerik NC file transfer


Summary of changes:
 epan/dissectors/packet-s7comm.c |  118 ++-
 1 file changed, 117 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 76ae2d9: AUTHORS: fix duplicate / wrong name entry

2016-06-27 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76ae2d9721b870937a92c97328f6f316ebac5f13
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

76ae2d9 by Alexis La Goutte (alexis.lagou...@gmail.com):

AUTHORS: fix duplicate / wrong name entry

Change-Id: I1e2bb98d1e78af193f449c75109eabc92f934c11
Reviewed-on: https://code.wireshark.org/review/16149
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: David Zoller 
Reviewed-by: Anders Broman 


Actions performed:

from  148d586   json: corrected json output format.
adds  76ae2d9   AUTHORS: fix duplicate / wrong name entry


Summary of changes:
 .mailmap |2 ++
 AUTHORS  |3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe