[Wireshark-commits] master 8d7aba1: IEEE 802.15.4:dissecting header & payload information elements used by 6tisch.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d7aba1060ef1823223e52c06d613fa3fe3828b0
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

8d7aba1 by Jonathan Muñoz (jonathan.mu...@inria.fr):

IEEE 802.15.4:dissecting header & payload information elements used by 
6tisch.

This patch shows the Information Elements (IE) defined by the
IEEE802.15.4. It dissects the information of those IE which are used
by the IETF WG 6tisch and announces the others. Here the list of the
fully dissected ones:

- For the header IEs:
- Time Correction.
- Header Termination 1.
- Header Termination 2.

- For the payload IEs:
- MLME:
- Nested Shorts:
- TSCH Synchronization IE.
- TSCH Timeslot IE.
- TSCH Slotframe and Link IE.
- Nested Longs:
- Channel Hopping IE.
- Payload Termination IE.

For the rest of the IEs defined in the standart, this patch shows them
but does not analyze their inner fields.

References:
https://datatracker.ietf.org/doc/draft-ietf-6tisch-minimal/
IEEE Standard for Low-Rate Wireless Personal Area Networks (WPANs).

Change-Id: I45292315fa532f08be6a218eb5756284a224
Reviewed-on: https://code.wireshark.org/review/16671
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  52910f4   isakmp: fix type confusion
adds  8d7aba1   IEEE 802.15.4:dissecting header & payload information 
elements used by 6tisch.


Summary of changes:
 epan/dissectors/packet-ieee802154.c |  259 +--
 epan/dissectors/packet-ieee802154.h |   10 +-
 2 files changed, 254 insertions(+), 15 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 52910f4: isakmp: fix type confusion

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=52910f4e3fa7d771a671cd30bd5320d70aee3eec
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

52910f4 by Peter Wu (pe...@lekensteyn.nl):

isakmp: fix type confusion

Caught by ASAN with WIRESHARK_DEBUG_WMEM_OVERRIDE=simple set.

Manually inspection of all type casts to decrypt_data_t and
ikev2_decrypt_data_t showed no other users that do not check
isakmp_version first.

Change-Id: If889afff85a20e31222d33cbea8db3a91a77f389
Reviewed-on: https://code.wireshark.org/review/17246
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michał Skalski 
Reviewed-by: Anders Broman 


Actions performed:

from  bee0cd7   See if *this* convinces the compiler that valuelen and 
value will be set.
adds  52910f4   isakmp: fix type confusion


Summary of changes:
 epan/dissectors/packet-isakmp.c |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 2697dbb: See if *this* convinces the compiler that valuelen and value will be set.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2697dbb2895b6205e03275a53b0cc7f23b7b95b0
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2697dbb by Guy Harris (g...@alum.mit.edu):

See if *this* convinces the compiler that valuelen and value will be set.

Change-Id: I2a7715ac3255502f244a0d0a7e588b3a44c34f11
Reviewed-on: https://code.wireshark.org/review/17258
Reviewed-by: Guy Harris 
(cherry picked from commit bee0cd776219fc3cd6ac6a932a1d25b944c299a0)
Reviewed-on: https://code.wireshark.org/review/17259


Actions performed:

from  e23a7d0   Fix handling of parameters with no value.
adds  2697dbb   See if *this* convinces the compiler that valuelen and 
value will be set.


Summary of changes:
 epan/media_params.c |   30 +++---
 1 file changed, 19 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bee0cd7: See if *this* convinces the compiler that valuelen and value will be set.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bee0cd776219fc3cd6ac6a932a1d25b944c299a0
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

bee0cd7 by Guy Harris (g...@alum.mit.edu):

See if *this* convinces the compiler that valuelen and value will be set.

Change-Id: I2a7715ac3255502f244a0d0a7e588b3a44c34f11
Reviewed-on: https://code.wireshark.org/review/17258
Reviewed-by: Guy Harris 


Actions performed:

from  9edb7af   More fields, more pre-allocated memory for fields.
adds  bee0cd7   See if *this* convinces the compiler that valuelen and 
value will be set.


Summary of changes:
 epan/media_params.c |   30 +++---
 1 file changed, 19 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9edb7af: More fields, more pre-allocated memory for fields.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9edb7afa84cc694eddc563e794492f8dd1fe61ca
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

9edb7af by Guy Harris (g...@alum.mit.edu):

More fields, more pre-allocated memory for fields.

Change-Id: I8362e64354c4ca985dbabc190cfb75d2bd31a5ad
Reviewed-on: https://code.wireshark.org/review/17257
Reviewed-by: Guy Harris 


Actions performed:

from  ff00166   Fix handling of parameters with no value.
adds  9edb7af   More fields, more pre-allocated memory for fields.


Summary of changes:
 epan/proto.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 e23a7d0: Fix handling of parameters with no value.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e23a7d02ff403906ece7452b23f4ec2f54a8af7a
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

e23a7d0 by Guy Harris (g...@alum.mit.edu):

Fix handling of parameters with no value.

Return a value length of 0 if there's no parameter value.

(And don't return anything if the pointers through which we return them
are null.)

If no value is present, return NULL from ws_find_media_type_parameter().

Change-Id: I32b57623d7651bcf065af5b81f2390a600988b21
Reviewed-on: https://code.wireshark.org/review/17255
Reviewed-by: Guy Harris 
(cherry picked from commit ff00166a96d887e03899577caae3a355c26b0837)
Reviewed-on: https://code.wireshark.org/review/17256


Actions performed:

from  1c167f8   Add cast to squelch "building with a C++ compiler" warnings.
adds  e23a7d0   Fix handling of parameters with no value.


Summary of changes:
 epan/media_params.c |   15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ff00166: Fix handling of parameters with no value.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff00166a96d887e03899577caae3a355c26b0837
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

ff00166 by Guy Harris (g...@alum.mit.edu):

Fix handling of parameters with no value.

Return a value length of 0 if there's no parameter value.

(And don't return anything if the pointers through which we return them
are null.)

If no value is present, return NULL from ws_find_media_type_parameter().

Change-Id: I32b57623d7651bcf065af5b81f2390a600988b21
Reviewed-on: https://code.wireshark.org/review/17255
Reviewed-by: Guy Harris 


Actions performed:

from  4458c48   Add cast to squelch "building with a C++ compiler" warnings.
adds  ff00166   Fix handling of parameters with no value.


Summary of changes:
 epan/media_params.c |   15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 1c167f8: Add cast to squelch "building with a C++ compiler" warnings.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c167f8caa6cde0ecf11c40b3f7f7c9d3401c29a
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

1c167f8 by Guy Harris (g...@alum.mit.edu):

Add cast to squelch "building with a C++ compiler" warnings.

Change-Id: Ia95c40096018479aec99fafd93d7b95d31ba4723
Reviewed-on: https://code.wireshark.org/review/17253
Reviewed-by: Guy Harris 
(cherry picked from commit 4458c48cf4b94da8626361499a044d7c8c096538)
Reviewed-on: https://code.wireshark.org/review/17254


Actions performed:

from  d6f83a3   Handle quoted-pairs in quoted-strings correctly.
adds  1c167f8   Add cast to squelch "building with a C++ compiler" warnings.


Summary of changes:
 epan/media_params.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4458c48: Add cast to squelch "building with a C++ compiler" warnings.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4458c48cf4b94da8626361499a044d7c8c096538
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

4458c48 by Guy Harris (g...@alum.mit.edu):

Add cast to squelch "building with a C++ compiler" warnings.

Change-Id: Ia95c40096018479aec99fafd93d7b95d31ba4723
Reviewed-on: https://code.wireshark.org/review/17253
Reviewed-by: Guy Harris 


Actions performed:

from  0b3a962   Handle quoted-pairs in quoted-strings correctly.
adds  4458c48   Add cast to squelch "building with a C++ compiler" warnings.


Summary of changes:
 epan/media_params.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/11851

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 0b3a96222b39ea4df1fdc899a950c50ec56a1077
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 d6f83a3: Handle quoted-pairs in quoted-strings correctly.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d6f83a375d29217f4bf8e5e6b59672030fa4e602
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

d6f83a3 by Guy Harris (g...@alum.mit.edu):

Handle quoted-pairs in quoted-strings correctly.

Backslash, in a quoted-string, escapes quotes (and any other characters,
although the only ones that *need* escaping are a double-quote and a
backslash).

This means that the value of a parameter isn't just the raw characters
from the parameters string; for a quoted string, it needs to be
un-escaped, and for a *non*-quoted string, it has to stop at the first
non-token character (you can put comments in).  So
ws_find_media_type_parameter() must return an allocated string with the
actual value.

Get rid of index_of_char(); it doesn't do anything that strchr() does.

Change-Id: I36328ea71c28fe6ac4918a8e73c281a25f6be844
Reviewed-on: https://code.wireshark.org/review/17251
Reviewed-by: Guy Harris 
(cherry picked from commit 0b3a96222b39ea4df1fdc899a950c50ec56a1077)
Reviewed-on: https://code.wireshark.org/review/17252


Actions performed:

from  d24bf49   2.2.0rc1 → 2.2.0rc2.
adds  d6f83a3   Handle quoted-pairs in quoted-strings correctly.


Summary of changes:
 epan/dissectors/packet-isup.c  |   17 +--
 epan/dissectors/packet-multipart.c |   92 ++-
 epan/media_params.c|  222 +++-
 epan/media_params.h|4 +-
 4 files changed, 215 insertions(+), 120 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0b3a962: Handle quoted-pairs in quoted-strings correctly.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b3a96222b39ea4df1fdc899a950c50ec56a1077
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

0b3a962 by Guy Harris (g...@alum.mit.edu):

Handle quoted-pairs in quoted-strings correctly.

Backslash, in a quoted-string, escapes quotes (and any other characters,
although the only ones that *need* escaping are a double-quote and a
backslash).

This means that the value of a parameter isn't just the raw characters
from the parameters string; for a quoted string, it needs to be
un-escaped, and for a *non*-quoted string, it has to stop at the first
non-token character (you can put comments in).  So
ws_find_media_type_parameter() must return an allocated string with the
actual value.

Get rid of index_of_char(); it doesn't do anything that strchr() does.

Change-Id: I36328ea71c28fe6ac4918a8e73c281a25f6be844
Reviewed-on: https://code.wireshark.org/review/17251
Reviewed-by: Guy Harris 


Actions performed:

from  943a9ed   Update docbook/README.txt
adds  0b3a962   Handle quoted-pairs in quoted-strings correctly.


Summary of changes:
 epan/dissectors/packet-isup.c  |   17 +--
 epan/dissectors/packet-multipart.c |   92 ++-
 epan/media_params.c|  222 +++-
 epan/media_params.h|4 +-
 4 files changed, 215 insertions(+), 120 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 943a9ed: Update docbook/README.txt

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=943a9ede85962f07fc75b64e2ed12bdc54a911bb
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

943a9ed by Gerald Combs (ger...@wireshark.org):

Update docbook/README.txt

Update to reflect current reality. Still needs a lot of work.

Change-Id: Id6bb12f5e8ca42bbadc237f148bb388b54a321e2
Reviewed-on: https://code.wireshark.org/review/17247
Reviewed-by: Gerald Combs 


Actions performed:

from  9c80ff0   IKEv2: Add D-H Transform IDs for Brainpool Curves
adds  943a9ed   Update docbook/README.txt


Summary of changes:
 docbook/README.txt |   88 +---
 1 file changed, 21 insertions(+), 67 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 d24bf49: 2.2.0rc1 → 2.2.0rc2.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d24bf4901d97b803752e9510190cb414920ec8af
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

d24bf49 by Gerald Combs (ger...@wireshark.org):

2.2.0rc1 → 2.2.0rc2.

Change-Id: I8272c2a8eb05fd5215999657728f56cf09950920
Reviewed-on: https://code.wireshark.org/review/17248
Reviewed-by: Gerald Combs 


Actions performed:

from  438c022   Build 2.2.0rc1.
adds  d24bf49   2.2.0rc1 → 2.2.0rc2.


Summary of changes:
 version.conf |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag wireshark-2.2.0rc1 created (now f053eb1)

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f053eb122b05585dd2a73e2f52d4e11a569741c5
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: annotated tag: wireshark-2.2.0rc1
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  f053eb1   (tag)
 tagging  438c022e570b23172739e19543d498bae35bd71b (commit)
  replaces  v2.2.0rc0
 tagged by  Gerald Combs
on  Mon Aug 22 12:45:33 2016 -0700

- Log -
Build 2.2.0rc1.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAABCgAGBQJXu1ZjAAoJEIIkSnjm/q7q/ncQAIcy9S7cOPzgntwKkA0oTnFv
BnsUjXSGcAnQjH8HaZhUs0vLJvDO4lTPdDcgVurXocbKP/tvo0UFfg85yF9Ouill
1Pbf9x9kT7L0XNdNUYoH9kfDnjV3UV4AquyG59mDbkIQEydlhZUlHWvtsfwXYHcq
k2ucjKjhD3fT/acpUEVq/TwDjo96O1Cl31ijIXpjMAX9vdWsCL13iCb4Jc5qbeMC
lDVy9AK5nq5CbXDaaKqMTshTQS0e+WeUevG5SCz/LuqfAUpLpsdfMQtE1qBdzbMt
+0jdcnPC3pLZoQqwJZM3Fw/PC7R9AgMHj6UIOP+fI/wj9gUavt+ATK1fZKXWrrmU
WB3r2ysO6Gg671qQ7BtdFJ60GxH/7YZRK9NQ2XKE5YoQXMbO0+LZNn4jwE1P2RM/
v5o69a+2tgZeH6EzdWvevLOiuTtedxdAsKOKOwK2WJ3FbxcugQGqhOdkxOfG12SH
aXibEF1zgygWRSU+X7YSvbDqq9IQSpV7NO32UY1XDbhthXoRHZ1TkdtXZDu/8V8c
Uifnx1Mze5jriPniF/njVJQO6YGvGpBnuM/wiQg06RmOAxCirYH1vpn2R4YRsP1c
hAiOpYgpCgvafd2RNy+4VcMjfMEbSCfcOUnbGUTcwZJm7RRoQQFnykON6mNKXQ8g
SeSE6mPVT4hQIVq+c66z
=1VDf
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag v2.2.0rc1 created (now 92029b0)

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=92029b0c91cb858b3c5c7df74234cb055259bbf0
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: annotated tag: v2.2.0rc1
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  92029b0   (tag)
 tagging  438c022e570b23172739e19543d498bae35bd71b (commit)
  replaces  v2.2.0rc0
 tagged by  Gerald Combs
on  Mon Aug 22 12:45:08 2016 -0700

- Log -
Build 2.2.0rc1.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAABCgAGBQJXu1ZTAAoJEIIkSnjm/q7qMr4P/jP0XC6qDw9Q5t7nd8pHlUrs
FftTD9E+NCAtjHH/YTH+KE60wUHOyEuCV0Qfpp+ZsJXxmooouRHPK3ZVEv/dmTZc
csyWzYIUzQOkmL71/JP6NRmt6HqJPsrqxtP1uhsSumzU8869PiqkT6hcjrLLCp2V
mv+maKZ7kDmQ/uqAVesTo56tWeLPqM/06msPA8Iy9lkQaIkwv/Up0MzdWMlYmOHN
HIA8HDGx+pVlFMVg72XvunzxWOf36OE/3LnB1vE/rXFwApZRv+GC6CbpIME2aD7L
YmyePiEhmECg7EJWo+kDSe8Mxnned2qT0s9C+vIg8Qsp/zvOI9mGuenZvPOFQjuk
48Em7BfTX2eGk5ZNif2fNyXis87QmSx2AFO3wW/RM4rs68UGaOjpSjec1Jym0bhd
UO10LSziFKW/vCkVUSU9drcZnpUhfAy2rZJf7WI1OiVbYTv8t2jspYzaIXtpklSn
fg0ia1cS8zQdaDuHltVQFoWo7Ea+wH/qhFcRUF+lyf9YRapeFo18L7V9uUj5ZDRK
TiKs2+EFGtGOSD65HJwarAoCP/B95almelY7fZvQwtkeCqzc38By4Z0pu4u2UTbk
heXsgPfQYQeDyB79Lf6xOXvNOst0YhZP3VPOy29BeJ3vDstNldr4T2xS9VAAeER0
+edwQSXYTxSq4qKq5mYb
=RV9v
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 438c022: Build 2.2.0rc1.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=438c022e570b23172739e19543d498bae35bd71b
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

438c022 by Gerald Combs (ger...@wireshark.org):

Build 2.2.0rc1.

Change-Id: Ie10bd263ed766273c279c9dc52062aed4bdac0b5
Reviewed-on: https://code.wireshark.org/review/17244
Reviewed-by: Gerald Combs 


Actions performed:

from  5a79a9a   Temporarily disable IKEv1 tests.
adds  438c022   Build 2.2.0rc1.


Summary of changes:
 ChangeLog  | 8962 +++-
 NEWS   |  116 +-
 docbook/asciidoc.conf  |2 +-
 docbook/release-notes.asciidoc |6 +-
 version.conf   |7 +-
 5 files changed, 2497 insertions(+), 6596 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 5a79a9a: Temporarily disable IKEv1 tests.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a79a9a7946ff620bd4636c92d53985277c8b96b
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

5a79a9a by Gerald Combs (ger...@wireshark.org):

Temporarily disable IKEv1 tests.

Temporarily disable the "IKEv1 Decryption (simultaneous exchanges)" and
IKEv1 Decryption (unencrypted phase 1) tests. The code that fixes them
hasn't yet been backported.

Change-Id: I9904f057cc6ea5651865b2db87b37d81b6bf117d
Reviewed-on: https://code.wireshark.org/review/17243
Petri-Dish: Gerald Combs 
Reviewed-by: Gerald Combs 


Actions performed:

from  c8f79ec   ipp: fix typo indent
adds  5a79a9a   Temporarily disable IKEv1 tests.


Summary of changes:
 test/suite-decryption.sh |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9c80ff0: IKEv2: Add D-H Transform IDs for Brainpool Curves

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c80ff0617a67d9f024f11d0dbd7943a76f69bc6
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

9c80ff0 by Mirko Parthey (mirko.part...@web.de):

IKEv2: Add D-H Transform IDs for Brainpool Curves

Add Diffie-Hellman Group Transform IDs for the ECC Brainpool Curves.

References: RFC 6932, RFC 6954

Change-Id: I1ca0da8e5e06abbd1c53a591d01c1f05aa60c35a
Reviewed-on: https://code.wireshark.org/review/17231
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  ee0f94a   Make index_of_char() static again
adds  9c80ff0   IKEv2: Add D-H Transform IDs for Brainpool Curves


Summary of changes:
 epan/dissectors/packet-isakmp.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c8f79ec: ipp: fix typo indent

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8f79ecb640402a3135ec4e5e3702637ccb785df
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c8f79ec by Alexis La Goutte (alexis.lagou...@gmail.com):

ipp: fix typo indent

Change-Id: Ibc44ab1e009f2dc07258b702f0e08aced38a66e2
Reviewed-on: https://code.wireshark.org/review/17223
Reviewed-by: Anders Broman 
(cherry picked from commit 3f4ef54776cc9216ad1d633723e8984018b4deba)
Reviewed-on: https://code.wireshark.org/review/17242
Reviewed-by: Guy Harris 


Actions performed:

from  2d0b46d   ERF: fix no previous prototype for 
'erf_ts_to_nstime/dissect_relative_time/dissect_ptp_timeinterval' 
[-Wmissing-prototypes]
adds  c8f79ec   ipp: fix typo indent


Summary of changes:
 epan/dissectors/packet-ipp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c97041c: packet-erf.c: Pacify OS X buildbot.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c97041c3744ce0df83268ef7983edd3413d4918e
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c97041c by Michael Mann (mman...@netscape.net):

packet-erf.c: Pacify OS X buildbot.

Change-Id: I6ec30e77eac91d1b02eaddada75741b2063426f2
Reviewed-on: https://code.wireshark.org/review/16812
Reviewed-by: Michael Mann 
(cherry picked from commit 9489c80949dcf027be99b6e493b79aeef4e29ab5)
Reviewed-on: https://code.wireshark.org/review/17240
Reviewed-by: Gerald Combs 


Actions performed:

from  14af515   ERF: Add ERF_TYPE_META clock tags
adds  c97041c   packet-erf.c: Pacify OS X buildbot.


Summary of changes:
 epan/dissectors/packet-erf.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 2d0b46d: ERF: fix no previous prototype for 'erf_ts_to_nstime/dissect_relative_time/dissect_ptp_timeinterval' [-Wmissing-prototypes]

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d0b46d0a5f67044c980fef26be86080dc045fcc
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2d0b46d by Alexis La Goutte (alexis.lagou...@gmail.com):

ERF: fix no previous prototype for 
'erf_ts_to_nstime/dissect_relative_time/dissect_ptp_timeinterval' 
[-Wmissing-prototypes]

Change-Id: I21ee4f8850f63de3a7fa91ed9e8a426c82a9d62e
Reviewed-on: https://code.wireshark.org/review/17143
Reviewed-by: Michael Mann 
(cherry picked from commit 26464b028baac61102fea77b7ae6f19755c2359e)
Reviewed-on: https://code.wireshark.org/review/17241
Reviewed-by: Gerald Combs 


Actions performed:

from  c97041c   packet-erf.c: Pacify OS X buildbot.
adds  2d0b46d   ERF: fix no previous prototype for 
'erf_ts_to_nstime/dissect_relative_time/dissect_ptp_timeinterval' 
[-Wmissing-prototypes]


Summary of changes:
 epan/dissectors/packet-erf.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 14af515: ERF: Add ERF_TYPE_META clock tags

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14af515846db90424b41b17a4b992d16a884ba46
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

14af515 by Anthony Coddington (anthony.codding...@endace.com):

ERF: Add ERF_TYPE_META clock tags

Adds various clock configuration related tags.
Uses ptp_v2 value strings exported from packet-ptp.

Refactor out common ERF_TYPE_META bitfield code.
Also clean up field registration a bit.
Add flow_hash_mode enum, other minor wording cleanup.
Manually display relative timestamps as nanoseconds for <1ms.
Fix ns_host_* tag subtree summary field name duplication.

Ping-Bug: 12303
Change-Id: I76264d141f1c4a3590627637daa5dcd4fdfd2e93
Reviewed-on: https://code.wireshark.org/review/16782
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 94cb86a0ca62680ceb8565b4f0a716e48010d885)
Reviewed-on: https://code.wireshark.org/review/17238
Petri-Dish: Gerald Combs 
Reviewed-by: Gerald Combs 


Actions performed:

from  c66c2a7   PTP: Expose ptp_v2 value strings for use by other dissectors
adds  14af515   ERF: Add ERF_TYPE_META clock tags


Summary of changes:
 epan/dissectors/packet-erf.c |  532 ++
 wiretap/erf.h|   32 +++
 2 files changed, 412 insertions(+), 152 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c66c2a7: PTP: Expose ptp_v2 value strings for use by other dissectors

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c66c2a7cf3e087a8913d2e7e6d90f1675fddbce7
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c66c2a7 by Anthony Coddington (anthony.codding...@endace.com):

PTP: Expose ptp_v2 value strings for use by other dissectors

Also rename ptp_v2 value strings in packet-ptp for better consistency.
TODO: could also be used and combined with definitions in packet-cip.

Change-Id: I84a9ae566ae6abdd95910cb5709bb63c2b7c26b8
Reviewed-on: https://code.wireshark.org/review/16781
Reviewed-by: Michael Mann 
(cherry picked from commit 765f3b53cfef707272652852639a9194c81f9c3d)
Reviewed-on: https://code.wireshark.org/review/17237
Petri-Dish: Gerald Combs 
Reviewed-by: Gerald Combs 


Actions performed:

from  bb8f307   Bump SOVERSION for upcoming 2.2.0 release
adds  c66c2a7   PTP: Expose ptp_v2 value strings for use by other dissectors


Summary of changes:
 epan/dissectors/Makefile.am  |1 +
 epan/dissectors/packet-ptp.c |   84 --
 epan/{crypt/kasumi.h => dissectors/packet-ptp.h} |   16 +++--
 3 files changed, 55 insertions(+), 46 deletions(-)
 copy epan/{crypt/kasumi.h => dissectors/packet-ptp.h} (69%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 bb8f307: Bump SOVERSION for upcoming 2.2.0 release

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb8f307e697089f29d2ccd83eda5b2e988a35194
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

bb8f307 by Balint Reczey (bal...@balintreczey.hu):

Bump SOVERSION for upcoming 2.2.0 release

Change-Id: I3c9e3f42d32921288fbf38029d786d40d42ed017
Reviewed-on: https://code.wireshark.org/review/17236
Reviewed-by: Balint Reczey 
Petri-Dish: Balint Reczey 
Reviewed-by: Gerald Combs 


Actions performed:

from  de5d20a   debian: Update symbols file with new symbols
adds  bb8f307   Bump SOVERSION for upcoming 2.2.0 release


Summary of changes:
 codecs/CMakeLists.txt  |4 +--
 codecs/Makefile.am |2 +-
 debian/control |   22 +++
 ...libwireshark0.install => libwireshark8.install} |0
 ...libwireshark0.symbols => libwireshark8.symbols} |   28 ++--
 debian/{libwiretap0.docs => libwiretap6.docs}  |0
 .../{libwiretap0.install => libwiretap6.install}   |0
 .../{libwiretap0.symbols => libwiretap6.symbols}   |2 +-
 .../{libwscodecs0.install => libwscodecs1.install} |0
 .../{libwscodecs0.symbols => libwscodecs1.symbols} |2 +-
 debian/{libwsutil0.install => libwsutil7.install}  |0
 debian/{libwsutil0.symbols => libwsutil7.symbols}  |2 +-
 epan/CMakeLists.txt|2 +-
 wiretap/CMakeLists.txt |2 +-
 wsutil/CMakeLists.txt  |2 +-
 15 files changed, 34 insertions(+), 34 deletions(-)
 rename debian/{libwireshark0.install => libwireshark8.install} (100%)
 rename debian/{libwireshark0.symbols => libwireshark8.symbols} (99%)
 rename debian/{libwiretap0.docs => libwiretap6.docs} (100%)
 rename debian/{libwiretap0.install => libwiretap6.install} (100%)
 rename debian/{libwiretap0.symbols => libwiretap6.symbols} (99%)
 rename debian/{libwscodecs0.install => libwscodecs1.install} (100%)
 rename debian/{libwscodecs0.symbols => libwscodecs1.symbols} (96%)
 rename debian/{libwsutil0.install => libwsutil7.install} (100%)
 rename debian/{libwsutil0.symbols => libwsutil7.symbols} (99%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 de5d20a: debian: Update symbols file with new symbols

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=de5d20a95f3135c48d1baf7ecb2d1ea553cd6a4a
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

de5d20a by Balint Reczey (bal...@balintreczey.hu):

debian: Update symbols file with new symbols

Change-Id: I67ecc259128dfa90ba8b47fc040cdc9a38e264c5
Reviewed-on: https://code.wireshark.org/review/17235
Reviewed-by: Gerald Combs 


Actions performed:

from  8a0abec   Make index_of_char() static again
adds  de5d20a   debian: Update symbols file with new symbols


Summary of changes:
 debian/libwireshark0.symbols |2 ++
 debian/libwiretap0.symbols   |2 ++
 2 files changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 8a0abec: Make index_of_char() static again

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a0abec91c7964ad9d455d1eefd1c5c52900f7f9
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8a0abec by Balint Reczey (bal...@balintreczey.hu):

Make index_of_char() static again

Change-Id: I1c0d344c50ee5d78dd8247ccfe795ce0cd94aaa2
Reviewed-on: https://code.wireshark.org/review/17230
Reviewed-by: Balint Reczey 
(cherry picked from commit ee0f94aaaec4cc35b463a94df601a83a23f7967e)
Reviewed-on: https://code.wireshark.org/review/17234


Actions performed:

from  4843a66   Rename find_parameter() to ws_find_media_type_parameter()
adds  8a0abec   Make index_of_char() static again


Summary of changes:
 epan/dissectors/packet-multipart.c |   19 +++
 epan/media_params.c|   22 +-
 epan/media_params.h|6 --
 3 files changed, 20 insertions(+), 27 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ee0f94a: Make index_of_char() static again

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee0f94aaaec4cc35b463a94df601a83a23f7967e
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

ee0f94a by Balint Reczey (bal...@balintreczey.hu):

Make index_of_char() static again

Change-Id: I1c0d344c50ee5d78dd8247ccfe795ce0cd94aaa2
Reviewed-on: https://code.wireshark.org/review/17230
Reviewed-by: Balint Reczey 


Actions performed:

from  e129aec   debian: Update symbols file with new symbols
adds  ee0f94a   Make index_of_char() static again


Summary of changes:
 epan/dissectors/packet-multipart.c |   19 +++
 epan/media_params.c|   22 +-
 epan/media_params.h|6 --
 3 files changed, 20 insertions(+), 27 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 4843a66: Rename find_parameter() to ws_find_media_type_parameter()

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4843a665a097d1ed92418a7b7fa05c782e652029
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

4843a66 by Balint Reczey (bal...@balintreczey.hu):

Rename find_parameter() to ws_find_media_type_parameter()

The symbols exported from libs should use less generic. preferably
prefixed names to avoid name collisions with other shared library
symbols.

Change-Id: I8323b3e194a7ee4d61baec0c007342fab6cbde84
Reviewed-on: https://code.wireshark.org/review/17229
Petri-Dish: Michael Mann 
Reviewed-by: Michael Mann 
(cherry picked from commit c43b8b5ef95b7b2dc865d8b0df89222b224059ce)
Reviewed-on: https://code.wireshark.org/review/17233
Reviewed-by: Balint Reczey 


Actions performed:

from  32ac8d2   wmem_array_index() returns a *pointer* to the array element.
adds  4843a66   Rename find_parameter() to ws_find_media_type_parameter()


Summary of changes:
 epan/dissectors/packet-isup.c  |4 ++--
 epan/dissectors/packet-multipart.c |   10 +-
 epan/media_params.c|2 +-
 epan/media_params.h|2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e129aec: debian: Update symbols file with new symbols

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e129aec55870af97224b37ecc7f05416b6b215dd
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

e129aec by Balint Reczey (bal...@balintreczey.hu):

debian: Update symbols file with new symbols

Some symbols are marked as appearing in 2.2 intentionally,
because they are cherry-picked to master-2.2.

Change-Id: Ia7807b3bddab0a069812f56c1be2eca8bf7d1cd4
Reviewed-on: https://code.wireshark.org/review/17232
Reviewed-by: Balint Reczey 
Petri-Dish: Balint Reczey 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  c43b8b5   Rename find_parameter() to ws_find_media_type_parameter()
adds  e129aec   debian: Update symbols file with new symbols


Summary of changes:
 debian/libwireshark0.symbols |2 ++
 debian/libwiretap0.symbols   |2 ++
 debian/libwsutil0.symbols|1 +
 3 files changed, 5 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c43b8b5: Rename find_parameter() to ws_find_media_type_parameter()

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c43b8b5ef95b7b2dc865d8b0df89222b224059ce
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

c43b8b5 by Balint Reczey (bal...@balintreczey.hu):

Rename find_parameter() to ws_find_media_type_parameter()

The symbols exported from libs should use less generic. preferably
prefixed names to avoid name collisions with other shared library
symbols.

Change-Id: I8323b3e194a7ee4d61baec0c007342fab6cbde84
Reviewed-on: https://code.wireshark.org/review/17229
Petri-Dish: Michael Mann 
Reviewed-by: Michael Mann 


Actions performed:

from  22e421f   Fixed a bug which might have caused a division by 0.
adds  c43b8b5   Rename find_parameter() to ws_find_media_type_parameter()


Summary of changes:
 epan/dissectors/packet-isup.c  |4 ++--
 epan/dissectors/packet-multipart.c |   10 +-
 epan/media_params.c|2 +-
 epan/media_params.h|2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 22e421f: Fixed a bug which might have caused a division by 0.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22e421f7d390e7558b998dc458bfb536cfaf460b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

22e421f by Andreas Leibold (andreas.leib...@harman.com):

Fixed a bug which might have caused a division by 0.

Variable "channels_per_frame" could have caused a division by 0.
This is now changed, by stopping dissection in this case. A warning is
shown for this case.

Change-Id: I6d4dcb91b833a7d7f0759e28f56950b94ab1ed7e
Reviewed-on: https://code.wireshark.org/review/17228
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  b9e70e9   RANAP:  Add an heuristic to decode the HO-to-UTRAN Command 
embedded in the RRC Container within the TargetRNC-to-SourceRNC Transparent 
Container
adds  22e421f   Fixed a bug which might have caused a division by 0.


Summary of changes:
 epan/dissectors/packet-ieee1722.c |   59 +++--
 1 file changed, 31 insertions(+), 28 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b9e70e9: RANAP: Add an heuristic to decode the HO-to-UTRAN Command embedded in the RRC Container within the TargetRNC-to-SourceRNC Transparent Container

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9e70e9b4cb0d85b6fcbbcfa387a5bea80046665
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

b9e70e9 by Binh Trinh (bea...@gmail.com):

RANAP:  Add an heuristic to decode the HO-to-UTRAN Command embedded in the 
RRC Container within the TargetRNC-to-SourceRNC Transparent Container

Change-Id: Iea7c8d24f52cf8bd11e13a53853e11ec1ecdcd36
Reviewed-on: https://code.wireshark.org/review/17058
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  3f4ef54   ipp: fix typo indent
adds  b9e70e9   RANAP:  Add an heuristic to decode the HO-to-UTRAN Command 
embedded in the RRC Container within the TargetRNC-to-SourceRNC Transparent 
Container


Summary of changes:
 epan/dissectors/asn1/ranap/packet-ranap-template.c |2 +-
 epan/dissectors/asn1/ranap/ranap.cnf   |   13 ++-
 epan/dissectors/packet-ranap.c |   39 
 3 files changed, 36 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3f4ef54: ipp: fix typo indent

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f4ef54776cc9216ad1d633723e8984018b4deba
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3f4ef54 by Alexis La Goutte (alexis.lagou...@gmail.com):

ipp: fix typo indent

Change-Id: Ibc44ab1e009f2dc07258b702f0e08aced38a66e2
Reviewed-on: https://code.wireshark.org/review/17223
Reviewed-by: Anders Broman 


Actions performed:

from  e8ba606   [Diameter] Add Command codes 8388718 - 8388722.
adds  3f4ef54   ipp: fix typo indent


Summary of changes:
 epan/dissectors/packet-ipp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e8ba606: [Diameter] Add Command codes 8388718 - 8388722.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8ba606348ab2cea260b9ddb31ee21568f1ed3f9
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e8ba606 by AndersBroman (anders.bro...@ericsson.com):

[Diameter] Add Command codes 8388718 - 8388722.

Bug: 12774
Change-Id: I413ba4a195ee1bd3d7de66399d1be714ef77d7e2
Reviewed-on: https://code.wireshark.org/review/17227
Reviewed-by: Anders Broman 


Actions performed:

from  e83bdc6   wmem_array_index() returns a *pointer* to the array element.
adds  e8ba606   [Diameter] Add Command codes 8388718 - 8388722.


Summary of changes:
 diameter/dictionary.xml |   25 -
 1 file changed, 20 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 32ac8d2: wmem_array_index() returns a *pointer* to the array element.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32ac8d225ae08677c4ac6047878c137ac703c045
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

32ac8d2 by Guy Harris (g...@alum.mit.edu):

wmem_array_index() returns a *pointer* to the array element.

The array is an array of guint8 *'s that point to strings;
wmem_array_index() doesn't return a pointer to the string, it returns a
pointer to a pointer to the string, and you have to dereference the
result of the wmem_array_index() call to get a pointer to the string.

Change-Id: I8c7b3320f0979b01383ad255419c21cdeb7df4c7
Reviewed-on: https://code.wireshark.org/review/17221
Reviewed-by: Guy Harris 
(cherry picked from commit e83bdc67cc413c25321ae75792a2c92d55b6e544)
Reviewed-on: https://code.wireshark.org/review/17222


Actions performed:

from  e388dd0   Get rid of trailing blank line.
adds  32ac8d2   wmem_array_index() returns a *pointer* to the array element.


Summary of changes:
 epan/dissectors/packet-pcp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e83bdc6: wmem_array_index() returns a *pointer* to the array element.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e83bdc67cc413c25321ae75792a2c92d55b6e544
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

e83bdc6 by Guy Harris (g...@alum.mit.edu):

wmem_array_index() returns a *pointer* to the array element.

The array is an array of guint8 *'s that point to strings;
wmem_array_index() doesn't return a pointer to the string, it returns a
pointer to a pointer to the string, and you have to dereference the
result of the wmem_array_index() call to get a pointer to the string.

Change-Id: I8c7b3320f0979b01383ad255419c21cdeb7df4c7
Reviewed-on: https://code.wireshark.org/review/17221
Reviewed-by: Guy Harris 


Actions performed:

from  c00ea6f   Look up the XML dissector the right way.
adds  e83bdc6   wmem_array_index() returns a *pointer* to the array element.


Summary of changes:
 epan/dissectors/packet-pcp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 e388dd0: Get rid of trailing blank line.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e388dd0e6d81ef344d55f84f48bb78d2c3c9
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

e388dd0 by Guy Harris (g...@alum.mit.edu):

Get rid of trailing blank line.

Change-Id: I409a843b48983355c242708f6c9972bd8f337bf6
Reviewed-on: https://code.wireshark.org/review/17218
Reviewed-by: Guy Harris 
(cherry picked from commit e1f11c97349dad879c3d3a875c289a195a8ba52c)
Reviewed-on: https://code.wireshark.org/review/17220


Actions performed:

from  359fdbb   Pass an HTTP message type to all HTTP subdissectors.
adds  e388dd0   Get rid of trailing blank line.


Summary of changes:
 epan/media_params.c |1 -
 1 file changed, 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c00ea6f: Look up the XML dissector the right way.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c00ea6f26e3c83e1db144d9d858cf9c4662d7e19
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

c00ea6f by Guy Harris (g...@alum.mit.edu):

Look up the XML dissector the right way.

Looking up "text/xml" in the "media_type" dissector is somewhat of a
long-way-around way of finding the XML dissector; just look for it by
name.

Change-Id: Ifafeabc563bf7bfa529bc44ba31bf6ae376a09c8
Reviewed-on: https://code.wireshark.org/review/17219
Reviewed-by: Guy Harris 


Actions performed:

from  e1f11c9   Get rid of trailing blank line.
adds  c00ea6f   Look up the XML dissector the right way.


Summary of changes:
 epan/dissectors/packet-skinny.c|   10 --
 epan/dissectors/packet-skinny.c.in |   10 --
 2 files changed, 8 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 359fdbb: Pass an HTTP message type to all HTTP subdissectors.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=359fdbb606cf4f00335a4afc9dffd932547dfd27
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

359fdbb by Guy Harris (g...@alum.mit.edu):

Pass an HTTP message type to all HTTP subdissectors.

This gets complicated, because those subdissectors might be called by
other dissectors as well.  We need a better way of passing that sort of
out-of-bound information.

Pull some routines used for processing Content-Type parameters into
common code; we can't guarantee that the media parameters passed in
would be writable (passing it as *the* data hid that; passing a
structure with that *and* the HTTP message type revealed it), so don't
convert it to lower-case in place.

Use that information, if available, to determine whether an IPP message
is a requet or a response.

Change-Id: I4bccc9f05cd0b14ad445be7ab37b3d884d841325
Reviewed-on: https://code.wireshark.org/review/17216
Reviewed-by: Guy Harris 
(cherry picked from commit 5825f59ddccb8af2b4a06356f61195dd26c977d7)
Reviewed-on: https://code.wireshark.org/review/17217


Actions performed:

from  a35bcd1   CDP: Don't read outside payload for Port ID
adds  359fdbb   Pass an HTTP message type to all HTTP subdissectors.


Summary of changes:
 epan/CMakeLists.txt  |1 +
 epan/Makefile.am |2 +
 epan/dissectors/packet-http-urlencoded.c |   15 +++-
 epan/dissectors/packet-http.c|   25 +++---
 epan/dissectors/packet-http.h|   13 +++
 epan/dissectors/packet-imf.c |7 +-
 epan/dissectors/packet-ipp.c |   24 -
 epan/dissectors/packet-isup.c|   59 +++-
 epan/dissectors/packet-json.c|   15 +++-
 epan/dissectors/packet-jxta.c|9 +-
 epan/dissectors/packet-media.c   |8 +-
 epan/dissectors/packet-msrp.c|7 +-
 epan/dissectors/packet-multipart.c   |  143 +++---
 epan/dissectors/packet-sip.c |   10 ++-
 epan/dissectors/packet-spdy.c|   16 +++-
 epan/dissectors/packet-text-media.c  |   14 ++-
 epan/media_params.c  |  133 +++
 wsutil/crc8.h => epan/media_params.h |   30 ---
 18 files changed, 344 insertions(+), 187 deletions(-)
 create mode 100644 epan/media_params.c
 copy wsutil/crc8.h => epan/media_params.h (62%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e1f11c9: Get rid of trailing blank line.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e1f11c97349dad879c3d3a875c289a195a8ba52c
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

e1f11c9 by Guy Harris (g...@alum.mit.edu):

Get rid of trailing blank line.

Change-Id: I409a843b48983355c242708f6c9972bd8f337bf6
Reviewed-on: https://code.wireshark.org/review/17218
Reviewed-by: Guy Harris 


Actions performed:

from  5825f59   Pass an HTTP message type to all HTTP subdissectors.
adds  e1f11c9   Get rid of trailing blank line.


Summary of changes:
 epan/media_params.c |1 -
 1 file changed, 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5825f59: Pass an HTTP message type to all HTTP subdissectors.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5825f59ddccb8af2b4a06356f61195dd26c977d7
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

5825f59 by Guy Harris (g...@alum.mit.edu):

Pass an HTTP message type to all HTTP subdissectors.

This gets complicated, because those subdissectors might be called by
other dissectors as well.  We need a better way of passing that sort of
out-of-bound information.

Pull some routines used for processing Content-Type parameters into
common code; we can't guarantee that the media parameters passed in
would be writable (passing it as *the* data hid that; passing a
structure with that *and* the HTTP message type revealed it), so don't
convert it to lower-case in place.

Use that information, if available, to determine whether an IPP message
is a requet or a response.

Change-Id: I4bccc9f05cd0b14ad445be7ab37b3d884d841325
Reviewed-on: https://code.wireshark.org/review/17216
Reviewed-by: Guy Harris 


Actions performed:

from  efdcb25   ISUP: Enhance display of unknown (opt) parameter
adds  5825f59   Pass an HTTP message type to all HTTP subdissectors.


Summary of changes:
 epan/CMakeLists.txt  |1 +
 epan/Makefile.am |2 +
 epan/dissectors/packet-http-urlencoded.c |   15 +++-
 epan/dissectors/packet-http.c|   25 +++---
 epan/dissectors/packet-http.h|   13 +++
 epan/dissectors/packet-imf.c |7 +-
 epan/dissectors/packet-ipp.c |   24 -
 epan/dissectors/packet-isup.c|   59 +++-
 epan/dissectors/packet-json.c|   15 +++-
 epan/dissectors/packet-jxta.c|9 +-
 epan/dissectors/packet-media.c   |8 +-
 epan/dissectors/packet-msrp.c|7 +-
 epan/dissectors/packet-multipart.c   |  143 +++---
 epan/dissectors/packet-sip.c |   10 ++-
 epan/dissectors/packet-spdy.c|   16 +++-
 epan/dissectors/packet-text-media.c  |   14 ++-
 epan/media_params.c  |  133 +++
 wsutil/crc8.h => epan/media_params.h |   30 ---
 18 files changed, 344 insertions(+), 187 deletions(-)
 create mode 100644 epan/media_params.c
 copy wsutil/crc8.h => epan/media_params.h (62%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master efdcb25: ISUP: Enhance display of unknown (opt) parameter

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=efdcb25360621e5ac14f276b37964f27f4ce0ba4
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

efdcb25 by Alexis La Goutte (alexis.lagou...@gmail.com):

ISUP: Enhance display of unknown (opt) parameter

Ping-Bug:12674
Change-Id: If67920246a9122dc693a71a4afcea212fb7f84ab
Reviewed-on: https://code.wireshark.org/review/17108
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  f062341   Merge the CaveBear list into manuf.tmpl.
adds  efdcb25   ISUP: Enhance display of unknown (opt) parameter


Summary of changes:
 epan/dissectors/packet-isup.c |   29 +++--
 1 file changed, 19 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe