[Wireshark-commits] master-2.2 dadebff: NBT: fix Bad description for NBSS error code 0x81

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dadebff34874137671c381d6bfe8f32fbf3ca874
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

dadebff by Alexis La Goutte (alexis.lagou...@gmail.com):

NBT: fix  Bad description for NBSS error code 0x81

Issue reported by Pavel Kankovsky
https://tools.ietf.org/html/rfc1002#section-4.3.4

Bug:12835
Change-Id: Iac7e58b9fd61f1f0dfd86960ef4f306ac6ed5a9c
Reviewed-on: https://code.wireshark.org/review/17565
Reviewed-by: Anders Broman 
(cherry picked from commit 03e4307cb2daf1f208d3653b04f64580ee6d0c38)
Reviewed-on: https://code.wireshark.org/review/17571
Petri-Dish: Alexis La Goutte 
Reviewed-by: Michael Mann 


Actions performed:

from  5193363   extcap_child_watch_cb() always uses the status argument.
adds  dadebff   NBT: fix  Bad description for NBSS error code 0x81


Summary of changes:
 epan/dissectors/packet-nbt.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.0 b0eb538: NBT: fix Bad description for NBSS error code 0x81

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b0eb5384bdfd20637fbf7a9bd76093b73de03ea6
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

b0eb538 by Alexis La Goutte (alexis.lagou...@gmail.com):

NBT: fix  Bad description for NBSS error code 0x81

Issue reported by Pavel Kankovsky
https://tools.ietf.org/html/rfc1002#section-4.3.4

Bug:12835
Change-Id: Iac7e58b9fd61f1f0dfd86960ef4f306ac6ed5a9c
Reviewed-on: https://code.wireshark.org/review/17565
Reviewed-by: Anders Broman 
(cherry picked from commit 03e4307cb2daf1f208d3653b04f64580ee6d0c38)
Reviewed-on: https://code.wireshark.org/review/17572
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  3264cb5   IRemUnknown: initialize remunk_remqueryinterface_call_t 
structure
adds  b0eb538   NBT: fix  Bad description for NBSS error code 0x81


Summary of changes:
 epan/dissectors/packet-nbt.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 1948f7b: nfs: add dissector for CB_NOTIFY_LOCK args

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1948f7bd7553f215dc2519a35dcd62e29e35a614
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

1948f7b by Jeff Layton (jlay...@redhat.com):

nfs: add dissector for CB_NOTIFY_LOCK args

Show the filehandle and lockowner for the callback.

Change-Id: Id09b260d4b31f8fa35ba8452dc143095e5cc88ec
Signed-off-by: Jeff Layton 
Reviewed-on: https://code.wireshark.org/review/17574
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  6519f8e   OCFS2: dissector incorrectly parses LVB data and claims 
malformed message
adds  1948f7b   nfs: add dissector for CB_NOTIFY_LOCK args


Summary of changes:
 epan/dissectors/packet-nfs.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 6519f8e: OCFS2: dissector incorrectly parses LVB data and claims malformed message

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6519f8e4e81d838e49bf4e4cef179f968378f62d
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

6519f8e by Makoto Shimamura (makoto.shimam...@toshiba.co.jp):

OCFS2: dissector incorrectly parses LVB data and claims malformed message

Some messages related to LVB data are mistakenly treated as malformed.
This patch fixes it by checking LVB flags before parsing LVB data.
I found that "Convert lock" and "Unlock" use PUT_LVB flags, but "Proxy AST" 
uses GET_LVB flags.

Ping-Bug: 12122
Change-Id: I2c62c8cc9f9bd84abaf92de9f216550101962520
Reviewed-on: https://code.wireshark.org/review/17532
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Michael Mann 


Actions performed:

from  bd45929   extcap_child_watch_cb() always uses the status argument.
adds  6519f8e   OCFS2: dissector incorrectly parses LVB data and claims 
malformed message


Summary of changes:
 epan/dissectors/packet-ocfs2.c |   72 +---
 1 file changed, 46 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.2 5193363: extcap_child_watch_cb() always uses the status argument.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51933630e9044c87bee5ae370ca3ca341d57e30e
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

5193363 by Guy Harris (g...@alum.mit.edu):

extcap_child_watch_cb() always uses the status argument.

Change-Id: I2537f2e3babe2158796acda6855f5aebeb0b7d4d
Reviewed-on: https://code.wireshark.org/review/17595
Reviewed-by: Guy Harris 
(cherry picked from commit bd45929ba6075c4f41a3df87d823cb2dac3bae55)
Reviewed-on: https://code.wireshark.org/review/17596


Actions performed:

from  fa74120   Fix compilation on FreeBSD.
adds  5193363   extcap_child_watch_cb() always uses the status argument.


Summary of changes:
 extcap.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master bd45929: extcap_child_watch_cb() always uses the status argument.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd45929ba6075c4f41a3df87d823cb2dac3bae55
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

bd45929 by Guy Harris (g...@alum.mit.edu):

extcap_child_watch_cb() always uses the status argument.

Change-Id: I2537f2e3babe2158796acda6855f5aebeb0b7d4d
Reviewed-on: https://code.wireshark.org/review/17595
Reviewed-by: Guy Harris 


Actions performed:

from  f1a7497   IRemUnknown: initialize remunk_remqueryinterface_call_t 
structure
adds  bd45929   extcap_child_watch_cb() always uses the status argument.


Summary of changes:
 extcap.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.2 fa74120: Fix compilation on FreeBSD.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa74120b75dca2923598cd1964132751bbfc058f
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

fa74120 by Michael Tuexen (tue...@wireshark.org):

Fix compilation on FreeBSD.

Includes are needed for using macros like WIFEXITED.

Change-Id: Ia09ca58eeab2d151a756d285b0aeb55141c4d24a
Reviewed-on: https://code.wireshark.org/review/16841
Reviewed-by: Michael Tüxen 
(cherry picked from commit 18f775af55ddf60aa72b4d2b3d635701d1ac50b1)
Reviewed-on: https://code.wireshark.org/review/17594
Reviewed-by: Guy Harris 


Actions performed:

from  602f7a3   IRemUnknown: initialize remunk_remqueryinterface_call_t 
structure
adds  fa74120   Fix compilation on FreeBSD.


Summary of changes:
 extcap.c |7 +++
 1 file changed, 7 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 3264cb5: IRemUnknown: initialize remunk_remqueryinterface_call_t structure

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3264cb5f5200c9cc01d075465c5f41f20eac929d
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

3264cb5 by Pascal Quantin (pascal.quan...@gmail.com):

IRemUnknown: initialize remunk_remqueryinterface_call_t structure

Bug: 12841
Change-Id: I5916c30a18029d0872e0439d3393eaa6d27964dd
Reviewed-on: https://code.wireshark.org/review/17589
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 
(cherry picked from commit f1a7497b5341dba1f07bac9894a713263257b08f)
Reviewed-on: https://code.wireshark.org/review/17592


Actions performed:

from  fb0cf79   2.0.6 → 2.0.7.
adds  3264cb5   IRemUnknown: initialize remunk_remqueryinterface_call_t 
structure


Summary of changes:
 epan/dissectors/packet-dcom-remunkn.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 602f7a3: IRemUnknown: initialize remunk_remqueryinterface_call_t structure

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=602f7a3641593a8be597eb4a9a1b48f7310aeb4e
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

602f7a3 by Pascal Quantin (pascal.quan...@gmail.com):

IRemUnknown: initialize remunk_remqueryinterface_call_t structure

Bug: 12841
Change-Id: I5916c30a18029d0872e0439d3393eaa6d27964dd
Reviewed-on: https://code.wireshark.org/review/17589
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 
(cherry picked from commit f1a7497b5341dba1f07bac9894a713263257b08f)
Reviewed-on: https://code.wireshark.org/review/17591


Actions performed:

from  d1b03dc   U3V: ensure that gencp_transaction_t structure is fully 
initialized
adds  602f7a3   IRemUnknown: initialize remunk_remqueryinterface_call_t 
structure


Summary of changes:
 epan/dissectors/packet-dcom-remunkn.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master f1a7497: IRemUnknown: initialize remunk_remqueryinterface_call_t structure

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1a7497b5341dba1f07bac9894a713263257b08f
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

f1a7497 by Pascal Quantin (pascal.quan...@gmail.com):

IRemUnknown: initialize remunk_remqueryinterface_call_t structure

Bug: 12841
Change-Id: I5916c30a18029d0872e0439d3393eaa6d27964dd
Reviewed-on: https://code.wireshark.org/review/17589
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  fb85325   IPP: fix use after free error
adds  f1a7497   IRemUnknown: initialize remunk_remqueryinterface_call_t 
structure


Summary of changes:
 epan/dissectors/packet-dcom-remunkn.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master fb85325: IPP: fix use after free error

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb85325d695a2c8d7b78073f5f493dfbfe496956
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

fb85325 by Pascal Quantin (pascal.quan...@gmail.com):

IPP: fix use after free error

Packet memory pool is already freed when columns are printed

Bug: 12840
Change-Id: If3e63586f14872aafe701612998370fffe506443
Reviewed-on: https://code.wireshark.org/review/17584
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  2f0a99e   M2AP: fix a typo leading to an expert info when decoding an 
IPv6 address
adds  fb85325   IPP: fix use after free error


Summary of changes:
 epan/dissectors/packet-ipp.c |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 2f0a99e: M2AP: fix a typo leading to an expert info when decoding an IPv6 address

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f0a99eab34b36bba3e5069be155b05665cc8783
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2f0a99e by Pascal Quantin (pascal.quan...@gmail.com):

M2AP: fix a typo leading to an expert info when decoding an IPv6 address

Change-Id: I10b67541427ca39a8f1d0989d680841b9d7883c9
Reviewed-on: https://code.wireshark.org/review/17581
Reviewed-by: Pascal Quantin 


Actions performed:

from  d0e55f0   M3AP: fix dissection of IP address
adds  2f0a99e   M2AP: fix a typo leading to an expert info when decoding an 
IPv6 address


Summary of changes:
 epan/dissectors/asn1/m2ap/m2ap.cnf |6 +++---
 epan/dissectors/packet-m2ap.c  |6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master d0e55f0: M3AP: fix dissection of IP address

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d0e55f0f6dd6850bdf7c082f859f8d3d913fa943
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d0e55f0 by Pascal Quantin (pascal.quan...@gmail.com):

M3AP: fix dissection of IP address

Change-Id: I96faed61c33f6fe14cc4196c3440d873b69d5334
Reviewed-on: https://code.wireshark.org/review/17585
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  a1368ce   Use get_nonzero_guint32() to fetch guint32 values.
adds  d0e55f0   M3AP: fix dissection of IP address


Summary of changes:
 epan/dissectors/asn1/m3ap/m3ap.cnf   |   10 ++--
 epan/dissectors/asn1/m3ap/packet-m3ap-template.c |5 +-
 epan/dissectors/packet-m3ap.c|   63 +++---
 3 files changed, 42 insertions(+), 36 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-09-08 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/11987

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] fcb6fd3b6fcc6b3ed56cbd81c419b28920f2ec70
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master a1368ce: Use get_nonzero_guint32() to fetch guint32 values.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a1368ce47d155cb00437c7189285808a3271e3c9
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

a1368ce by Guy Harris (g...@alum.mit.edu):

Use get_nonzero_guint32() to fetch guint32 values.

Change-Id: I3adeb2974b1093270bec12039cd855c92f660f4d
Reviewed-on: https://code.wireshark.org/review/17588
Reviewed-by: Guy Harris 


Actions performed:

from  83eb448   Fix the signature of the stub version of ws80211_set_freq().
adds  a1368ce   Use get_nonzero_guint32() to fetch guint32 values.


Summary of changes:
 dumpcap.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 83eb448: Fix the signature of the stub version of ws80211_set_freq().

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83eb448dfcf7804582f904a8f253718bbfbd5e3c
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

83eb448 by Guy Harris (g...@alum.mit.edu):

Fix the signature of the stub version of ws80211_set_freq().

Change-Id: I5f0da4fb5d8d452f3cff3d37e0749dde8e98b600
Reviewed-on: https://code.wireshark.org/review/17587
Reviewed-by: Guy Harris 


Actions performed:

from  fcb6fd3   dumpcap: change types.
adds  83eb448   Fix the signature of the stub version of ws80211_set_freq().


Summary of changes:
 caputils/ws80211_utils.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master fcb6fd3: dumpcap: change types.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fcb6fd3b6fcc6b3ed56cbd81c419b28920f2ec70
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

fcb6fd3 by Dario Lombardo (lom...@gmail.com):

dumpcap: change types.

Change-Id: I6520971e607623dadcb3ae392ce264bf49c621bd
Reviewed-on: https://code.wireshark.org/review/17499
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 


Actions performed:

from  e09b03e   Add get_ routines to get a guint32, and use them.
adds  fcb6fd3   dumpcap: change types.


Summary of changes:
 caputils/ws80211_utils.c |4 ++--
 caputils/ws80211_utils.h |2 +-
 dumpcap.c|   10 +-
 3 files changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master e09b03e: Add get_ routines to get a guint32, and use them.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e09b03e9b131b3a43e4d8e43cc2c667bcb8d0a68
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

e09b03e by Guy Harris (g...@alum.mit.edu):

Add get_ routines to get a guint32, and use them.

By analogy to get_natural_int() and get_positive_int(), add routines to
get a guint32 and to get a non-zero guint32, doing all the necessary
error checks, and use it.

Change-Id: I65a9ac8a3d136886df3588806ae7af5bdc7b8cb6
Reviewed-on: https://code.wireshark.org/review/17586
Reviewed-by: Guy Harris 


Actions performed:

from  132632b   editcap: use ws_strtou/i functions.
adds  e09b03e   Add get_ routines to get a guint32, and use them.


Summary of changes:
 editcap.c  |   41 +++--
 wsutil/clopts_common.c |   34 +-
 wsutil/clopts_common.h |6 ++
 3 files changed, 50 insertions(+), 31 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 132632b: editcap: use ws_strtou/i functions.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=132632bcd96e4ee1ad8e395926af2050545878c4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

132632b by Dario Lombardo (lom...@gmail.com):

editcap: use ws_strtou/i functions.

Change-Id: Ib69241eb04088fe32f53ac4e87911499cf5e9e40
Reviewed-on: https://code.wireshark.org/review/17500
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 


Actions performed:

from  468acff   PER: only display internal extension presence bit if 
activated in preferences
adds  132632b   editcap: use ws_strtou/i functions.


Summary of changes:
 editcap.c |   51 +--
 1 file changed, 25 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 468acff: PER: only display internal extension presence bit if activated in preferences

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=468acff2bd38227ff04421cb964fe0cea0eeeccb
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

468acff by Pascal Quantin (pascal.quan...@gmail.com):

PER: only display internal extension presence bit if activated in
preferences

Change-Id: I889b32c5e609c8c10ed2a8aa5a5e6d5b88baadc4
Reviewed-on: https://code.wireshark.org/review/17580
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  6652620   M2AP: display IP address in a subtree
adds  468acff   PER: only display internal extension presence bit if 
activated in preferences


Summary of changes:
 epan/dissectors/packet-per.c |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] [wireshark] annotated tag v2.0.7rc0 created (now fdb0f84)

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fdb0f8485e2504672d87bb498215fb1e7c06c200
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: annotated tag: v2.0.7rc0
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  fdb0f84   (tag)
 tagging  fb0cf79ece0447b6129757c87de3ae8efe4ce6d6 (commit)
  replaces  wireshark-2.0.6
 tagged by  Gerald Combs
on  Thu Sep 8 10:48:03 2016 -0700

- Log -
2.0.6 → 2.0.7.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAABCgAGBQJX0aRoAAoJEIIkSnjm/q7qmwMQALtCsMwB0WwNl9B90QZm+DUv
/mVkWfSxoEC+gkCAOHWHxQ/RkshC8xoc0wwcpENN7W3JyBQYPBe3SRHsTUr4KJOX
vO6T/SWBbWwXj58hIvVhMVsg0Dmb1wXjQ+0obcQuQO6HkLYpRrCaL34yZH2aEa71
0EpUMmOlk1J56rBG7wOdtQ9uG0QxMh2cLnkuG+7Ep5Ttt1uc4Ma60e2xIQCTz4j4
Af3SKM1TDYPVHCNObFZk7t1F/K2KBvr5FuJxmuFEp5CE7vbuXube72F67MQUlGB8
c20w8HVkve/a/o4D+rIghH+lIZS520PqtNEJAAL4UwhNtCP+VX0UniEl1YqvaLve
MMCCWIrK/16HZq0E+Kk3Cg3Tp6B/QgRad6U3YG+J/TqjaP9ZBIsLih7JYTlpBCva
HytcYYF9YpwERZeetXH6ERksu7wolrIiN0qjAElMw3peVUXazLyxH3hJLKipe1oV
eD6HK5+XJFHzjIm34iCr3P/myh20W+diBot1HO38o2UQ8Y+I1OQWuwnqb2LF9TK0
sjdIeaHsp9eEAt8Gm+7tYCaGJSg5QLJ3pPj0iAsRjT0aGJJt1fftEsvYmVgYo52Q
NN/Xe9BDDZ8TkeJh+2CCEWK1QMNEBomBYd6tw50F9aZSHILdUn5CNbSKCu4i3+Ji
T+nGtXlt63bstKmYIcBx
=mLcf
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6652620: M2AP: display IP address in a subtree

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6652620f272a1d408e291e2738576af1c3127333
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

6652620 by Pascal Quantin (pascal.quan...@gmail.com):

M2AP: display IP address in a subtree

Change-Id: Ic1853e1d265797e482495b8d07aa324545a7442e
Reviewed-on: https://code.wireshark.org/review/17579
Reviewed-by: Pascal Quantin 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 


Actions performed:

from  1e83b59   U3V: ensure that gencp_transaction_t structure is fully 
initialized
adds  6652620   M2AP: display IP address in a subtree


Summary of changes:
 epan/dissectors/asn1/m2ap/m2ap.cnf   |   11 +--
 epan/dissectors/asn1/m2ap/packet-m2ap-template.c |2 +
 epan/dissectors/packet-m2ap.c|   81 +++---
 3 files changed, 50 insertions(+), 44 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.0 fb0cf79: 2.0.6 → 2.0.7.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb0cf79ece0447b6129757c87de3ae8efe4ce6d6
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

fb0cf79 by Gerald Combs (ger...@wireshark.org):

2.0.6 → 2.0.7.

Change-Id: If8d52bdc61fb066469194bf814531bec8418ee1a
Reviewed-on: https://code.wireshark.org/review/17583
Reviewed-by: Gerald Combs 


Actions performed:

from  d0e42d7   Build 2.0.6.
adds  fb0cf79   2.0.6 → 2.0.7.


Summary of changes:
 CMakeLists.txt |2 +-
 config.nmake   |2 +-
 configure.ac   |2 +-
 debian/changelog   |2 +-
 docbook/asciidoc.conf  |2 +-
 docbook/release-notes.asciidoc |  111 +++-
 epan/CMakeLists.txt|2 +-
 epan/Makefile.am   |2 +-
 make-version.pl|2 +-
 version.conf   |   12 ++---
 wiretap/CMakeLists.txt |2 +-
 wiretap/Makefile.am|2 +-
 12 files changed, 22 insertions(+), 121 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag wireshark-2.0.6 created (now 833f5a1)

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=833f5a14846c3e5857c5098c40402634c6f6ad87
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: annotated tag: wireshark-2.0.6
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  833f5a1   (tag)
 tagging  d0e42d78193cfacd1022656cd8dad7fc222e6dbc (commit)
  replaces  v2.0.6rc0
 tagged by  Gerald Combs
on  Thu Sep 8 09:13:24 2016 -0700

- Log -
Build 2.0.6.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAABCgAGBQJX0Y4qAAoJEIIkSnjm/q7qUWQQAMCz7aIP6uAsxYsrM05N3GNC
RtgodE7qHcAZW2pP3J2cIoCwzWHKglnwEi7Fzm0jTMtWfR6KG0V9txle+fcT6l64
WzUubH3qM1Lvs04Ls74RFuQtbU7dIykOazvai1DMbR1Pa4up6xtb2PalUb8644zW
YYb7/fuklSIo/YQ46FJu2+az2J7dreUc3vwnWKf1nzMinjLnvH1zpYWN5cX1hGef
6nky8OPeGpEQIX+RgOp7PRd5+P89vryzBEjn7eKWFyWif+EO6Wtep9viYOn+j72c
8gu/pKlKi+EvghYx4o4pv0lbDA0ArmXKj+nRY830S0Tw36hQB1SReU8EB76KfTL/
7VS05XU+zzyjiIFGg+aKUK9g/FtLwaGqexiPGJApukYE/doVYo/V3XYznxFOzeW3
zZB8yD3o3/FYDhohaCBF2SvTGOhoJeJVcF0edTqLTLPxRudeO9cHYtoWqEZC8/WV
yuUic06abXXkNPNGFlUWUjd7ZVpLYTpep1KenZK2/1LW3IjcBHOXgXW90LTqJndY
fp/sEdGecTnTXfVSq4dZwLkPVqLZsv8t5mXVFzZ16nMvJxPi4sOGse7e5mBjzfku
BmWH78K0INb3hI2yXMry0KcNrP5xiBc8spwcvR72hcgd2GNveQnvU9lqh3+yNDZx
6L98XptqIrniiOHOMyAg
=Qf0D
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] [wireshark] annotated tag v2.0.6 created (now 0833176)

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=083317686ac08e858dd28595fad4ad563d02e07e
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: annotated tag: v2.0.6
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  0833176   (tag)
 tagging  d0e42d78193cfacd1022656cd8dad7fc222e6dbc (commit)
  replaces  v2.0.6rc0
 tagged by  Gerald Combs
on  Thu Sep 8 09:12:59 2016 -0700

- Log -
Build 2.0.6.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAABCgAGBQJX0Y4cAAoJEIIkSnjm/q7qgJ0QAMBujhmf1yFeaiw2qCBnZdNV
1dNOnU72Wkx0K8bm7mwoCm3R8tYUWdXBuaks7Pm/NRAAI1hrDvhsEnISlIqpc8Qs
jfmhRaSVHpQIdrmg8a+rCZBNC0+ZkTUIRlZOiQ4XlK1XkdUQGY5NdEIzFJye3/ls
fb8VfpOTtyXBfU5232h+RZbsJ3TxhLwwE5s3bouxc8XdDuvR4A38odQdNH6ZzwG7
Ri9wXLcgiVPQJsvG1WqfDhTD/K8XpqrMGefEDQ5R2xPwEhwGg0XmsC/QKgRxM3U1
Pr0ANYKQlvhy8S216nbAkkcwHFE1ZiJfYP/qv8mME97PMz/JaaWpEQCrLfhyuMrD
OtD1lKikQe+Rd1QfX6pNBF2AiJjBPcWLtye0D1LKwKfvogFJ0WGTt39tb4Dx/nY6
HwNcz0Owy43CCE4t7/zMj9++Fj4WUnSDQiY/9IorzoMfXowBpCz9c8XYDKOcW/aW
kQH5EoE8f5g0y0Bxhul87+j+ASBF60f0QDNLooO4AIQwnxP2T6aqZgMZw676/Rh0
sYCz/fi7Km9OktKDsG0vh1E+GdNWro675s+JYH2hQQ04ZWosCkyzVurHMnG/KRjf
ZS5DBtmrL3OHvE2+W1gxjOeuIjlwyXuaTKQh4tEvGnHJtL1meecQRTrj9FRQcCi0
9LgpqDAseKcvkREmMg1X
=iU0V
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.0 d0e42d7: Build 2.0.6.

2016-09-08 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d0e42d78193cfacd1022656cd8dad7fc222e6dbc
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

d0e42d7 by Gerald Combs (ger...@wireshark.org):

Build 2.0.6.

Change-Id: I40566106df1641b4ca2cdbb2e4795c2160922df0
Reviewed-on: https://code.wireshark.org/review/17582
Reviewed-by: Gerald Combs 


Actions performed:

from  11ed97f   OCFS2: dissector incorrectly takes pdu length as little 
endian
adds  d0e42d7   Build 2.0.6.


Summary of changes:
 ChangeLog  | 1538 
 NEWS   |  247 +++
 docbook/release-notes.asciidoc |   25 +
 version.conf   |   12 +-
 4 files changed, 1680 insertions(+), 142 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe