[Wireshark-commits] master-2.2 eb2dd01: Note that we're shipping Qt 5.6 on Windows.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eb2dd01d8780505ace28e9e214bc452cd18429de
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

eb2dd01 by Gerald Combs (ger...@wireshark.org):

Note that we're shipping Qt 5.6 on Windows.

Change-Id: I5eb3c9c0eab95bc2e6b8f489f04577947276bef5
Reviewed-on: https://code.wireshark.org/review/17675
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  8960d2e   Remove unnecessary extcap_cleanup() declaration.
adds  eb2dd01   Note that we're shipping Qt 5.6 on Windows.


Summary of changes:
 docbook/release-notes.asciidoc |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 99fff00: WSDG: Updates for Qt 5.6.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99fff00e020748514ee80efd0cea28d0148f4bdd
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

99fff00 by Gerald Combs (ger...@wireshark.org):

WSDG: Updates for Qt 5.6.

Refer to Qt 5.6 for Windows builds. Update the download URL.

Change-Id: Id4de0d55679a6ac1b7aac82ddd5eb80d6b54568a
Reviewed-on: https://code.wireshark.org/review/17674
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  6c4b0ff   telnet: get rid of atoi().
adds  99fff00   WSDG: Updates for Qt 5.6.


Summary of changes:
 docbook/wsdg_src/WSDG_chapter_quick_setup.asciidoc |   24 +++-
 1 file changed, 13 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/179

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] 687799bde27033e56e168649b06a7cc5fad5e0ad
Blamelist: Guy Harris 

BUILD FAILED: failed compile_4 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/1670

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] f2d6d07498b42637134a08459458cdda679380e0
Blamelist: Guy Harris 

BUILD FAILED: failed compile_5 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%20Server%202012%20R2%20x64/builds/354

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 9e952d63a2c2fe77161c3e37bde5eed0d7dc55f0
Blamelist: Guy Harris 

BUILD FAILED: failed compile_4 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6c4b0ff: telnet: get rid of atoi().

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c4b0ffe9119e9e48bbe3e3cd2fa7d0c0fb70d2e
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

6c4b0ff by Dario Lombardo (lom...@gmail.com):

telnet: get rid of atoi().

Change-Id: Id445aef1af21fcf176611122a757482c0b22f4bd
Reviewed-on: https://code.wireshark.org/review/17662
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  8443643   Fix file name in comment.
adds  6c4b0ff   telnet: get rid of atoi().


Summary of changes:
 epan/dissectors/packet-telnet.c |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c837ecc: fix some compilation issues without extcap.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c837eccb97126bf0c56bd4ef896a03c9254f0e83
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c837ecc by Dario Lombardo (lom...@gmail.com):

fix some compilation issues without extcap.

Change-Id: I18c855e13281013a6277c1f38eeac92e74d52b34
Reviewed-on: https://code.wireshark.org/review/17665
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 
(cherry picked from commit e3247b3a71f1bdb89c40573412ab7b2181212a98)
Reviewed-on: https://code.wireshark.org/review/17670
Reviewed-by: Guy Harris 


Actions performed:

from  687799b   Fix file name in comment.
adds  c837ecc   fix some compilation issues without extcap.


Summary of changes:
 rawshark.c   |9 -
 tfshark.c|   10 ++
 tshark.c |   10 ++
 ui/gtk/main.c|2 ++
 wireshark-qt.cpp |2 ++
 5 files changed, 32 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 8960d2e: Remove unnecessary extcap_cleanup() declaration.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8960d2e8c11cf3f573c5acbacc1b558cd493a808
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8960d2e by Guy Harris (g...@alum.mit.edu):

Remove unnecessary extcap_cleanup() declaration.

That wasn't sufficient to avoid #ifdeffing calls to extcap_cleanup(), as
this header wasn't even being included if HAVE_EXTCAP wasn't defined,
hence change I18c855e13281013a6277c1f38eeac92e74d52b34 was necessary.

It's probably best that this not be included if HAVE_EXTCAP isn't
defined, so as to catch *other* references to functions etc. that aren't
available without extcap.

Change-Id: I5c4ad331b6df93bbbcd28ad3b9815e4cd226039a
Reviewed-on: https://code.wireshark.org/review/17666
Reviewed-by: Guy Harris 
(cherry picked from commit f2d6d07498b42637134a08459458cdda679380e0)
Reviewed-on: https://code.wireshark.org/review/17671


Actions performed:

from  c837ecc   fix some compilation issues without extcap.
adds  8960d2e   Remove unnecessary extcap_cleanup() declaration.


Summary of changes:
 extcap.h |4 
 1 file changed, 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 9e952d6: Fix file name in comment.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9e952d63a2c2fe77161c3e37bde5eed0d7dc55f0
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9e952d6 by Guy Harris (g...@alum.mit.edu):

Fix file name in comment.

Change-Id: I2a5b6e5c0ba8e729fbfa7e9e218aca1c747d6e45
Reviewed-on: https://code.wireshark.org/review/17667
Reviewed-by: Guy Harris 
(cherry picked from commit 84436438a8cbcb533839584b0eef2eb43f4b5396)
Reviewed-on: https://code.wireshark.org/review/17669


Actions performed:

from  956d175   Qt: Word wrap static text preferences
adds  9e952d6   Fix file name in comment.


Summary of changes:
 extcap.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 687799b: Fix file name in comment.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=687799bde27033e56e168649b06a7cc5fad5e0ad
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

687799b by Guy Harris (g...@alum.mit.edu):

Fix file name in comment.

Change-Id: I2a5b6e5c0ba8e729fbfa7e9e218aca1c747d6e45
Reviewed-on: https://code.wireshark.org/review/17667
Reviewed-by: Guy Harris 
(cherry picked from commit 84436438a8cbcb533839584b0eef2eb43f4b5396)
Reviewed-on: https://code.wireshark.org/review/17668


Actions performed:

from  ba5a44f   Qt: Word wrap static text preferences
adds  687799b   Fix file name in comment.


Summary of changes:
 extcap.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8443643: Fix file name in comment.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=84436438a8cbcb533839584b0eef2eb43f4b5396
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

8443643 by Guy Harris (g...@alum.mit.edu):

Fix file name in comment.

Change-Id: I2a5b6e5c0ba8e729fbfa7e9e218aca1c747d6e45
Reviewed-on: https://code.wireshark.org/review/17667
Reviewed-by: Guy Harris 


Actions performed:

from  f2d6d07   Remove unnecessary extcap_cleanup() declaration.
adds  8443643   Fix file name in comment.


Summary of changes:
 extcap.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f2d6d07: Remove unnecessary extcap_cleanup() declaration.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2d6d07498b42637134a08459458cdda679380e0
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

f2d6d07 by Guy Harris (g...@alum.mit.edu):

Remove unnecessary extcap_cleanup() declaration.

That wasn't sufficient to avoid #ifdeffing calls to extcap_cleanup(), as
this header wasn't even being included if HAVE_EXTCAP wasn't defined,
hence change I18c855e13281013a6277c1f38eeac92e74d52b34 was necessary.

It's probably best that this not be included if HAVE_EXTCAP isn't
defined, so as to catch *other* references to functions etc. that aren't
available without extcap.

Change-Id: I5c4ad331b6df93bbbcd28ad3b9815e4cd226039a
Reviewed-on: https://code.wireshark.org/review/17666
Reviewed-by: Guy Harris 


Actions performed:

from  cea1737   Let strtoi with NULL endptr require no invalid characters
adds  f2d6d07   Remove unnecessary extcap_cleanup() declaration.


Summary of changes:
 extcap.h |4 
 1 file changed, 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master cea1737: Let strtoi with NULL endptr require no invalid characters

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cea1737bd218aa84bf41637deee25bd199fb128d
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

cea1737 by Peter Wu (pe...@lekensteyn.nl):

Let strtoi with NULL endptr require no invalid characters

If the caller is not interested in checking its end, then it probably
wants a valid number only if the string contains a valid number. Add a
shortcut for this.

Change-Id: I39701bd445e29fb2606720b18ca3764c74a7255b
Reviewed-on: https://code.wireshark.org/review/17658
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 
Reviewed-by: Dario Lombardo 


Actions performed:

from  e3247b3   fix some compilation issues without extcap.
adds  cea1737   Let strtoi with NULL endptr require no invalid characters


Summary of changes:
 wsutil/clopts_common.c |   10 --
 wsutil/strtoi.c|4 ++--
 wsutil/strtoi.h|8 +---
 3 files changed, 11 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e3247b3: fix some compilation issues without extcap.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3247b3a71f1bdb89c40573412ab7b2181212a98
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e3247b3 by Dario Lombardo (lom...@gmail.com):

fix some compilation issues without extcap.

Change-Id: I18c855e13281013a6277c1f38eeac92e74d52b34
Reviewed-on: https://code.wireshark.org/review/17665
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  159d431   androiddump: fix memleaks
adds  e3247b3   fix some compilation issues without extcap.


Summary of changes:
 rawshark.c   |9 -
 tfshark.c|   10 ++
 tshark.c |   10 ++
 ui/gtk/main.c|2 ++
 wireshark-qt.cpp |2 ++
 5 files changed, 32 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 159d431: androiddump: fix memleaks

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=159d4317dc5eff3a450bac44610f9023e96b50e5
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

159d431 by Peter Wu (pe...@lekensteyn.nl):

androiddump: fix memleaks

Most of the actions (e.g.  `androiddump --extcap-interfaces`) return
immediately without cleaning up. Fix this by adding a common exit path.

Change-Id: If02b18da49d866fb5525306e52fbf4590d98ecd2
Reviewed-on: https://code.wireshark.org/review/17634
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 
Reviewed-by: Dario Lombardo 
Reviewed-by: Peter Wu 


Actions performed:

from  26bf66f   extcap: plug more memory leaks
adds  159d431   androiddump: fix memleaks


Summary of changes:
 extcap/androiddump.c |   58 ++
 1 file changed, 35 insertions(+), 23 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 26bf66f: extcap: plug more memory leaks

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26bf66f423489fa3128d406c949954be5c39455c
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

26bf66f by Peter Wu (pe...@lekensteyn.nl):

extcap: plug more memory leaks

Fix leak of the preference key name which happen for every new extcap
argument. Fix leak of extcap arguments and the interface names in
extcap_register_preferences.

Change-Id: Idd68f924baa000303043cb98b32b23ce34fddb64
Reviewed-on: https://code.wireshark.org/review/17637
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  c64762d   extcap: Fix misc memory leaks triggered by network 
interface changes
adds  26bf66f   extcap: plug more memory leaks


Summary of changes:
 extcap.c |   38 +++---
 1 file changed, 23 insertions(+), 15 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c64762d: extcap: Fix misc memory leaks triggered by network interface changes

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c64762d33c3a9cbc4af4040284534b440d12b210
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

c64762d by Mikael Kanstrup (mikael.kanst...@gmail.com):

extcap: Fix misc memory leaks triggered by network interface changes

Valgrind reports plenty of misc memory leaks in extcap after the network
interface list has changed or is refreshed. Errors can be seen by
starting Wireshark with Valgrind's memcheck tool and bringing a network
interface up and down a few times with:

ifconfig eth0 up
ifconfig eth0 down

Change-Id: I90f53847071854b7d02facb39b7a380732de79b4
Reviewed-on: https://code.wireshark.org/review/17606
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  e079862   cmake: fix breakage with libnl2
adds  c64762d   extcap: Fix misc memory leaks triggered by network 
interface changes


Summary of changes:
 extcap.c|   60 ---
 extcap.h|9 ++
 extcap_parser.c |   37 +++-
 extcap_spawn.c  |3 ++
 ui/qt/extcap_options_dialog.cpp |   12 +---
 5 files changed, 86 insertions(+), 35 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e079862: cmake: fix breakage with libnl2

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e079862fad331cba874717ec1d0af9e35ba438b5
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

e079862 by Peter Wu (pe...@lekensteyn.nl):

cmake: fix breakage with libnl2

I accidentally assumed that libnl2 works fine with just libnl.so, but
apparently the other libraries are also necessary.

Change-Id: I1636710ea3f41ed10a5ccb37106cae9e688abec9
Reviewed-on: https://code.wireshark.org/review/17654
Reviewed-by: Michal Labedzki 
Petri-Dish: Michal Labedzki 
Tested-by: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  3c70e6d   dmp: Code cleanup
adds  e079862   cmake: fix breakage with libnl2


Summary of changes:
 cmake/modules/FindNL.cmake |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/162

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] ba5a44fbfc9a56c04e36d4c3becaf26fbf880fa1
Blamelist: Stig Bjørlykke 

BUILD FAILED: failed compile_4 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/7431

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 68fafcf43f096c2db01527a2265570f7a1ffe373
Blamelist: Stig Bjørlykke 

BUILD FAILED: failed compile_5 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/1664

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 68fafcf43f096c2db01527a2265570f7a1ffe373
Blamelist: Stig Bjørlykke 

BUILD FAILED: failed compile_5 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3c70e6d: dmp: Code cleanup

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c70e6d684ff822806e0dd9d1a46c5350825d012
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

3c70e6d by Stig Bjørlykke (s...@bjorlykke.org):

dmp: Code cleanup

Change-Id: I06c80ca44e8f727c9dc8ec552117ff60e44a7ef4
Reviewed-on: https://code.wireshark.org/review/17659
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  b28cd2d   Qt: Word wrap static text preferences
adds  3c70e6d   dmp: Code cleanup


Summary of changes:
 epan/dissectors/packet-dmp.c |  136 ++
 1 file changed, 84 insertions(+), 52 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 956d175: Qt: Word wrap static text preferences

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=956d175219e554227dcc84f4da2f01f647c6c949
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

956d175 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Word wrap static text preferences

The preferences static text may be too long for the preferences
dialog width, so set word wrap for this label.

Change-Id: I0828601b39a5e189de707087e317c598576fc3db
Reviewed-on: https://code.wireshark.org/review/17656
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit b28cd2dbd78bfeecd0209142f6dd6a8e8ad8aa90)
Reviewed-on: https://code.wireshark.org/review/17660
(cherry picked from commit ba5a44fbfc9a56c04e36d4c3becaf26fbf880fa1)
Reviewed-on: https://code.wireshark.org/review/17661


Actions performed:

from  1c46fb0   [Automatic update for 2016-09-11]
adds  956d175   Qt: Word wrap static text preferences


Summary of changes:
 ui/qt/module_preferences_scroll_area.cpp |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 ba5a44f: Qt: Word wrap static text preferences

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba5a44fbfc9a56c04e36d4c3becaf26fbf880fa1
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ba5a44f by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Word wrap static text preferences

The preferences static text may be too long for the preferences
dialog width, so set word wrap for this label.

Change-Id: I0828601b39a5e189de707087e317c598576fc3db
Reviewed-on: https://code.wireshark.org/review/17656
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit b28cd2dbd78bfeecd0209142f6dd6a8e8ad8aa90)
Reviewed-on: https://code.wireshark.org/review/17660


Actions performed:

from  53a33ea   dumpcap: fix memleak on exit
adds  ba5a44f   Qt: Word wrap static text preferences


Summary of changes:
 ui/qt/module_preferences_scroll_area.cpp |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b28cd2d: Qt: Word wrap static text preferences

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b28cd2dbd78bfeecd0209142f6dd6a8e8ad8aa90
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

b28cd2d by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Word wrap static text preferences

The preferences static text may be too long for the preferences
dialog width, so set word wrap for this label.

Change-Id: I0828601b39a5e189de707087e317c598576fc3db
Reviewed-on: https://code.wireshark.org/review/17656
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  68fafcf   dmp: Remove obsolete structured id handling
adds  b28cd2d   Qt: Word wrap static text preferences


Summary of changes:
 ui/qt/module_preferences_scroll_area.cpp |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 68fafcf: dmp: Remove obsolete structured id handling

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=68fafcf43f096c2db01527a2265570f7a1ffe373
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

68fafcf by Stig Bjørlykke (s...@bjorlykke.org):

dmp: Remove obsolete structured id handling

The structured id handling is not in use by anyone.

Change-Id: I643fb03f642a5c1900aaec7d41e2b66dba5a2b05
Reviewed-on: https://code.wireshark.org/review/17655
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  2e42199   [SELFM] Fix reassembly, tcp_dissect_pdus() can't be used as 
the real length of the PDU is not known(length is exluding escape bytes).
adds  68fafcf   dmp: Remove obsolete structured id handling


Summary of changes:
 epan/dissectors/packet-dmp.c |  133 ++
 1 file changed, 5 insertions(+), 128 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2e42199: [SELFM] Fix reassembly, tcp_dissect_pdus() can't be used as the real length of the PDU is not known(length is exluding escape bytes).

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e42199e1177f01b5cd1789b0cbe112d36f05fbc
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2e42199 by AndersBroman (anders.bro...@ericsson.com):

[SELFM] Fix reassembly, tcp_dissect_pdus() can't be used as the real
length of the PDU is not known(length is exluding escape bytes).

Change-Id: I762419f12ca80f6597163e232c4b853819927b65
Reviewed-on: https://code.wireshark.org/review/17302
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  4fe91cf   S1AP: add missing messages in info column
adds  2e42199   [SELFM] Fix reassembly, tcp_dissect_pdus() can't be used as 
the real length of the PDU is not known(length is exluding escape bytes).


Summary of changes:
 epan/dissectors/packet-selfm.c |  141 
 1 file changed, 85 insertions(+), 56 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 53a33ea: dumpcap: fix memleak on exit

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=53a33ea9cc8b1c9a8865c5439ce99227b30ef6a9
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

53a33ea by Peter Wu (pe...@lekensteyn.nl):

dumpcap: fix memleak on exit

Invocation of tshark -D (dumpcap -D -Z none) under ASAN fails with:

tshark: Child dumpcap process died: Abort - core dumped

Change-Id: Ida363089066205d579e841b019b32c2e33516f12
Reviewed-on: https://code.wireshark.org/review/17633
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 456312e22b06dd900ce11776f35321c0a158ea7e)
Reviewed-on: https://code.wireshark.org/review/17653
Reviewed-by: Guy Harris 


Actions performed:

from  a7d7c29   [Automatic update for 2016-09-11]
adds  53a33ea   dumpcap: fix memleak on exit


Summary of changes:
 dumpcap.c |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe