[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/1713

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 41567191d8c19d2b27571f9c1713fa1f9d6bd11a
Blamelist: Peter Wu 

BUILD FAILED: failed

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4156719: TLS(1.3): Add Share Key (40) Hello extension

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41567191d8c19d2b27571f9c1713fa1f9d6bd11a
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

4156719 by Alexis La Goutte (alexis.lagou...@gmail.com):

TLS(1.3): Add Share Key (40) Hello extension

Bug: 12779
Change-Id: I5cbc911f2c7818558c5182d2e3ccf9235be9281b
Reviewed-on: https://code.wireshark.org/review/17301
Reviewed-by: Peter Wu 


Actions performed:

from  5540df7   TLS: Pass directly the handshake_type to 
dissect_hnd_hello_ext
adds  4156719   TLS(1.3): Add Share Key (40) Hello extension


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   63 
 epan/dissectors/packet-ssl-utils.h |   32 --
 2 files changed, 93 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/197

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] 6a2c63ac4897f23f29334ad3890cd5b800a50881
Blamelist: Stig Bjørlykke 

BUILD FAILED: failed compile_4 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%20Server%202012%20R2%20x64/builds/358

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] f768cda482a6df24294cd7a451248fa2d189329e
Blamelist: Stig Bjørlykke 

BUILD FAILED: failed compile_4 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5540df7: TLS: Pass directly the handshake_type to dissect_hnd_hello_ext

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5540df7a82a4a3ef0ce0b51536dd93d296b77483
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

5540df7 by Alexis La Goutte (alexis.lagou...@gmail.com):

TLS: Pass directly the handshake_type to dissect_hnd_hello_ext

with TLS 1.3, there is a new 'Hello' type (Hello Retry Request)

Change-Id: If7a11b70a5b0a69044126c50e1d6ab4e1d443f77
Reviewed-on: https://code.wireshark.org/review/17573
Reviewed-by: Peter Wu 


Actions performed:

from  c1d9ce4   TLS(1.3): Add new Hello extension list
adds  5540df7   TLS: Pass directly the handshake_type to 
dissect_hnd_hello_ext


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   53 +++-
 1 file changed, 34 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c1d9ce4: TLS(1.3): Add new Hello extension list

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1d9ce47b5164dc010ff525335e9fa48446d7023
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

c1d9ce4 by Alexis La Goutte (alexis.lagou...@gmail.com):

TLS(1.3): Add new Hello extension list

* Key share (40)
* Pre-Shared Key (41)
* Early Data (42)
* Cookie (44)

Bug: 12779
Change-Id: I16e3cf691ae66e244608db233db180e24538a68d
Reviewed-on: https://code.wireshark.org/review/17239
Reviewed-by: Peter Wu 


Actions performed:

from  d32b116   TLS(1.3): Add (experimental) extension 'Draft version TLS 
1.3'
adds  c1d9ce4   TLS(1.3): Add new Hello extension list


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |4 
 epan/dissectors/packet-ssl-utils.h |4 
 2 files changed, 8 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d32b116: TLS(1.3): Add (experimental) extension 'Draft version TLS 1.3'

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d32b116d408bfc64f74d7a98ad518e7cd0d4d688
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

d32b116 by Alexis La Goutte (alexis.lagou...@gmail.com):

TLS(1.3): Add (experimental) extension 'Draft version TLS 1.3'

Coming from 
https://github.com/tlswg/tls13-spec/wiki/Implementations#version-negotiation

Bug: 12779
Change-Id: Ieca74eac737b5ba6c101b719e2e5e3aecf931279
Reviewed-on: https://code.wireshark.org/review/17226
Reviewed-by: Peter Wu 


Actions performed:

from  7319887   TLS(1.3): Fix Server Hello
adds  d32b116   TLS(1.3): Add (experimental) extension 'Draft version TLS 
1.3'


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |6 ++
 epan/dissectors/packet-ssl-utils.h |   11 ++-
 2 files changed, 16 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7319887: TLS(1.3): Fix Server Hello

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7319887c3169adba91d0f3fd1b5201354e246979
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

7319887 by Alexis La Goutte (alexis.lagou...@gmail.com):

TLS(1.3): Fix Server Hello

There is no session_id and compression method with TLS 1.3 Server Hello

Also no time on first bytes of random field

Bug: 12779
Change-Id: Id79221c2ad50695cf6d46cd5c9255deab99e2d2c
Reviewed-on: https://code.wireshark.org/review/17225
Reviewed-by: Peter Wu 


Actions performed:

from  778f7c5   TLS(1.3): Add TLS 1.3 value for version Handshake
adds  7319887   TLS(1.3): Fix Server Hello


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   82 
 epan/dissectors/packet-ssl-utils.h |   10 -
 2 files changed, 54 insertions(+), 38 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 778f7c5: TLS(1.3): Add TLS 1.3 value for version Handshake

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=778f7c52cc454d97e3ff560ebf7fa9694da56e98
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

778f7c5 by Alexis La Goutte (alexis.lagou...@gmail.com):

TLS(1.3): Add TLS 1.3 value for version Handshake

Bug: 12779
Change-Id: I298ecf4a0537df2e88354aed6912d4298a094216
Reviewed-on: https://code.wireshark.org/review/17224
Reviewed-by: Peter Wu 


Actions performed:

from  ee2c4da   Qt: Reset expert info icon when start capture failed
adds  778f7c5   TLS(1.3): Add TLS 1.3 value for version Handshake


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |3 +++
 epan/dissectors/packet-ssl-utils.h |1 +
 2 files changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 f768cda: Qt: Reset expert info icon when start capture failed

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f768cda482a6df24294cd7a451248fa2d189329e
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

f768cda by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Reset expert info icon when start capture failed

When starting capture fails the expert info icon must be removed
and the file status must be cleared.  This happens more frequently
when using sshdump with configuration errors.

Change-Id: I9b2215c71bd16406a0978256018b1664f06c19f1
Reviewed-on: https://code.wireshark.org/review/17741
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit ee2c4da947a6e7ae638efa464d9eb09c9082fa00)
Reviewed-on: https://code.wireshark.org/review/17751
(cherry picked from commit 6a2c63ac4897f23f29334ad3890cd5b800a50881)
Reviewed-on: https://code.wireshark.org/review/17752


Actions performed:

from  a7a4846   ssl-utils: fix buffer overrun (read) with AEAD cipher suites
adds  f768cda   Qt: Reset expert info icon when start capture failed


Summary of changes:
 ui/qt/main_window_slots.cpp |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 6a2c63a: Qt: Reset expert info icon when start capture failed

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a2c63ac4897f23f29334ad3890cd5b800a50881
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

6a2c63a by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Reset expert info icon when start capture failed

When starting capture fails the expert info icon must be removed
and the file status must be cleared.  This happens more frequently
when using sshdump with configuration errors.

Change-Id: I9b2215c71bd16406a0978256018b1664f06c19f1
Reviewed-on: https://code.wireshark.org/review/17741
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit ee2c4da947a6e7ae638efa464d9eb09c9082fa00)
Reviewed-on: https://code.wireshark.org/review/17751


Actions performed:

from  dfa8729   Qt: Argument vector fixups.
adds  6a2c63a   Qt: Reset expert info icon when start capture failed


Summary of changes:
 ui/qt/main_window_slots.cpp |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ee2c4da: Qt: Reset expert info icon when start capture failed

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee2c4da947a6e7ae638efa464d9eb09c9082fa00
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

ee2c4da by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Reset expert info icon when start capture failed

When starting capture fails the expert info icon must be removed
and the file status must be cleared.  This happens more frequently
when using sshdump with configuration errors.

Change-Id: I9b2215c71bd16406a0978256018b1664f06c19f1
Reviewed-on: https://code.wireshark.org/review/17741
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  686d72f   Type and size cleanups.
adds  ee2c4da   Qt: Reset expert info icon when start capture failed


Summary of changes:
 ui/qt/main_window_slots.cpp |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 686d72f: Type and size cleanups.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=686d72fc7d8a71f63a51f02cee08d269e55cdb81
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

686d72f by Guy Harris (g...@alum.mit.edu):

Type and size cleanups.

Use size_t for sizes.  Do checks to make sure we don't overflow ints.

Change-Id: Id0846cc5c6348d67a23064517ad1c432cf1cb61a
Reviewed-on: https://code.wireshark.org/review/17742
Petri-Dish: Guy Harris 
Reviewed-by: Guy Harris 


Actions performed:

from  ef527fa   M3AP: remove Procedure Code from info column
adds  686d72f   Type and size cleanups.


Summary of changes:
 extcap/androiddump.c |   47 +++
 1 file changed, 39 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ef527fa: M3AP: remove Procedure Code from info column

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef527fa9618eeb24824de1be9a84c2126fe46290
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ef527fa by Pascal Quantin (pascal.quan...@gmail.com):

M3AP: remove Procedure Code from info column

Change-Id: I69aebed5000f6544eede69e7435fb49e4e0ce179
Reviewed-on: https://code.wireshark.org/review/17744
Reviewed-by: Pascal Quantin 


Actions performed:

from  953b85c   M2AP: remove Procedure Code from info column
adds  ef527fa   M3AP: remove Procedure Code from info column


Summary of changes:
 epan/dissectors/asn1/m3ap/m3ap.cnf   |5 --
 epan/dissectors/asn1/m3ap/packet-m3ap-template.c |2 +
 epan/dissectors/packet-m3ap.c|   67 +++---
 3 files changed, 34 insertions(+), 40 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 953b85c: M2AP: remove Procedure Code from info column

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=953b85c1d42c3daf73ba08dea861ae13122e6879
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

953b85c by Pascal Quantin (pascal.quan...@gmail.com):

M2AP: remove Procedure Code from info column

Change-Id: I965cc0455f5f3ac8a676cc0e3453e8a449d76109
Reviewed-on: https://code.wireshark.org/review/17743
Reviewed-by: Pascal Quantin 


Actions performed:

from  770a873   Add ws_hexstrtou{bits} and use ws_hexstrtou32 in 
androiddump.
adds  953b85c   M2AP: remove Procedure Code from info column


Summary of changes:
 epan/dissectors/asn1/m2ap/m2ap.cnf   |5 --
 epan/dissectors/asn1/m2ap/packet-m2ap-template.c |2 +
 epan/dissectors/packet-m2ap.c|   81 +++---
 3 files changed, 41 insertions(+), 47 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 dfa8729: Qt: Argument vector fixups.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dfa87296ab89407feb136d68f82755fbe9e9c923
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

dfa8729 by Gerald Combs (ger...@wireshark.org):

Qt: Argument vector fixups.

In wireshark-qt.cpp we have two "argv" variables, one that we pass to
QCoreApplication (which it then corrupts irreversibly on Windows if you
pass it multibyte characters), and one that we convert to UTF-8 and use
normally.

Name the throwaway argument vector "qt_argv". Name ours "argv", which is
the traditional and less error-prone name.

Bug: 12900
Change-Id: Idd80b9f779f36ffe977465afd623d320212f92b1
Reviewed-on: https://code.wireshark.org/review/17723
Reviewed-by: Gerald Combs 
(cherry picked from commit f317a2b304f50392b360ac95de995459a24c3b7d)
Reviewed-on: https://code.wireshark.org/review/17739
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  cb5a292   ssl-utils: fix buffer overrun (read) with AEAD cipher suites
adds  dfa8729   Qt: Argument vector fixups.


Summary of changes:
 wireshark-qt.cpp |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/7472

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 770a8737d7dd0772078d4711fce186c6b3915b20
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 770a873: Add ws_hexstrtou{bits} and use ws_hexstrtou32 in androiddump.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=770a8737d7dd0772078d4711fce186c6b3915b20
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

770a873 by Guy Harris (g...@alum.mit.edu):

Add ws_hexstrtou{bits} and use ws_hexstrtou32 in androiddump.

Make the reply length unsigned - there's no reason for it to be signed.

Change-Id: I5f4d1f027eeddee939547c052220efb89800f4b1
Reviewed-on: https://code.wireshark.org/review/17740
Reviewed-by: Guy Harris 


Actions performed:

from  1ca260b   udpdump: use socket_handle_t instead of int for portability.
adds  770a873   Add ws_hexstrtou{bits} and use ws_hexstrtou32 in 
androiddump.


Summary of changes:
 extcap/androiddump.c |8 +++-
 wsutil/strtoi.c  |  106 ++
 wsutil/strtoi.h  |   20 +-
 3 files changed, 88 insertions(+), 46 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1ca260b: udpdump: use socket_handle_t instead of int for portability.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1ca260bbb4126423acc2c6c8199ab2831fad995d
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

1ca260b by Dario Lombardo (lom...@gmail.com):

udpdump: use socket_handle_t instead of int for portability.

Change-Id: Ic31302046e95d1678073a8a77812316be367e9a5
Reviewed-on: https://code.wireshark.org/review/17736
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Graham Bloice 
Reviewed-by: Dario Lombardo 


Actions performed:

from  f317a2b   Qt: Argument vector fixups.
adds  1ca260b   udpdump: use socket_handle_t instead of int for portability.


Summary of changes:
 extcap/udpdump.c |   22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f317a2b: Qt: Argument vector fixups.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f317a2b304f50392b360ac95de995459a24c3b7d
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

f317a2b by Gerald Combs (ger...@wireshark.org):

Qt: Argument vector fixups.

In wireshark-qt.cpp we have two "argv" variables, one that we pass to
QCoreApplication (which it then corrupts irreversibly on Windows if you
pass it multibyte characters), and one that we convert to UTF-8 and use
normally.

Name the throwaway argument vector "qt_argv". Name ours "argv", which is
the traditional and less error-prone name.

Bug: 12900
Change-Id: Idd80b9f779f36ffe977465afd623d320212f92b1
Reviewed-on: https://code.wireshark.org/review/17723
Reviewed-by: Gerald Combs 


Actions performed:

from  547a5c8   eap: add identity details.
adds  f317a2b   Qt: Argument vector fixups.


Summary of changes:
 wireshark-qt.cpp |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 547a5c8: eap: add identity details.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=547a5c8c9e71a19fd44addec741289da4febcbe3
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

547a5c8 by Dario Lombardo (lom...@gmail.com):

eap: add identity details.

Change-Id: I60e017ac48d9daf52b8a40809625dc1ae09c9d8e
Reviewed-on: https://code.wireshark.org/review/17735
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  3120536   Have TPKT support a TCP port range preference instead of 
having "subdissectors?" register their own.
adds  547a5c8   eap: add identity details.


Summary of changes:
 epan/dissectors/packet-eap.c |   58 +++---
 1 file changed, 55 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12058

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] d67c1db3f2b16185d7cff250e098f48d94883f0e
Blamelist: Dario Lombardo 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3120536: Have TPKT support a TCP port range preference instead of having "subdissectors?" register their own.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3120536012bc85361e2e5cd204bd4aa91fb67ff6
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

3120536 by Michael Mann (mman...@netscape.net):

Have TPKT support a TCP port range preference instead of having 
"subdissectors?" register their own.

There are a number of dissectors who are subdissectors of TPKT (and OSITP) 
that are
not called by TCP dissector directly, yet can possibly register a TCP port 
"on the
behalf" of TPKT.  Just allow TPKT to support a range of ports to possibly 
include
these protocols.
Remove the preferences from these dissectors, but add backwards 
compatibility for
the preferences by hooking into set_prefs and have the preferences just 
hook into
Decode As functionality directly.

Change-Id: Ic1b4959d39607f2b6b20fa6508da8d87d04cf098
Reviewed-on: https://code.wireshark.org/review/17476
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  d67c1db   extcap: make extcap use the ws_strtoi/u functions.
adds  3120536   Have TPKT support a TCP port range preference instead of 
having "subdissectors?" register their own.


Summary of changes:
 epan/dissectors/asn1/dap/packet-dap-template.c   |   37 ++
 epan/dissectors/asn1/disp/packet-disp-template.c |   37 +++---
 epan/dissectors/asn1/dop/packet-dop-template.c   |   36 ++
 epan/dissectors/asn1/dsp/packet-dsp-template.c   |   36 ++
 epan/dissectors/asn1/p1/packet-p1-template.c |   36 +++---
 epan/dissectors/asn1/p7/packet-p7-template.c |   37 ++
 epan/dissectors/packet-dap.c |   55 ++--
 epan/dissectors/packet-disp.c|   49 +-
 epan/dissectors/packet-dop.c |   48 --
 epan/dissectors/packet-dsp.c |   48 --
 epan/dissectors/packet-p1.c  |   56 ++---
 epan/dissectors/packet-p7.c  |   57 ++---
 epan/dissectors/packet-rdp.c |   38 ++
 epan/dissectors/packet-tpkt.c|   35 ++---
 epan/prefs.c |   58 ++
 15 files changed, 202 insertions(+), 461 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d67c1db: extcap: make extcap use the ws_strtoi/u functions.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d67c1db3f2b16185d7cff250e098f48d94883f0e
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d67c1db by Dario Lombardo (lom...@gmail.com):

extcap: make extcap use the ws_strtoi/u functions.

Change-Id: Id75c72eba869c8a0f413ce8b5d6329ce172aed1f
Reviewed-on: https://code.wireshark.org/review/17415
Petri-Dish: Dario Lombardo 
Reviewed-by: Roland Knall 
Reviewed-by: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Dario Lombardo 


Actions performed:

from  2492fe4   VTP: Always display reserved/unsed fields
adds  d67c1db   extcap: make extcap use the ws_strtoi/u functions.


Summary of changes:
 extcap/androiddump.c|   18 ++
 extcap/ciscodump.c  |   23 +--
 extcap/randpktdump.c|   14 +-
 extcap/ssh-base.c   |2 +-
 extcap/ssh-base.h   |4 +++-
 extcap/sshdump.c|   23 +--
 randpkt_core/randpkt_core.h |2 --
 7 files changed, 53 insertions(+), 33 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2492fe4: VTP: Always display reserved/unsed fields

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2492fe41ba165738aa8667ebfe7f9e96f69ef350
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2492fe4 by Alexis La Goutte (alexis.lagou...@gmail.com):

VTP: Always display reserved/unsed fields

Change-Id: Ib0b065c20e599567224c05068dad5bd24a711609
Reviewed-on: https://code.wireshark.org/review/17728
Petri-Dish: Alexis La Goutte 
Reviewed-by: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  e4aa7be   ZigBee: Fix reassembly of APS fragments.
adds  2492fe4   VTP: Always display reserved/unsed fields


Summary of changes:
 epan/dissectors/packet-vtp.c |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e4aa7be: ZigBee: Fix reassembly of APS fragments.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4aa7be94943369c7f8119d7f15135d3f07b56df
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e4aa7be by Kenneth Soerensen (knnthsr...@gmail.com):

ZigBee: Fix reassembly of APS fragments.

The unsigned variable num_blocks was initialized to -1. Which caused the
dissector to set the total length to 4294967295 fragments when the second
fragment was processed. This made the dissector unable to reassemble data
made of more than two fragments.

Change-Id: I120af090ed29ac73a1fa699bea2bfc91798ef92b
Reviewed-on: https://code.wireshark.org/review/17712
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  663031e   ssl-utils: fix -Wshorten-64-to-32 and other warnings
adds  e4aa7be   ZigBee: Fix reassembly of APS fragments.


Summary of changes:
 epan/dissectors/packet-zbee-aps.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 663031e: ssl-utils: fix -Wshorten-64-to-32 and other warnings

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=663031e4a84850fdeeab52cd36f44117664b285c
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

663031e by Peter Wu (pe...@lekensteyn.nl):

ssl-utils: fix -Wshorten-64-to-32 and other warnings

Fixes -Wshorten-64-to-32 from v2.3.0rc0-697-gb1d36fe ("ssl-utils: remove
block and key sizes from cipher suites table"), -Wpointer-sign,
-Wunreachable-code-break.

Change-Id: I37ca5e9effe5d6560d49ccef53e9feb096cd2ad6
Reviewed-on: https://code.wireshark.org/review/17727
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  6d13aeb   ws_strou16() now takes three arguments.
adds  663031e   ssl-utils: fix -Wshorten-64-to-32 and other warnings


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6d13aeb: ws_strou16() now takes three arguments.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6d13aebde939c8d3eb3f60410dbeb953b139a299
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6d13aeb by Guy Harris (g...@alum.mit.edu):

ws_strou16() now takes three arguments.

Change-Id: I94a3a8707de724b1b4c2fafaa4c96d2a52b418c6
Reviewed-on: https://code.wireshark.org/review/17732
Reviewed-by: Guy Harris 


Actions performed:

from  689ff93   Squelch some compiler warnings.
adds  6d13aeb   ws_strou16() now takes three arguments.


Summary of changes:
 extcap/udpdump.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 689ff93: Squelch some compiler warnings.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=689ff93474c61984adcf5ad0bd3230e77dd83545
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

689ff93 by Guy Harris (g...@alum.mit.edu):

Squelch some compiler warnings.

gcry_cipher_get_algo_keylen() returns a size_t, which is bigger than a
guint on most if not all 64-bit platforms; however, if the key is bigger
than 2^32 bytes, we have bigger problems, so just cast it down.

Change-Id: Ia7c97d2742686daf2e42f634c6e349cb580fa9df
Reviewed-on: https://code.wireshark.org/review/17731
Reviewed-by: Guy Harris 


Actions performed:

from  47650d3   extcap: add udpdump.
adds  689ff93   Squelch some compiler warnings.


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/7464

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 47650d357e3115e89b854f195b385855c4703a21
Blamelist: Peter Wu ,Roland Knall 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/17075

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] b1d36fe0df74266be57878f16f80790d41dfcf6c
Blamelist: Alexis La Goutte 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 a7a4846: ssl-utils: fix buffer overrun (read) with AEAD cipher suites

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7a4846eb1ddcbf56030f2677b2792423e26f400
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a7a4846 by Peter Wu (pe...@lekensteyn.nl):

ssl-utils: fix buffer overrun (read) with AEAD cipher suites

ssl_cipher_init should only set the IV for CBC cipher suites. NULL
cipher suites will not invoke gcry_cipher_setiv and AEAD ciphers will
set the nonce in a different place anyway.

Fixes a buffer overrun (read) by 12 bytes for any AES-CCM and AES-GCM
cipher suite because the "block size" is set to 4 bytes while the
reported block size for AES is 16 bytes (128 bit). (The four bytes are
the "salt" part of the nonce that is extracted from the "client/server
write IV" part of the key block.)

Observed with the DTLS packet capture from

https://ask.wireshark.org/questions/55487/decrypt-application-data-pending-dtls-abbreviated-handshake-using-psk

Change-Id: I4cc7216f2d77cbd1eac9a40dca3fdfde7e7b3680
Reviewed-on: https://code.wireshark.org/review/17713
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
(cherry picked from commit 979df813dc60358d3f6972d6ca8f5c97ea7b747b)
Reviewed-on: https://code.wireshark.org/review/17730
Reviewed-by: Peter Wu 


Actions performed:

from  73892d4   Fix a test to work with Xcode 8.
adds  a7a4846   ssl-utils: fix buffer overrun (read) with AEAD cipher suites


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 cb5a292: ssl-utils: fix buffer overrun (read) with AEAD cipher suites

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb5a2926cfa988cf8da3057f07fd1569d4895f0c
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master-2.2
Repository: wireshark

Commits:

cb5a292 by Peter Wu (pe...@lekensteyn.nl):

ssl-utils: fix buffer overrun (read) with AEAD cipher suites

ssl_cipher_init should only set the IV for CBC cipher suites. NULL
cipher suites will not invoke gcry_cipher_setiv and AEAD ciphers will
set the nonce in a different place anyway.

Fixes a buffer overrun (read) by 12 bytes for any AES-CCM and AES-GCM
cipher suite because the "block size" is set to 4 bytes while the
reported block size for AES is 16 bytes (128 bit). (The four bytes are
the "salt" part of the nonce that is extracted from the "client/server
write IV" part of the key block.)

Observed with the DTLS packet capture from

https://ask.wireshark.org/questions/55487/decrypt-application-data-pending-dtls-abbreviated-handshake-using-psk

Change-Id: I4cc7216f2d77cbd1eac9a40dca3fdfde7e7b3680
Reviewed-on: https://code.wireshark.org/review/17713
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
(cherry picked from commit 979df813dc60358d3f6972d6ca8f5c97ea7b747b)
Reviewed-on: https://code.wireshark.org/review/17729
Reviewed-by: Peter Wu 


Actions performed:

from  2ace9b2   Qt: Avoid crashes in IAX2 Stream Analysis
adds  cb5a292   ssl-utils: fix buffer overrun (read) with AEAD cipher suites


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 47650d3: extcap: add udpdump.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=47650d357e3115e89b854f195b385855c4703a21
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

47650d3 by Dario Lombardo (lom...@gmail.com):

extcap: add udpdump.

Udpdump is a generic UDP receiver that exports datagram in PCAP format.

Change-Id: I52620a92b12530b6f9b5449c43e692663acdfc14
Reviewed-on: https://code.wireshark.org/review/17195
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Roland Knall 


Actions performed:

from  1cd3587   ssl-utils: fix runtime memory leak
adds  47650d3   extcap: add udpdump.


Summary of changes:
 .gitignore |1 +
 CMakeLists.txt |   21 +++
 CMakeOptions.txt   |1 +
 configure.ac   |   28 
 doc/CMakeLists.txt |3 +
 doc/udpdump.pod|  128 
 extcap/Makefile.am |   22 ++-
 extcap/udpdump.c   |  416 
 8 files changed, 618 insertions(+), 2 deletions(-)
 create mode 100644 doc/udpdump.pod
 create mode 100644 extcap/udpdump.c
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12052

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] b1d36fe0df74266be57878f16f80790d41dfcf6c
Blamelist: Alexis La Goutte 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1cd3587: ssl-utils: fix runtime memory leak

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1cd3587b739c5e5aa1b5fd75c8df4ca374f4a6ff
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

1cd3587 by Peter Wu (pe...@lekensteyn.nl):

ssl-utils: fix runtime memory leak

Ensure that Libgcrypt and zlib memory are freed when closing a pcap.

Change-Id: I420f9950911d95d59ff046fee57900ca6f7e9621
Reviewed-on: https://code.wireshark.org/review/17718
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Peter Wu 


Actions performed:

from  b1d36fe   ssl-utils: remove block and key sizes from cipher suites 
table
adds  1cd3587   ssl-utils: fix runtime memory leak


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   26 +-
 1 file changed, 21 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/1699

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] b1d36fe0df74266be57878f16f80790d41dfcf6c
Blamelist: Alexis La Goutte 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 2ace9b2: Qt: Avoid crashes in IAX2 Stream Analysis

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ace9b2f3aa64394b9625a6cfe19a2625c38de6f
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2ace9b2 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Avoid crashes in IAX2 Stream Analysis

Avoid crash when opening IAX2 Stream Analysis without having any
packets and when not having a selected packet.  Also disable the
Save Audio options if not having any IAX2 packets.

Also set Close as default button.

Change-Id: I1da04e3f907d9d562fa227ab9f0428aa6097131e
Reviewed-on: https://code.wireshark.org/review/17708
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
Reviewed-by: Michael Mann 
(cherry picked from commit f674ef75d765a7933774b8659ca20ef0ef16e78d)
Reviewed-on: https://code.wireshark.org/review/17726
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  3a1f272   Don't pick up junk from an unset error-number variable.
adds  2ace9b2   Qt: Avoid crashes in IAX2 Stream Analysis


Summary of changes:
 ui/qt/iax2_analysis_dialog.cpp |   15 +--
 ui/qt/iax2_analysis_dialog.h   |1 +
 2 files changed, 14 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b1d36fe: ssl-utils: remove block and key sizes from cipher suites table

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1d36fe0df74266be57878f16f80790d41dfcf6c
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

b1d36fe by Peter Wu (pe...@lekensteyn.nl):

ssl-utils: remove block and key sizes from cipher suites table

There was an implicit dependency between the block size in the cipher
suites table and the size expected by Libgcrypt. Just remove the block
size from the table and rely on the value from Libgcrypt to avoid the
risk of mismatching values (which could lead to a buffer overflow).

While at it, remove the size of the key ("bits") and the size of key
material ("eff_bits") too. Move the key material sizes for export
ciphers away from the table and use byte quantities instead of bits.

Additionally, this fixes an issue where 8 bytes of uninitialized stack
memory is written to the SSL debug log for stream ciphers like RC4.
The size of the Write Key is also corrected for export ciphers, now it
prints the actual (restricted) number of bytes that are used.

Change-Id: I71d3c83ece0f02b2e11e45455dc08c41740836be
Reviewed-on: https://code.wireshark.org/review/17714
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  979df81   ssl-utils: fix buffer overrun (read) with AEAD cipher suites
adds  b1d36fe   ssl-utils: remove block and key sizes from cipher suites 
table


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |  709 +++-
 epan/dissectors/packet-ssl-utils.h |   10 +-
 epan/dissectors/packet-ssl.c   |2 +-
 3 files changed, 390 insertions(+), 331 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe