[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/17168

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 8ca846436d14da6079a51da4111a860e0f357c36
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12149

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 8ca846436d14da6079a51da4111a860e0f357c36
Blamelist: Michael Mann 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 31cd04e: ssh: use ws_strtoi function.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31cd04e901d6c730b00ecac231d828fcc8bb5577
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

31cd04e by Dario Lombardo (lom...@gmail.com):

ssh: use ws_strtoi function.

Change-Id: Iafcb721eb6081902dd6b5c3a2258ae5c2ccd95e9
Reviewed-on: https://code.wireshark.org/review/17822
Reviewed-by: Michael Mann 


Actions performed:

from  8ca8464   idl2wrs: use ws_strtou function
adds  31cd04e   ssh: use ws_strtoi function.


Summary of changes:
 epan/dissectors/packet-ssh.c |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8ca8464: idl2wrs: use ws_strtou function

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ca846436d14da6079a51da4111a860e0f357c36
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

8ca8464 by Dario Lombardo (lom...@gmail.com):

idl2wrs: use ws_strtou function

Change-Id: I90173b0defc04ac80054170153afe9389def620b
Reviewed-on: https://code.wireshark.org/review/17837
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  3c9fb07   iscsi: use ws_strtou functions.
adds  8ca8464   idl2wrs: use ws_strtou function


Summary of changes:
 epan/dissectors/dcerpc/CMakeLists.txt |2 +-
 epan/dissectors/dcerpc/Makefile.am|2 +-
 epan/dissectors/dcerpc/idl2wrs.c  |8 ++--
 3 files changed, 8 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3c9fb07: iscsi: use ws_strtou functions.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c9fb071191a211af756faedd7647cf80e542639
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

3c9fb07 by Dario Lombardo (lom...@gmail.com):

iscsi: use ws_strtou functions.

Add expert info for failed conversion.

Change-Id: I03d5e2db791f81d43384bb047c268d07709a6099
Reviewed-on: https://code.wireshark.org/review/17863
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  06b09ee   Changes to 1722.1 / MAAP to work with 1722 draft15
adds  3c9fb07   iscsi: use ws_strtou functions.


Summary of changes:
 epan/dissectors/packet-iscsi.c |   26 +-
 1 file changed, 21 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 06b09ee: Changes to 1722.1 / MAAP to work with 1722 draft15

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06b09eea72ecbfe937a89a5887274e445b4c1bbf
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

06b09ee by Andreas Leibold (andreas.leib...@harman.com):

Changes to 1722.1 / MAAP to work with 1722 draft15

The C/D control flag was integrated in the subtype field of 1722 after
draft 6. These changes are now added to the 1722-1 and MAAP protocol.

Change-Id: I19b2e8237fb87d42ec7bcb6f9f53e8cc8605731d
Reviewed-on: https://code.wireshark.org/review/17664
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  75ae538   ssl: fix exact matching of ALPN protocol names
adds  06b09ee   Changes to 1722.1 / MAAP to work with 1722 draft15


Summary of changes:
 epan/dissectors/packet-ieee1722.c  |4 +---
 epan/dissectors/packet-ieee17221.c |6 +++---
 epan/dissectors/packet-maap.c  |2 +-
 3 files changed, 5 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/1797

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 46aba5a3407be21db89fff8ed3be4bed4883e806
Blamelist: Michael Mann 

BUILD FAILED: failed compile_5 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%20Server%202012%20R2%20x64/builds/374

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 31977d99ef327f604f371681d8ab51ab253e9870
Blamelist: Michael Mann 

BUILD FAILED: failed compile_4 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 75ae538: ssl: fix exact matching of ALPN protocol names

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75ae538514f55f8faa114ce31fc5a2a1d7b7ef22
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

75ae538 by Peter Wu (pe...@lekensteyn.nl):

ssl: fix exact matching of ALPN protocol names

The "name_length >= alpn_proto->proto_name_len" condition always failed
to match for short names (like "h2" where the reported length is 2, but
the proto_name_len would be 3).

This fixes recognition of HTTP/2 traffic, without this patch it would be
interpreted as http-over-tls as reported on

https://ask.wireshark.org/questions/55720/how-to-install-http2-dissector-plugin

Change-Id: Idc3eae0b6d593c8f3c435230ef76da90a4b1e7fc
Reviewed-on: https://code.wireshark.org/review/17907
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  46aba5a   doc: add the -d (decode as) option to wireshark(1)
adds  75ae538   ssl: fix exact matching of ALPN protocol names


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   21 +++--
 1 file changed, 11 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 31977d9: doc: add the -d (decode as) option to wireshark(1)

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31977d99ef327f604f371681d8ab51ab253e9870
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

31977d9 by Peter Wu (pe...@lekensteyn.nl):

doc: add the -d (decode as) option to wireshark(1)

Text is partially copied from the tshark manual page.

Change-Id: I120e327f15394fc48fce6e4a122e7eab83e91c82
Reviewed-on: https://code.wireshark.org/review/17904
Reviewed-by: Michael Mann 
(cherry picked from commit 46aba5a3407be21db89fff8ed3be4bed4883e806)
Reviewed-on: https://code.wireshark.org/review/17908
(cherry picked from commit faa10f23d682d1316fc4a3dc770ebe9164e35e77)
Reviewed-on: https://code.wireshark.org/review/17909


Actions performed:

from  b288ac8   6LowPAN: initialize interface identifier even when no 
data-link source is found
adds  31977d9   doc: add the -d (decode as) option to wireshark(1)


Summary of changes:
 doc/wireshark.pod.template |   13 +
 1 file changed, 13 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 faa10f2: doc: add the -d (decode as) option to wireshark(1)

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=faa10f23d682d1316fc4a3dc770ebe9164e35e77
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

faa10f2 by Peter Wu (pe...@lekensteyn.nl):

doc: add the -d (decode as) option to wireshark(1)

Text is partially copied from the tshark manual page.

Change-Id: I120e327f15394fc48fce6e4a122e7eab83e91c82
Reviewed-on: https://code.wireshark.org/review/17904
Reviewed-by: Michael Mann 
(cherry picked from commit 46aba5a3407be21db89fff8ed3be4bed4883e806)
Reviewed-on: https://code.wireshark.org/review/17908


Actions performed:

from  d22bad9   6LowPAN: initialize interface identifier even when no 
data-link source is found
adds  faa10f2   doc: add the -d (decode as) option to wireshark(1)


Summary of changes:
 doc/wireshark.pod.template |   13 +
 1 file changed, 13 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 46aba5a: doc: add the -d (decode as) option to wireshark(1)

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=46aba5a3407be21db89fff8ed3be4bed4883e806
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

46aba5a by Peter Wu (pe...@lekensteyn.nl):

doc: add the -d (decode as) option to wireshark(1)

Text is partially copied from the tshark manual page.

Change-Id: I120e327f15394fc48fce6e4a122e7eab83e91c82
Reviewed-on: https://code.wireshark.org/review/17904
Reviewed-by: Michael Mann 


Actions performed:

from  cacb4a4   Editcap: Fix comparsion between signed and unsigned int
adds  46aba5a   doc: add the -d (decode as) option to wireshark(1)


Summary of changes:
 doc/wireshark.pod.template |   13 +
 1 file changed, 13 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master cacb4a4: Editcap: Fix comparsion between signed and unsigned int

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cacb4a428715b6a77ddee50d87d5dffe1f83557c
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

cacb4a4 by Uli Heilmeier (u...@heilmeier.eu):

Editcap: Fix comparsion between signed and unsigned int

secs_per_block is a unsigned integer. Therefore we can't
compare a signed integer with it.

Change-Id: Ic965a88e0e704e296c4af9193ca4a3504173ae36
Reviewed-on: https://code.wireshark.org/review/17901
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  17546ad   Check for ASAN when fuzzing.
adds  cacb4a4   Editcap: Fix comparsion between signed and unsigned int


Summary of changes:
 editcap.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 17546ad: Check for ASAN when fuzzing.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17546ad88378fbeaad25e571e0fa35e7a5bfa622
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

17546ad by Gerald Combs (ger...@wireshark.org):

Check for ASAN when fuzzing.

Try to determine if we passed -fsanitize=address to gcc or clang and
adjust the ASAN variable fuzz-test.sh, randpkt-test.sh and
test-captures.sh accordingly.

Change-Id: I88a34828fb5875e1a74a3b180ffb3da37daac0bd
Reviewed-on: https://code.wireshark.org/review/17848
Reviewed-by: Pascal Quantin 


Actions performed:

from  8b04755   ssl-utils: fix decryption of NULL ciphers
adds  17546ad   Check for ASAN when fuzzing.


Summary of changes:
 tools/fuzz-test.sh |2 +-
 tools/randpkt-test.sh  |2 +-
 tools/test-captures.sh |4 ++--
 tools/test-common.sh   |9 +
 4 files changed, 13 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8b04755: ssl-utils: fix decryption of NULL ciphers

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b047554ee93fbbf7731da371df0779acc9fc87a
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

8b04755 by Peter Wu (pe...@lekensteyn.nl):

ssl-utils: fix decryption of NULL ciphers

A dissector bug was reported:

epan/dissectors/packet-ssl-utils.c:1615: failed assertion "data"

and fair enough, the MAC Key is indeed NULL because of our special
handling for NULL ciphers. Just ignore the MAC key then.

Change-Id: I12d2be5e84520badb44a99fc965c48c3afa89346
Fixes: v2.3.0rc0-697-gb1d36fe ("ssl-utils: remove block and key sizes from 
cipher suites table")
Reviewed-on: https://code.wireshark.org/review/17903
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  ca232b1   Udpdump: Fix g_debug() for ssize_t buflen
adds  8b04755   ssl-utils: fix decryption of NULL ciphers


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ca232b1: Udpdump: Fix g_debug() for ssize_t buflen

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca232b1d129f55a65c53bddb1f215208a32c2ec6
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ca232b1 by Uli Heilmeier (u...@heilmeier.eu):

Udpdump: Fix g_debug() for ssize_t buflen

Using %lu for ssize_t throws an error. This commit change it to %zd.

Change-Id: I19ae72fe0836424bcb93e912e9b1757df4ae5fb1
Reviewed-on: https://code.wireshark.org/review/17900
Petri-Dish: Roland Knall 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Dario Lombardo 


Actions performed:

from  989dcef   TLS: Update Hello ExtensionType list
adds  ca232b1   Udpdump: Fix g_debug() for ssize_t buflen


Summary of changes:
 extcap/udpdump.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 989dcef: TLS: Update Hello ExtensionType list

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=989dcef3175267c6db4f9256c6a61ce8640f132f
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

989dcef by Alexis La Goutte (alexis.lagou...@gmail.com):

TLS: Update Hello ExtensionType list

use same name and display in dec from 
http://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml

Change-Id: Ia4a959571204b611dbf275311c9ce58c594b6716
Reviewed-on: https://code.wireshark.org/review/17886
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  1a3f1d0   update description of PDML file format by updating URLs to 
external documentation. Also mention the pdml2html.xsl file.
adds  989dcef   TLS: Update Hello ExtensionType list


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   67 ++--
 epan/dissectors/packet-ssl-utils.h |   62 -
 2 files changed, 72 insertions(+), 57 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe