[Wireshark-commits] master ba00be5: mgcp: use ws_strtou function.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba00be5266aff1bdf6507fdb9bd263d30c8dcc32
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ba00be5 by Dario Lombardo (lom...@gmail.com):

mgcp: use ws_strtou function.

Change-Id: Ia2a7fac5d1bd86d4f163117993e2e897e5dd315e
Reviewed-on: https://code.wireshark.org/review/18280
Petri-Dish: Dario Lombardo 
Reviewed-by: Anders Broman 


Actions performed:

from  bf96599   Drop redundant SIZEOF() macro
adds  ba00be5   mgcp: use ws_strtou function.


Summary of changes:
 epan/dissectors/packet-mgcp.c |   27 ++-
 1 file changed, 22 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bf96599: Drop redundant SIZEOF() macro

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf96599f1916667cc8f1c19b58fe9cae4a1e3d66
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

bf96599 by Balint Reczey (bal...@balintreczey.hu):

Drop redundant SIZEOF() macro

Change-Id: I6db2033746f5f22dd0229c96727bb352bdb1e866
Reviewed-on: https://code.wireshark.org/review/18298
Reviewed-by: Balint Reczey 
Petri-Dish: Balint Reczey 
Reviewed-by: Anders Broman 


Actions performed:

from  739bdfb   Some Pref <-> Decode As bugfixes.
adds  bf96599   Drop redundant SIZEOF() macro


Summary of changes:
 plugins/gryphon/packet-gryphon.c |   20 ++--
 plugins/gryphon/packet-gryphon.h |2 --
 2 files changed, 10 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 739bdfb: Some Pref <-> Decode As bugfixes.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=739bdfb45f6e6f78a88e978de1eff088377e8330
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

739bdfb by Michael Mann (mman...@netscape.net):

Some Pref <-> Decode As bugfixes.

1. If a deprecated port preference is found, populate the new port 
preference with the value
2. Mark preferences as changed to trigger preference callback at startup.

Change-Id: Ic271841686617e847d2e0ed8800bbb0fa874df47
Reviewed-on: https://code.wireshark.org/review/18274
Reviewed-by: Michael Mann 


Actions performed:

from  09b4359   While the channelwidth was dissected the information was 
not passed to the phdr
adds  739bdfb   Some Pref <-> Decode As bugfixes.


Summary of changes:
 epan/decode_as.c |6 +-
 epan/prefs.c |   53 -
 2 files changed, 33 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

2016-10-18 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/241

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] 4039bc7ec0b7e1c174b2ac5c1229e2f38f853b54
Blamelist: Guy Harris ,Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 09b4359: While the channelwidth was dissected the information was not passed to the phdr

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=09b43591a13e9834a66adbd7b24c3c28af8ea5fc
Submitter: Jörg Mayer (jma...@loplof.de)
Changed: branch: master
Repository: wireshark

Commits:

09b4359 by Joerg Mayer (jma...@loplof.de):

While the channelwidth was dissected the information was not passed to the 
phdr

No other flags were verified.

Change-Id: I77e35af8accb83595d3046dc804f0c6a7e1d1000
Reviewed-on: https://code.wireshark.org/review/18295
Reviewed-by: Jörg Mayer 


Actions performed:

from  6a14408   Fix typo.
adds  09b4359   While the channelwidth was dissected the information was 
not passed to the phdr


Summary of changes:
 epan/dissectors/packet-ppi.c |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 0627e2c: BGP: fix bgp.ls.tlv.link_protection_type_value is not of an FT_{U}INTn type]

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0627e2c24bf93a5134c25edc2e1aa336f361d5ae
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0627e2c by Alexis La Goutte (alexis.lagou...@gmail.com):

BGP: fix bgp.ls.tlv.link_protection_type_value is not of an FT_{U}INTn type]

Bug: 13021
Change-Id: I3464c7af61323efb25dd89655865d536aeae6e59
Reviewed-on: https://code.wireshark.org/review/18261
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 9796e811f51892db729e02735a8bf31628ea7dcb)
Reviewed-on: https://code.wireshark.org/review/18293


Actions performed:

from  916b47d   Fix typo.
adds  0627e2c   BGP: fix bgp.ls.tlv.link_protection_type_value is not of an 
FT_{U}INTn type]


Summary of changes:
 epan/dissectors/packet-bgp.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 4039bc7: BGP: fix bgp.ls.tlv.link_protection_type_value is not of an FT_{U}INTn type]

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4039bc7ec0b7e1c174b2ac5c1229e2f38f853b54
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

4039bc7 by Alexis La Goutte (alexis.lagou...@gmail.com):

BGP: fix bgp.ls.tlv.link_protection_type_value is not of an FT_{U}INTn type]

Bug: 13021
Change-Id: I3464c7af61323efb25dd89655865d536aeae6e59
Reviewed-on: https://code.wireshark.org/review/18261
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 9796e811f51892db729e02735a8bf31628ea7dcb)
Reviewed-on: https://code.wireshark.org/review/18292


Actions performed:

from  187ae08   Fix typo.
adds  4039bc7   BGP: fix bgp.ls.tlv.link_protection_type_value is not of an 
FT_{U}INTn type]


Summary of changes:
 epan/dissectors/packet-bgp.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 916b47d: Fix typo.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=916b47df1ef984b8d19115dbf23131005a4b076e
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

916b47d by Guy Harris (g...@alum.mit.edu):

Fix typo.

Change-Id: Ie28490c93736c7e95f0b1eaed1e075e61f005e16
Reviewed-on: https://code.wireshark.org/review/18289
Reviewed-by: Guy Harris 
(cherry picked from commit 6a14408bf62f534db2374f131195fc2c42785f57)
Reviewed-on: https://code.wireshark.org/review/18291


Actions performed:

from  72afa7e   Separate "Link Access Control Protocol" and the version 
number with a space.
adds  916b47d   Fix typo.


Summary of changes:
 epan/dissectors/packet-cfm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 187ae08: Fix typo.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=187ae086f9335f256b8d63f6e90394f6fb501304
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

187ae08 by Guy Harris (g...@alum.mit.edu):

Fix typo.

Change-Id: Ie28490c93736c7e95f0b1eaed1e075e61f005e16
Reviewed-on: https://code.wireshark.org/review/18289
Reviewed-by: Guy Harris 
(cherry picked from commit 6a14408bf62f534db2374f131195fc2c42785f57)
Reviewed-on: https://code.wireshark.org/review/18290


Actions performed:

from  fb35643   Separate "Link Access Control Protocol" and the version 
number with a space.
adds  187ae08   Fix typo.


Summary of changes:
 epan/dissectors/packet-cfm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6a14408: Fix typo.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a14408bf62f534db2374f131195fc2c42785f57
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6a14408 by Guy Harris (g...@alum.mit.edu):

Fix typo.

Change-Id: Ie28490c93736c7e95f0b1eaed1e075e61f005e16
Reviewed-on: https://code.wireshark.org/review/18289
Reviewed-by: Guy Harris 


Actions performed:

from  537705a   wslua: prepare for split class/instance (meta)methods
adds  6a14408   Fix typo.


Summary of changes:
 epan/dissectors/packet-cfm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 537705a: wslua: prepare for split class/instance (meta)methods

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=537705a8b20ee89bf1f713bc0c9959cf21b26900
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

537705a by Peter Wu (pe...@lekensteyn.nl):

wslua: prepare for split class/instance (meta)methods

Previously the metatables for classes were the same for the class and
its instances. This results in issues like calling __gc on the class
table on exit.

Make it possible to declare separate class methods (functions) and
instance methods. Observe that all attributes apply to the instances
only, so make these just available on the instance.

The attribute/methods lookup method (via __index/__newindex) have been
rewritten to use upvalues, removing the technical need for the
properties __getters/__setters/__methods. The "lua globals" test still
checks for these, but it could be removed in the future.

To fix bug 12968, the __gc method is removed from the class method.
Future patches should remove the WSLUA_REGISTER_CLASS,
WSLUA_REGISTER_META and WSLUA_REGISTER_ATTRIBUTES macros completely and
create split class functions/methods (such that __call for an instance
cannot accidentally be invoked on the class).

Removed duplicate "fragmented" property from Pinfo (which triggered an
error) and replaced exit() by g_error() for debugger friendliness.
Remove lua_shiftstring since checkstring always returns non-NULL.

Bug: 12968
Change-Id: I57f8a93d08bb84c79b0e94cf2c82d8402fc16646
Reviewed-on: https://code.wireshark.org/review/18026
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Balint Reczey 


Actions performed:

from  41c6b94   Rename a function to have a name different from a data 
object's name.
adds  537705a   wslua: prepare for split class/instance (meta)methods


Summary of changes:
 doc/README.wslua |   50 +++--
 epan/wslua/wslua.h   |   81 ---
 epan/wslua/wslua_internals.c |  495 --
 epan/wslua/wslua_pinfo.c |1 -
 test/lua/globals_2.2.txt |   25 ---
 5 files changed, 362 insertions(+), 290 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

2016-10-18 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/17356

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 2898c2a244eeccdb41c334d2b6c16117e9844dc4
Blamelist: Anders Broman 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 41c6b94: Rename a function to have a name different from a data object's name.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41c6b944b42a31c9593e4374336fee8022e0011d
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

41c6b94 by Guy Harris (g...@alum.mit.edu):

Rename a function to have a name different from a data object's name.

Change-Id: Iefef8b2161b43900fd81fb1b163a4feee69fd069
Reviewed-on: https://code.wireshark.org/review/18285
Reviewed-by: Guy Harris 


Actions performed:

from  2898c2a   Fix wrong local function names
adds  41c6b94   Rename a function to have a name different from a data 
object's name.


Summary of changes:
 ui/qt/bluetooth_hci_summary_dialog.cpp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-10-18 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/1998

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 2898c2a244eeccdb41c334d2b6c16117e9844dc4
Blamelist: Anders Broman 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-10-18 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12345

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 2898c2a244eeccdb41c334d2b6c16117e9844dc4
Blamelist: Anders Broman 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2016-10-18 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/7734

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 2898c2a244eeccdb41c334d2b6c16117e9844dc4
Blamelist: Anders Broman 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2016-10-18 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/557

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 2898c2a244eeccdb41c334d2b6c16117e9844dc4
Blamelist: Anders Broman 

BUILD FAILED: failed compile

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2898c2a: Fix wrong local function names

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2898c2a244eeccdb41c334d2b6c16117e9844dc4
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2898c2a by Michal Labedzki (michal.labed...@tieto.com):

Fix wrong local function names

Copy->Paste issue.

Change-Id: I77bc755c772df0fb95a9e4ce91b8b3bc8a8e019d
Reviewed-on: https://code.wireshark.org/review/18282
Reviewed-by: Anders Broman 


Actions performed:

from  7a906dc   Ensure http_tcp_range gets initialized through preference 
callback.
adds  2898c2a   Fix wrong local function names


Summary of changes:
 ui/qt/bluetooth_hci_summary_dialog.cpp |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7a906dc: Ensure http_tcp_range gets initialized through preference callback.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a906dc877c06700ef6d09aa8edd0e09f5b22f9d
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

7a906dc by Michael Mann (mman...@netscape.net):

Ensure http_tcp_range gets initialized through preference callback.

Bug: 13016
Change-Id: I814c901898790045be0e2003ebe5a8000704b8af
Reviewed-on: https://code.wireshark.org/review/18273
Reviewed-by: Michael Mann 


Actions performed:

from  4a46982   WiresharkApplication: Add signal emitter for Interface 
Changes
adds  7a906dc   Ensure http_tcp_range gets initialized through preference 
callback.


Summary of changes:
 epan/dissectors/packet-http.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4a46982: WiresharkApplication: Add signal emitter for Interface Changes

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a4698259c3c770eb4c675adcaa11674c306e551
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4a46982 by Roland Knall (rkn...@gmail.com):

WiresharkApplication: Add signal emitter for Interface Changes

Change-Id: I468ef9462aa91d02c5568cec0d08081a2b3840bb
Reviewed-on: https://code.wireshark.org/review/18269
Petri-Dish: Roland Knall 
Reviewed-by: Roland Knall 


Actions performed:

from  63eb48a   sdp: use ws_strtou function.
adds  4a46982   WiresharkApplication: Add signal emitter for Interface 
Changes


Summary of changes:
 ui/qt/wireshark_application.cpp |3 +++
 ui/qt/wireshark_application.h   |1 +
 2 files changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 63eb48a: sdp: use ws_strtou function.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63eb48adaa49e6781953f0555998db6622372843
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

63eb48a by Dario Lombardo (lom...@gmail.com):

sdp: use ws_strtou function.

Change-Id: Idd624170cf8d3bb0441c765ecfebcbe51f99deaf
Reviewed-on: https://code.wireshark.org/review/18264
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  397065b   mrcpv2: use ws_strtou function.
adds  63eb48a   sdp: use ws_strtou function.


Summary of changes:
 epan/dissectors/packet-sdp.c |  110 ++
 1 file changed, 90 insertions(+), 20 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 397065b: mrcpv2: use ws_strtou function.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=397065bb591d224df94463705b51d9c13f613654
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

397065b by Dario Lombardo (lom...@gmail.com):

mrcpv2: use ws_strtou function.

Change-Id: I2d3ddf1f376ac44e3ccc618d94aebdba9c86e3df
Reviewed-on: https://code.wireshark.org/review/18250
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  47e9345   fc00: Fix Dead Store (Dead assignement/Dead increment) 
Warning found by Clang
adds  397065b   mrcpv2: use ws_strtou function.


Summary of changes:
 epan/dissectors/packet-mrcpv2.c |   35 +--
 1 file changed, 25 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 47e9345: fc00: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=47e93451161c9af972c55af856ebbc1ab65441cb
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

47e9345 by Alexis La Goutte (alexis.lagou...@gmail.com):

fc00: Fix Dead Store (Dead assignement/Dead increment) Warning found by 
Clang

Change-Id: I3c494b190f93e9a1d042fa666d4f7037cd69c986
Reviewed-on: https://code.wireshark.org/review/18262
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  41e9bba   Qt: Main welcome show/hide interface updates.
adds  47e9345   fc00: Fix Dead Store (Dead assignement/Dead increment) 
Warning found by Clang


Summary of changes:
 epan/dissectors/packet-fc00.c |2 --
 1 file changed, 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 41e9bba: Qt: Main welcome show/hide interface updates.

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41e9bbac91c76fa0c95944a0329dd674cbeb61d9
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

41e9bba by Gerald Combs (ger...@wireshark.org):

Qt: Main welcome show/hide interface updates.

Pluralize the text in the main welcome show/hide interfaces button.
Remove the styling, which matches other places we use a pushbutton +
menu.

Change-Id: I7559f98d0c1afbfb2920b09c3885d9b1fbdf76f1
Reviewed-on: https://code.wireshark.org/review/18260
Petri-Dish: Gerald Combs 
Reviewed-by: Roland Knall 
Reviewed-by: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 


Actions performed:

from  9796e81   BGP: fix bgp.ls.tlv.link_protection_type_value is not of an 
FT_{U}INTn type]
adds  41e9bba   Qt: Main welcome show/hide interface updates.


Summary of changes:
 ui/qt/main_welcome.cpp |   39 +
 ui/qt/wireshark_en.ts  |   65 +++-
 2 files changed, 43 insertions(+), 61 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9796e81: BGP: fix bgp.ls.tlv.link_protection_type_value is not of an FT_{U}INTn type]

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9796e811f51892db729e02735a8bf31628ea7dcb
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

9796e81 by Alexis La Goutte (alexis.lagou...@gmail.com):

BGP: fix bgp.ls.tlv.link_protection_type_value is not of an FT_{U}INTn type]

Bug: 13021
Change-Id: I3464c7af61323efb25dd89655865d536aeae6e59
Reviewed-on: https://code.wireshark.org/review/18261
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  5d2c54e   ZigBee Green Power: fix commissioning cmd dissection
adds  9796e81   BGP: fix bgp.ls.tlv.link_protection_type_value is not of an 
FT_{U}INTn type]


Summary of changes:
 epan/dissectors/packet-bgp.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-10-18 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/1993

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 5d2c54ed2029dd98c44e17672e9c63ad0172e87b
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5d2c54e: ZigBee Green Power: fix commissioning cmd dissection

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5d2c54ed2029dd98c44e17672e9c63ad0172e87b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

5d2c54e by Vladlen Popov (vladlen.po...@yahoo.com):

ZigBee Green Power: fix commissioning cmd dissection

Dissect fields: number of gpd commands, GPD cmd list, Cluster list

Change-Id: Ifda60987072c3526d5f0ae4687ddf2b6e46bfb93
Reviewed-on: https://code.wireshark.org/review/18259
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Michael Mann 


Actions performed:

from  256f834   Update MNC list for MCC 432 (Iran)
adds  5d2c54e   ZigBee Green Power: fix commissioning cmd dissection


Summary of changes:
 epan/dissectors/packet-zbee-nwk-gp.c |  123 +-
 1 file changed, 122 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 256f834: Update MNC list for MCC 432 (Iran)

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=256f834293e54be5d54a6f9c55472876851cbbbf
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

256f834 by Babak Farrokhi (ba...@farrokhi.net):

Update MNC list for MCC 432 (Iran)

The official E.212 list does not contain the latest
MNC codes that are in use for MCC 432. This commit
contains an up to date list according to:

http://mcclist.com/mobile-network-codes-country-codes.asp#Iran

Change-Id: I847d31b1d77825c6f95f4e5879ee1f688834ed88
Reviewed-on: https://code.wireshark.org/review/18258
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  418b7d1   CQL: free buffer earlier in case of Snappy decompression 
failure
adds  256f834   Update MNC list for MCC 432 (Iran)


Summary of changes:
 epan/dissectors/packet-e212.c |   14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 418b7d1: CQL: free buffer earlier in case of Snappy decompression failure

2016-10-18 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=418b7d125dcf65cd335c5dc113fde27074453d2a
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

418b7d1 by Pascal Quantin (pascal.quan...@gmail.com):

CQL: free buffer earlier in case of Snappy decompression failure

Change-Id: I3048823b4057caf49f2f6bf28cf2389dc3c88f27
Reviewed-on: https://code.wireshark.org/review/18255
Reviewed-by: Pascal Quantin 


Actions performed:

from  2c07129   packet-infiniband: Add support for CM DREQ/DRSP
adds  418b7d1   CQL: free buffer earlier in case of Snappy decompression 
failure


Summary of changes:
 epan/dissectors/packet-cql.c |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe