[Wireshark-commits] master 961b053: WelcomeUI: Make Open and Capture clickable

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=961b05315df0c17bc21ca77553d1e29ebdf39309
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

961b053 by Roland Knall (rkn...@gmail.com):

WelcomeUI: Make Open and Capture clickable

Make the texts "Open" and "Capture" clickable, and have them open
the FileOpen and CaptureOptions dialogs respectively

Change-Id: I2a3efbc4cdf160aa0b4efc6496d09228affbff46
Reviewed-on: https://code.wireshark.org/review/18303
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Reviewed-by: Anders Broman 


Actions performed:

from  f0cb70b   Exclude scanner-generated headers from ABI check
adds  961b053   WelcomeUI: Make Open and Capture clickable


Summary of changes:
 ui/qt/CMakeLists.txt   |2 +
 ui/qt/Makefile.am  |2 +
 ...tock_icon_tool_button.h => clickable_label.cpp} |   42 ++--
 ui/qt/{capture_info_dialog.h => clickable_label.h} |   22 +-
 ui/qt/main_welcome.cpp |   19 -
 ui/qt/main_welcome.h   |4 ++
 ui/qt/main_welcome.ui  |9 -
 ui/qt/wireshark_application.cpp|   13 ++
 ui/qt/wireshark_application.h  |8 
 wireshark-qt.cpp   |2 +
 10 files changed, 88 insertions(+), 35 deletions(-)
 copy ui/qt/{stock_icon_tool_button.h => clickable_label.cpp} (60%)
 copy ui/qt/{capture_info_dialog.h => clickable_label.h} (74%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f0cb70b: Exclude scanner-generated headers from ABI check

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0cb70bd18171a8102f4a6baefb385a1dcd2d960
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

f0cb70b by Balint Reczey (bal...@balintreczey.hu):

Exclude scanner-generated headers from ABI check

They break the check by not including header files for custom types
and they are not part of the API anyway.

Bug: 13018
Change-Id: Ia0f81f861251b5659af723b9da795daeb7454eb3
Reviewed-on: https://code.wireshark.org/review/18297
Reviewed-by: Balint Reczey 
Petri-Dish: Balint Reczey 
Petri-Dish: Guy Harris 
Reviewed-by: Anders Broman 


Actions performed:

from  9c3d81a   Officially require Qt 4.8 or newer
adds  f0cb70b   Exclude scanner-generated headers from ABI check


Summary of changes:
 epan/Makefile.am|3 +++
 wiretap/Makefile.am |4 
 2 files changed, 7 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9c3d81a: Officially require Qt 4.8 or newer

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c3d81adde2d901a18fb0dc5a5dc2220f76cd920
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

9c3d81a by Peter Wu (pe...@lekensteyn.nl):

Officially require Qt 4.8 or newer

Since v2.3.0rc0-1002-g1cd2255, Qt 4.8 became mandatory, reflect this in
the version requirements. This will not affect a lot of distributions
(RHEL and SLES only had Qt 4.6).

For a more complete list of supported platforms, see
https://wiki.wireshark.org/Development/Support_library_version_tracking

While at it, correct some other minimum versions in documentation.

Change-Id: I11f2dfba72c75429f6838404a81ed3b3dc302d5f
Reviewed-on: https://code.wireshark.org/review/18314
Reviewed-by: Michal Labedzki 
Petri-Dish: Anders Broman 
Reviewed-by: Anders Broman 


Actions performed:

from  d38ed8e   Put the SS7 PC name resolution feature in the release notes.
adds  9c3d81a   Officially require Qt 4.8 or newer


Summary of changes:
 CMakeLists.txt |2 +-
 configure.ac   |   35 +++-
 doc/README.developer   |9 
 ui/qt/font_color_preferences_frame.cpp |6 --
 ui/qt/proto_tree.cpp   |4 
 ui/qt/qt_ui_utils.cpp  |4 
 ui/qt/stock_icon.cpp   |4 
 7 files changed, 8 insertions(+), 56 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d38ed8e: Put the SS7 PC name resolution feature in the release notes.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d38ed8e55f7df9b34b9a7859ff54dde726f2feb0
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d38ed8e by Jeff Morriss (jeff.morriss...@gmail.com):

Put the SS7 PC name resolution feature in the release notes.

Fix the casing of the preference while at it (it now matches other name
resolution preferences).

Change-Id: Ibfecbc94f9eccefa7d3b1a50ae2598dfefb707a2
Reviewed-on: https://code.wireshark.org/review/18330
Reviewed-by: Anders Broman 


Actions performed:

from  f252831   wlan_statistics_dialog: Add number of retry
adds  d38ed8e   Put the SS7 PC name resolution feature in the release notes.


Summary of changes:
 docbook/release-notes.asciidoc |1 +
 epan/addr_resolv.c |2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f252831: wlan_statistics_dialog: Add number of retry

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f252831b43269dd06487cdf3e5e791ecc991bf3d
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

f252831 by Alexis La Goutte (alexis.lagou...@gmail.com):

wlan_statistics_dialog: Add number of retry

Change-Id: I27194670dcd2e6c2ec6502c562e50ee6925c4c45
Reviewed-on: https://code.wireshark.org/review/18306
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  404c314   Skype: Remove TCP heuristic dissection
adds  f252831   wlan_statistics_dialog: Add number of retry


Summary of changes:
 epan/dissectors/packet-ieee80211.c |1 +
 epan/dissectors/packet-ieee80211.h |1 +
 ui/qt/wlan_statistics_dialog.cpp   |   43 +++-
 3 files changed, 34 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 198fdae: Skype: Remove TCP heuristic dissection

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=198fdae316e0aa27f8568f3bf523dd523de43dee
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

198fdae by Michael Mann (mman...@netscape.net):

Skype: Remove TCP heuristic dissection

It was taking any/all TCP packets.

Also clean up a little of the UDP heuristic.

Change-Id: Iae08e79c0d71e4676cfc7821372ab9581c1d1cfc
Ping-Bug: 13029
Reviewed-on: https://code.wireshark.org/review/18322
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 404c31492be8b01d1b6bf9944ea3bb71feb92dd6)
Reviewed-on: https://code.wireshark.org/review/18328
Petri-Dish: Michael Mann 


Actions performed:

from  5d6be2c   e212: Fix for e212.*.mnc
adds  198fdae   Skype: Remove TCP heuristic dissection


Summary of changes:
 epan/dissectors/packet-skype.c |   37 ++---
 1 file changed, 18 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/572

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] d3995b5248e412dd1b00c06a3f54936326967e2d
Blamelist: Jörg Mayer 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 404c314: Skype: Remove TCP heuristic dissection

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=404c31492be8b01d1b6bf9944ea3bb71feb92dd6
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

404c314 by Michael Mann (mman...@netscape.net):

Skype: Remove TCP heuristic dissection

It was taking any/all TCP packets.

Also clean up a little of the UDP heuristic.

Change-Id: Iae08e79c0d71e4676cfc7821372ab9581c1d1cfc
Ping-Bug: 13029
Reviewed-on: https://code.wireshark.org/review/18322
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  bd057c8   ZigBee Green Power: add dissector for commands Proxy Table 
resp and Sink Table resp
adds  404c314   Skype: Remove TCP heuristic dissection


Summary of changes:
 epan/dissectors/packet-skype.c |   37 ++---
 1 file changed, 18 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bd057c8: ZigBee Green Power: add dissector for commands Proxy Table resp and Sink Table resp

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd057c8dd226dd3c33104b95310ac592d7a19b09
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

bd057c8 by Vladlen Popov (vladlen.po...@yahoo.com):

ZigBee Green Power: add dissector for commands Proxy Table resp and Sink 
Table resp

Change-Id: I6623a389551a727f933f8600ceba9d3050a51b25
Reviewed-on: https://code.wireshark.org/review/18326
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  d561afc   raknet: remove if(tree) no longer needed
adds  bd057c8   ZigBee Green Power: add dissector for commands Proxy Table 
resp and Sink Table resp


Summary of changes:
 epan/dissectors/packet-zbee-zcl-general.c |   71 -
 1 file changed, 69 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d561afc: raknet: remove if(tree) no longer needed

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d561afcd129132877197bd0c77d9ea9a6471a6c4
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

d561afc by Alexis La Goutte (alexis.lagou...@gmail.com):

raknet: remove if(tree) no longer needed

also remove item_size variable (replace directly by the value)

Will be also fix some Clang analyzer warning about used variable

Change-Id: I4bf3b118efb2b0846012a92e5bf596ca95043414
Reviewed-on: https://code.wireshark.org/review/18318
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  fbf4f6c   Add the wlan_mgt -> wlan renaming to the release notes
adds  d561afc   raknet: remove if(tree) no longer needed


Summary of changes:
 epan/dissectors/packet-raknet.c |  669 +--
 1 file changed, 286 insertions(+), 383 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fbf4f6c: Add the wlan_mgt -> wlan renaming to the release notes

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fbf4f6c62f3967b45e706ad3150d6b7d0208b34c
Submitter: Jörg Mayer (jma...@loplof.de)
Changed: branch: master
Repository: wireshark

Commits:

fbf4f6c by Joerg Mayer (jma...@loplof.de):

Add the wlan_mgt -> wlan renaming to the release notes

Change-Id: Iae346329ad90035a3f047d748783c6f9f2dd4e1e
Reviewed-on: https://code.wireshark.org/review/18327
Reviewed-by: Jörg Mayer 


Actions performed:

from  d3995b5   Disable GTK+ by default.
adds  fbf4f6c   Add the wlan_mgt -> wlan renaming to the release notes


Summary of changes:
 docbook/release-notes.asciidoc |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d3995b5: Disable GTK+ by default.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3995b5248e412dd1b00c06a3f54936326967e2d
Submitter: Jörg Mayer (jma...@loplof.de)
Changed: branch: master
Repository: wireshark

Commits:

d3995b5 by Gerald Combs (ger...@wireshark.org):

Disable GTK+ by default.

I suggested disabling GTK+ by default at Sharkfest EU and no one
objected, hence this patch.

Disable it by default in both Autotools and CMake. Make sure it's
enabled for Debian packaging. The RPM packaging enables GTK3 explicitly
so no change appears to be necessary there.

Change-Id: If5daeaef4bb26cf60006bc8883be15b2cf6c6ae4
Reviewed-on: https://code.wireshark.org/review/18256
Reviewed-by: Peter Wu 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jörg Mayer 


Actions performed:

from  5ab49c6   InterfaceList: Changing text clears the cell
adds  d3995b5   Disable GTK+ by default.


Summary of changes:
 .travis.yml|4 +++-
 CMakeOptions.txt   |2 +-
 configure.ac   |4 ++--
 debian/rules   |1 +
 docbook/release-notes.asciidoc |1 +
 5 files changed, 8 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1042

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 907948fb7f59a3a4d746db00ad6325f5572df012
Blamelist: Pascal Quantin 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 907948f: e212: Fix for e212.*.mnc

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=907948fb7f59a3a4d746db00ad6325f5572df012
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

907948f by Hessam Jalali (hessam.jal...@gmail.com):

e212: Fix for e212.*.mnc

when mnc was not detected as long, the value was shown as e212.mnc instead 
of e212.*.mnc (e.g e212.rai.mnc)

Change-Id: Ic0d275f259e1121abb1b7812651fadb9d475053e
Reviewed-on: https://code.wireshark.org/review/18317
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
Tested-by: Michael Mann 
(cherry picked from commit b31bdfdc58ed78a409a35f1f5861010701935236)
Reviewed-on: https://code.wireshark.org/review/18324


Actions performed:

from  7ba41cb   IP: Fix evil flag expert item text
adds  907948f   e212: Fix for e212.*.mnc


Summary of changes:
 epan/dissectors/packet-e212.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 5d6be2c: e212: Fix for e212.*.mnc

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5d6be2cfb612b4fac600cbabce44fb9a0c6ccfd9
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

5d6be2c by Hessam Jalali (hessam.jal...@gmail.com):

e212: Fix for e212.*.mnc

when mnc was not detected as long, the value was shown as e212.mnc instead 
of e212.*.mnc (e.g e212.rai.mnc)

Change-Id: Ic0d275f259e1121abb1b7812651fadb9d475053e
Reviewed-on: https://code.wireshark.org/review/18317
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
Tested-by: Michael Mann 
(cherry picked from commit b31bdfdc58ed78a409a35f1f5861010701935236)
Reviewed-on: https://code.wireshark.org/review/18323


Actions performed:

from  2ebb6d3   IP: Fix evil flag expert item text
adds  5d6be2c   e212: Fix for e212.*.mnc


Summary of changes:
 epan/dissectors/packet-e212.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5ab49c6: InterfaceList: Changing text clears the cell

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ab49c623df23a5d19cffdc29f912dd1d2798ca9
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

5ab49c6 by Roland Knall (rkn...@gmail.com):

InterfaceList: Changing text clears the cell

If the cell is double-clicked to edit an existing text, it is cleared
upon start of the edit widget

Change-Id: I9d718635de5c4b091aab1f88c2482434aaae1286
Reviewed-on: https://code.wireshark.org/review/18319
Petri-Dish: Roland Knall 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  c92cc9c   ZigBee ZDO dissector: fix for r21 in column description in 
ZDO Node Desc Resp.
adds  5ab49c6   InterfaceList: Changing text clears the cell


Summary of changes:
 ui/qt/interface_tree_cache_model.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c92cc9c: ZigBee ZDO dissector: fix for r21 in column description in ZDO Node Desc Resp.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c92cc9c95a8bc45c932bb37775627657994e906d
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

c92cc9c by dsrsupport (eugene.exarev...@dsr-company.com):

ZigBee ZDO dissector: fix for r21 in column description in ZDO Node Desc 
Resp.

Fixed display for Server flags:
a) introduce a flag 'show_ver_flags' to display stack revision only for ZDO 
Node Desc Resp;
b) fix crash in zdp_parse_node_desc when passed NULL as pinfo. Now never 
pass NULL there.

Change-Id: Ibdb7fe2da54a902b39e20e07aa2aa5c9c23b
Reviewed-on: https://code.wireshark.org/review/18313
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  11e8bac   Qt: add include to fix compilation without pcap.
adds  c92cc9c   ZigBee ZDO dissector: fix for r21 in column description in 
ZDO Node Desc Resp.


Summary of changes:
 epan/dissectors/packet-zbee-zdp-discovery.c |4 ++--
 epan/dissectors/packet-zbee-zdp.c   |4 ++--
 epan/dissectors/packet-zbee-zdp.h   |2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 11e8bac: Qt: add include to fix compilation without pcap.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11e8bac88e067b226f92add83eca3009fa5b95a7
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

11e8bac by Dario Lombardo (lom...@gmail.com):

Qt: add include to fix compilation without pcap.

Regression introduced in 864f750be560a7a739c7453f19a8f5679cf7d6b3.

Change-Id: I306903e8252d932425f420e1901a8f3e949f5568
Reviewed-on: https://code.wireshark.org/review/18309
Reviewed-by: Anders Broman 


Actions performed:

from  b31bdfd   e212: Fix for e212.*.mnc
adds  11e8bac   Qt: add include to fix compilation without pcap.


Summary of changes:
 ui/qt/interface_tree_cache_model.cpp |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b31bdfd: e212: Fix for e212.*.mnc

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b31bdfdc58ed78a409a35f1f5861010701935236
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

b31bdfd by Hessam Jalali (hessam.jal...@gmail.com):

e212: Fix for e212.*.mnc

when mnc was not detected as long, the value was shown as e212.mnc instead 
of e212.*.mnc (e.g e212.rai.mnc)

Change-Id: Ic0d275f259e1121abb1b7812651fadb9d475053e
Reviewed-on: https://code.wireshark.org/review/18317
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
Tested-by: Michael Mann 


Actions performed:

from  5c8f4de   androiddump: Update help
adds  b31bdfd   e212: Fix for e212.*.mnc


Summary of changes:
 epan/dissectors/packet-e212.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5c8f4de: androiddump: Update help

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c8f4decd9797275a77c73d032633c5a55100289
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

5c8f4de by Michal Labedzki (michal.labed...@tieto.com):

androiddump: Update help

Minor changes in androiddump implies minor changes in help file.

Change-Id: Ifbf4dbdca427e8b19272c2b4f28e06fd6a548834
Reviewed-on: https://code.wireshark.org/review/18316
Reviewed-by: Anders Broman 


Actions performed:

from  afc2034   bt-dht: add bencoding terminators.
adds  5c8f4de   androiddump: Update help


Summary of changes:
 doc/androiddump.pod |   64 +++
 1 file changed, 49 insertions(+), 15 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master afc2034: bt-dht: add bencoding terminators.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=afc2034721923534d8810fbee087155240edf687
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

afc2034 by Dario Lombardo (lom...@gmail.com):

bt-dht: add bencoding terminators.

Change-Id: I367495fb11aa09f1c8cb7f1df8812e179d41d9b9
Reviewed-on: https://code.wireshark.org/review/18305
Reviewed-by: Dario Lombardo 
Petri-Dish: Dario Lombardo 
Reviewed-by: Michael Mann 
Tested-by: Michael Mann 


Actions performed:

from  dbb391a   Kafka: add Snappy decompression support
adds  afc2034   bt-dht: add bencoding terminators.


Summary of changes:
 epan/dissectors/packet-bt-dht.c |   14 --
 1 file changed, 12 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master dbb391a: Kafka: add Snappy decompression support

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dbb391a64681e3c5722f8e7ff79bd4154d0b2e6b
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

dbb391a by Pascal Quantin (pascal.quan...@gmail.com):

Kafka: add Snappy decompression support

Change-Id: Ida8d941809a4e0f2fd4d9f142363187a757d0278
Reviewed-on: https://code.wireshark.org/review/18288
Reviewed-by: Pascal Quantin 
Reviewed-by: Martin Mathieson 


Actions performed:

from  25122f5   [GIOP] Use g_slist_prepend().
adds  dbb391a   Kafka: add Snappy decompression support


Summary of changes:
 epan/dissectors/packet-kafka.c |   69 ++--
 1 file changed, 67 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 25122f5: [GIOP] Use g_slist_prepend().

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=25122f5ef6f722a12077ce91f1b0d9784570009c
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

25122f5 by AndersBroman (anders.bro...@ericsson.com):

[GIOP] Use g_slist_prepend().

Change-Id: I3a6c43f617f7634ce0007bc75aa6293eb5e1cad6
Reviewed-on: https://code.wireshark.org/review/18302
Petri-Dish: Anders Broman 
Reviewed-by: Michael Mann 
Tested-by: Michael Mann 


Actions performed:

from  b4f86c9   androiddump: Fix help - interfaces
adds  25122f5   [GIOP] Use g_slist_prepend().


Summary of changes:
 epan/dissectors/packet-giop.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b4f86c9: androiddump: Fix help - interfaces

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b4f86c9cb84c8cefcf0784fa1bbe10a89392da74
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

b4f86c9 by Michal Labedzki (michal.labed...@tieto.com):

androiddump: Fix help - interfaces

Fix help output that describes interfaces provided by tool
to reflect reality - add missed DEVICE_ID that is part of interface.

Change-Id: Ib6374db28d8d4696ce27c5358da49d3ebfcf31e1
Reviewed-on: https://code.wireshark.org/review/18267
Petri-Dish: Michal Labedzki 
Reviewed-by: Roland Knall 
Reviewed-by: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Tested-by: Michael Mann 


Actions performed:

from  4ef14c7   ZigBee Green Power: add dissectors for Sink Table and Proxy 
Table attributes (GP Cluster)
adds  b4f86c9   androiddump: Fix help - interfaces


Summary of changes:
 extcap/androiddump.c |   35 +--
 1 file changed, 21 insertions(+), 14 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4ef14c7: ZigBee Green Power: add dissectors for Sink Table and Proxy Table attributes (GP Cluster)

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ef14c76513acb92e75c87a1f987c8c9c18fabc6
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4ef14c7 by Vladlen Popov (vladlen.po...@yahoo.com):

ZigBee Green Power: add dissectors for Sink Table and Proxy Table 
attributes (GP Cluster)

Change-Id: I9d18aa84e24a713951d5e537dcbc2dee6998192c
Reviewed-on: https://code.wireshark.org/review/18278
Reviewed-by: Anders Broman 


Actions performed:

from  d399bfa   cmake/FindPOD: improve formatting, add modelines
adds  4ef14c7   ZigBee Green Power: add dissectors for Sink Table and Proxy 
Table attributes (GP Cluster)


Summary of changes:
 epan/dissectors/packet-zbee-zcl-general.c |  614 -
 1 file changed, 609 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1040

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 7ba41cb6d913b7dfc9744dda65e7e2c744db32fa
Blamelist: Jaap Keuter 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d399bfa: cmake/FindPOD: improve formatting, add modelines

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d399bfaa0768de53831d0a841f0e4ef55bd37d24
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d399bfa by Peter Wu (pe...@lekensteyn.nl):

cmake/FindPOD: improve formatting, add modelines

CMake standard style is to use lowercase function names, do that.

Change-Id: I893825cfac0cc402177ffb1a0f43f0ffc6341c45
Reviewed-on: https://code.wireshark.org/review/18312
Reviewed-by: Alexis La Goutte 


Actions performed:

from  10c46fc   Qt: declare one_em to fix compile error when 
HAVE_PCAP_REMOTE is defined
adds  d399bfa   cmake/FindPOD: improve formatting, add modelines


Summary of changes:
 cmake/modules/FindPOD.cmake |   33 +++--
 1 file changed, 23 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 10c46fc: Qt: declare one_em to fix compile error when HAVE_PCAP_REMOTE is defined

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=10c46fc3082b728b08a7dcd70cad7d6eef1337bc
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

10c46fc by Hessam Jalali (hessam.jal...@gmail.com):

Qt: declare one_em to fix compile error when HAVE_PCAP_REMOTE is defined

Occured on Windows(10) x64 build.

Change-Id: I04d88bec1660dae20f459d2e03c88864c9366dc3
Reviewed-on: https://code.wireshark.org/review/18315
Reviewed-by: Roland Knall 


Actions performed:

from  1d35c7f   IP: Fix evil flag expert item text
adds  10c46fc   Qt: declare one_em to fix compile error when 
HAVE_PCAP_REMOTE is defined


Summary of changes:
 ui/qt/manage_interfaces_dialog.cpp |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/266

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] 2ebb6d329100b95d64651a2579dd250e9be1e46c
Blamelist: Jaap Keuter 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 7ba41cb: IP: Fix evil flag expert item text

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ba41cb6d913b7dfc9744dda65e7e2c744db32fa
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master-2.0
Repository: wireshark

Commits:

7ba41cb by Jaap Keuter (jaap.keu...@xs4all.nl):

IP: Fix evil flag expert item text

When creating the expert info item definition the copied line wasn't
updated with the correct message text. This change sets the right text.

Change-Id: I9a98126c0b8a650e5ab195f97c53bb32e3053e89
Reviewed-on: https://code.wireshark.org/review/18301
Petri-Dish: Jaap Keuter 
Reviewed-by: Stig Bjørlykke 
Reviewed-by: Jaap Keuter 
(cherry picked from commit 1d35c7f096792d5c2d873a3585de462d8fe54ee8)
Reviewed-on: https://code.wireshark.org/review/18311


Actions performed:

from  0627e2c   BGP: fix bgp.ls.tlv.link_protection_type_value is not of an 
FT_{U}INTn type]
adds  7ba41cb   IP: Fix evil flag expert item text


Summary of changes:
 epan/dissectors/packet-ip.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 2ebb6d3: IP: Fix evil flag expert item text

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ebb6d329100b95d64651a2579dd250e9be1e46c
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2ebb6d3 by Jaap Keuter (jaap.keu...@xs4all.nl):

IP: Fix evil flag expert item text

When creating the expert info item definition the copied line wasn't
updated with the correct message text. This change sets the right text.

Change-Id: I9a98126c0b8a650e5ab195f97c53bb32e3053e89
Reviewed-on: https://code.wireshark.org/review/18301
Petri-Dish: Jaap Keuter 
Reviewed-by: Stig Bjørlykke 
Reviewed-by: Jaap Keuter 
(cherry picked from commit 1d35c7f096792d5c2d873a3585de462d8fe54ee8)
Reviewed-on: https://code.wireshark.org/review/18310


Actions performed:

from  4039bc7   BGP: fix bgp.ls.tlv.link_protection_type_value is not of an 
FT_{U}INTn type]
adds  2ebb6d3   IP: Fix evil flag expert item text


Summary of changes:
 epan/dissectors/packet-ip.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1d35c7f: IP: Fix evil flag expert item text

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d35c7f096792d5c2d873a3585de462d8fe54ee8
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master
Repository: wireshark

Commits:

1d35c7f by Jaap Keuter (jaap.keu...@xs4all.nl):

IP: Fix evil flag expert item text

When creating the expert info item definition the copied line wasn't
updated with the correct message text. This change sets the right text.

Change-Id: I9a98126c0b8a650e5ab195f97c53bb32e3053e89
Reviewed-on: https://code.wireshark.org/review/18301
Petri-Dish: Jaap Keuter 
Reviewed-by: Stig Bjørlykke 
Reviewed-by: Jaap Keuter 


Actions performed:

from  59c3704   Add a Kerberos decryption test.
adds  1d35c7f   IP: Fix evil flag expert item text


Summary of changes:
 epan/dissectors/packet-ip.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 59c3704: Add a Kerberos decryption test.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59c370440423131e3ef460ca3b8f1f55ca319926
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

59c3704 by Gerald Combs (ger...@wireshark.org):

Add a Kerberos decryption test.

Test Kerberos decryption using files from krb-816.zip on the
SampleCaptures page.

Change-Id: Ic1360b637ca6a1f6cb86d09a6aebfd7f5ff89419
Reviewed-on: https://code.wireshark.org/review/18275
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  a0e1d28   Do not update register.c's timestamp if it is unchanged, 
otherwise it gets recompiled every time one of its dependencies is touched.
adds  59c3704   Add a Kerberos decryption test.


Summary of changes:
 test/captures/krb-816.pcap.gz |  Bin 0 -> 21013 bytes
 test/config.sh|7 ++-
 test/keys/krb-816.keytab  |  Bin 0 -> 97 bytes
 test/suite-decryption.sh  |   28 +++-
 4 files changed, 33 insertions(+), 2 deletions(-)
 create mode 100644 test/captures/krb-816.pcap.gz
 create mode 100644 test/keys/krb-816.keytab
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a0e1d28: Do not update register.c's timestamp if it is unchanged, otherwise it gets recompiled every time one of its dependencies is touched.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a0e1d282f2d8c87b985a8896a5418dda2894f48c
Submitter: Jörg Mayer (jma...@loplof.de)
Changed: branch: master
Repository: wireshark

Commits:

a0e1d28 by Joerg Mayer (jma...@loplof.de):

Do not update register.c's timestamp if it is unchanged, otherwise it gets 
recompiled
every time one of its dependencies is touched.

Change-Id: I8c0c4caea8355748e5abf9b9fe3804834353075f
Reviewed-on: https://code.wireshark.org/review/18304
Reviewed-by: Jörg Mayer 


Actions performed:

from  9672913   Bluetooth: ATT: Add missing expert info for Regulatory 
Certification
adds  a0e1d28   Do not update register.c's timestamp if it is unchanged, 
otherwise it gets recompiled every time one of its dependencies is touched.


Summary of changes:
 tools/make-dissector-reg.py |1 -
 1 file changed, 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/17363

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 7edf3eeef811135f128075a679f8d6aed400a173
Blamelist: Anders Broman ,Balint Reczey 


BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2006

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 9672913350adf1bf9d1a624e56a24ece2bfc6891
Blamelist: Anders Broman ,Balint Reczey 


BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12353

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 7edf3eeef811135f128075a679f8d6aed400a173
Blamelist: Anders Broman ,Balint Reczey 


BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/7741

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 7edf3eeef811135f128075a679f8d6aed400a173
Blamelist: Anders Broman ,Balint Reczey 


BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9672913: Bluetooth: ATT: Add missing expert info for Regulatory Certification

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9672913350adf1bf9d1a624e56a24ece2bfc6891
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

9672913 by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: ATT: Add missing expert info for Regulatory Certification

Add missed expert info for IEEE 11073-20601
Regulatory Certification Data List.

Change-Id: Id9520e1c604ee38bf11ce42248357ca007bffcfd
Reviewed-on: https://code.wireshark.org/review/18233
Reviewed-by: Anders Broman 


Actions performed:

from  7edf3ee   Use the proper include dirs for ABI check
adds  9672913   Bluetooth: ATT: Add missing expert info for Regulatory 
Certification


Summary of changes:
 epan/dissectors/packet-btatt.c |   21 +
 1 file changed, 17 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7edf3ee: Use the proper include dirs for ABI check

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7edf3eeef811135f128075a679f8d6aed400a173
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

7edf3ee by Balint Reczey (bal...@balintreczey.hu):

Use the proper include dirs for ABI check

Ping-Bug: 13018
Change-Id: I05203c56e6b595c5bff6d8e475f16b66264bdd0e
Reviewed-on: https://code.wireshark.org/review/18296
Reviewed-by: Balint Reczey 


Actions performed:

from  e68247e   InterfaceTree: Change foreach to const_iterator
adds  7edf3ee   Use the proper include dirs for ABI check


Summary of changes:
 Makefile.am.inc |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e68247e: InterfaceTree: Change foreach to const_iterator

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e68247e1fdc5a81872f5f3ee01a40ea71db71380
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e68247e by Roland Knall (rkn...@gmail.com):

InterfaceTree: Change foreach to const_iterator

Change all occurences of the foreach macro to while loops with
const_iterator for performance reasons

Change-Id: I1cd378696136b3d6cc100b9bfff95295baa2ff83
Reviewed-on: https://code.wireshark.org/review/18286
Reviewed-by: Anders Broman 


Actions performed:

from  864f750   ManageInterfacesDialog: Implement View/Data Model
adds  e68247e   InterfaceTree: Change foreach to const_iterator


Summary of changes:
 ui/qt/interface_frame.cpp |   24 ++--
 ui/qt/interface_sort_filter_model.cpp |   12 
 ui/qt/interface_tree_model.cpp|   19 +++
 3 files changed, 37 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 864f750: ManageInterfacesDialog: Implement View/Data Model

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=864f750be560a7a739c7453f19a8f5679cf7d6b3
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

864f750 by Roland Knall (rkn...@gmail.com):

ManageInterfacesDialog: Implement View/Data Model

Implement the same interface view/data model as used for
the interface_tree selection in this dialog, to encapsulate
all access to global_capture_devices from the dialog.

Change-Id: I0e568fe236d077befa2a79765638db8bb3ed1a3f
Reviewed-on: https://code.wireshark.org/review/18062
Petri-Dish: Roland Knall 
Reviewed-by: Peter Wu 
Reviewed-by: Anders Broman 


Actions performed:

from  5cbdbec   GTPv2: Add support for NB-IoT features
adds  864f750   ManageInterfacesDialog: Implement View/Data Model


Summary of changes:
 ui/qt/CMakeLists.txt |2 +
 ui/qt/Makefile.am|2 +
 ui/qt/interface_tree_cache_model.cpp |  261 ++
 ui/qt/interface_tree_cache_model.h   |   76 ++
 ui/qt/interface_tree_model.cpp   |  124 +++-
 ui/qt/interface_tree_model.h |2 +
 ui/qt/manage_interfaces_dialog.cpp   |  193 +++--
 ui/qt/manage_interfaces_dialog.h |   13 +-
 ui/qt/manage_interfaces_dialog.ui|   24 +---
 9 files changed, 456 insertions(+), 241 deletions(-)
 create mode 100644 ui/qt/interface_tree_cache_model.cpp
 create mode 100644 ui/qt/interface_tree_cache_model.h
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5cbdbec: GTPv2: Add support for NB-IoT features

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5cbdbecc35f77c40142e2e5389e553931490eea0
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

5cbdbec by Jan Spevak (jan.spe...@nokia.com):

GTPv2: Add support for NB-IoT features

Bug: 13026
Change-Id: I75de63bd58a35e234eef308fa592922e01ea3c18
Reviewed-on: https://code.wireshark.org/review/18300
Reviewed-by: Anders Broman 


Actions performed:

from  b83ea46   extcap: put missed parameters into the help
adds  5cbdbec   GTPv2: Add support for NB-IoT features


Summary of changes:
 diameter/dictionary.xml|2 +
 epan/dissectors/packet-gtpv2.c |  112 +++-
 2 files changed, 112 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b83ea46: extcap: put missed parameters into the help

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b83ea466655a77dacd8ad0bd38706afbec1ce21c
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

b83ea46 by Michal Labedzki (michal.labed...@tieto.com):

extcap: put missed parameters into the help

"--debug" and "--extcap-version" are part of extcap-base helper,
do not hide them.

Change-Id: I287b68dbed5344c188fede69d112ab007a6ee18b
Reviewed-on: https://code.wireshark.org/review/18279
Reviewed-by: Dario Lombardo 
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Roland Knall 


Actions performed:

from  ba00be5   mgcp: use ws_strtou function.
adds  b83ea46   extcap: put missed parameters into the help


Summary of changes:
 extcap/androiddump.c |2 --
 extcap/ciscodump.c   |1 -
 extcap/extcap-base.c |2 ++
 extcap/extcap-base.h |4 ++--
 extcap/randpktdump.c |1 -
 extcap/sshdump.c |1 -
 extcap/udpdump.c |1 -
 7 files changed, 4 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe