[Wireshark-commits] master-2.0 c1b9698: AMPQ: Fix malformed packed in session.expected and session.confirmed.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1b9698fe8ddf7e7651e3f8f401e616157b9f0c6
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

c1b9698 by boris.bochkarev (boris-bochkar...@yandex.ru):

AMPQ: Fix malformed packed in session.expected and session.confirmed.

Bug: 13037
Change-Id: I935ff68050eb085789d9bd99b5ec833609c6fdca
Reviewed-on: https://code.wireshark.org/review/18336
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 812e5fd893915591cd7cea34f275efc0c30cdd0a)
Reviewed-on: https://code.wireshark.org/review/18403
(cherry picked from commit a8cad8527a72cc5423062398bc384f049fe2816f)
Reviewed-on: https://code.wireshark.org/review/18404


Actions performed:

from  9465924   Clean up conditional code for getting creation time.
adds  c1b9698   AMPQ: Fix malformed packed in session.expected and 
session.confirmed.


Summary of changes:
 epan/dissectors/packet-amqp.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1c7b431: LSD: avoid dereferencing a null pointer

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c7b431a75bba97c46b54d150d6e5a3fe9f78a6a
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

1c7b431 by Pascal Quantin (pascal.quan...@gmail.com):

LSD: avoid dereferencing a null pointer

Bug: 13038
Change-Id: I701aa8cf89d8c53091974d6329f340316df8a870
Reviewed-on: https://code.wireshark.org/review/18405
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  ed18759   diameter: add new standardized QCI
adds  1c7b431   LSD: avoid dereferencing a null pointer


Summary of changes:
 epan/dissectors/packet-lsd.c |   14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ed18759: diameter: add new standardized QCI

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed187592ae8479f6e6eaea7f78f936a37db4471b
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ed18759 by Joakim Karlsson (oak...@gmail.com):

diameter: add new standardized QCI

Change-Id: If8c29934515b61081d0cbd44a0356144d5d3c466
Reviewed-on: https://code.wireshark.org/review/18407
Reviewed-by: Anders Broman 


Actions performed:

from  d3b2ee9   wsutil: add statements for c++ calls.
adds  ed18759   diameter: add new standardized QCI


Summary of changes:
 diameter/dictionary.xml |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d3b2ee9: wsutil: add statements for c++ calls.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3b2ee9b0c41478d627e90e8a9ef3b5e02512b43
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

d3b2ee9 by Dario Lombardo (lom...@gmail.com):

wsutil: add statements for c++ calls.

Change-Id: I082eb462b0a6ce77f9ca82c51d79d65516c92b53
Reviewed-on: https://code.wireshark.org/review/18401
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 


Actions performed:

from  6b03eea   GTPv2: add dissection of a few Information Elements
adds  d3b2ee9   wsutil: add statements for c++ calls.


Summary of changes:
 wsutil/strtoi.h |8 
 1 file changed, 8 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6b03eea: GTPv2: add dissection of a few Information Elements

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b03eea7143c4fb41110e8de3a16a31146300fe7
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

6b03eea by Pascal Quantin (pascal.quan...@gmail.com):

GTPv2: add dissection of a few Information Elements

This commit adds the following IEs:
- CSG ID
- CSG Membership Indication (CMI)
- Service Indicator
- Detach Type
- Local Distinguished Name (LDN)

Change-Id: I1e3db7ffd217e3644acf6de0ad5002e65c73a9ea
Reviewed-on: https://code.wireshark.org/review/18396
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  812e5fd   AMPQ: Fix malformed packed in session.expected and 
session.confirmed.
adds  6b03eea   GTPv2: add dissection of a few Information Elements


Summary of changes:
 epan/dissectors/packet-gtpv2.c |   70 ++--
 1 file changed, 60 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 a8cad85: AMPQ: Fix malformed packed in session.expected and session.confirmed.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8cad8527a72cc5423062398bc384f049fe2816f
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

a8cad85 by boris.bochkarev (boris-bochkar...@yandex.ru):

AMPQ: Fix malformed packed in session.expected and session.confirmed.

Bug: 13037
Change-Id: I935ff68050eb085789d9bd99b5ec833609c6fdca
Reviewed-on: https://code.wireshark.org/review/18336
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 812e5fd893915591cd7cea34f275efc0c30cdd0a)
Reviewed-on: https://code.wireshark.org/review/18403


Actions performed:

from  cd7c71d   Clean up conditional code for getting creation time.
adds  a8cad85   AMPQ: Fix malformed packed in session.expected and 
session.confirmed.


Summary of changes:
 epan/dissectors/packet-amqp.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 812e5fd: AMPQ: Fix malformed packed in session.expected and session.confirmed.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=812e5fd893915591cd7cea34f275efc0c30cdd0a
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

812e5fd by boris.bochkarev (boris-bochkar...@yandex.ru):

AMPQ: Fix malformed packed in session.expected and session.confirmed.

Bug: 13037
Change-Id: I935ff68050eb085789d9bd99b5ec833609c6fdca
Reviewed-on: https://code.wireshark.org/review/18336
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  48972d8   tpncp: load hf array in the handoff function
adds  812e5fd   AMPQ: Fix malformed packed in session.expected and 
session.confirmed.


Summary of changes:
 epan/dissectors/packet-amqp.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 48972d8: tpncp: load hf array in the handoff function

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=48972d883fb8865e37b83a8b8ded2ff270ca9b38
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

48972d8 by Martin Kaiser (wiresh...@kaiser.cx):

tpncp: load hf array in the handoff function

tpncp reads hf entries from a database. There's a boolean preference
defining if the database is actually read. We can't access this
preference until the preferences are initialized. The code as it is now
wil always default to false and never read the database.

Check the preference in the handoff function and initialize the hf
entries if they are not yet initialized.

Change-Id: I545a49a946b78e1a0bc23e9803eb671d8765bba4
Reviewed-on: https://code.wireshark.org/review/18386
Reviewed-by: Martin Kaiser 
Petri-Dish: Martin Kaiser 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  49a525a   fc00: skip sha512 calculations for glib < 2.36
adds  48972d8   tpncp: load hf array in the handoff function


Summary of changes:
 epan/dissectors/packet-tpncp.c |   69 +---
 1 file changed, 37 insertions(+), 32 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 49a525a: fc00: skip sha512 calculations for glib < 2.36

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49a525a97e68f9ba5b840c3054669a5dd6081010
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

49a525a by Martin Kaiser (wiresh...@kaiser.cx):

fc00: skip sha512 calculations for glib < 2.36

Our minimum supported version of glib is 2.22 at the moment.
SHA512 support was added in glib 2.36.

Bring up an expert info if checksum calculation is not supported
by our glib version.

Change-Id: I116b32f63a4342a7e4198eaae8a35189fcc92edc
Reviewed-on: https://code.wireshark.org/review/18391
Reviewed-by: Martin Kaiser 
Petri-Dish: Martin Kaiser 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  ce9405b   cleanup: move extra libs to EPAN_EXTRA_LIBS
adds  49a525a   fc00: skip sha512 calculations for glib < 2.36


Summary of changes:
 epan/dissectors/packet-fc00.c |   20 
 1 file changed, 20 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ce9405b: cleanup: move extra libs to EPAN_EXTRA_LIBS

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce9405b00b0bc49fef5a21f984251a1e0065580b
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ce9405b by Jakub Zawadzki (darkjames...@darkjames.pl):

cleanup: move extra libs to EPAN_EXTRA_LIBS

Every program linking with epan lib added some extra dependencies.
Keep these in EPAN_EXTRA_LIBS.

Change-Id: I3fac0974ef6a46675d35ee7b9862674923369b67
Reviewed-on: https://code.wireshark.org/review/18356
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  28bbd56   Add SBC decoding support to Windows
adds  ce9405b   cleanup: move extra libs to EPAN_EXTRA_LIBS


Summary of changes:
 Makefile.am |   47 ---
 1 file changed, 16 insertions(+), 31 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 28bbd56: Add SBC decoding support to Windows

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=28bbd565917d59b20458e5de783096bc332c1965
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

28bbd56 by Pascal Quantin (pascal.quan...@gmail.com):

Add SBC decoding support to Windows

Change-Id: Ibef872dff26c22e2834e958c496c33a5695bb131
Reviewed-on: https://code.wireshark.org/review/18394
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  a2d4912   cmake, qt4: check if QT4_FOUND
adds  28bbd56   Add SBC decoding support to Windows


Summary of changes:
 CMakeLists.txt|7 +++
 cmake/modules/FindSBC.cmake   |   17 -
 packaging/nsis/CMakeLists.txt |2 +-
 packaging/wix/CMakeLists.txt  |4 ++--
 tools/win-setup.ps1   |7 +--
 5 files changed, 31 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a2d4912: cmake, qt4: check if QT4_FOUND

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a2d49125a52e0eb21215368a7e1f248b6d4a6c06
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

a2d4912 by Martin Kaiser (wiresh...@kaiser.cx):

cmake, qt4: check if QT4_FOUND

AFAICS, FindQt4.cmake sets QT4_FOUND, not Qt4_FOUND

This fixes compilation on Debian Wheezy (cmake 2.8.9, Qt 4.8.2).

Change-Id: I08b3ac6ae4292b8c8d3f9e8752780459e5329e29
Reviewed-on: https://code.wireshark.org/review/18395
Reviewed-by: Gerald Combs 


Actions performed:

from  44cf0bd   main_welcome: include QUrl
adds  a2d4912   cmake, qt4: check if QT4_FOUND


Summary of changes:
 CMakeLists.txt |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 44cf0bd: main_welcome: include QUrl

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=44cf0bdccfc36e11419b1a9bf3d72ac0db13d58b
Submitter: Martin Kaiser (wiresh...@kaiser.cx)
Changed: branch: master
Repository: wireshark

Commits:

44cf0bd by Martin Kaiser (wiresh...@kaiser.cx):

main_welcome: include QUrl

This fixes compilation with Qt4.

.../main_welcome.cpp: In member function ‘void 
MainWelcome::on_helpLabel_clicked()’:
.../main_welcome.cpp:509:69: error: invalid use of incomplete type ‘class 
QUrl’

Change-Id: Ib31a4e28f67a27d3f644e8a8cfd3e6d848e034c4
Reviewed-on: https://code.wireshark.org/review/18388
Reviewed-by: Martin Kaiser 


Actions performed:

from  e858829   CMake: Disable Qt4 && (Windows || macOS).
adds  44cf0bd   main_welcome: include QUrl


Summary of changes:
 ui/qt/main_welcome.cpp |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win64-libs rev 455: /tags/2016-10-22/ /tags/2016-10-22/: README.txt README.txt /tags/2016-10-22/packages/: sbc-1.3-win64ws.zip

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win64-libs=455

User: pascal
Date: 2016/10/22 01:26 PM

Log:
 Add SBC 1.3

Directory: /tags/2016-10-22/
  ChangesPath  Action
  +227 -0README.txtRemoved
  None   README.txtAdded

Directory: /tags/2016-10-22/packages/
  ChangesPath   Action
  +0 -0  sbc-1.3-win64ws.zipAdded

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win64-libs rev 454: / /trunk/packages/: sbc-1.3-win64ws.zip /trunk/: README.txt

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win64-libs=454

User: pascal
Date: 2016/10/22 01:25 PM

Log:
 Add SBC 1.3

Directory: /trunk/packages/
  ChangesPath   Action
  +0 -0  sbc-1.3-win64ws.zipAdded

Directory: /trunk/
  ChangesPath  Action
  +7 -0  README.txtModified

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win32-libs rev 502: /tags/2016-10-22/

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win32-libs=502

User: pascal
Date: 2016/10/22 01:05 PM

Log:
 Add SBC 1.3

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/254

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] cd7c71ddfd1ed809be886c6096bdda2cc877e4a4
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win32-libs rev 501: / /trunk/packages/: sbc-1.3-win32ws.zip /trunk/: README.txt

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win32-libs=501

User: pascal
Date: 2016/10/22 01:01 PM

Log:
 Add SBC 1.3

Directory: /trunk/packages/
  ChangesPath   Action
  +0 -0  sbc-1.3-win32ws.zipAdded

Directory: /trunk/
  ChangesPath  Action
  +7 -0  README.txtModified

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/7783

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] d32fee2d6252c485dacdf51441d7ba5c6d37d7f3
Blamelist: Michal Labedzki 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1050

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 787ee25e78819344c9f1ad02c3f6da10176c1d93
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e858829: CMake: Disable Qt4 && (Windows || macOS).

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e85882940419dd9ce012489689e13ae4b18be04e
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e858829 by Gerald Combs (ger...@wireshark.org):

CMake: Disable Qt4 && (Windows || macOS).

We haven't built the Windows and macOS installers with Qt4 for quite
some time. In the case of macOS+Qt4 it looks like there's a problem with
the main screen size (bug 13009) and it's a safe bet that there are
other problems. There's not much we can do exept say "don't do that." Do
so at build time rather than after the user has installed Wireshark and
is trying to use it.

Change-Id: I22f47b9705ea044238046676b6336aa5feab3f60
Reviewed-on: https://code.wireshark.org/review/18364
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  7dfaec9   alljoyn: fix signature length adjustments
adds  e858829   CMake: Disable Qt4 && (Windows || macOS).


Summary of changes:
 CMakeLists.txt |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7dfaec9: alljoyn: fix signature length adjustments

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7dfaec969e67e3aa14b9763d804802ef614c9ddd
Submitter: Martin Kaiser (wiresh...@kaiser.cx)
Changed: branch: master
Repository: wireshark

Commits:

7dfaec9 by Peter Wu (pe...@lekensteyn.nl):

alljoyn: fix signature length adjustments

Ensure that the signature pointer and length always matches, otherwise a
buffer overrun (read) is possible.

Tested with the original captures from bug 12953, the PDML output is
still the same while the fuzzed capture does not crash anymore.

Bug: 12953
Change-Id: I8843a5daf98a79fb19906e824326cdf619164484
Reviewed-on: https://code.wireshark.org/review/18347
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Martin Kaiser 


Actions performed:

from  e80a8ac   Clean up conditional code for getting creation time.
adds  7dfaec9   alljoyn: fix signature length adjustments


Summary of changes:
 epan/dissectors/packet-alljoyn.c |   31 ++-
 1 file changed, 18 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2051

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 5f68435a079dc7ce633e1da22f363e4e715d66f6
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 9465924: Clean up conditional code for getting creation time.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94659249901e8603cff53ec6d532922f21e0084e
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9465924 by Guy Harris (g...@alum.mit.edu):

Clean up conditional code for getting creation time.

Define a macro to get the creation time from a stat structure, or to
return 0 if the creation time is unavailable, and use that in both
places where we fetch the creation time.

Change-Id: I15354f2d52a40cb1227f30ae274120575eec2055
Reviewed-on: https://code.wireshark.org/review/18387
Reviewed-by: Guy Harris 
(cherry picked from commit e80a8acbe3cb0d0bdefeff51292bd90c3461a02a)
Reviewed-on: https://code.wireshark.org/review/18390


Actions performed:

from  787ee25   Fix #defines for the creation time in struct stat on UN*X.
adds  9465924   Clean up conditional code for getting creation time.


Summary of changes:
 fileset.c |   45 +++--
 1 file changed, 19 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 cd7c71d: Clean up conditional code for getting creation time.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cd7c71ddfd1ed809be886c6096bdda2cc877e4a4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

cd7c71d by Guy Harris (g...@alum.mit.edu):

Clean up conditional code for getting creation time.

Define a macro to get the creation time from a stat structure, or to
return 0 if the creation time is unavailable, and use that in both
places where we fetch the creation time.

Change-Id: I15354f2d52a40cb1227f30ae274120575eec2055
Reviewed-on: https://code.wireshark.org/review/18387
Reviewed-by: Guy Harris 
(cherry picked from commit e80a8acbe3cb0d0bdefeff51292bd90c3461a02a)
Reviewed-on: https://code.wireshark.org/review/18389


Actions performed:

from  ddde79b   Fix the #defines for the presence of structure names.
adds  cd7c71d   Clean up conditional code for getting creation time.


Summary of changes:
 fileset.c |   45 +++--
 1 file changed, 19 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e80a8ac: Clean up conditional code for getting creation time.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e80a8acbe3cb0d0bdefeff51292bd90c3461a02a
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

e80a8ac by Guy Harris (g...@alum.mit.edu):

Clean up conditional code for getting creation time.

Define a macro to get the creation time from a stat structure, or to
return 0 if the creation time is unavailable, and use that in both
places where we fetch the creation time.

Change-Id: I15354f2d52a40cb1227f30ae274120575eec2055
Reviewed-on: https://code.wireshark.org/review/18387
Reviewed-by: Guy Harris 


Actions performed:

from  5f68435   Fix the #defines for the presence of structure names.
adds  e80a8ac   Clean up conditional code for getting creation time.


Summary of changes:
 fileset.c |   45 +++--
 1 file changed, 19 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 787ee25: Fix #defines for the creation time in struct stat on UN*X.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=787ee25e78819344c9f1ad02c3f6da10176c1d93
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

787ee25 by Guy Harris (g...@alum.mit.edu):

Fix #defines for the creation time in struct stat on UN*X.

Fix the #defines in ConfigureChecks.cmake to match what the autotools
configure script defines and what cmakeconfig.h.in has.

Change-Id: I3bffed7b9966c2dcdc8419f7671c38dbe2c71347
Reviewed-on: https://code.wireshark.org/review/18385
Reviewed-by: Guy Harris 


Actions performed:

from  7ef4796   On UN*X, st_ctime is the last status change time, not the 
creation time.
adds  787ee25   Fix #defines for the creation time in struct stat on UN*X.


Summary of changes:
 ConfigureChecks.cmake |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5f68435: Fix the #defines for the presence of structure names.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f68435a079dc7ce633e1da22f363e4e715d66f6
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

5f68435 by Guy Harris (g...@alum.mit.edu):

Fix the #defines for the presence of structure names.

AC_CHECK_MEMBER() and AC_CHECK_MEMBERS() use a standard name for the
{structurename} being the name of the structure type, complete with
"struct" if a typedef wasn't used, and with all letters mapped to upper
case, and with {membername} being the name of the structure member, with
all letters mapped to upper case.

check_struct_has_member() lets you choose the name; choose the same name
that the autoconf macros use, and fix the code to check for them.

Change-Id: Ifb3cf65e7e94907ad0a2f8aacca0c21a531f0c5b
Reviewed-on: https://code.wireshark.org/review/18382
Petri-Dish: Guy Harris 
Reviewed-by: Guy Harris 


Actions performed:

from  d32fee2   Qt/Bluetooth: Add Display Filter Edit field to HCI Summary 
dialogue
adds  5f68435   Fix the #defines for the presence of structure names.


Summary of changes:
 ConfigureChecks.cmake |8 
 caputils/capture-pcap-util-unix.c |2 +-
 cmakeconfig.h.in  |4 ++--
 ui/gtk/file_dlg.c |   10 +-
 4 files changed, 12 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 ddde79b: Fix the #defines for the presence of structure names.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ddde79b5843da9048ba67031709cc83a2a927410
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ddde79b by Guy Harris (g...@alum.mit.edu):

Fix the #defines for the presence of structure names.

AC_CHECK_MEMBER() and AC_CHECK_MEMBERS() use a standard name for the
{structurename} being the name of the structure type, complete with
"struct" if a typedef wasn't used, and with all letters mapped to upper
case, and with {membername} being the name of the structure member, with
all letters mapped to upper case.

check_struct_has_member() lets you choose the name; choose the same name
that the autoconf macros use, and fix the code to check for them.

Change-Id: Ifb3cf65e7e94907ad0a2f8aacca0c21a531f0c5b
Reviewed-on: https://code.wireshark.org/review/18382
Petri-Dish: Guy Harris 
Reviewed-by: Guy Harris 
(cherry picked from commit 5f68435a079dc7ce633e1da22f363e4e715d66f6)
Reviewed-on: https://code.wireshark.org/review/18384


Actions performed:

from  ce6e29b   On UN*X, st_ctime is the last status change time, not the 
creation time.
adds  ddde79b   Fix the #defines for the presence of structure names.


Summary of changes:
 ConfigureChecks.cmake |8 
 caputils/capture-pcap-util-unix.c |2 +-
 cmakeconfig.h.in  |4 ++--
 ui/gtk/file_dlg.c |   10 +-
 4 files changed, 12 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/252

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] ce6e29bf94d2982c65f6bb03c6bcba555de701ed
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d32fee2: Qt/Bluetooth: Add Display Filter Edit field to HCI Summary dialogue

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d32fee2d6252c485dacdf51441d7ba5c6d37d7f3
Submitter: Michal Labedzki (michal.labed...@tieto.com)
Changed: branch: master
Repository: wireshark

Commits:

d32fee2 by Michal Labedzki (michal.labed...@tieto.com):

Qt/Bluetooth: Add Display Filter Edit field to HCI Summary dialogue

Display Filter can be useful for this summary dialogue,
for example to reduce number of frame that were analyzed, like:
"frame.number >= 100 && frame.number <= 4674"

Change-Id: I19587b9d41f3b253d1ca2683d198f7d7af2ad50f
Reviewed-on: https://code.wireshark.org/review/18265
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 
Tested-by: Michal Labedzki 


Actions performed:

from  0cb4d0d   C1222: update auto generated file
adds  d32fee2   Qt/Bluetooth: Add Display Filter Edit field to HCI Summary 
dialogue


Summary of changes:
 ui/qt/bluetooth_hci_summary_dialog.cpp |   23 +++
 ui/qt/bluetooth_hci_summary_dialog.h   |1 +
 ui/qt/bluetooth_hci_summary_dialog.ui  |   19 ++-
 3 files changed, 42 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 7ef4796: On UN*X, st_ctime is the last status change time, not the creation time.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ef4796ba9e1f41242ab737aad26f81bb62a4eaa
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

7ef4796 by Guy Harris (g...@alum.mit.edu):

On UN*X, st_ctime is the last status change time, not the creation time.

That's the time the file's inode last changed, so size changes,
permission changes, etc. affect it.  It's *not* the time the file was
created; most UN*Xes don't provide that.  Newer versions of FreeBSD,
NetBSD, OpenBSD, and macOS do, but other UN*Xes don't appear to.

On Windows, at least according to Microsoft's documentation, st_ctime
*is* the creation time.  Hopefully that's not the result of confusion on
the part of somebody at Microsoft.

Change-Id: I9e91cc562582bec46d42589f134eb8561dbb5f40
Reviewed-on: https://code.wireshark.org/review/18381
Reviewed-by: Guy Harris 


Actions performed:

from  bdf6ec3   Suppress "discarding const" warning.
adds  7ef4796   On UN*X, st_ctime is the last status change time, not the 
creation time.


Summary of changes:
 ConfigureChecks.cmake |8 +---
 cmakeconfig.h.in  |6 ++
 configure.ac  |6 ++
 fileset.c |   24 
 ui/gtk/fileset_dlg.c  |   28 +++-
 ui/qt/file_set_dialog.cpp |   14 --
 6 files changed, 72 insertions(+), 14 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 ce6e29b: On UN*X, st_ctime is the last status change time, not the creation time.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce6e29bf94d2982c65f6bb03c6bcba555de701ed
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ce6e29b by Guy Harris (g...@alum.mit.edu):

On UN*X, st_ctime is the last status change time, not the creation time.

That's the time the file's inode last changed, so size changes,
permission changes, etc. affect it.  It's *not* the time the file was
created; most UN*Xes don't provide that.  Newer versions of FreeBSD,
NetBSD, OpenBSD, and macOS do, but other UN*Xes don't appear to.

On Windows, at least according to Microsoft's documentation, st_ctime
*is* the creation time.  Hopefully that's not the result of confusion on
the part of somebody at Microsoft.

Change-Id: I20743703f6ef66e40dff9004dc91bed46af6fad0
Reviewed-on: https://code.wireshark.org/review/18378
Reviewed-by: Guy Harris 
(cherry picked from commit 528894e72f973c5db5dc76c975620754f7bbe5aa)
Reviewed-on: https://code.wireshark.org/review/18380


Actions performed:

from  31e1149   Suppress "discarding const" warning.
adds  ce6e29b   On UN*X, st_ctime is the last status change time, not the 
creation time.


Summary of changes:
 ConfigureChecks.cmake |8 +---
 cmakeconfig.h.in  |6 ++
 configure.ac  |6 ++
 fileset.c |   24 
 ui/gtk/fileset_dlg.c  |   28 +++-
 ui/qt/file_set_dialog.cpp |   14 --
 6 files changed, 72 insertions(+), 14 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0cb4d0d: C1222: update auto generated file

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0cb4d0d346a9cf39135ef12c9eb65e727c14b3dc
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

0cb4d0d by Pascal Quantin (pascal.quan...@gmail.com):

C1222: update auto generated file

Change-Id: I9c29ebe0ef24dcf9f5db5f5e767f910644bb9762
Reviewed-on: https://code.wireshark.org/review/18379
Reviewed-by: Pascal Quantin 


Actions performed:

from  a63b5eb   Qt: Make "Learn" on the welcome screen clickable.
adds  0cb4d0d   C1222: update auto generated file


Summary of changes:
 epan/dissectors/packet-c1222.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1048

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] bdf6ec3618cd9f0424293f6c5bcf6f06c6fb2fe8
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a63b5eb: Qt: Make "Learn" on the welcome screen clickable.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a63b5eb711cc50efe2725d716e0774e147376d25
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

a63b5eb by Gerald Combs (ger...@wireshark.org):

Qt: Make "Learn" on the welcome screen clickable.

Make the "Learn" header a ClickableLabel to match "Open" and "Capture".
Link to the docs page for now. Adjust its stylesheet and properties to
match ast well.

Change-Id: Id9c7c05269de8134af28f0f9c1e2820a60442236
Reviewed-on: https://code.wireshark.org/review/18358
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  528894e   On UN*X, st_ctime is the last status change time, not the 
creation time.
adds  a63b5eb   Qt: Make "Learn" on the welcome screen clickable.


Summary of changes:
 ui/help_url.c  |3 +++
 ui/help_url.h  |1 +
 ui/qt/main_welcome.cpp |   26 --
 ui/qt/main_welcome.h   |1 +
 ui/qt/main_welcome.ui  |8 +++-
 5 files changed, 28 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe