[Wireshark-commits] master 681b97a: Qt: Make horizontal spacer size to be fixed

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=681b97a047fa10c050a86869e113f8ecb3f9d127
Submitter: Michal Labedzki (michal.labed...@tieto.com)
Changed: branch: master
Repository: wireshark

Commits:

681b97a by Michal Labedzki (michal.labed...@tieto.com):

Qt: Make horizontal spacer size to be fixed

The Search Frame can be used to find frames by a display filter
expression that can be very long, so stretch a text field instead
of free space.

Example of a display filter expression that can be used in
the "search bar":
bthci_cmd.opcode == 0x200d || bthci_evt.le_meta_subevent == 0x0a

Change-Id: I52b30386e96a726824c25a926742a24d653dfcfe
Reviewed-on: https://code.wireshark.org/review/18234
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 


Actions performed:

from  3b502c8   Qt: fix possible crash on sorting custom columns
adds  681b97a   Qt: Make horizontal spacer size to be fixed


Summary of changes:
 ui/qt/search_frame.ui |3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3b502c8: Qt: fix possible crash on sorting custom columns

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b502c873f2b30e661d46693d3a3f6fcba9474ea
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3b502c8 by Peter Wu (pe...@lekensteyn.nl):

Qt: fix possible crash on sorting custom columns

The sorting function must maintain a strict weak ordering, otherwise it
may result in crashes. In the case of custom columns, this was violated
when exactly one of the two rows had a non-numeric value.

Bug: 13023
Change-Id: Ie338b1cce5156eeb313dd33491ee3d3f2eaddf1c
Reviewed-on: https://code.wireshark.org/review/18406
Reviewed-by: Jim Young 
Petri-Dish: Jim Young 
Tested-by: Jim Young 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  20e2edc   Add some Diameter AVPs referenced by (recently added) 
grouped AVPs.
adds  3b502c8   Qt: fix possible crash on sorting custom columns


Summary of changes:
 ui/qt/packet_list_model.cpp |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 20e2edc: Add some Diameter AVPs referenced by (recently added) grouped AVPs.

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20e2edca572a835ab4ee6ff1fbbf86bf5db54b35
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

20e2edc by Jeff Morriss (jeff.morriss...@gmail.com):

Add some Diameter AVPs referenced by (recently added) grouped AVPs.

... In order to make the Diameter XML valid again.

This includes adding T6a/T6b and most of the AVPs of that application.

Fix up some white space while at it.

Change-Id: Ie39b3e574065628fdba215cc9c045eebcbd3077e
Reviewed-on: https://code.wireshark.org/review/18422
Reviewed-by: Anders Broman 


Actions performed:

from  af7fc8b   Qt: add fullscreen feature.
adds  20e2edc   Add some Diameter AVPs referenced by (recently added) 
grouped AVPs.


Summary of changes:
 diameter/TGPP.xml   |  118 +++---
 diameter/dictionary.xml |  257 +++
 2 files changed, 250 insertions(+), 125 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master af7fc8b: Qt: add fullscreen feature.

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=af7fc8b7e4979e77d2d072789e98d58a0b175908
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

af7fc8b by Dario Lombardo (lom...@gmail.com):

Qt: add fullscreen feature.

The feature activates/deactivates fullscreen mode of Qt UI.
A new menu item has been added as well as a shortcut (F11 or Ctrl+Cmd+F)
according to browsers common shortcut.

Change-Id: I01906b494d0a13ce70d27c00ebbe03e6ec87cbd7
Reviewed-on: https://code.wireshark.org/review/18332
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Peter Wu 
Reviewed-by: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Roland Knall 


Actions performed:

from  3156980   packet-infiniband: Fixed displaying reserved field
adds  af7fc8b   Qt: add fullscreen feature.


Summary of changes:
 capture_opts.h |4 +++-
 doc/wireshark.pod.template |7 +++
 docbook/release-notes.asciidoc |1 +
 ui/commandline.c   |5 +
 ui/commandline.h   |3 ++-
 ui/qt/main_window.cpp  |   13 +
 ui/qt/main_window.h|2 ++
 ui/qt/main_window.ui   |   12 +++-
 ui/qt/main_window_slots.cpp|   18 ++
 9 files changed, 62 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3156980: packet-infiniband: Fixed displaying reserved field

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3156980aa559186a10e3b8566d41e4a50477d967
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master
Repository: wireshark

Commits:

3156980 by Parav Pandit (paravpan...@yahoo.com):

packet-infiniband: Fixed displaying reserved field

1. Added Extended transport type field instead of reserved as per latest
release 1.3.1 in CM Req msg.
2. Defined reserved bits and bytes for CM messages
3. Minor code refactor to move to smaller functions for CM Req Rsp
parsing instead of 200+ lines function which is hard to read and
is expected to grow for more features
4. Cleanup around primary and alternate fields which were crossing byte
boundary

CM request and response messages are tested.
Reject message reserved fields change is untested but it a minor change
that is expected to work.

Change-Id: I94da62614f854218249b4e14c780f4168f44751c
Reported-by: Alexis La Goutte
Tested-by: paravpan...@yahoo.com
Reviewed-on: https://code.wireshark.org/review/18340
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Petri-Dish: Alexis La Goutte 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Jaap Keuter 


Actions performed:

from  875b3e2   ZigBee: fix the first parameter of memcpy
adds  3156980   packet-infiniband: Fixed displaying reserved field


Summary of changes:
 epan/dissectors/packet-infiniband.c |  526 ---
 1 file changed, 306 insertions(+), 220 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 0dc72c4: ZigBee Green Power: fix loading of keys during runtime

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0dc72c4b40d3dcc50f9c0438382719134c063236
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

0dc72c4 by Pascal Quantin (pascal.quan...@gmail.com):

ZigBee Green Power: fix loading of keys during runtime

Register a post update calback to ensure that the keys are loaded
for all entries and not only the ones last edited

Bug: 13031
Change-Id: Ib670f9e1c702546631df5fe6094b02484806dd00
Reviewed-on: https://code.wireshark.org/review/18416
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
Reviewed-by: Pascal Quantin 
(cherry picked from commit a3a20531b1a7ae2bb8b48ca25fbe27f10e2462a9)
Reviewed-on: https://code.wireshark.org/review/18419


Actions performed:

from  a8d5526   [Automatic update for 2016-10-23]
adds  0dc72c4   ZigBee Green Power: fix loading of keys during runtime


Summary of changes:
 epan/dissectors/packet-zbee-nwk-gp.c |   20 ++--
 1 file changed, 18 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 875b3e2: ZigBee: fix the first parameter of memcpy

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=875b3e2732e8ad20f87ef940300605080a807132
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

875b3e2 by Pascal Quantin (pascal.quan...@gmail.com):

ZigBee: fix the first parameter of memcpy

key_record.key is already a pointer on an array

Change-Id: I9bcc715be54817f8daa3928fff72d9ef98d586f9
Reviewed-on: https://code.wireshark.org/review/18417
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
Reviewed-by: Pascal Quantin 


Actions performed:

from  a3a2053   ZigBee Green Power: fix loading of keys during runtime
adds  875b3e2   ZigBee: fix the first parameter of memcpy


Summary of changes:
 epan/dissectors/packet-zbee-security.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a3a2053: ZigBee Green Power: fix loading of keys during runtime

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a3a20531b1a7ae2bb8b48ca25fbe27f10e2462a9
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

a3a2053 by Pascal Quantin (pascal.quan...@gmail.com):

ZigBee Green Power: fix loading of keys during runtime

Register a post update calback to ensure that the keys are loaded
for all entries and not only the ones last edited

Bug: 13031
Change-Id: Ib670f9e1c702546631df5fe6094b02484806dd00
Reviewed-on: https://code.wireshark.org/review/18416
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
Reviewed-by: Pascal Quantin 


Actions performed:

from  3c3f592   [Automatic update for 2016-10-23]
adds  a3a2053   ZigBee Green Power: fix loading of keys during runtime


Summary of changes:
 epan/dissectors/packet-zbee-nwk-gp.c |   20 ++--
 1 file changed, 18 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 401da09: [Automatic update for 2016-10-23]

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=401da09a13e8f2494391127973a8841dd9dff143
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

401da09 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-10-23]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I0d57604046ff7411ed3eb74e51715e95d58da830
Reviewed-on: https://code.wireshark.org/review/18414
Reviewed-by: Gerald Combs 


Actions performed:

from  a5770b6   alljoyn: fix signature length adjustments
adds  401da09   [Automatic update for 2016-10-23]


Summary of changes:
 epan/enterprise-numbers  |   72 ++
 epan/sminmpec.c  |   17 ++-
 manuf|   56 
 services |1 +
 ui/qt/wireshark_de.ts|   10 +++
 ui/qt/wireshark_en.ts|   10 +++
 ui/qt/wireshark_fr.ts|   10 +++
 ui/qt/wireshark_it.ts|   10 +++
 ui/qt/wireshark_ja_JP.ts |   10 +++
 ui/qt/wireshark_pl.ts|   10 +++
 ui/qt/wireshark_zh_CN.ts |   10 +++
 11 files changed, 168 insertions(+), 48 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 a8d5526: [Automatic update for 2016-10-23]

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8d55261132b735248418d623b0412fa027abb2a
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

a8d5526 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-10-23]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I321856652a70c7a2dd2fe4a52c527867431e493e
Reviewed-on: https://code.wireshark.org/review/18413
Reviewed-by: Gerald Combs 


Actions performed:

from  f44fd03   alljoyn: fix signature length adjustments
adds  a8d5526   [Automatic update for 2016-10-23]


Summary of changes:
 AUTHORS  |1 +
 epan/enterprise-numbers  |   76 ++
 epan/sminmpec.c  |   18 ++-
 manuf|   71 +++
 services |1 +
 ui/qt/wireshark_de.ts|   10 +++---
 ui/qt/wireshark_en.ts|   10 +++---
 ui/qt/wireshark_fr.ts|   10 +++---
 ui/qt/wireshark_it.ts|   10 +++---
 ui/qt/wireshark_ja_JP.ts |   10 +++---
 ui/qt/wireshark_pl.ts|   10 +++---
 ui/qt/wireshark_zh_CN.ts |   10 +++---
 12 files changed, 189 insertions(+), 48 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3c3f592: [Automatic update for 2016-10-23]

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c3f592ebc9e84a7c77bb50bf45ae7222dcd8a4c
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

3c3f592 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-10-23]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I5127251ce46aa668cd12daacc7c6702564c04c8f
Reviewed-on: https://code.wireshark.org/review/18412
Reviewed-by: Gerald Combs 


Actions performed:

from  3576394   interface_sort_filter_model: don't dereference a NULL 
pointer
adds  3c3f592   [Automatic update for 2016-10-23]


Summary of changes:
 AUTHORS  |4 +
 epan/enterprise-numbers  |   76 +-
 epan/sminmpec.c  |   18 ++-
 services |1 +
 ui/qt/wireshark_de.ts|  353 +
 ui/qt/wireshark_en.ts|  345 +++-
 ui/qt/wireshark_fr.ts|  353 +
 ui/qt/wireshark_it.ts|  353 +
 ui/qt/wireshark_ja_JP.ts |  352 +
 ui/qt/wireshark_pl.ts|  354 ++
 ui/qt/wireshark_zh_CN.ts |  352 +
 11 files changed, 1697 insertions(+), 864 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

2016-10-23 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/257

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] f44fd03955e1023165cb661f9fe05d53ba7ee540
Blamelist: Anders Broman 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2016-10-23 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/7795

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 903eab03798d636cc3cebd1fd08e0097190c745d
Blamelist: Anders Broman 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3576394: interface_sort_filter_model: don't dereference a NULL pointer

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3576394ed4fc782ce5a2151c88c5a10b37cb3393
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3576394 by Martin Kaiser (wiresh...@kaiser.cx):

interface_sort_filter_model: don't dereference a NULL pointer

This fixes a crash in InterfaceSortFilterModel::mapToSource().

sourceModel was set to match the sourceModel of the underlying
InterfaceFrame. When Wireshark is closed,
InterfaceSortFilterModel::mapToSource() is called after
InterfaceFrame was freed, the sourceModel is NULL in this case.

 #0  0x0079a81e in InterfaceSortFilterModel::mapToSource
 (this=0xe9fab0, proxyIndex=...)
 /home/martin/src/wireshark.git/ui/qt/interface_sort_filter_model.cpp:250
 ...
 #7  0x00797ed9 in InterfaceTreeModel::~InterfaceTreeModel
 (this=0xe9ff90, __in_chrg=)
at /home/martin/src/wireshark.git/ui/qt/interface_tree_model.cpp:72
 #8  0x006c4e20 in InterfaceFrame::~InterfaceFrame
 (this=0xe643b0, __in_chrg=)
at /home/martin/src/wireshark.git/ui/qt/interface_frame.cpp:109
 #9  0x006c4ec9 in InterfaceFrame::~InterfaceFrame
 (this=0xe643b0, __in_chrg=)
at /home/martin/src/wireshark.git/ui/qt/interface_frame.cpp:112

Change-Id: Ibe7f75ccd7a0af5f04febf967c47ada1a05bc3d3
Reviewed-on: https://code.wireshark.org/review/18411
Reviewed-by: Martin Kaiser 
Petri-Dish: Martin Kaiser 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  892246a   diameter: improvement of AVP 1066
adds  3576394   interface_sort_filter_model: don't dereference a NULL 
pointer


Summary of changes:
 ui/qt/interface_sort_filter_model.cpp |3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 892246a: diameter: improvement of AVP 1066

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=892246acb02868ee4be14543521a20b9818184d6
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

892246a by Joakim Karlsson (oak...@gmail.com):

diameter: improvement of AVP 1066

Printing ascii value in the same way as AVP 1005

Change-Id: I058be87974bf8197e207fdd61be6354031ed8d35
Reviewed-on: https://code.wireshark.org/review/18409
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  903eab0   sip: use ws_strtoi functions.
adds  892246a   diameter: improvement of AVP 1066


Summary of changes:
 epan/dissectors/packet-diameter_3gpp.c |   35 +++-
 1 file changed, 34 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 a5770b6: alljoyn: fix signature length adjustments

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a5770b6559b6e6765c4ef800e85ae42781ea4900
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a5770b6 by Peter Wu (pe...@lekensteyn.nl):

alljoyn: fix signature length adjustments

Ensure that the signature pointer and length always matches, otherwise a
buffer overrun (read) is possible.

Tested with the original captures from bug 12953, the PDML output is
still the same while the fuzzed capture does not crash anymore.

Bug: 12953
Change-Id: I8843a5daf98a79fb19906e824326cdf619164484
Reviewed-on: https://code.wireshark.org/review/18347
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Martin Kaiser 
(cherry picked from commit 7dfaec969e67e3aa14b9763d804802ef614c9ddd)
 [Peter: resolved conflicts in context]
Reviewed-on: https://code.wireshark.org/review/18410
Reviewed-by: Anders Broman 


Actions performed:

from  c1b9698   AMPQ: Fix malformed packed in session.expected and 
session.confirmed.
adds  a5770b6   alljoyn: fix signature length adjustments


Summary of changes:
 epan/dissectors/packet-alljoyn.c |   31 ++-
 1 file changed, 18 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 f44fd03: alljoyn: fix signature length adjustments

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f44fd03955e1023165cb661f9fe05d53ba7ee540
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

f44fd03 by Peter Wu (pe...@lekensteyn.nl):

alljoyn: fix signature length adjustments

Ensure that the signature pointer and length always matches, otherwise a
buffer overrun (read) is possible.

Tested with the original captures from bug 12953, the PDML output is
still the same while the fuzzed capture does not crash anymore.

Bug: 12953
Change-Id: I8843a5daf98a79fb19906e824326cdf619164484
Reviewed-on: https://code.wireshark.org/review/18347
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Martin Kaiser 
(cherry picked from commit 7dfaec969e67e3aa14b9763d804802ef614c9ddd)
Reviewed-on: https://code.wireshark.org/review/18408
Reviewed-by: Anders Broman 


Actions performed:

from  a8cad85   AMPQ: Fix malformed packed in session.expected and 
session.confirmed.
adds  f44fd03   alljoyn: fix signature length adjustments


Summary of changes:
 epan/dissectors/packet-alljoyn.c |   31 ++-
 1 file changed, 18 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-10-23 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2063

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 2e962d368a6f19d8a32a997dfa144eb3794009ef
Blamelist: Anders Broman 

BUILD FAILED: failed copy-build

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 903eab0: sip: use ws_strtoi functions.

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=903eab03798d636cc3cebd1fd08e0097190c745d
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

903eab0 by Dario Lombardo (lom...@gmail.com):

sip: use ws_strtoi functions.

Change-Id: I69cdc1118f62ed86661ccfb9fb522ad0bb00596e
Reviewed-on: https://code.wireshark.org/review/18397
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  2e962d3   dtls: use ws_strtoi function.
adds  903eab0   sip: use ws_strtoi functions.


Summary of changes:
 epan/dissectors/packet-sip.c |   38 ++
 1 file changed, 30 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2e962d3: dtls: use ws_strtoi function.

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e962d368a6f19d8a32a997dfa144eb3794009ef
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2e962d3 by Dario Lombardo (lom...@gmail.com):

dtls: use ws_strtoi function.

Change-Id: I4feacfa8e4739faf555c05e3c4823ad8487a994c
Reviewed-on: https://code.wireshark.org/review/18392
Reviewed-by: Anders Broman 


Actions performed:

from  6b25798   fc00: get rid of if(tree)
adds  2e962d3   dtls: use ws_strtoi function.


Summary of changes:
 epan/dissectors/packet-dtls.c |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6b25798: fc00: get rid of if(tree)

2016-10-23 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b2579801445e25e49b85c4f71283e07858ba6b7
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

6b25798 by Martin Kaiser (wiresh...@kaiser.cx):

fc00: get rid of if(tree)

Make sure that the newly added expert info will show up in the expert
info window. Expert infos should never be under if (tree).

Change-Id: I55daa693d4dc910eab38028340a934062d351e98
Reviewed-on: https://code.wireshark.org/review/18393
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  1c7b431   LSD: avoid dereferencing a null pointer
adds  6b25798   fc00: get rid of if(tree)


Summary of changes:
 epan/dissectors/packet-fc00.c |  115 -
 1 file changed, 57 insertions(+), 58 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe