[Wireshark-commits] master 978cbf0: gsm_abis_pgsl: make Incremental Redundancy (IR) IEs conditional

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=978cbf06eddad1d3b9b57779a035c4acbeab87c1
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

978cbf0 by Harald Welte (lafo...@gnumonks.org):

gsm_abis_pgsl: make Incremental Redundancy (IR) IEs conditional

There are some IEs in the Downlink Data Indication which are
conditional.  As the condition cannot be found in the packets
themselves (to my knowledge), let's introduce a preference.

Change-Id: I408c73e5f48018d3ea4ebcacb7bd94358a9eaac5
Reviewed-on: https://code.wireshark.org/review/18482
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  565f1b1   Fix compile errors in GTK build
adds  978cbf0   gsm_abis_pgsl: make Incremental Redundancy (IR) IEs 
conditional


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |   23 +--
 1 file changed, 17 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 565f1b1: Fix compile errors in GTK build

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=565f1b13d76bfad50469b0b9e03b2659a6f2453b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

565f1b1 by Michael Mann (mman...@netscape.net):

Fix compile errors in GTK build

Change-Id: Ib28c63e0ead6950b3b11b7c87adc543f80c070ed
Reviewed-on: https://code.wireshark.org/review/18498
Reviewed-by: Michael Mann 


Actions performed:

from  5c82f91   bthci_cmd: fix spelling typo found by lintian
adds  565f1b1   Fix compile errors in GTK build


Summary of changes:
 ui/gtk/sctp_graph_dlg.c |2 +-
 ui/gtk/tcp_graph.c  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 d7ad4f9: Update libssh to 0.7.3

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7ad4f9453b670fdf3695efc002f90655d7d31e1
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

d7ad4f9 by Pascal Quantin (pascal.quan...@gmail.com):

Update libssh to 0.7.3

Change-Id: Ib5f93d0e3be2866e665713af3a1fa95a4f3253b7
(cherry picked from commit c7b3cf725845fe4c32bf34a65a95d529c5e9f50f)
Reviewed-on: https://code.wireshark.org/review/18494
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Reviewed-by: Michael Mann 


Actions performed:

from  8391aa8   Qt: Set uniformRowHeights for some of our trees.
adds  d7ad4f9   Update libssh to 0.7.3


Summary of changes:
 tools/win-setup.ps1 |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5c82f91: bthci_cmd: fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c82f910a6f421b6ee2dac2fc4c6a51c9ed505b8
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

5c82f91 by Alexis La Goutte (alexis.lagou...@gmail.com):

bthci_cmd: fix spelling typo found by lintian

Change-Id: I6ebc828eb7eafd3ca41275a9b0b9b45a0994a7d3
Reviewed-on: https://code.wireshark.org/review/18493
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  4e31c0c   Qt: WLAN Statistics performance improvements.
adds  5c82f91   bthci_cmd: fix spelling typo found by lintian


Summary of changes:
 epan/dissectors/packet-bthci_cmd.c |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4e31c0c: Qt: WLAN Statistics performance improvements.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e31c0c61b7fc38022d82a189953e8b0e4cb8978
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

4e31c0c by Gerald Combs (ger...@wireshark.org):

Qt: WLAN Statistics performance improvements.

In the WLAN statistics dialog, add our stations to the tree in the
background. This returns control to the user immediately after tapping.

Add notes about further performance improvements.

Change-Id: Ie7ff818b8d835ecb38f5ff702a0d0e8f2635abb2
Reviewed-on: https://code.wireshark.org/review/18495
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 


Actions performed:

from  7a09f52   packet-mbtcp: Allow decode as Modbus RTU over USB
adds  4e31c0c   Qt: WLAN Statistics performance improvements.


Summary of changes:
 ui/qt/wlan_statistics_dialog.cpp |   30 +++---
 ui/qt/wlan_statistics_dialog.h   |6 ++
 2 files changed, 33 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7a09f52: packet-mbtcp: Allow decode as Modbus RTU over USB

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a09f52c8edba3ab5fe4e9e20e9f737c7ea199ad
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

7a09f52 by Dave Pifke (d...@pifke.org):

packet-mbtcp: Allow decode as Modbus RTU over USB

Modbus RTU is typically seen over serial links, which can be captured
by sniffing USB traffic.  This patch enables decoding USB payloads as
Modbus RTU.

Bug: 13055
Change-Id: I70d970760aa1b37b0f56dda9d3384e72d27c9d0a
Reviewed-on: https://code.wireshark.org/review/18468
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  c52d920   Driver.pm (pidl): fix spelling typo found by lintian
adds  7a09f52   packet-mbtcp: Allow decode as Modbus RTU over USB


Summary of changes:
 epan/dissectors/packet-mbtcp.c |3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c52d920: Driver.pm (pidl): fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c52d9209cc524420f6900c8fdc990047cdddaca9
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

c52d920 by Alexis La Goutte (alexis.lagou...@gmail.com):

Driver.pm (pidl): fix spelling typo found by lintian

Change-Id: Idb288beb54c91e100c164e0026b39bfe27daec39
Reviewed-on: https://code.wireshark.org/review/18485
Reviewed-by: Michael Mann 


Actions performed:

from  1a7e21d   wccp: fix spelling typo found by lintian
adds  c52d920   Driver.pm (pidl): fix spelling typo found by lintian


Summary of changes:
 tools/pidl/lib/Parse/Yapp/Driver.pm |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1a7e21d: wccp: fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a7e21d2fd5b51d93ed3f2d31d0344c774ee5e09
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

1a7e21d by Alexis La Goutte (alexis.lagou...@gmail.com):

wccp: fix spelling typo found by lintian

Change-Id: I9ce35505d4b35e2c2bcacd13eca075005e05c307
Reviewed-on: https://code.wireshark.org/review/18488
Reviewed-by: Michael Mann 


Actions performed:

from  8d0af2f   Gtk: remove atoi calls and use ws_strtoi functions.
adds  1a7e21d   wccp: fix spelling typo found by lintian


Summary of changes:
 epan/dissectors/packet-wccp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8d0af2f: Gtk: remove atoi calls and use ws_strtoi functions.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d0af2f57826b309404c5b7f3b02aaf5b3171f27
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

8d0af2f by Dario Lombardo (lom...@gmail.com):

Gtk: remove atoi calls and use ws_strtoi functions.

Change-Id: Ie38bdd27d9e3810e3a64b985dfd5621a3aa6d073
Reviewed-on: https://code.wireshark.org/review/18445
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  dab4ea5   Update libssh to 0.7.3
adds  8d0af2f   Gtk: remove atoi calls and use ws_strtoi functions.


Summary of changes:
 ui/gtk/capture_dlg.c|   26 +++---
 ui/gtk/expert_comp_table.c  |   12 
 ui/gtk/main_80211_toolbar.c |4 +++-
 ui/gtk/rlc_lte_graph.c  |7 +--
 ui/gtk/rlc_lte_stat_dlg.c   |8 +---
 ui/gtk/sctp_graph_dlg.c |7 ---
 ui/gtk/tcp_graph.c  |6 --
 7 files changed, 52 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master dab4ea5: Update libssh to 0.7.3

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dab4ea552dbeccbb403b6aff701a9de3bc25a64a
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

dab4ea5 by Pascal Quantin (pascal.quan...@gmail.com):

Update libssh to 0.7.3

Change-Id: Ib5f93d0e3be2866e665713af3a1fa95a4f3253b7
Reviewed-on: https://code.wireshark.org/review/18481
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  3a05d00   synphasor: fix spelling typo found by lintian
adds  dab4ea5   Update libssh to 0.7.3


Summary of changes:
 tools/win-setup.ps1 |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ddaf566: spice: fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ddaf566f212979d4cb203a35398cfbcfe82b7818
Submitter: Jeff Morriss (jeff.morriss...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ddaf566 by Alexis La Goutte (alexis.lagou...@gmail.com):

spice: fix spelling typo found by lintian

Change-Id: Ie558ae44a8978cc61679ffeb4b2c1c800b2d6371
Reviewed-on: https://code.wireshark.org/review/18491
Reviewed-by: Jeff Morriss 


Actions performed:

from  752c2dd   u3v: fix spelling typo found by lintian
adds  ddaf566   spice: fix spelling typo found by lintian


Summary of changes:
 epan/dissectors/packet-spice.c |   18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a92058e: ncp2222.py: fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a92058ec09e09e24cff542c58ec6dad0287cb8ea
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

a92058e by Alexis La Goutte (alexis.lagou...@gmail.com):

ncp.py: fix spelling typo found by lintian

Change-Id: If077e05568efc4dc8981da9558047fe147b5d139
Reviewed-on: https://code.wireshark.org/review/18486
Reviewed-by: Peter Wu 


Actions performed:

from  4d368de   wslua_pref(.c): fix spelling typo found by lintian
adds  a92058e   ncp.py: fix spelling typo found by lintian


Summary of changes:
 tools/ncp.py |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3a05d00: synphasor: fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a05d00c800f9e0b57dc5bc2cce4ba1702faa633
Submitter: Jeff Morriss (jeff.morriss...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3a05d00 by Alexis La Goutte (alexis.lagou...@gmail.com):

synphasor: fix spelling typo found by lintian

Change-Id: I9ab5b6c20b544ec09f808cee62a3aa611baf3dae
Reviewed-on: https://code.wireshark.org/review/18492
Reviewed-by: Jeff Morriss 


Actions performed:

from  ddaf566   spice: fix spelling typo found by lintian
adds  3a05d00   synphasor: fix spelling typo found by lintian


Summary of changes:
 epan/dissectors/packet-synphasor.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 752c2dd: u3v: fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=752c2dde946ac98a199116424cedc8be748cb279
Submitter: Jeff Morriss (jeff.morriss...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

752c2dd by Alexis La Goutte (alexis.lagou...@gmail.com):

u3v: fix spelling typo found by lintian

Change-Id: I03f79e4502694042a78762f4711712a31f7ca028
Reviewed-on: https://code.wireshark.org/review/18490
Reviewed-by: Jeff Morriss 


Actions performed:

from  133031d   uds: fix spelling typo found by lintian
adds  752c2dd   u3v: fix spelling typo found by lintian


Summary of changes:
 epan/dissectors/packet-u3v.c |   32 
 1 file changed, 16 insertions(+), 16 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 133031d: uds: fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=133031db1689e9599022644739f94fc54fda3fc6
Submitter: Jeff Morriss (jeff.morriss...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

133031d by Alexis La Goutte (alexis.lagou...@gmail.com):

uds: fix spelling typo found by lintian

Change-Id: I78efa2fd9d3a4d1261f0276af85329ee05dbb5e3
Reviewed-on: https://code.wireshark.org/review/18489
Reviewed-by: Jeff Morriss 


Actions performed:

from  39bfca1   mpeg-audio: fix spelling typo found by lintian
adds  133031d   uds: fix spelling typo found by lintian


Summary of changes:
 epan/dissectors/packet-uds.c |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 39bfca1: mpeg-audio: fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39bfca1a7e78786f49d82f42f45a005896991a76
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

39bfca1 by Alexis La Goutte (alexis.lagou...@gmail.com):

mpeg-audio: fix spelling typo found by lintian

Change-Id: Ie4f5db3f3f07388d3a6194839e33c939dbc0e92d
Reviewed-on: https://code.wireshark.org/review/18487
Reviewed-by: Peter Wu 


Actions performed:

from  a92058e   ncp.py: fix spelling typo found by lintian
adds  39bfca1   mpeg-audio: fix spelling typo found by lintian


Summary of changes:
 epan/dissectors/asn1/mpeg-audio/mpeg-audio.asn |2 +-
 epan/dissectors/packet-mpeg-audio.c|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4d368de: wslua_pref(.c): fix spelling typo found by lintian

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d368de26ea6d43b78aa866cec00f5c197765663
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

4d368de by Alexis La Goutte (alexis.lagou...@gmail.com):

wslua_pref(.c): fix spelling typo found by lintian

Change-Id: Ie371e144a9b385d893ead67c03688841039b8319
Reviewed-on: https://code.wireshark.org/review/18484
Reviewed-by: Peter Wu 


Actions performed:

from  ecfee35   [DTAP] Add an expert info when DTAP_TIE_PRES_MASK is there 
and the length is less than 3.
adds  4d368de   wslua_pref(.c): fix spelling typo found by lintian


Summary of changes:
 epan/wslua/wslua_pref.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ecfee35: [DTAP] Add an expert info when DTAP_TIE_PRES_MASK is there and the length is less than 3.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ecfee35ec80c39eb384e534ea3f720de96f505f8
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ecfee35 by Anders (anders.bro...@ericsson.com):

[DTAP] Add an expert info when DTAP_TIE_PRES_MASK is there and the length
is less than 3.

Bug 13052
Change-Id: I62aabf93059ec763eff629125084a45aba84cb3a
Reviewed-on: https://code.wireshark.org/review/18474
Reviewed-by: Alexis La Goutte 


Actions performed:

from  5afe1a7   Qt: Set uniformRowHeights for some of our trees.
adds  ecfee35   [DTAP] Add an expert info when DTAP_TIE_PRES_MASK is there 
and the length is less than 3.


Summary of changes:
 epan/dissectors/packet-gsm_a_dtap.c |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5afe1a7: Qt: Set uniformRowHeights for some of our trees.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5afe1a70df102e3610388a66489014302077ebd5
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

5afe1a7 by Gerald Combs (ger...@wireshark.org):

Qt: Set uniformRowHeights for some of our trees.

Set the uniformRowHeights property for a few of our QTreeWidgets. This
can improve performance, particularly when we have many items.

Change-Id: I2685646a533aa7accfb3a8578b5198894d873fb2
Reviewed-on: https://code.wireshark.org/review/18476
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 


Actions performed:

from  a7bc4b8   Properly align the text in an error message.
adds  5afe1a7   Qt: Set uniformRowHeights for some of our trees.


Summary of changes:
 ui/qt/dissector_tables_dialog.ui   |3 +++
 ui/qt/protocol_hierarchy_dialog.ui |3 +++
 ui/qt/rtp_analysis_dialog.ui   |6 ++
 ui/qt/rtp_player_dialog.ui |3 +++
 ui/qt/tap_parameter_dialog.ui  |3 +++
 ui/qt/voip_calls_dialog.ui |3 +++
 6 files changed, 21 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 8391aa8: Qt: Set uniformRowHeights for some of our trees.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8391aa8ff82431c8fd206b25b9947ea0e4ab559c
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8391aa8 by Gerald Combs (ger...@wireshark.org):

Qt: Set uniformRowHeights for some of our trees.

Set the uniformRowHeights property for a few of our QTreeWidgets. This
can improve performance, particularly when we have many items.

Change-Id: I2685646a533aa7accfb3a8578b5198894d873fb2
Reviewed-on: https://code.wireshark.org/review/18479
Reviewed-by: Gerald Combs 


Actions performed:

from  5766d1e   Properly align the text in an error message.
adds  8391aa8   Qt: Set uniformRowHeights for some of our trees.


Summary of changes:
 ui/qt/dissector_tables_dialog.ui   |3 +++
 ui/qt/protocol_hierarchy_dialog.ui |3 +++
 ui/qt/rtp_analysis_dialog.ui   |6 ++
 ui/qt/rtp_player_dialog.ui |3 +++
 ui/qt/tap_parameter_dialog.ui  |3 +++
 ui/qt/voip_calls_dialog.ui |3 +++
 6 files changed, 21 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win64-libs rev 457: /tags/2016-10-26/

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win64-libs=457

User: pascal
Date: 2016/10/26 06:56 PM

Log:
 Update libssh to 0.7.3

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win64-libs rev 456: / /trunk/packages/: libssh-0.7.2-win64ws.zip libssh-0.7.3-win64ws.zip /trunk/: README.txt

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win64-libs=456

User: pascal
Date: 2016/10/26 06:54 PM

Log:
 Update libssh to 0.7.3

Directory: /trunk/packages/
  ChangesPathAction
  +0 -0  libssh-0.7.2-win64ws.zipRemoved
  +0 -0  libssh-0.7.3-win64ws.zipAdded

Directory: /trunk/
  ChangesPath  Action
  +2 -2  README.txtModified

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win32-libs rev 504: /tags/2016-10-26/

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win32-libs=504

User: pascal
Date: 2016/10/26 06:50 PM

Log:
 Update libssh to 0.7.3

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win32-libs rev 503: / /trunk/packages/: libssh-0.7.2-win32ws.zip libssh-0.7.3-win32ws.zip /trunk/: README.txt

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win32-libs=503

User: pascal
Date: 2016/10/26 06:47 PM

Log:
 Update libssh to 0.7.3

Directory: /trunk/packages/
  ChangesPathAction
  +0 -0  libssh-0.7.2-win32ws.zipRemoved
  +0 -0  libssh-0.7.3-win32ws.zipAdded

Directory: /trunk/
  ChangesPath  Action
  +1 -1  README.txtModified

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 5766d1e: Properly align the text in an error message.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5766d1e259df1ceedb92c598db28263c61475f99
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

5766d1e by Guy Harris (g...@alum.mit.edu):

Properly align the text in an error message.

Change-Id: Id8081c26bbe1349f9a7c89daf1188ba9de7da210
Reviewed-on: https://code.wireshark.org/review/18477
Reviewed-by: Guy Harris 
(cherry picked from commit a7bc4b81463d73e181b7b88b2940e4aef31cf247)
Reviewed-on: https://code.wireshark.org/review/18478


Actions performed:

from  2e51bc2   SCTP: find right assoc id
adds  5766d1e   Properly align the text in an error message.


Summary of changes:
 tshark.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a7bc4b8: Properly align the text in an error message.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7bc4b81463d73e181b7b88b2940e4aef31cf247
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

a7bc4b8 by Guy Harris (g...@alum.mit.edu):

Properly align the text in an error message.

Change-Id: Id8081c26bbe1349f9a7c89daf1188ba9de7da210
Reviewed-on: https://code.wireshark.org/review/18477
Reviewed-by: Guy Harris 


Actions performed:

from  5134cf1   quakeworld: fix a complain from gcc 4.4.7
adds  a7bc4b8   Properly align the text in an error message.


Summary of changes:
 tshark.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 61e3569: L2TP: Dissect three formerly unknown bytes in Ericsson Transport Cfg

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61e3569c4d8b02010cac4ef1fad29e8ef59299f0
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

61e3569 by Harald Welte (lafo...@gnumonks.org):

L2TP: Dissect three formerly unknown bytes in Ericsson Transport Cfg

The meaning of the last three bytes of a Transport configuration has
been uncovered: They control the batching/bundling of signalling
messages: All signalling messages are delayed + bundled until either
the timeout expires, or the message exceeds the limit.

Change-Id: I794658e99e3c66145627652de4269fb08bc74ca3
Reviewed-on: https://code.wireshark.org/review/18471
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  88868c9   qt: fix build without pcap_create
adds  61e3569   L2TP: Dissect three formerly unknown bytes in Ericsson 
Transport Cfg


Summary of changes:
 epan/dissectors/packet-l2tp.c |   15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 41c4cd8: packet-infiniband: Add support to sub dissect CM messages private data

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41c4cd81a5fdba2b88817c1fa60fc64f6dc1c272
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

41c4cd8 by Parav Pandit (paravpan...@yahoo.com):

packet-infiniband: Add support to sub dissect CM messages private data

1. This patch enables sub dissectors to parse RTU, REJ,
DREQ, DRSP CM messages private data.
(Sub dissection for CM REQ and RSP private data was
already present).

2. For dissecting non CM data specific packets, connection
context needs to be active until connection is closed. So instead of
removing hash table entry during CM response message,
it keeps it around until DRSP (when connection is closed).

3. This patch moves CM messsage dissection to their individual
functions for cleanup, so that main parser remains readable code.

4. created smaller functions for reusing in different message parsing
functions.

REQ, RSP, DREQ, DRSP message are tested.
REJ is untested.

Change-Id: I3b4695402d1dbe93fc003d4b43424ae0aa96ba43
Tested-by: paravpan...@yahoo.com
Reviewed-on: https://code.wireshark.org/review/18469
Petri-Dish: Roland Knall 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  d0bb041   Add support to dissect iperf2 packets
adds  41c4cd8   packet-infiniband: Add support to sub dissect CM messages 
private data


Summary of changes:
 epan/dissectors/packet-infiniband.c |  275 ---
 1 file changed, 188 insertions(+), 87 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d0bb041: Add support to dissect iperf2 packets

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d0bb041e5624c4a2369ebb60188aa26f08a0cf5f
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d0bb041 by Anish Bhatt (an...@gatech.edu):

Add support to dissect iperf2 packets

Change-Id: Ieb36a77a98da1ce6e5de34010806cdc05f8e6533
Reviewed-on: https://code.wireshark.org/review/15637
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Reviewed-by: Anish Bhatt 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  ca2dc53   InterfaceList: Make storing preferences optional
adds  d0bb041   Add support to dissect iperf2 packets


Summary of changes:
 docbook/release-notes.asciidoc |2 +
 epan/dissectors/CMakeLists.txt |1 +
 epan/dissectors/Makefile.am|1 +
 epan/dissectors/packet-iperf.c |  202 
 4 files changed, 206 insertions(+)
 create mode 100644 epan/dissectors/packet-iperf.c
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ca2dc53: InterfaceList: Make storing preferences optional

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca2dc538ffbf6ecda2416bc53808fc97e7b8b3d4
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ca2dc53 by Roland Knall (rkn...@gmail.com):

InterfaceList: Make storing preferences optional

If multiple proxy models are used, not all should change
the preferences if types are being displayed or hidden. Only
the main list should have that option.

Change-Id: I8617e402b6608eda98d7ecc0167cd0ccc3c43eaa
Reviewed-on: https://code.wireshark.org/review/18470
Petri-Dish: Roland Knall 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Roland Knall 


Actions performed:

from  6eee29b   InterfaceTreeList: Enable all editable columns
adds  ca2dc53   InterfaceList: Make storing preferences optional


Summary of changes:
 ui/qt/interface_frame.cpp |2 +-
 ui/qt/interface_sort_filter_model.cpp |   43 +
 ui/qt/interface_sort_filter_model.h   |3 +++
 3 files changed, 32 insertions(+), 16 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12445

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 6eee29bf2a86eee890051b566db26628e2e52918
Blamelist: Roland Knall 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master dcb49539d: ICMPv6: Convert flag fields to use proto_tree_add_bitmask

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dcb49539dd6542528d36b239892d7086d5693f4e
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

dcb49539d by Michael Mann (mman...@netscape.net):

ICMPv6: Convert flag fields to use proto_tree_add_bitmask

Change-Id: Ib037b8ac6e16901408597696e1d4cd8cc95b2230
Reviewed-on: https://code.wireshark.org/review/18465
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  7719bd5   L2TP: Fix decoding of SC-TEI Map in Ericsson ALTCRQ
adds  dcb49539d ICMPv6: Convert flag fields to use proto_tree_add_bitmask


Summary of changes:
 epan/dissectors/packet-icmpv6.c |  590 +++
 1 file changed, 345 insertions(+), 245 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 2e51bc2: SCTP: find right assoc id

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e51bc237488d7f01fa28712cdabd5ef03b66cce
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2e51bc2 by ruengeler (ruenge...@wireshark.org):

SCTP: find right assoc id

Change-Id: I107b7f4c585ef5e080d6473a37b3db9a97f12365
Reviewed-on: https://code.wireshark.org/review/18325
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
(cherry picked from commit c63f89515985a8db0aa8a500b1832474619090aa)
Reviewed-on: https://code.wireshark.org/review/18467


Actions performed:

from  136ff7f   Qt: fix possible crash on sorting custom columns
adds  2e51bc2   SCTP: find right assoc id


Summary of changes:
 epan/dissectors/packet-sctp.c |   93 +
 ui/tap-sctp-analysis.c|   13 +++---
 ui/tap-sctp-analysis.h|2 +-
 3 files changed, 67 insertions(+), 41 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe