[Wireshark-commits] master e0a4f0c: SMB: Limit Export object files to 32 bits.

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0a4f0c79b68830547dab1baad7641a09b4d93f5
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e0a4f0c by Michael Mann (mman...@netscape.net):

SMB: Limit Export object files to 32 bits.

Most of the file offset fields are 32-bit, but the algorithms use gsize
variables, which can vary between 32 and 64 bit builds.  The 64-bit
builds are the ones with the problem with "garbage" data comes from
(effectively) invalid 32-bit offsets.

Bug: 11133
Change-Id: I20b8cafb75fc021594159ab092c18c24f3e257e3
Reviewed-on: https://code.wireshark.org/review/19073
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  26def3e   Honor protocols.display_hidden_proto_items preferences when 
outputting fields in TShark
adds  e0a4f0c   SMB: Limit Export object files to 32 bits.


Summary of changes:
 epan/dissectors/packet-smb.c |8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 26def3e: Honor protocols.display_hidden_proto_items preferences when outputting fields in TShark

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26def3ef72b3dc1f936322fb1e96b7d81a19390b
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

26def3e by Michael Mann (mman...@netscape.net):

Honor protocols.display_hidden_proto_items preferences when outputting 
fields in TShark

Bug: 13192
Change-Id: Ibb2b3913716d31a3d5f600e1b6400fdf14a69ca4
Reviewed-on: https://code.wireshark.org/review/19075
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  037c64a   Clean up initialization code for programs.
adds  26def3e   Honor protocols.display_hidden_proto_items preferences when 
outputting fields in TShark


Summary of changes:
 epan/print.c |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 037c64a: Clean up initialization code for programs.

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=037c64aa34d4196da5a39dfb59af16abceb1247b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

037c64a by Guy Harris (g...@alum.mit.edu):

Clean up initialization code for programs.

Make the init_progfile_dir() call unconditionally, even if plugins
aren't supported, as that doesn't necessarily mean nobody uses the
directory containing the executable.

Report the error the same way in all programs, and free the error string
after we're finished with it.

Make the error - and the comment before the code - reflect what
init_progfile_dir() is actually doing (the goal is to get the full
pathname of the directory *containing* the executable; that's generally
done by getting the pathname of the executable and stripping off the
name of the executable, but that's won't necessarily always be the
case).  Also note for TShark that we won't be able to capture traffic,
just as we do for Wireshark (if we don't have the pathname of the
program file, we don't have a pathname to use to find dumpcap).

Have the plugin scanner just fail silently if we weren't able to get the
plugin directory path, so we don't have to worry about calling it if
init_progfile_dir() fails.

Clean up white space while we're at it.

Change-Id: I8e580c719aab6fbf74a764bf6629962394fff7c8
Reviewed-on: https://code.wireshark.org/review/19076
Reviewed-by: Guy Harris 


Actions performed:

from  faf7060   Update a comment to reflect current reality.
adds  037c64a   Clean up initialization code for programs.


Summary of changes:
 capinfos.c   |   39 ++-
 captype.c|   40 ++--
 dftest.c |6 --
 editcap.c|   40 ++--
 mergecap.c   |   41 ++---
 randpkt.c|   42 +++---
 rawshark.c   |3 ++-
 reordercap.c |   50 +++---
 tfshark.c|7 +--
 tshark.c |9 +++--
 ui/gtk/main.c|5 +++--
 wireshark-qt.cpp |3 ++-
 wsutil/plugins.c |9 +++--
 13 files changed, 168 insertions(+), 126 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master faf7060: Update a comment to reflect current reality.

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=faf70602a8e96433ae888278cccaac057091fbca
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

faf7060 by Guy Harris (g...@alum.mit.edu):

Update a comment to reflect current reality.

Change-Id: Ied84e0363161ebc42c8cf24e7ade4b1b4e536448
Reviewed-on: https://code.wireshark.org/review/19074
Reviewed-by: Guy Harris 


Actions performed:

from  83a1ab2   cmake: Fix building with plugins disabled
adds  faf7060   Update a comment to reflect current reality.


Summary of changes:
 wsutil/filesystem.c |   26 +++---
 1 file changed, 15 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 83a1ab2: cmake: Fix building with plugins disabled

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83a1ab23abdb22ae7b84cff99009988f97fb3653
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

83a1ab2 by Peter Wu (pe...@lekensteyn.nl):

cmake: Fix building with plugins disabled

When Lua is enabled, scripts can still be loaded from the plugin dir
(filesystem.c uses PLUGIN_INSTALL_DIR), so be sure to set it or the
cmake build fails.

Change-Id: I87d2d705434052220f9619438c90905c24b2a3a6
Reviewed-on: https://code.wireshark.org/review/18976
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  fca6bf6   Reflect API changes.
adds  83a1ab2   cmake: Fix building with plugins disabled


Summary of changes:
 CMakeLists.txt |   14 --
 1 file changed, 8 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2346

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
ab07f8e0f89eb1bb2c2c61c71e44e3fd0e31cc52
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master fca6bf6: Reflect API changes.

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fca6bf6a99b08be574ab8679104d19623b4881fc
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

fca6bf6 by Guy Harris (g...@alum.mit.edu):

Reflect API changes.

Change-Id: I6a8d50cb697bcd4a5232dc01107c7d9618258d87
Reviewed-on: https://code.wireshark.org/review/19071
Reviewed-by: Guy Harris 


Actions performed:

from  bded2b6   Rawshark uses libwiretap, so it has to call wtap_init().
adds  fca6bf6   Reflect API changes.


Summary of changes:
 debian/libwiretap0.symbols |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/873

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
ab07f8e0f89eb1bb2c2c61c71e44e3fd0e31cc52
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh shell_4

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master bded2b6: Rawshark uses libwiretap, so it has to call wtap_init().

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bded2b681485fe9a91041688bcb41d371c9099e8
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

bded2b6 by Guy Harris (g...@alum.mit.edu):

Rawshark uses libwiretap, so it has to call wtap_init().

Change-Id: I4b87227e4828ebad98b22e5e5d1f3896e636582a
Reviewed-on: https://code.wireshark.org/review/19070
Reviewed-by: Guy Harris 


Actions performed:

from  ab07f8e   Have a routine to do all the work of initializing 
libwiretap.
adds  bded2b6   Rawshark uses libwiretap, so it has to call wtap_init().


Summary of changes:
 rawshark.c |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master ab07f8e: Have a routine to do all the work of initializing libwiretap.

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ab07f8e0f89eb1bb2c2c61c71e44e3fd0e31cc52
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

ab07f8e by Guy Harris (g...@alum.mit.edu):

Have a routine to do all the work of initializing libwiretap.

Have programs that use libwiretap call that routine rather than
separately calling some or all of init_open_routines(),
wtap_register_plugin_types(), and wtap_opttypes_initialize().

Also don't have routines internal to libwiretap call those.  Yes, this
means doing some initialization work when it isn't necessary, but
scattering on-demand calls throughout the code is a great way to forget
to make those calls.

Change-Id: I5828e1c5591c9d94fbb3eb0a0e54591e8fc61710
Reviewed-on: https://code.wireshark.org/review/19069
Reviewed-by: Guy Harris 


Actions performed:

from  51d23c6   Show codec information in About dialog
adds  ab07f8e   Have a routine to do all the work of initializing 
libwiretap.


Summary of changes:
 capinfos.c  |6 ++
 captype.c   |6 ++
 editcap.c   |6 ++
 extcap/androiddump.c|3 +--
 mergecap.c  |6 ++
 randpkt.c   |6 ++
 randpkt_core/randpkt_core.c |2 +-
 reordercap.c|6 ++
 tfshark.c   |2 +-
 tshark.c|3 +--
 ui/gtk/main.c   |3 +--
 wireshark-qt.cpp|3 +--
 wiretap/file_access.c   |7 ---
 wiretap/wtap.c  |   21 +++--
 wiretap/wtap.h  |6 --
 15 files changed, 37 insertions(+), 49 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2344

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
dcc062eeddda1bd74c66e20b3968861c451a8d7c
Blamelist: Gerald Combs 

BUILD FAILED: failed compile_4 compile_6 sign WiX installer

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/8072

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
dcc062eeddda1bd74c66e20b3968861c451a8d7c
Blamelist: Gerald Combs 

BUILD FAILED: failed

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/871

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
dcc062eeddda1bd74c66e20b3968861c451a8d7c
Blamelist: Gerald Combs 

BUILD FAILED: failed check licenses

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1101

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
dcc062eeddda1bd74c66e20b3968861c451a8d7c
Blamelist: Gerald Combs 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/336

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
d8086cc38610b52281ddad74b9954f6ca509746c
Blamelist: Gerald Combs 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 51d23c6: Show codec information in About dialog

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51d23c6959edfbf45033ba26237820fa2914ff77
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

51d23c6 by Peter Wu (pe...@lekensteyn.nl):

Show codec information in About dialog

Show codec libraries in About dialog, this should give the user a clue
of what codecs are available.

SBC is already supported, Spandsp (for G.722/G.726) is work in progress.

Change-Id: Iebc4d9c9fae619a442e06c8afc780a420aa3971b
Reviewed-on: https://code.wireshark.org/review/18978
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Peter Wu 


Actions performed:

from  98efddc   codecs: allow it to be used without plugins
adds  51d23c6   Show codec information in About dialog


Summary of changes:
 codecs/codecs.c |   20 
 codecs/codecs.h |5 +
 debian/libwscodecs0.symbols |1 +
 ui/gtk/main.c   |2 ++
 wireshark-qt.cpp|2 ++
 5 files changed, 30 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 98efddc: codecs: allow it to be used without plugins

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=98efddc6c26313809b6f9326f09f76c390d21676
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

98efddc by Peter Wu (pe...@lekensteyn.nl):

codecs: allow it to be used without plugins

Not all codecs require the plugin infrastructure. For example, G.711U/A
is a built-in codec. Allow such functionality to be registered even if
plugin support is disabled.

Change-Id: I2505cc9955e7953268ec0739531278921f70a771
Reviewed-on: https://code.wireshark.org/review/18977
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  0544556   [Automatic update for 2016-12-04]
adds  98efddc   codecs: allow it to be used without plugins


Summary of changes:
 codecs/codecs.c  |5 -
 codecs/codecs.h  |6 +-
 ui/gtk/main.c|2 +-
 wireshark-qt.cpp |4 +---
 4 files changed, 11 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.0 dcc062e: [Automatic update for 2016-12-04]

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dcc062eeddda1bd74c66e20b3968861c451a8d7c
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

dcc062e by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-12-04]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I7505d39ec4e72cb96a89be89c006275715fbb7d2
Reviewed-on: https://code.wireshark.org/review/19068
Reviewed-by: Gerald Combs 


Actions performed:

from  94a9d4b   Qt: clear Export Objects list on retapping
adds  dcc062e   [Automatic update for 2016-12-04]


Summary of changes:
 epan/enterprise-numbers  |   62 +++-
 epan/sminmpec.c  |   15 
 manuf|   89 ++
 services |2 ++
 ui/qt/wireshark_de.ts|   12 +++
 ui/qt/wireshark_en.ts|   12 +++
 ui/qt/wireshark_fr.ts|   12 +++
 ui/qt/wireshark_it.ts|   12 +++
 ui/qt/wireshark_ja_JP.ts |   12 +++
 ui/qt/wireshark_pl.ts|   12 +++
 ui/qt/wireshark_zh_CN.ts |   12 +++
 11 files changed, 203 insertions(+), 49 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.2 d8086cc: [Automatic update for 2016-12-04]

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d8086cc38610b52281ddad74b9954f6ca509746c
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

d8086cc by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-12-04]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: Id29d87f78e1cac18817de2bbb8ce01a8b3c22bf8
Reviewed-on: https://code.wireshark.org/review/19067
Reviewed-by: Gerald Combs 


Actions performed:

from  563b1f3   Qt: clear Export Objects list on retapping
adds  d8086cc   [Automatic update for 2016-12-04]


Summary of changes:
 AUTHORS  |1 +
 epan/enterprise-numbers  |   62 +++-
 epan/sminmpec.c  |   15 +++
 manuf|  101 ++
 services |2 +
 ui/qt/wireshark_de.ts|   24 +--
 ui/qt/wireshark_en.ts|   24 +--
 ui/qt/wireshark_fr.ts|   24 +--
 ui/qt/wireshark_it.ts|   24 +--
 ui/qt/wireshark_ja_JP.ts |   24 +--
 ui/qt/wireshark_pl.ts|   24 +--
 ui/qt/wireshark_zh_CN.ts |   24 +--
 12 files changed, 257 insertions(+), 92 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 0544556: [Automatic update for 2016-12-04]

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=054455683b2e3697a0e41640a7137781cdc754c8
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

0544556 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-12-04]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: Icad3ffb6cbd570b0b8a2c650d3c11a3c9bed536f
Reviewed-on: https://code.wireshark.org/review/19066
Reviewed-by: Gerald Combs 


Actions performed:

from  5721a87   Qt: clear Export Objects list on retapping
adds  0544556   [Automatic update for 2016-12-04]


Summary of changes:
 AUTHORS  |1 +
 epan/enterprise-numbers  |   62 ++-
 epan/sminmpec.c  |   15 +
 manuf|  101 -
 services |2 +
 ui/qt/wireshark_de.ts| 1077 +++--
 ui/qt/wireshark_en.ts| 1085 ++
 ui/qt/wireshark_fr.ts| 1077 +++--
 ui/qt/wireshark_it.ts| 1077 +++--
 ui/qt/wireshark_ja_JP.ts | 1077 +++--
 ui/qt/wireshark_pl.ts| 1077 +++--
 ui/qt/wireshark_zh_CN.ts | 1077 +++--
 12 files changed, 3907 insertions(+), 3821 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/8068

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
94a9d4b4647c178551c61cafa7051986ad61ee5b
Blamelist: Peter Wu 

BUILD FAILED: failed compile_4 compile_6 sign WiX installer

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2341

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
94a9d4b4647c178551c61cafa7051986ad61ee5b
Blamelist: Peter Wu 

BUILD FAILED: failed compile_4 compile_6 sign WiX installer

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/867

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
94a9d4b4647c178551c61cafa7051986ad61ee5b
Blamelist: Peter Wu 

BUILD FAILED: failed check licenses

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

2016-12-04 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/358

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
563b1f39c4c0fa1cadf0aa7bbb32dbfd2059e8ee
Blamelist: Peter Wu 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.0 94a9d4b: Qt: clear Export Objects list on retapping

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94a9d4b4647c178551c61cafa7051986ad61ee5b
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master-2.0
Repository: wireshark

Commits:

94a9d4b by Peter Wu (pe...@lekensteyn.nl):

Qt: clear Export Objects list on retapping

The tap reset callback should not just invoke the reset callback of the
dissector, but also clear the previous list of objects in the dialog.
Otherwise duplicate entries will be created every time retapping occurs
(e.g. on changing the display filter).

Bug: 12230
Change-Id: I75f25db0652dcc9c0ac59ab0e536c06874aedb9c
Reviewed-on: https://code.wireshark.org/review/19055
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
(cherry picked from commit 5721a87330f8afe3fed12d4af250d7a3d219cbe2)
[ Peter: resolved conflict in context ]
Reviewed-on: https://code.wireshark.org/review/19065


Actions performed:

from  eee5f97   packet-rpcrdma: Fix protocol frame pre-detection
adds  94a9d4b   Qt: clear Export Objects list on retapping


Summary of changes:
 ui/qt/export_object_dialog.cpp |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.2 563b1f3: Qt: clear Export Objects list on retapping

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=563b1f39c4c0fa1cadf0aa7bbb32dbfd2059e8ee
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master-2.2
Repository: wireshark

Commits:

563b1f3 by Peter Wu (pe...@lekensteyn.nl):

Qt: clear Export Objects list on retapping

The tap reset callback should not just invoke the reset callback of the
dissector, but also clear the previous list of objects in the dialog.
Otherwise duplicate entries will be created every time retapping occurs
(e.g. on changing the display filter).

Bug: 12230
Change-Id: I75f25db0652dcc9c0ac59ab0e536c06874aedb9c
Reviewed-on: https://code.wireshark.org/review/19055
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
(cherry picked from commit 5721a87330f8afe3fed12d4af250d7a3d219cbe2)
[ Peter: resolved conflict in context ]
Reviewed-on: https://code.wireshark.org/review/19064


Actions performed:

from  a6f89d6   echo: decide on req/resp based on matched port
adds  563b1f3   Qt: clear Export Objects list on retapping


Summary of changes:
 ui/qt/export_object_dialog.cpp |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 5721a87: Qt: clear Export Objects list on retapping

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5721a87330f8afe3fed12d4af250d7a3d219cbe2
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

5721a87 by Peter Wu (pe...@lekensteyn.nl):

Qt: clear Export Objects list on retapping

The tap reset callback should not just invoke the reset callback of the
dissector, but also clear the previous list of objects in the dialog.
Otherwise duplicate entries will be created every time retapping occurs
(e.g. on changing the display filter).

Bug: 12230
Change-Id: I75f25db0652dcc9c0ac59ab0e536c06874aedb9c
Reviewed-on: https://code.wireshark.org/review/19055
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  40ebfb9   ssh: fix the heuristic for MAC size determination
adds  5721a87   Qt: clear Export Objects list on retapping


Summary of changes:
 ui/qt/export_object_dialog.cpp |3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 40ebfb9: ssh: fix the heuristic for MAC size determination

2016-12-04 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=40ebfb9a6f180b5b6deb0ed727e38c98e848b6cb
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

40ebfb9 by Роман Донченко (d...@corrigendum.ru):

ssh: fix the heuristic for MAC size determination

size_str points to a dash, so the result of calling ws_strtoi32 on it is
a negative number, which becomes a huge positive number, because size is
a guint32.

Parse the number after the dash instead, and use ws_strtou32.

Also, check that size is divisible by 8, since otherwise it's unlikely
to be a bit length.

Change-Id: I531f67d45e9e914574d36a9ffceed9239fd46d64
Reviewed-on: https://code.wireshark.org/review/19006
Reviewed-by: Graham Bloice 
Petri-Dish: Graham Bloice 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  dd98856   Have separate merge APIs for regular file/temporary 
file/standard output.
adds  40ebfb9   ssh: fix the heuristic for MAC size determination


Summary of changes:
 epan/dissectors/packet-ssh.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe