[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/379

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
f7ba00c06786f0a86f354da0d3e73982d2ea370c
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2451

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
232cb9a2dd87ea9cc9c88d4c32bfb7b452705130
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 f7ba00c: Add symlinks to Wireshark binaries in Resources/bin, and point there.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7ba00c06786f0a86f354da0d3e73982d2ea370c
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

f7ba00c by Guy Harris (g...@alum.mit.edu):

Add symlinks to Wireshark binaries in Resources/bin, and point there.

That way, $PATH points to .../Wireshark.app/Contents/Resources/bin, so
the man command will look in
.../Wireshark.app/Contents/Resources/share/man.

This also may obviate the need to install the wrapper scripts in
/usr/local/bin, although those scripts obviate the need to re-set PATH
after installing Wireshark.

Change-Id: I7202b5a0fe5d2b90c956dc0db2af073f6c08b00d
Reviewed-on: https://code.wireshark.org/review/19296
Reviewed-by: Guy Harris 
(cherry picked from commit d706f9c221e85992f7011baed53f5b31b7109493)
Reviewed-on: https://code.wireshark.org/review/19299


Actions performed:

from  ad5952a   Just use strncmp() to check the prefix of the file's first 
line.
adds  f7ba00c   Add symlinks to Wireshark binaries in Resources/bin, and 
point there.


Summary of changes:
 packaging/macosx/Scripts/wireshark-postinstall.sh |2 +-
 packaging/macosx/osx-app.sh   |   49 +
 packaging/macosx/utility-launcher/wireshark   |   12 +
 3 files changed, 33 insertions(+), 30 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 232cb9a: Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=232cb9a2dd87ea9cc9c88d4c32bfb7b452705130
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

232cb9a by Michael Mann (mman...@netscape.net):

Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.

Many proto_item_append_text calls were just adding a unit string to a field.
There's a better way to do that now.

Change-Id: Id18d5ac1ea4d8ecdc4cbe7ebaec07fbd2eab6e78
Reviewed-on: https://code.wireshark.org/review/19289
Petri-Dish: Michael Mann 
Reviewed-by: Michael Mann 


Actions performed:

from  8efb7fe   Adjust proto_tree_add_xxx_format_value calls to use unit 
string
adds  232cb9a   Remove proto_item_append_text calls in favor of 
BASE_UNIT_STRING.


Summary of changes:
 debian/libwireshark0.symbols  |8 +++
 epan/dissectors/packet-asap.c |6 +-
 epan/dissectors/packet-btavdtp.c  |   18 ++---
 epan/dissectors/packet-bthci_cmd.c|6 +-
 epan/dissectors/packet-bthci_evt.c|   16 ++---
 epan/dissectors/packet-bthfp.c|8 +--
 epan/dissectors/packet-bthsp.c|8 +--
 epan/dissectors/packet-btl2cap.c  |5 +-
 epan/dissectors/packet-btle.c |   10 ++-
 epan/dissectors/packet-btmcap.c   |   30 -
 epan/dissectors/packet-enrp.c |6 +-
 epan/dissectors/packet-gsm_a_common.c |   22 +++---
 epan/dissectors/packet-gsm_a_gm.c |   17 +++--
 epan/dissectors/packet-gtp.c  |   43 +---
 epan/dissectors/packet-gvcp.c |6 +-
 epan/dissectors/packet-ieee1722.c |   10 ++-
 epan/dissectors/packet-ieee802154.c   |5 +-
 epan/dissectors/packet-ipsec.c|7 +-
 epan/dissectors/packet-ipv6.c |   15 ++---
 epan/dissectors/packet-ismacryp.c |5 +-
 epan/dissectors/packet-knxnetip.c |   77 +++--
 epan/dissectors/packet-lldp.c |   53 +++
 epan/dissectors/packet-mbim.c |  119 -
 epan/dissectors/packet-oampdu.c   |   20 +++---
 epan/dissectors/packet-ppi-vector.c   |   89 +++-
 epan/dissectors/packet-rftap.c|   36 --
 epan/dissectors/packet-sbc.c  |   24 +++
 epan/dissectors/packet-simulcrypt.c   |   68 +++
 epan/dissectors/packet-spice.c|   11 ++-
 epan/dissectors/packet-sync.c |5 +-
 epan/dissectors/packet-usb-ccid.c |   10 ++-
 epan/dissectors/packet-usb-com.c  |   14 ++--
 epan/dissectors/packet-xip-serval.c   |8 +--
 epan/unit_strings.c   |8 +++
 epan/unit_strings.h   |8 +++
 plugins/wimax/msg_dcd.c   |   73 +---
 plugins/wimax/msg_rng_rsp.c   |   10 ++-
 plugins/wimax/msg_ucd.c   |   79 +-
 plugins/wimax/wimax_utils.c   |   57 
 plugins/wimax/wimax_utils.h   |   12 
 40 files changed, 418 insertions(+), 614 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8efb7fe: Adjust proto_tree_add_xxx_format_value calls to use unit string

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8efb7fece1ffefd26dacd79f5ec8722c4e01e827
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

8efb7fe by Michael Mann (mman...@netscape.net):

Adjust proto_tree_add_xxx_format_value calls to use unit string

proto_tree_add_uint_format_value had the most use of unit strings, this
patch handles all of the other proto_tree_add_xxx_format_value calls that
could be better served using BASE_UNIT_STRING with a "unit string" in hf_ 
field.

Added more "common" unit string values to unit_strings.[ch]

Change-Id: I0fb680be781e10037eb7bd40dd21a9ee20c1fb1c
Reviewed-on: https://code.wireshark.org/review/19288
Reviewed-by: Michael Mann 


Actions performed:

from  d706f9c   Add symlinks to Wireshark binaries in Resources/bin, and 
point there.
adds  8efb7fe   Adjust proto_tree_add_xxx_format_value calls to use unit 
string


Summary of changes:
 debian/libwireshark0.symbols|1 +
 epan/dissectors/packet-ieee80211-radio.c|   14 +++--
 epan/dissectors/packet-ieee80211-radiotap.c |   18 +---
 epan/dissectors/packet-ixveriwave.c |   42 ---
 epan/dissectors/packet-osc.c|   14 -
 epan/dissectors/packet-tcp.c|7 +++--
 epan/dissectors/packet-windows-common.c |4 +--
 epan/unit_strings.c |1 +
 epan/unit_strings.h |1 +
 9 files changed, 45 insertions(+), 57 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d706f9c: Add symlinks to Wireshark binaries in Resources/bin, and point there.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d706f9c221e85992f7011baed53f5b31b7109493
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

d706f9c by Guy Harris (g...@alum.mit.edu):

Add symlinks to Wireshark binaries in Resources/bin, and point there.

That way, $PATH points to .../Wireshark.app/Contents/Resources/bin, so
the man command will look in
.../Wireshark.app/Contents/Resources/share/man.

This also may obviate the need to install the wrapper scripts in
/usr/local/bin, although those scripts obviate the need to re-set PATH
after installing Wireshark.

Change-Id: I7202b5a0fe5d2b90c956dc0db2af073f6c08b00d
Reviewed-on: https://code.wireshark.org/review/19296
Reviewed-by: Guy Harris 


Actions performed:

from  8234de5   Fix release-notes.html generation
adds  d706f9c   Add symlinks to Wireshark binaries in Resources/bin, and 
point there.


Summary of changes:
 packaging/macosx/Scripts/wireshark-postinstall.sh |2 +-
 packaging/macosx/osx-app.sh   |   49 +
 packaging/macosx/utility-launcher/wireshark   |   12 +
 3 files changed, 33 insertions(+), 30 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8234de5: Fix release-notes.html generation

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8234de535022a699f6c2ac5f870cad6cd7439060
Submitter: Graham Bloice (graham.blo...@trihedral.com)
Changed: branch: master
Repository: wireshark

Commits:

8234de5 by Graham Bloice (graham.blo...@trihedral.com):

Fix release-notes.html generation

The ASCIIDOC_CONF_FILES setting for asciidoc was only generated
if any of the guides were being built.

Clean up a dup setting and some and blank lines in FindASCIIDOC

Change-Id: Ie8ab97db09e18cdb8d7e2a7bd4dcf8c288dd036f
Reviewed-on: https://code.wireshark.org/review/19291
Petri-Dish: Graham Bloice 
Reviewed-by: Gerald Combs 
Reviewed-by: Graham Bloice 


Actions performed:

from  2c20ffa   Update tools/commit-msg.
adds  8234de5   Fix release-notes.html generation


Summary of changes:
 cmake/modules/FindASCIIDOC.cmake |4 
 docbook/CMakeLists.txt   |   12 ++--
 2 files changed, 6 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2c20ffa: Update tools/commit-msg.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c20ffa871d39457ef3e10bef3e380e1c86e9661
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

2c20ffa by Gerald Combs (ger...@wireshark.org):

Update tools/commit-msg.

Update tools/commit-msg to version 2.12.7 by running

curl -Lo tools/commit-msg 
https://code.wireshark.org/review/tools/hooks/commit-msg

Change-Id: Ie70a8e869968b5237c9e21c0624f1f8af696d83b
Reviewed-on: https://code.wireshark.org/review/19290
Reviewed-by: Gerald Combs 


Actions performed:

from  08a6925   UDP: Add missing space to string
adds  2c20ffa   Update tools/commit-msg.


Summary of changes:
 tools/commit-msg |   20 +++-
 1 file changed, 15 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2445

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
08a6925ced4fbf97ab679dcd4795d95fc78c19b3
Blamelist: João Valverde 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 08a6925: UDP: Add missing space to string

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08a6925ced4fbf97ab679dcd4795d95fc78c19b3
Submitter: João Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

08a6925 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

UDP: Add missing space to string

Change-Id: I0b5a60d426b2d06441323d74aa973e1b700d4f03
Reviewed-on: https://code.wireshark.org/review/19286
Reviewed-by: João Valverde 


Actions performed:

from  0d3fd95   Update the release notes.
adds  08a6925   UDP: Add missing space to string


Summary of changes:
 epan/dissectors/packet-udp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2443

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
0d3fd95733dcc75c8967892e85281436c23748a6
Blamelist: Gerald Combs 

BUILD FAILED: failed copy-build

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/8189

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
0d3fd95733dcc75c8967892e85281436c23748a6
Blamelist: Gerald Combs 

BUILD FAILED: failed copy-build

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/984

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
0d3fd95733dcc75c8967892e85281436c23748a6
Blamelist: Gerald Combs 

BUILD FAILED: failed copy-build

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12811

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
0d3fd95733dcc75c8967892e85281436c23748a6
Blamelist: Gerald Combs 

BUILD FAILED: failed copy-build

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0d3fd95: Update the release notes.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0d3fd95733dcc75c8967892e85281436c23748a6
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

0d3fd95 by Gerald Combs (ger...@wireshark.org):

Update the release notes.

Change-Id: Id26548a1c262a91e4fe0a4c44dcb578b5b4e5c11
Reviewed-on: https://code.wireshark.org/review/19285
Reviewed-by: Gerald Combs 


Actions performed:

from  c8b96ef   [GTPv2] Fix dissection of MM Context fpr EPS
adds  0d3fd95   Update the release notes.


Summary of changes:
 docbook/release-notes.asciidoc |   35 ---
 1 file changed, 16 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c8b96ef: [GTPv2] Fix dissection of MM Context fpr EPS

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8b96ef1a9b34faf5bb869b40a4c1e2c71590cd7
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

c8b96ef by AndersBroman (anders.bro...@ericsson.com):

[GTPv2] Fix dissection of MM Context fpr EPS

Change-Id: I1ee7f4caa23834ac8bcbd56731c116a785b67d6b
Reviewed-on: https://code.wireshark.org/review/19283
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  e7ba5d7   packet.c: add initializer.
adds  c8b96ef   [GTPv2] Fix dissection of MM Context fpr EPS


Summary of changes:
 epan/dissectors/packet-gtpv2.c |   38 +++---
 1 file changed, 19 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e7ba5d7: packet.c: add initializer.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7ba5d78ea49abd28a34696f631271d5b3338471
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e7ba5d7 by Dario Lombardo (lom...@gmail.com):

packet.c: add initializer.

As per glib manual, GSLists need to be NULL initialized.

Change-Id: If78904b900f6ddd7a0afaf3a1c480ec7626f2027
Reviewed-on: https://code.wireshark.org/review/19281
Reviewed-by: Anders Broman 


Actions performed:

from  c65e5851  Make some items that don't need to be size_t guint.
adds  e7ba5d7   packet.c: add initializer.


Summary of changes:
 epan/packet.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c65e5851: Make some items that don't need to be size_t guint.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c65e5851b2eef0ef99e4cb9388eb780cd6a87aa7
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

c65e5851 by Guy Harris (g...@alum.mit.edu):

Make some items that don't need to be size_t guint.

Those sizes are limited by the packet sizes we support, and we only
support a maximum packet size of 2^32.

This squelches some compiler warnings.

Remove some casts that this renders unnecessary.

Change-Id: Id9a7bcf8c2ce30bbed7be6c0e28deb9cf38002e0
Reviewed-on: https://code.wireshark.org/review/19279
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  e6a9877   Improved  parsing of sniffed homeplug-av data
adds  c65e5851  Make some items that don't need to be size_t guint.


Summary of changes:
 epan/dissectors/packet-rtp.h |4 ++--
 ui/gtk/rtp_analysis.c|2 +-
 ui/qt/rtp_audio_stream.cpp   |2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe