[Wireshark-commits] master faaff7d: Replace "n/a" with an em dash.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=faaff7d180fd0ba3994871b1a1a121da91d0377b
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

faaff7d by Gerald Combs (ger...@wireshark.org):

Replace "n/a" with an em dash.

Replace occurrences of "n/a" with an em dash. It matches what we do
elsewhere and reduces the need for translation.

Change-Id: Ib5b63be765b7da9ae3e66ab19bd25cb497fd722d
Reviewed-on: https://code.wireshark.org/review/20267
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  42cf565   dtd: fix build due to -Wtypedef-redefinition
adds  faaff7d   Replace "n/a" with an em dash.


Summary of changes:
 ui/qt/capture_file_properties_dialog.cpp |4 ++--
 ui/qt/gsm_map_summary_dialog.cpp |5 +++--
 ui/qt/mtp3_summary_dialog.cpp|5 +++--
 3 files changed, 8 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2948

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
42cf565b50badec2b23e0a38bfff3749448ac98f
Blamelist: Peter Wu 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 42cf565: dtd: fix build due to -Wtypedef-redefinition

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=42cf565b50badec2b23e0a38bfff3749448ac98f
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

42cf565 by Peter Wu (pe...@lekensteyn.nl):

dtd: fix build due to -Wtypedef-redefinition

dtd.h defines the type, so avoid redefining to avoid this warning:

epan/dtd_preparse.l:113:3: warning: redefinition of typedef 
'Dtd_PreParse_scanner_state_t' is a C11 feature [-Wtypedef-redefinition]

Change-Id: Id6dddb8fe082717b483a6eeae08dfde468c19c89
Fixes: v2.3.0rc0-2505-ge1282f2875 ("dtd: free memory on shutdown.")
Reviewed-on: https://code.wireshark.org/review/20266
Petri-Dish: Peter Wu 
Reviewed-by: Peter Wu 


Actions performed:

from  e1282f2   dtd: free memory on shutdown.
adds  42cf565   dtd: fix build due to -Wtypedef-redefinition


Summary of changes:
 epan/dtd_preparse.l |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/13323

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
e1282f28751fefc437280b4cb8b2e1b5df016752
Blamelist: Dario Lombardo 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e1282f2: dtd: free memory on shutdown.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e1282f28751fefc437280b4cb8b2e1b5df016752
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e1282f2 by Dario Lombardo (lom...@gmail.com):

dtd: free memory on shutdown.

Change-Id: I502e505730b9310066563bfd9c8df9fceddd0301
Reviewed-on: https://code.wireshark.org/review/20229
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Dario Lombardo 


Actions performed:

from  43487d8   udpdump: fix help.
adds  e1282f2   dtd: free memory on shutdown.


Summary of changes:
 epan/dtd.h  |3 +++
 epan/dtd_preparse.l |   15 ---
 epan/epan.c |2 ++
 3 files changed, 13 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 43487d8: udpdump: fix help.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=43487d825b9974c0406c940810e1afac371230df
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

43487d8 by Dario Lombardo (lom...@gmail.com):

udpdump: fix help.

Change-Id: Iad0e802f8c5d3920104751fab5135d71f02b29b8
Reviewed-on: https://code.wireshark.org/review/20264
Reviewed-by: Dario Lombardo 


Actions performed:

from  147d0c2   androiddump: Use nonblocking connect
adds  43487d8   udpdump: fix help.


Summary of changes:
 extcap/udpdump.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2945

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
f22c7139e06f46685384d7ac22f4c0279cc13195
Blamelist: Dario Lombardo 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 147d0c2: androiddump: Use nonblocking connect

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=147d0c2e36822afa17df686d8634b7918614a80a
Submitter: Michal Labedzki (michal.tomasz.labed...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

147d0c2 by Michal Labedzki (michal.labed...@tieto.com):

androiddump: Use nonblocking connect

Release as version 1.0.5:
All connects to ADB are now non-blocking.
Try to connect up to 10 times with 1ms delays,
so in worst-case it takes ~10ms (for example 14ms)

Bug: 13104
Change-Id: I791909c9c951b62195b48acd82490e1b9ebf2be0
Reviewed-on: https://code.wireshark.org/review/19968
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 
Tested-by: Michal Labedzki 


Actions performed:

from  f22c713   tools: add options validation.
adds  147d0c2   androiddump: Use nonblocking connect


Summary of changes:
 extcap/androiddump.c |   68 --
 1 file changed, 61 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f22c713: tools: add options validation.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f22c7139e06f46685384d7ac22f4c0279cc13195
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

f22c713 by Dario Lombardo (lom...@gmail.com):

tools: add options validation.

This prevents to call the apps with incongruent options.

Change-Id: I76919a2da141bd277c06e708548c971c19dd7af7
Reviewed-on: https://code.wireshark.org/review/20211
Reviewed-by: Dario Lombardo 


Actions performed:

from  8e6b5c1   Developers Guide typo
adds  f22c713   tools: add options validation.


Summary of changes:
 tools/valgrind-wireshark.sh |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8e6b5c1: Developers Guide typo

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8e6b5c14fadafa9541347b715f0fead2eb4702f7
Submitter: Graham Bloice (graham.blo...@trihedral.com)
Changed: branch: master
Repository: wireshark

Commits:

8e6b5c1 by Graham Bloice (graham.blo...@trihedral.com):

Developers Guide typo

Change-Id: I125f8d9171ebdfaf7528d784e69d9768e6b1b8b7
Reviewed-on: https://code.wireshark.org/review/20262
Reviewed-by: Graham Bloice 


Actions performed:

from  beea673   Qt: Code cleanup
adds  8e6b5c1   Developers Guide typo


Summary of changes:
 docbook/wsdg_src/WSDG_chapter_dissection.asciidoc |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2943

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
beea6736abfcd27176ba19954141cc4654c08f03
Blamelist: Roland Knall ,Stig Bjørlykke 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master beea673: Qt: Code cleanup

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=beea6736abfcd27176ba19954141cc4654c08f03
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

beea673 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Code cleanup

Remove whitespace to match coding style used in file.

Change-Id: I4c1649aa02087cd39b2f516db6e40749899c5125
Reviewed-on: https://code.wireshark.org/review/20260
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  3697192   pluginif: Add documentation for toolbar interface
adds  beea673   Qt: Code cleanup


Summary of changes:
 ui/qt/main_window.cpp   |   69 +++
 ui/qt/main_window_slots.cpp |   41 +++--
 2 files changed, 48 insertions(+), 62 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3697192: pluginif: Add documentation for toolbar interface

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3697192ea2097d867aab61faa966f4c938be8199
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3697192 by Roland Knall (roland.kn...@br-automation.com):

pluginif: Add documentation for toolbar interface

Add the documentation for the new toolbar interface
to the README file

Change-Id: I9dd37dc4f31760ccd1c9a3e6ae379cd6f9ca1db9
Reviewed-on: https://code.wireshark.org/review/20261
Reviewed-by: Roland Knall 


Actions performed:

from  321386e   PluginIF: AdditionalToolbar
adds  3697192   pluginif: Add documentation for toolbar interface


Summary of changes:
 doc/README.plugins |  108 
 1 file changed, 108 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 321386e: PluginIF: AdditionalToolbar

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=321386e9f49d88b64f48868c6e4079b2073547a1
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

321386e by Roland Knall (roland.kn...@br-automation.com):

PluginIF: AdditionalToolbar

Creates an interface for plugins and other parts of the code, to
add a new toolbar to the system and have various widget types interact
with this toolbar.

All toolbars added via this interface, will be added to an additional
submenu called "Additional Toolbars" within Wireshark.

Also a demo plugin is being provided, demonstrating various features
of the toolbar, including updating the gui elements. It also demonstrates
how to update toolbar items.

Change-Id: I8d0351224b3d7f4b90220d58970b51695551d7e3
Reviewed-on: https://code.wireshark.org/review/19803
Petri-Dish: Roland Knall 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 
Reviewed-by: Roland Knall 


Actions performed:

from  bd9afdd   Reduce number of fwrite when writing pcap-ng EPB.
adds  321386e   PluginIF: AdditionalToolbar


Summary of changes:
 CMakeLists.txt |9 +
 CMakeOptions.txt   |1 +
 epan/plugin_if.c   |  337 +++-
 epan/plugin_if.h   |  178 ++-
 plugins/pluginifdemo/AUTHORS   |2 +
 plugins/{transum => pluginifdemo}/CMakeLists.txt   |   58 +--
 plugins/{gryphon => pluginifdemo}/COPYING  |0
 plugins/{gryphon => pluginifdemo}/Makefile.am  |   18 +-
 plugins/pluginifdemo/NEWS  |1 +
 plugins/pluginifdemo/README|2 +
 plugins/{wimaxasncp => pluginifdemo}/moduleinfo.h  |4 +-
 plugins/{docsis => pluginifdemo}/plugin.rc.in  |0
 plugins/pluginifdemo/pluginifdemo.c|  157 ++
 .../pluginifdemo/pluginifdemo.h|   12 +-
 .../pluginifdemo/ui/pluginifdemo_about.cpp |   43 +-
 .../pluginifdemo/ui/pluginifdemo_about.h   |   31 +-
 plugins/pluginifdemo/ui/pluginifdemo_about.ui  |  156 ++
 plugins/pluginifdemo/ui/pluginifdemo_main.cpp  |  320 
 plugins/pluginifdemo/ui/pluginifdemo_main.h|  133 +
 plugins/pluginifdemo/ui/pluginifdemo_main.ui   |  315 
 plugins/pluginifdemo/ui/uiclasshandler.cpp |  128 +
 .../pluginifdemo/ui/uihandler.cpp  |   71 ++-
 plugins/pluginifdemo/ui/uihandler.h|  101 
 ui/qt/CMakeLists.txt   |4 +
 ui/qt/Makefile.am  |4 +
 ui/qt/additional_toolbar.cpp   |  537 
 ui/qt/additional_toolbar.h |  101 
 ui/qt/apply_line_edit.cpp  |  181 +++
 .../{extcap_argument_file.h => apply_line_edit.h}  |   50 +-
 ui/qt/main_window.cpp  |  133 -
 ui/qt/main_window.h|5 +-
 ui/qt/main_window.ui   |6 +
 ui/qt/main_window_slots.cpp|   70 +++
 ui/recent.c|   14 +
 ui/recent.h|1 +
 35 files changed, 3010 insertions(+), 173 deletions(-)
 create mode 100644 plugins/pluginifdemo/AUTHORS
 copy plugins/{transum => pluginifdemo}/CMakeLists.txt (72%)
 copy plugins/{gryphon => pluginifdemo}/COPYING (100%)
 copy plugins/{gryphon => pluginifdemo}/Makefile.am (82%)
 create mode 100644 plugins/pluginifdemo/NEWS
 create mode 100644 plugins/pluginifdemo/README
 copy plugins/{wimaxasncp => pluginifdemo}/moduleinfo.h (97%)
 copy plugins/{docsis => pluginifdemo}/plugin.rc.in (100%)
 create mode 100644 plugins/pluginifdemo/pluginifdemo.c
 copy epan/dissectors/packet-bfd.h => plugins/pluginifdemo/pluginifdemo.h (84%)
 copy ui/qt/about_dialog.h => plugins/pluginifdemo/ui/pluginifdemo_about.cpp 
(67%)
 copy ui/qt/export_pdu_dialog.h => plugins/pluginifdemo/ui/pluginifdemo_about.h 
(69%)
 create mode 100644 plugins/pluginifdemo/ui/pluginifdemo_about.ui
 create mode 100644 plugins/pluginifdemo/ui/pluginifdemo_main.cpp
 create mode 100644 plugins/pluginifdemo/ui/pluginifdemo_main.h
 create mode 100644 plugins/pluginifdemo/ui/pluginifdemo_main.ui
 create mode 100644 plugins/pluginifdemo/ui/uiclasshandler.cpp
 copy ui/qt/sctp_all_assocs_dialog.h => plugins/pluginifdemo/ui/uihandler.cpp 
(52%)
 create mode 100644 plugins/pluginifdemo/ui/uihandler.h
 create mode 100644 ui/qt/additional_toolbar.cpp
 create mode 100644 ui/qt/additional_toolbar.h
 create mode 100644 ui/qt/apply_line_edit.cpp
 copy ui/qt/{extcap_argument_file.h =>