[Wireshark-commits] master 311b1ee: IEEE 802.11: Handle Atheros padding

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=311b1ee70072531352262f3a47181e89472e3109
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master
Repository: wireshark

Commits:

311b1ee by Jaap Keuter (jaap.keu...@xs4all.nl):

IEEE 802.11: Handle Atheros padding

For some unknown reason between 802.11 protocol fields end and LLC
protocol field start two octets of padding may appear. These octets
(value 0x00) were observed on the OLPC laptop, heuristically detected
and marked as OLPC mysterious stuff.

It seems that Atheros chipset drivers also show this behaviour,
although the padding is not 0x, but seem to be a duplicate of the
sequence control field. This is now also heuristically detected and
marked more generically as payload padding.

Bug: 13411
Change-Id: I1e817e07dc19be8b3917ff302ede3328ca6a4938
Reviewed-on: https://code.wireshark.org/review/20284
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jaap Keuter 


Actions performed:

from  2534ec4   sharkd: support for rtp tap.
adds  311b1ee   IEEE 802.11: Handle Atheros padding


Summary of changes:
 epan/dissectors/packet-ieee80211.c |   10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2017-02-27 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/13351

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
2534ec45c108c00a9e8c5fa09b85f1c70f4ae35e
Blamelist: Jakub Zawadzki 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 2534ec4: sharkd: support for rtp tap.

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2534ec45c108c00a9e8c5fa09b85f1c70f4ae35e
Submitter: Jakub Zawadzki (darkjames...@darkjames.pl)
Changed: branch: master
Repository: wireshark

Commits:

2534ec4 by Jakub Zawadzki (darkjames...@darkjames.pl):

sharkd: support for rtp tap.

Change-Id: I84b542f8ace1e53f41be0b73a24aeb720c3c904a
Reviewed-on: https://code.wireshark.org/review/20271
Petri-Dish: Jakub Zawadzki 
Tested-by: Jakub Zawadzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jakub Zawadzki 


Actions performed:

from  5c6f633   androiddump: Use only non-blocking connect() instead of the 
socket
adds  2534ec4   sharkd: support for rtp tap.


Summary of changes:
 sharkd_session.c |   96 ++
 1 file changed, 96 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 5c6f633: androiddump: Use only non-blocking connect() instead of the socket

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c6f6333768e16fc682b732db561754434f41272
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

5c6f633 by Michal Labedzki (michal.labed...@tieto.com):

androiddump: Use only non-blocking connect() instead of the socket

Architecture of androiddump based on "blocking" sockets,
however for start-up it is better to use non-bloking connect()
to avoid long waiting time then fail.

Change-Id: I2bb8ea51e24db4dd1f5a6b97e1d2bc0156342d97
Reviewed-on: https://code.wireshark.org/review/20293
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
Reviewed-by: Anders Broman 


Actions performed:

from  606f941   RSVDv2 support - 2nd stage
adds  5c6f633   androiddump: Use only non-blocking connect() instead of the 
socket


Summary of changes:
 extcap/androiddump.c |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 606f941: RSVDv2 support - 2nd stage

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=606f941e7f9f67f7851c6eb285ca30175aad0344
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

606f941 by Volodymyr Khomenko (volodymyr_khome...@dellteam.com):

RSVDv2 support - 2nd stage

Improved META_OPERATION_START (CreateSnapshot, ApplySnapshot)
Added VHDSET_QUERY_INFORMATION (SnapshotEntry)
Added DELETE_SNAPSHOT

Minor fixes:
RSVD Status field of RSVD header shown as NT_STATUS
Using more structural names for RSVDv2 hf_

Change-Id: I0199527a2de819796c7b34b663df73547f32d2fd
Ping-Bug: 11232
Reviewed-on: https://code.wireshark.org/review/20300
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Anders Broman 


Actions performed:

from  4ef0fa2   Some ERF pseudo-headers have color instead of lctr value
adds  606f941   RSVDv2 support - 2nd stage


Summary of changes:
 epan/dissectors/packet-rsvd.c |  322 -
 1 file changed, 288 insertions(+), 34 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 4ef0fa2: Some ERF pseudo-headers have color instead of lctr value

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ef0fa2f15b0d389e05ff94024f194702ddf42f9
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4ef0fa2 by sfd (stephen.donne...@endace.com):

Some ERF pseudo-headers have color instead of lctr value

Don't report expert-info warnings for lctr when it is actually color.

Change-Id: I689ec84dd8f1cafa1ec7e8740f9bc4091339929a
Reviewed-on: https://code.wireshark.org/review/20306
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  841531b   wiretap (nettl/pppdump): fix this statement may fall 
through [-Werror=implicit-fallthrough=] found by gcc7
adds  4ef0fa2   Some ERF pseudo-headers have color instead of lctr value


Summary of changes:
 epan/dissectors/packet-erf.c |   29 ++---
 1 file changed, 26 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86

2017-02-27 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX 10.6 x86 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.6%20x86/builds/1184

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.6-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
4439e69914392c2cdbc219c27e5f9ee884038e8f
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 841531b: wiretap (nettl/pppdump): fix this statement may fall through [-Werror=implicit-fallthrough=] found by gcc7

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=841531bc85629023c9f3fb73d8af609e3cd32109
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

841531b by Alexis La Goutte (alexis.lagou...@gmail.com):

wiretap (nettl/pppdump): fix this statement may fall through 
[-Werror=implicit-fallthrough=] found by gcc7

Change-Id: I8c339e7484d410460d499dd2923641630b482ebe
Reviewed-on: https://code.wireshark.org/review/20303
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  59b672e   Return correct filter for get_hostlist_filter()
adds  841531b   wiretap (nettl/pppdump): fix this statement may fall 
through [-Werror=implicit-fallthrough=] found by gcc7


Summary of changes:
 wiretap/nettl.c   |1 +
 wiretap/pppdump.c |1 +
 2 files changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.2 991f1b5: Return correct filter for get_hostlist_filter()

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=991f1b59bec9c0ec945ef3b443d354af55c6b332
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

991f1b5 by Jakub Zawadzki (darkjames...@darkjames.pl):

Return correct filter for get_hostlist_filter()

It was returning (ip.src == ... && .port == ...).

Now, I think correctly returns (ip.addr == ... && .port == ...)

Change-Id: I242e13c0c79ce2b27fc2f9ee348b89d21ec1
Reviewed-on: https://code.wireshark.org/review/20281
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jakub Zawadzki 
Reviewed-by: Michael Mann 
(cherry picked from commit 59b672e5907d272ea5bd5ef571b03e004d07705a)
Reviewed-on: https://code.wireshark.org/review/20304


Actions performed:

from  6eaac3a   wslua: fix documentation of Struct.fromhex
adds  991f1b5   Return correct filter for get_hostlist_filter()


Summary of changes:
 epan/dissectors/packet-sctp.c |   17 +++--
 epan/dissectors/packet-tcp.c  |   16 +++-
 epan/dissectors/packet-udp.c  |   17 -
 3 files changed, 46 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.0 4439e69: Return correct filter for get_hostlist_filter()

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4439e69914392c2cdbc219c27e5f9ee884038e8f
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4439e69 by Jakub Zawadzki (darkjames...@darkjames.pl):

Return correct filter for get_hostlist_filter()

It was returning (ip.src == ... && .port == ...).

Now, I think correctly returns (ip.addr == ... && .port == ...)

Change-Id: I242e13c0c79ce2b27fc2f9ee348b89d21ec1
Reviewed-on: https://code.wireshark.org/review/20281
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jakub Zawadzki 
Reviewed-by: Michael Mann 
(cherry picked from commit 59b672e5907d272ea5bd5ef571b03e004d07705a)
Reviewed-on: https://code.wireshark.org/review/20305


Actions performed:

from  971aaca   wslua: fix documentation of Struct.fromhex
adds  4439e69   Return correct filter for get_hostlist_filter()


Summary of changes:
 epan/dissectors/packet-sctp.c |   17 +++--
 epan/dissectors/packet-tcp.c  |   16 +++-
 epan/dissectors/packet-udp.c  |   17 -
 3 files changed, 46 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 59b672e: Return correct filter for get_hostlist_filter()

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59b672e5907d272ea5bd5ef571b03e004d07705a
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

59b672e by Jakub Zawadzki (darkjames...@darkjames.pl):

Return correct filter for get_hostlist_filter()

It was returning (ip.src == ... && .port == ...).

Now, I think correctly returns (ip.addr == ... && .port == ...)

Change-Id: I242e13c0c79ce2b27fc2f9ee348b89d21ec1
Reviewed-on: https://code.wireshark.org/review/20281
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jakub Zawadzki 
Reviewed-by: Michael Mann 


Actions performed:

from  8b8a3b8   Qt: Avoid null pointer dereference (CID 1401573)
adds  59b672e   Return correct filter for get_hostlist_filter()


Summary of changes:
 epan/dissectors/packet-sctp.c |   17 +++--
 epan/dissectors/packet-tcp.c  |   16 +++-
 epan/dissectors/packet-udp.c  |   17 -
 3 files changed, 46 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 8b8a3b8: Qt: Avoid null pointer dereference (CID 1401573)

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b8a3b8d1a28c8406d41f3836dbc73fdddb568fc
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

8b8a3b8 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Avoid null pointer dereference (CID 1401573)

Change-Id: I638174a05c6275baf54e000d941f47f8ba572169
Reviewed-on: https://code.wireshark.org/review/20302
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  8851c1c   extcap: remove leak in interface lists.
adds  8b8a3b8   Qt: Avoid null pointer dereference (CID 1401573)


Summary of changes:
 ui/qt/main_window.cpp |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

2017-02-27 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/482

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
6eaac3aac36e84b916d28c35acdea716ab135657
Blamelist: Michael Mann 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2017-02-27 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/8717

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
d4cf57100ce10930551b1985eac77e78bae6361d
Blamelist: Michael Mann 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2017-02-27 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/1521

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
d4cf57100ce10930551b1985eac77e78bae6361d
Blamelist: Michael Mann 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 8851c1c: extcap: remove leak in interface lists.

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8851c1c56eb40432b6acd407e92da927ed909207
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

8851c1c by Dario Lombardo (lom...@gmail.com):

extcap: remove leak in interface lists.

Change-Id: Ib57292afc88cd32736b78a901385cfdde84c46c9
Reviewed-on: https://code.wireshark.org/review/20297
Reviewed-by: Roland Knall 
Petri-Dish: Roland Knall 
Reviewed-by: Dario Lombardo 


Actions performed:

from  a29fe9d   print_stream: free memory on exit.
adds  8851c1c   extcap: remove leak in interface lists.


Summary of changes:
 extcap.c |   16 ++--
 1 file changed, 14 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master a29fe9d: print_stream: free memory on exit.

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a29fe9d76afe04ae80caebfb4239d3b5a8318183
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

a29fe9d by Dario Lombardo (lom...@gmail.com):

print_stream: free memory on exit.

Change-Id: I6c4acaa9026cfdf1d4230c28c30bccfb6c025cef
Reviewed-on: https://code.wireshark.org/review/19920
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Dario Lombardo 


Actions performed:

from  d4cf571   Free radius dissector memory on shutdown
adds  a29fe9d   print_stream: free memory on exit.


Summary of changes:
 epan/print_stream.c   |2 +-
 tfshark.c |1 +
 tshark.c  |3 ++-
 ui/win32/file_dlg_win32.c |1 +
 4 files changed, 5 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master d4cf571: Free radius dissector memory on shutdown

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d4cf57100ce10930551b1985eac77e78bae6361d
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

d4cf571 by Michael Mann (mman...@netscape.net):

Free radius dissector memory on shutdown

Change-Id: I19eef65e8144d7cb6d5c9eea454581a532420c75
Reviewed-on: https://code.wireshark.org/review/20292
Reviewed-by: Dario Lombardo 
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  220772d   text2pcap: fix -Wmacro-redefined warning
adds  d4cf571   Free radius dissector memory on shutdown


Summary of changes:
 epan/dissectors/packet-radius.c |   49 +++
 epan/dissectors/packet-radius.h |5 ++--
 epan/radius_dict.l  |2 +-
 3 files changed, 48 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 220772d: text2pcap: fix -Wmacro-redefined warning

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=220772dc19ef8b9c20a919375b47390a794c4e42
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

220772d by Peter Wu (pe...@lekensteyn.nl):

text2pcap: fix -Wmacro-redefined warning

With flex 2.6.3, this warning is observed (which causes a build failure
when -Werror is not disabled:

text2pcap-scanner.c:398:9: warning: 'yywrap' macro redefined 
[-Wmacro-redefined]
#define yywrap() (/*CONSTCOND*/1)
^
text2pcap-scanner.c:76:13: note: previous definition is here
#define yywrap yywrap

Issue is specific to flex 2.6.3 and resolved upstream at
https://github.com/westes/flex/issues/162

Change-Id: I861565f5080f87a9457427e7a63b5d9256c49e85
Reviewed-on: https://code.wireshark.org/review/20294
Petri-Dish: Peter Wu 
Reviewed-by: Michael Mann 


Actions performed:

from  4b2a2eb   wslua: fix documentation of Struct.fromhex
adds  220772d   text2pcap: fix -Wmacro-redefined warning


Summary of changes:
 text2pcap-scanner.l |6 ++
 text2pcap.c |6 +++---
 text2pcap.h |2 +-
 3 files changed, 10 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.0 971aaca: wslua: fix documentation of Struct.fromhex

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=971aacaf781b73b90c701a101d09e69c62ef7d2b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

971aaca by Peter Wu (pe...@lekensteyn.nl):

wslua: fix documentation of Struct.fromhex

The default separator is really an empty string, not a single space.
This has been wrongly documented since the beginning.

Change-Id: I5598daec1486ce17cfeeaf5697f9759172db9cf5
Fixes: v1.11.3-rc1-1760-g860747e1e7 ("Adds some Lua helper functions: some 
commonly used functions, and to help troubleshooting Lua scripts")
Reviewed-on: https://code.wireshark.org/review/20296
Reviewed-by: Michael Mann 
(cherry picked from commit 4b2a2eb0a4c393dcf29e505ed8f135e9b85fb60e)
Reviewed-on: https://code.wireshark.org/review/20298
(cherry picked from commit 6eaac3aac36e84b916d28c35acdea716ab135657)
Reviewed-on: https://code.wireshark.org/review/20299


Actions performed:

from  5a3b90d   [Automatic update for 2017-02-26]
adds  971aaca   wslua: fix documentation of Struct.fromhex


Summary of changes:
 epan/wslua/wslua_struct.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.2 6eaac3a: wslua: fix documentation of Struct.fromhex

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6eaac3aac36e84b916d28c35acdea716ab135657
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

6eaac3a by Peter Wu (pe...@lekensteyn.nl):

wslua: fix documentation of Struct.fromhex

The default separator is really an empty string, not a single space.
This has been wrongly documented since the beginning.

Change-Id: I5598daec1486ce17cfeeaf5697f9759172db9cf5
Fixes: v1.11.3-rc1-1760-g860747e1e7 ("Adds some Lua helper functions: some 
commonly used functions, and to help troubleshooting Lua scripts")
Reviewed-on: https://code.wireshark.org/review/20296
Reviewed-by: Michael Mann 
(cherry picked from commit 4b2a2eb0a4c393dcf29e505ed8f135e9b85fb60e)
Reviewed-on: https://code.wireshark.org/review/20298


Actions performed:

from  4f9839f   [Automatic update for 2017-02-26]
adds  6eaac3a   wslua: fix documentation of Struct.fromhex


Summary of changes:
 epan/wslua/wslua_struct.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 4b2a2eb: wslua: fix documentation of Struct.fromhex

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4b2a2eb0a4c393dcf29e505ed8f135e9b85fb60e
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

4b2a2eb by Peter Wu (pe...@lekensteyn.nl):

wslua: fix documentation of Struct.fromhex

The default separator is really an empty string, not a single space.
This has been wrongly documented since the beginning.

Change-Id: I5598daec1486ce17cfeeaf5697f9759172db9cf5
Fixes: v1.11.3-rc1-1760-g860747e1e7 ("Adds some Lua helper functions: some 
commonly used functions, and to help troubleshooting Lua scripts")
Reviewed-on: https://code.wireshark.org/review/20296
Reviewed-by: Michael Mann 


Actions performed:

from  e8ff9f5   pluginifdemo: Adjust title texts
adds  4b2a2eb   wslua: fix documentation of Struct.fromhex


Summary of changes:
 epan/wslua/wslua_struct.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-02-27 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2967

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
e8ff9f5b488383fba593143fdd81731c7c0c97d0
Blamelist: Stig Bjørlykke 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e8ff9f5: pluginifdemo: Adjust title texts

2017-02-27 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8ff9f5b488383fba593143fdd81731c7c0c97d0
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

e8ff9f5 by Stig Bjørlykke (s...@bjorlykke.org):

pluginifdemo: Adjust title texts

Small improvement in the title texts.

Change-Id: Ia413577386dab11f78fd141d6333944beefb5b33
Reviewed-on: https://code.wireshark.org/review/20295
Petri-Dish: Stig Bjørlykke 
Reviewed-by: Roland Knall 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  513eed68  text2pcap: check return values of functions and use a 
single exit point.
adds  e8ff9f5   pluginifdemo: Adjust title texts


Summary of changes:
 plugins/pluginifdemo/pluginifdemo.c |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe