[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2017-03-28 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/13584

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
2de68eb47ff076c3a7e17e278098a584f367f391
Blamelist: Anders Broman 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-03-28 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3204

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
b56bbb493afe6717d2e26c6e795205d7ae10254a
Blamelist: Guy Harris ,Michael Mann 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f706011: TLS: fix decryption with Encrypt-then-MAC (RFC 7366)

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7060112b7e83edd844c90a397e60301ee5f1c29
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

f706011 by Peter Wu (pe...@lekensteyn.nl):

TLS: fix decryption with Encrypt-then-MAC (RFC 7366)

Bug: 13522
Change-Id: I0dfe30e086c3ef1a4f96f22e2db46e4d4cc7dffa
Reviewed-on: https://code.wireshark.org/review/20771
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  2de68eb   sharkd: support exporting ssl secrets
adds  f706011   TLS: fix decryption with Encrypt-then-MAC (RFC 7366)


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   64 
 epan/dissectors/packet-ssl-utils.h |3 +-
 2 files changed, 53 insertions(+), 14 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2de68eb: sharkd: support exporting ssl secrets

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2de68eb47ff076c3a7e17e278098a584f367f391
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2de68eb by Jakub Zawadzki (darkjames...@darkjames.pl):

sharkd: support exporting ssl secrets

Change-Id: Ie7db733d8aa7189b1ade6ef85d911653ed8c490f
Reviewed-on: https://code.wireshark.org/review/20703
Petri-Dish: Jakub Zawadzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
Reviewed-by: Anders Broman 


Actions performed:

from  572b80d   Add ENC_TIME_MSEC_NTP and use it in packet-gtpv2.c
adds  2de68eb   sharkd: support exporting ssl secrets


Summary of changes:
 sharkd_session.c |   21 +
 1 file changed, 21 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 572b80d: Add ENC_TIME_MSEC_NTP and use it in packet-gtpv2.c

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=572b80d2835f9296e87c0d099f133d55149c44f1
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

572b80d by AndersBroman (anders.bro...@ericsson.com):

Add ENC_TIME_MSEC_NTP and use it in packet-gtpv2.c

While at it fix expert info a typo and an calculation.

Change-Id: I071a36edb7eed5f58708b98aebcb24bc6c34f2a8
Reviewed-on: https://code.wireshark.org/review/20766
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  79ba8c3   Print signed values with %d, not %u.
adds  572b80d   Add ENC_TIME_MSEC_NTP and use it in packet-gtpv2.c


Summary of changes:
 doc/README.dissector   |5 -
 epan/dissectors/packet-gtpv2.c |4 ++--
 epan/proto.c   |   24 
 epan/proto.h   |4 
 4 files changed, 30 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86

2017-03-28 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x86 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.6%20x86/builds/1221

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.6-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
654be4374cf135dfe164a87ebbd56eb098e43ad3
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 654be43: Print signed values with %d, not %u.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=654be4374cf135dfe164a87ebbd56eb098e43ad3
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

654be43 by Guy Harris (g...@alum.mit.edu):

Print signed values with %d, not %u.

Change-Id: I1ad46df006976c052ff42baf6415e18b488b215f
Reviewed-on: https://code.wireshark.org/review/20780
Reviewed-by: Guy Harris 
(cherry picked from commit 79ba8c397653d99b4c52a5bbfa2f4d554067c6a4)
Reviewed-on: https://code.wireshark.org/review/20782


Actions performed:

from  3d4e738   Pick up error checks from the master branch.
adds  654be43   Print signed values with %d, not %u.


Summary of changes:
 epan/proto.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c9beee0: Print signed values with %d, not %u.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9beee0ce9cd2b1b9be30e26e6cfaa91853c8e23
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c9beee0 by Guy Harris (g...@alum.mit.edu):

Print signed values with %d, not %u.

Change-Id: I1ad46df006976c052ff42baf6415e18b488b215f
Reviewed-on: https://code.wireshark.org/review/20780
Reviewed-by: Guy Harris 
(cherry picked from commit 79ba8c397653d99b4c52a5bbfa2f4d554067c6a4)
Reviewed-on: https://code.wireshark.org/review/20781


Actions performed:

from  c52fcab   Pick up error checks from the master branch.
adds  c9beee0   Print signed values with %d, not %u.


Summary of changes:
 epan/proto.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 79ba8c3: Print signed values with %d, not %u.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79ba8c397653d99b4c52a5bbfa2f4d554067c6a4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

79ba8c3 by Guy Harris (g...@alum.mit.edu):

Print signed values with %d, not %u.

Change-Id: I1ad46df006976c052ff42baf6415e18b488b215f
Reviewed-on: https://code.wireshark.org/review/20780
Reviewed-by: Guy Harris 


Actions performed:

from  b56bbb4   Fix "warning C6246: Local declaration hides declaration of 
the same name in outer scope" warnings
adds  79ba8c3   Print signed values with %d, not %u.


Summary of changes:
 epan/proto.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b56bbb4: Fix "warning C6246: Local declaration hides declaration of the same name in outer scope" warnings

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b56bbb493afe6717d2e26c6e795205d7ae10254a
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

b56bbb4 by Michael Mann (mman...@netscape.net):

Fix "warning C6246: Local declaration hides declaration of the same name in 
outer scope" warnings

Change-Id: I98edc076fdab40ef1fd05313168011f58e13a4d6
Reviewed-on: https://code.wireshark.org/review/20773
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  6b0f846   Fix problem found by Coverity.
adds  b56bbb4   Fix "warning C6246: Local declaration hides declaration of 
the same name in outer scope" warnings


Summary of changes:
 ui/qt/about_dialog.cpp |1 -
 ui/qt/additional_toolbar.cpp   |8 
 ui/qt/bluetooth_hci_summary_dialog.cpp |2 --
 3 files changed, 4 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 3d4e738: Pick up error checks from the master branch.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d4e7388ff0d7dc1b1fc902cf6b02fcf8c7bbe07
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

3d4e738 by Guy Harris (g...@alum.mit.edu):

Pick up error checks from the master branch.

Change-Id: Ib91dca127ff9d6eb9eb1c8d4cfa88332dd406871
Reviewed-on: https://code.wireshark.org/review/20778
Reviewed-by: Guy Harris 
(cherry picked from commit c52fcab65186101c440272145a47ebc56ad2de04)
Reviewed-on: https://code.wireshark.org/review/20779


Actions performed:

from  21b03d7   Qt: update endpoint statistics column labels to match GTK 
ones
adds  3d4e738   Pick up error checks from the master branch.


Summary of changes:
 wiretap/netscaler.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c52fcab: Pick up error checks from the master branch.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c52fcab65186101c440272145a47ebc56ad2de04
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c52fcab by Guy Harris (g...@alum.mit.edu):

Pick up error checks from the master branch.

Change-Id: Ib91dca127ff9d6eb9eb1c8d4cfa88332dd406871
Reviewed-on: https://code.wireshark.org/review/20778
Reviewed-by: Guy Harris 


Actions performed:

from  fa6a31b   Qt: update endpoint statistics column labels to match GTK 
ones
adds  c52fcab   Pick up error checks from the master branch.


Summary of changes:
 wiretap/netscaler.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6b0f846: Fix problem found by Coverity.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b0f846ac35a9775090f85a02f58064b4b0117e6
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6b0f846 by Guy Harris (g...@alum.mit.edu):

Fix problem found by Coverity.

The loop was using bytes_read, but wasn't setting it.  Go back to
something similar to the previous loop condition, but don't lose the
error tests.

Fixes Coverity CID 1403388.

Change-Id: I557cbfa6e9ad81491af4fc90e85ce87c71fec8aa
Reviewed-on: https://code.wireshark.org/review/20776
Reviewed-by: Guy Harris 


Actions performed:

from  630b5a8   Check for localtime() failing.
adds  6b0f846   Fix problem found by Coverity.


Summary of changes:
 wiretap/netscaler.c |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 630b5a8: Check for localtime() failing.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=630b5a8165aab25d99989916f36412a0414068be
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

630b5a8 by Guy Harris (g...@alum.mit.edu):

Check for localtime() failing.

It "shouldn't happen", but at least this squelches a Coverity complaint,
CID 1394503.

Change-Id: I40af10d47c1d1b026f6b40ef68b139e6bf246109
Reviewed-on: https://code.wireshark.org/review/20774
Reviewed-by: Guy Harris 


Actions performed:

from  1bea950   Add bounds checks for references to outhdr_values.
adds  630b5a8   Check for localtime() failing.


Summary of changes:
 text2pcap.c |   14 --
 1 file changed, 12 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-03-28 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3202

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
1bea950b7a7934fe7bed7719a0ed99321785f7d6
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1bea950: Add bounds checks for references to outhdr_values.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1bea950b7a7934fe7bed7719a0ed99321785f7d6
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

1bea950 by Guy Harris (g...@alum.mit.edu):

Add bounds checks for references to outhdr_values.

Don't run past the end of the outhdr_values array.

While we're at it, don't make it a global array - it doesn't need to be
global, as its values don't persist from invocation to invocation, and
this would allow use of this routine in multiple threads in parallel.
(Yes, we have other global variables that don't maintain state, but we
should get rid of that, too.)

Change-Id: I7ceed3c9ba6356eddb7d52472e9d53dd08f90029
Reviewed-on: https://code.wireshark.org/review/20770
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 


Actions performed:

from  616bbce   packet-nstrace.c: Ensure value_strings end with {0, NULL}
adds  1bea950   Add bounds checks for references to outhdr_values.


Summary of changes:
 epan/dissectors/packet-catapult-dct2000.c |  118 -
 1 file changed, 81 insertions(+), 37 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2017-03-28 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/1744

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
616bbce78e0bc7986d51f4297f04f31b9ed75616
Blamelist: Michael Mann 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 616bbce: packet-nstrace.c: Ensure value_strings end with {0, NULL}

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=616bbce78e0bc7986d51f4297f04f31b9ed75616
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

616bbce by Michael Mann (mman...@netscape.net):

packet-nstrace.c: Ensure value_strings end with {0, NULL}

Change-Id: I548c51dd7333b0dc26a84f77b1e848530b79dde3
Reviewed-on: https://code.wireshark.org/review/20772
Reviewed-by: Michael Mann 


Actions performed:

from  8efd42c   Reflect new default value of snaplen in man pages.
adds  616bbce   packet-nstrace.c: Ensure value_strings end with {0, NULL}


Summary of changes:
 epan/dissectors/packet-nstrace.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-03-28 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3200

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
8efd42c4aa708e53bcb383e79c535137d6d0cade
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2017-03-28 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/13576

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
8efd42c4aa708e53bcb383e79c535137d6d0cade
Blamelist: Michael Mann 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8efd42c: Reflect new default value of snaplen in man pages.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8efd42c4aa708e53bcb383e79c535137d6d0cade
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

8efd42c by Martin Sehnoutka (msehn...@redhat.com):

Reflect new default value of snaplen in man pages.

Default value for snaplen is defined in wiretap/wtap.h:
 #define WTAP_MAX_PACKET_SIZE262144

and used in capture_opts.c:
capture_opts->default_options.snaplen =
WTAP_MAX_PACKET_SIZE;

but help and man pages don't reflect this change.

Change-Id: I35ddf1e8b7ffd657f4e01b3fe6b4c44c9acece2b
Reviewed-on: https://code.wireshark.org/review/20738
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  1721075   voip_calls_infO_model(.h): fix extra ‘;’ [-Wpedantic]
adds  8efd42c   Reflect new default value of snaplen in man pages.


Summary of changes:
 doc/dumpcap.pod  |2 +-
 doc/tshark.pod   |2 +-
 doc/wireshark.pod.template   |4 ++--
 docbook/wsug_src/WSUG_app_tools.asciidoc |6 +++---
 docbook/wsug_src/WSUG_chapter_capture.asciidoc   |2 +-
 docbook/wsug_src/WSUG_chapter_customize.asciidoc |2 +-
 dumpcap.c|2 +-
 tshark.c |2 +-
 ui/commandline.c |2 +-
 9 files changed, 12 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 21b03d7: Qt: update endpoint statistics column labels to match GTK ones

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21b03d72050b5fa187d5a3ce91d686f1b3c70ab7
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

21b03d7 by Pascal Quantin (pascal.quan...@gmail.com):

Qt: update endpoint statistics column labels to match GTK ones

Bug: 13526
Change-Id: I40485c6f9b54ff0bf07f955c1dde8cd5ac05ef9b
Reviewed-on: https://code.wireshark.org/review/20762
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit aa998d75732759abf8a5727c2977897c7425afe6)
Reviewed-on: https://code.wireshark.org/review/20765
Petri-Dish: Michael Mann 


Actions performed:

from  eb4f01d   [Automatic update for 2017-03-26]
adds  21b03d7   Qt: update endpoint statistics column labels to match GTK 
ones


Summary of changes:
 ui/gtk/hostlist_table.c |   11 +++
 ui/traffic_table_ui.c   |8 
 2 files changed, 7 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 fa6a31b: Qt: update endpoint statistics column labels to match GTK ones

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa6a31b59b7c07cf97b47f88f4423b37e280f761
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

fa6a31b by Pascal Quantin (pascal.quan...@gmail.com):

Qt: update endpoint statistics column labels to match GTK ones

Bug: 13526
Change-Id: I40485c6f9b54ff0bf07f955c1dde8cd5ac05ef9b
Reviewed-on: https://code.wireshark.org/review/20762
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit aa998d75732759abf8a5727c2977897c7425afe6)
Reviewed-on: https://code.wireshark.org/review/20764
Petri-Dish: Michael Mann 


Actions performed:

from  4744272   [Automatic update for 2017-03-26]
adds  fa6a31b   Qt: update endpoint statistics column labels to match GTK 
ones


Summary of changes:
 ui/gtk/hostlist_table.c |   11 +++
 ui/traffic_table_ui.c   |8 
 2 files changed, 7 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1721075: voip_calls_infO_model(.h): fix extra ‘;’ [-Wpedantic]

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=172107521b8be56911ce467b837ba047db40d0bb
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

1721075 by Alexis La Goutte (alexis.lagou...@gmail.com):

voip_calls_infO_model(.h): fix extra ‘;’ [-Wpedantic]

Change-Id: I2f131999cd0337d0d65d52f303c8ab9ca6bda39a
Reviewed-on: https://code.wireshark.org/review/20757
Reviewed-by: Peter Wu 


Actions performed:

from  aa998d7   Qt: update endpoint statistics column labels to match GTK 
ones
adds  1721075   voip_calls_infO_model(.h): fix extra ‘;’ [-Wpedantic]


Summary of changes:
 ui/qt/voip_calls_info_model.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master aa998d7: Qt: update endpoint statistics column labels to match GTK ones

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa998d75732759abf8a5727c2977897c7425afe6
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

aa998d7 by Pascal Quantin (pascal.quan...@gmail.com):

Qt: update endpoint statistics column labels to match GTK ones

Bug: 13526
Change-Id: I40485c6f9b54ff0bf07f955c1dde8cd5ac05ef9b
Reviewed-on: https://code.wireshark.org/review/20762
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  2f324e7   randpkt_core: Fix a handful of warnings
adds  aa998d7   Qt: update endpoint statistics column labels to match GTK 
ones


Summary of changes:
 ui/gtk/hostlist_table.c |   11 +++
 ui/traffic_table_ui.c   |8 
 2 files changed, 7 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2f324e7: randpkt_core: Fix a handful of warnings

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f324e770f0fd58065b9e80d878fd3536897ea81
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

2f324e7 by Michael Mann (mman...@netscape.net):

randpkt_core: Fix a handful of warnings

1. randpkt_core.c(559): warning C6262: Function uses '65596' bytes of 
stack:  exceeds /analyze:stacksize '16384'.  Consider moving some data to heap.
2. randpkt_core.c(615): warning C6386: Buffer overrun while writing to 
'buffer':  the writable size is '65536' bytes, but '-1' bytes might be written.

Change-Id: I0f3bcd19b49d6c8cde0d2ad9f745b14f5462a708
Reviewed-on: https://code.wireshark.org/review/20763
Petri-Dish: Michael Mann 
Reviewed-by: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  6b929ab   Don't wire in 262144, use WTAP_MAX_PACKET_SIZE.
adds  2f324e7   randpkt_core: Fix a handful of warnings


Summary of changes:
 randpkt_core/randpkt_core.c |   14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-03-28 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3196

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
ed3b5e5764ce368edc6ca10b81411a7b01b29444
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6b929ab: Don't wire in 262144, use WTAP_MAX_PACKET_SIZE.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b929abe6957f4c2cb27760daa1a248ac73c1b88
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6b929ab by Guy Harris (g...@alum.mit.edu):

Don't wire in 262144, use WTAP_MAX_PACKET_SIZE.

That way, if we ever increase WTAP_MAX_PACKET_SIZE, this code won't need
to be changed.

Change-Id: I68d21e10810b7b8a4732d9ecf7e145668b0fe1cb
Reviewed-on: https://code.wireshark.org/review/20761
Reviewed-by: Guy Harris 


Actions performed:

from  bd486eb   text2pcap: define max packet size to WTAP_MAX_PACKET_SIZE
adds  6b929ab   Don't wire in 262144, use WTAP_MAX_PACKET_SIZE.


Summary of changes:
 ui/gtk/file_import_dlg.c |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bd486eb: text2pcap: define max packet size to WTAP_MAX_PACKET_SIZE

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd486eb9b16640af51fb58995ff59c1434737dc2
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

bd486eb by Pascal Quantin (pascal.quan...@gmail.com):

text2pcap: define max packet size to WTAP_MAX_PACKET_SIZE

Change-Id: I73ab87032e4a0c0259227622412be36aaf66a9d6
Reviewed-on: https://code.wireshark.org/review/20758
Reviewed-by: Guy Harris 


Actions performed:

from  ed3b5e5   Get rid of blanks at the ends of lines.
adds  bd486eb   text2pcap: define max packet size to WTAP_MAX_PACKET_SIZE


Summary of changes:
 doc/text2pcap.pod |2 +-
 text2pcap.c   |   11 ++-
 2 files changed, 7 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ed3b5e5: Get rid of blanks at the ends of lines.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed3b5e5764ce368edc6ca10b81411a7b01b29444
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

ed3b5e5 by Guy Harris (g...@alum.mit.edu):

Get rid of blanks at the ends of lines.

Change-Id: I10a756a4a42d4f27f59e12c11f12d71947191c92
Reviewed-on: https://code.wireshark.org/review/20760
Reviewed-by: Guy Harris 


Actions performed:

from  8f515b1   Fix up time encodings.
adds  ed3b5e5   Get rid of blanks at the ends of lines.


Summary of changes:
 doc/README.dissector |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8f515b1: Fix up time encodings.

2017-03-28 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f515b1a99d0043966a8d287cee38fe67e06d189
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

8f515b1 by Guy Harris (g...@alum.mit.edu):

Fix up time encodings.

Add some new encodings for absolute time stamps, and use them as
appropriate; this fixes some cases where the time stamps in question
were being dissected incorrectly.

For the encodings with seconds and 1/2^32s of a second, don't
arbitrarily give only microsecond resolution; 2^32 is greater than 1
million, and, in fact, at least some NTP RFCs explicitly talk about time
resolution greater than 1 microsecond.

Update references in the RELOAD dissector to reflect the documents in
question having been updated and published as RFCs.

Change-Id: Icbe0b696d65eb622978eb71e99ddf699b84e4fca
Reviewed-on: https://code.wireshark.org/review/20759
Reviewed-by: Guy Harris 


Actions performed:

from  721182b   Qt: fix closing editor in capture interfaces dialog
adds  8f515b1   Fix up time encodings.


Summary of changes:
 doc/README.dissector   |   58 ++-
 epan/dissectors/packet-bitcoin.c   |8 +-
 epan/dissectors/packet-capwap.c|2 +-
 epan/dissectors/packet-diameter.c  |2 +-
 epan/dissectors/packet-dns.c   |2 +-
 epan/dissectors/packet-erf.c   |2 +-
 epan/dissectors/packet-icmpv6.c|2 +-
 epan/dissectors/packet-netflow.c   |   18 +-
 epan/dissectors/packet-reload.c|   20 +--
 epan/dissectors/packet-synphasor.c |2 +-
 epan/proto.c   |  322 +++-
 epan/proto.h   |   55 +++---
 12 files changed, 367 insertions(+), 126 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe