[Wireshark-commits] master 2eb6f3b: CMake: Remove SH from the packate list.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eb6f3b5de46bb4d52775df919e2a55a3f606d9c
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

2eb6f3b by Gerald Combs (ger...@wireshark.org):

CMake: Remove SH from the packate list.

Change-Id: Idafd85df598e0c58fc8252574ce0478b3e1464a9
Reviewed-on: https://code.wireshark.org/review/26278
Reviewed-by: Gerald Combs 


Actions performed:

from  a1da75c   Transition from GeoIP Legacy to MaxMindDB.
adds  2eb6f3b   CMake: Remove SH from the packate list.


Summary of changes:
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b0b87e4: IEEE 802.15.4: individual functions for MHR/PIE/payload processing

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b0b87e4b5f8dbdd69c515d63fa4413347179beb4
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

b0b87e4 by Robert Sauter (sau...@locoslab.com):

IEEE 802.15.4: individual functions for MHR/PIE/payload processing

- reduce scope of special handling for ZBOSS and 'options'
- move -2015 command byte handling to corresponding function
- fix data handling for unimplemented command types

Rationale: this allows reusing the individual functions for protocols
that are based on IEEE 802.15.4 but require additional transformation
of the payload without adding special cases within the functions.

Change-Id: I5447620f6779031c4f9b280b16de9678b255b06f
Reviewed-on: https://code.wireshark.org/review/26262
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Ed Beroset 
Reviewed-by: Anders Broman 


Actions performed:

from  99240e6   Docs: Updates for xsltproc and Asciidoctor.
adds  b0b87e4   IEEE 802.15.4: individual functions for MHR/PIE/payload 
processing


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 259 ++--
 epan/dissectors/packet-ieee802154.h |  49 ++-
 2 files changed, 209 insertions(+), 99 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a1da75c: Transition from GeoIP Legacy to MaxMindDB.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a1da75c554881667dd92e11f098630f2d604872b
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

a1da75c by Gerald Combs (ger...@wireshark.org):

Transition from GeoIP Legacy to MaxMindDB.

MaxMind is discontinuing its legacy databases in April in favor of
GeoIP2, which use a newer database format (MaxMind DB). The reference C
library (libmaxminddb) is available under the Apache 2.0 license which
isn't quite compatible with ours.

Add mmdbresolve, a utility that reads IPv4 and IPv6 addresses on stdin
and prints resolved information on stdout. Place it under a liberal
license (MIT) so that we can keep libmaxminddb at arm's length. Add
epan/maxmind_db.[ch], which spawns mmdbresolve and communicates with it
via stdio.

Migrate the preferences and documentation to MaxMindDB.

Change the IPv4 and IPv6 asnum fields to FT_UINT32s. Change the
geographic coordinate fields to FT_DOUBLEs.

Bug: 10658
Change-Id: I24aeed637bea1b41d173270bda413af230f4425f
Reviewed-on: https://code.wireshark.org/review/26214
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 


Actions performed:

from  b2d3680   CMake: Remove FindSH.
adds  a1da75c   Transition from GeoIP Legacy to MaxMindDB.


Summary of changes:
 CMakeLists.txt|  34 +-
 CMakeOptions.txt  |   2 +-
 Makefile.am   |   9 +-
 README.macos  |   7 -
 acinclude.m4  |  32 +-
 cmake/modules/FindGEOIP.cmake |  74 ---
 cmake/modules/FindMaxMindDB.cmake |  74 +++
 cmakeconfig.h.in  |  10 +-
 configure.ac  |  42 +-
 debian/control|   4 +-
 debian/libwireshark-data.install  |   2 +-
 debian/libwireshark0.symbols  |   9 +-
 debian/{geoip_db_paths => maxmind_db_paths}   |   0
 doc/CMakeLists.txt|  29 +-
 doc/Makefile.am   |  13 +-
 doc/mmdbresolve.pod   |  69 +++
 docbook/release-notes.asciidoc|   2 +
 docbook/wsdg_src/WSDG_chapter_libraries.asciidoc  |  23 +-
 docbook/wsug_src/WSUG_chapter_customize.asciidoc  |  41 +-
 docbook/wsug_src/WSUG_chapter_statistics.asciidoc |  11 +-
 docbook/wsug_src/WSUG_chapter_use.asciidoc|   7 +-
 epan/CMakeLists.txt   |   9 +-
 epan/Makefile.am  |   9 +-
 epan/addr_resolv.c|  10 +-
 epan/addr_resolv.h|   6 +
 epan/dissectors/Makefile.am   |   2 +-
 epan/dissectors/packet-ip.c   | 271 -
 epan/dissectors/packet-ipv6.c | 285 +-
 epan/epan.c   |  10 +-
 epan/geoip_db.c   | 638 --
 epan/geoip_db.h   | 104 
 epan/maxmind_db.c | 513 +
 epan/maxmind_db.h |  93 
 epan/prefs.c  |   8 +-
 mmdbresolve.c | 169 ++
 packaging/macosx/Scripts/cli-postinstall.sh   |   1 +
 packaging/nsis/CMakeLists.txt |   7 +-
 packaging/nsis/uninstall.nsi  |  18 +-
 packaging/nsis/wireshark.nsi  |   8 +
 packaging/rpm/SPECS/wireshark.spec.in |   4 +-
 packaging/wix/CMakeLists.txt  |  13 +-
 packaging/wix/ComponentGroups.wxi |  18 +
 packaging/wix/Features.wxi|   3 +
 tools/Get-HardenFlags.ps1 |   2 +-
 tools/debian-setup.sh |   6 +-
 tools/install_rpms_for_devel.sh   |   6 +-
 tools/macos-setup.sh  |  88 ++-
 tools/pre-commit-ignore.conf  |   1 +
 tools/rpm_setup.sh|   4 +-
 tools/win-setup.ps1   |   4 +-
 tshark.c  |  12 +-
 ui/qt/endpoint_dialog.cpp | 176 +++---
 ui/qt/endpoint_dialog.h   |  18 +-
 ui/traffic_table_ui.c |   8 +-
 ui/traffic_table_ui.h |   9 +-
 55 files changed, 1524 insertions(+), 1503 deletions(-)
 delete mode 100644 cmake/modules/FindGEOIP.cmake
 create mode 100644 

[Wireshark-commits] master f52bb2b: CMake: Fixup our Chocolatey bin path discovery.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f52bb2bf27cc55285398bbf6acb1884b10b8d3a4
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

f52bb2b by Gerald Combs (ger...@wireshark.org):

CMake: Fixup our Chocolatey bin path discovery.

Search for choco.exe directly instead of using PATHS + PATH_SUFFIXES.
Look in %ChocolateyInstall%\bin first. CHOCOLATEY_BIN_PATH is the binary
path. There's no need to append /bin to it.

Change-Id: I732db398bd989bf1a5cee2c79c0bd4161638
Reviewed-on: https://code.wireshark.org/review/26276
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 


Actions performed:

from  2eb6f3b   CMake: Remove SH from the packate list.
adds  f52bb2b   CMake: Fixup our Chocolatey bin path discovery.


Summary of changes:
 cmake/modules/FindAsciidoctor.cmake |  2 +-
 cmake/modules/FindChocolatey.cmake  | 26 --
 cmake/modules/FindLEX.cmake |  2 +-
 cmake/modules/FindXSLTPROC.cmake|  3 ++-
 cmake/modules/FindYACC.cmake|  2 +-
 5 files changed, 21 insertions(+), 14 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 99240e6: Docs: Updates for xsltproc and Asciidoctor.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99240e62bfad757cd50ac0fc38ce6e75ea3debc0
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

99240e6 by Gerald Combs (ger...@wireshark.org):

Docs: Updates for xsltproc and Asciidoctor.

Change-Id: I3cfe2121beaab0fe09228ec277997d68fe824693
Reviewed-on: https://code.wireshark.org/review/26281
Reviewed-by: Gerald Combs 


Actions performed:

from  f52bb2b   CMake: Fixup our Chocolatey bin path discovery.
adds  99240e6   Docs: Updates for xsltproc and Asciidoctor.


Summary of changes:
 docbook/wsdg_src/WSDG_chapter_quick_setup.asciidoc | 21 ++---
 docbook/wsdg_src/WSDG_chapter_tools.asciidoc   | 55 ++
 2 files changed, 60 insertions(+), 16 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b2d3680: CMake: Remove FindSH.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b2d3680558d19998c55b48e9807a26e145756eba
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

b2d3680 by Gerald Combs (ger...@wireshark.org):

CMake: Remove FindSH.

We haven't used SH_EXECUTABLE since the Asciidoctor migration.

Change-Id: I93e8245ea02ed994ebb62942d5ea4ec890e35a97
Reviewed-on: https://code.wireshark.org/review/26277
Reviewed-by: Gerald Combs 


Actions performed:

from  69ddfec   ipsec: zero memory in get_full_ipv6_addr (found by clang).
adds  b2d3680   CMake: Remove FindSH.


Summary of changes:
 cmake/modules/FindSH.cmake | 36 
 1 file changed, 36 deletions(-)
 delete mode 100644 cmake/modules/FindSH.cmake
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f0f4adc: maxmind_db.c: add an explicit cast to please gcc 7.3.1

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0f4adc9d9962376b545a72f5448be8f51676725
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

f0f4adc by Pascal Quantin (pascal.quan...@gmail.com):

maxmind_db.c: add an explicit cast to please gcc 7.3.1

Change-Id: Idb2ae052804fb523d6769fe50b5bb4ba45e40f79
Reviewed-on: https://code.wireshark.org/review/26283
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 


Actions performed:

from  b0b87e4   IEEE 802.15.4: individual functions for MHR/PIE/payload 
processing
adds  f0f4adc   maxmind_db.c: add an explicit cast to please gcc 7.3.1


Summary of changes:
 epan/maxmind_db.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 98ab887: TN3270: fix memory leaks in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=98ab887a2d4ffbe7b255655c510b676c32e93608
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

98ab887 by Pascal Quantin (pascal.quan...@gmail.com):

TN3270: fix memory leaks in conversation management

Bug: 14480
Change-Id: I9148bef80492426195a1673f8367a39c02c432ce
Reviewed-on: https://code.wireshark.org/review/26285
Reviewed-by: Pascal Quantin 
Reviewed-by: Guy Harris 


Actions performed:

from  76267f4   maxmind_db.c: fix a memory leak
adds  98ab887   TN3270: fix memory leaks in conversation management


Summary of changes:
 epan/dissectors/packet-tn3270.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f0fb6ee: mmdbresolve: Process our command line arguments by hand.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0fb6ee50c953ac07eb76d47036a761a57f35491
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

f0fb6ee by Gerald Combs (ger...@wireshark.org):

mmdbresolve: Process our command line arguments by hand.

Visual Studio doesn't ship with a getopt implementation, so process our
arguments ourselves. Note that if we add support for more flags we'll
probably want to use GOption.

Change-Id: Ie78204aa64321ca68f3e66195b8c39e47ca410d9
Reviewed-on: https://code.wireshark.org/review/26288
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 


Actions performed:

from  0ddaec1   Get rid of unused information.
adds  f0fb6ee   mmdbresolve: Process our command line arguments by hand.


Summary of changes:
 mmdbresolve.c | 28 +++-
 1 file changed, 15 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e3c263c: NSIS, WiX: Handle the presence or absence of mmdbresolve.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3c263c01236e7c31ec23f6c3d8750d7e92fb5a3
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

e3c263c by Gerald Combs (ger...@wireshark.org):

NSIS, WiX: Handle the presence or absence of mmdbresolve.

Only install mmdbresolve if MAXMINDDB_FOUND is true.

Fixup the Qt about box and WiX GTK defines while we're here.

Change-Id: I7ac3c21ddb4aebc1dae1c3d8cfd2bcafc4139d2e
Reviewed-on: https://code.wireshark.org/review/26299
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 


Actions performed:

from  f0fb6ee   mmdbresolve: Process our command line arguments by hand.
adds  e3c263c   NSIS, WiX: Handle the presence or absence of mmdbresolve.


Summary of changes:
 packaging/nsis/config.nsh.in  |  4 ++--
 packaging/nsis/uninstall.nsi  |  5 -
 packaging/nsis/wireshark.nsi  |  2 ++
 packaging/wix/CMakeLists.txt  | 13 +
 packaging/wix/ComponentGroups.wxi |  4 +++-
 packaging/wix/Features.wxi|  2 ++
 packaging/wix/WiresharkOptionsDlg.wxs |  2 ++
 ui/qt/about_dialog.cpp| 16 +++-
 8 files changed, 31 insertions(+), 17 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 b12cc58: TN3270: fix memory leaks in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b12cc581cd4878d74b6116ca02c7dbe650c1f242
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

b12cc58 by Pascal Quantin (pascal.quan...@gmail.com):

TN3270: fix memory leaks in conversation management

Bug: 14480
Change-Id: I9148bef80492426195a1673f8367a39c02c432ce
Reviewed-on: https://code.wireshark.org/review/26285
Reviewed-by: Pascal Quantin 
Reviewed-by: Guy Harris 
(cherry picked from commit 98ab887a2d4ffbe7b255655c510b676c32e93608)
Reviewed-on: https://code.wireshark.org/review/26297


Actions performed:

from  f05c3b9   VLAN: define a recursion depth limit
adds  b12cc58   TN3270: fix memory leaks in conversation management


Summary of changes:
 epan/dissectors/packet-tn3270.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 e932ab6: TN3270: fix memory leaks in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e932ab64900d743a3ecfc731c96eb05a67eebf2d
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

e932ab6 by Pascal Quantin (pascal.quan...@gmail.com):

TN3270: fix memory leaks in conversation management

Bug: 14480
Change-Id: I9148bef80492426195a1673f8367a39c02c432ce
Reviewed-on: https://code.wireshark.org/review/26285
Reviewed-by: Pascal Quantin 
Reviewed-by: Guy Harris 
(cherry picked from commit 98ab887a2d4ffbe7b255655c510b676c32e93608)
Reviewed-on: https://code.wireshark.org/review/26296


Actions performed:

from  7929700   VLAN: define a recursion depth limit
adds  e932ab6   TN3270: fix memory leaks in conversation management


Summary of changes:
 epan/dissectors/packet-tn3270.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fd62e50: Eliminate unused structure members and an unused list.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd62e506b93cb2d9d7d77d7282e522532c70025b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

fd62e50 by Guy Harris (g...@alum.mit.edu):

Eliminate unused structure members and an unused list.

We don't use the addresses, and don't use the inbound port.

We also don't need a list of tn5250_conv_info_t's - they're allocated
with wmem, so they get freed when we're done with a file, and they're
attached to conversations, so we don't need a list to find them.

Change-Id: Id3b44fb11cf353d7d15a58938883f2460cf642a0
Reviewed-on: https://code.wireshark.org/review/26301
Reviewed-by: Guy Harris 


Actions performed:

from  e3c263c   NSIS, WiX: Handle the presence or absence of mmdbresolve.
adds  fd62e50   Eliminate unused structure members and an unused list.


Summary of changes:
 epan/dissectors/packet-tn5250.c | 10 --
 1 file changed, 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 76267f4: maxmind_db.c: fix a memory leak

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76267f4bc5d8c62eaf72af6a8a2fbadeb75730c2
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

76267f4 by Pascal Quantin (pascal.quan...@gmail.com):

maxmind_db.c: fix a memory leak

Change-Id: Ie3484e863363a8d2b9ccb43506020678d15d
Reviewed-on: https://code.wireshark.org/review/26284
Petri-Dish: Pascal Quantin 
Reviewed-by: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 


Actions performed:

from  f0f4adc   maxmind_db.c: add an explicit cast to please gcc 7.3.1
adds  76267f4   maxmind_db.c: fix a memory leak


Summary of changes:
 epan/maxmind_db.c | 1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0ddaec1: Get rid of unused information.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ddaec13a162c01928e310c4f92532cdb70d45c0
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

0ddaec1 by Guy Harris (g...@alum.mit.edu):

Get rid of unused information.

We only need to know the outbound port, so we can determine whether this
is to or from the host.

Fix a comment to reflect reality while we're at it.

Change-Id: If01df5aeb73900850a0de9f9f9731c6fa7f094bb
Reviewed-on: https://code.wireshark.org/review/26298
Reviewed-by: Guy Harris 


Actions performed:

from  98ab887   TN3270: fix memory leaks in conversation management
adds  0ddaec1   Get rid of unused information.


Summary of changes:
 epan/dissectors/packet-tn3270.c | 10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 89a715e: SMB1/2: Update some FileFS fields with new flags

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=89a715eba45d89bd65ee9a190bb1300ac6ea6fd4
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

89a715e by Ronnie Sahlberg (ronniesahlb...@gmail.com):

SMB1/2: Update some FileFS fields with new flags

Change-Id: I7fbf874c8f9f7fcbcdecd07b04762688d080b961
Signed-off-by: Ronnie Sahlberg 
Reviewed-on: https://code.wireshark.org/review/26300
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte 


Actions performed:

from  05c4705   multipart: use packet scope memory to avoid leaking in case 
an exception is triggered by subdissectors
adds  89a715e   SMB1/2: Update some FileFS fields with new flags


Summary of changes:
 epan/dissectors/packet-smb.c  | 117 +-
 epan/dissectors/packet-smb2.c |  14 ++---
 2 files changed, 123 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8f81eb2: H223: fix a memory leak in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f81eb2cf671573461ccba3bde6ce5ec99016afa
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

8f81eb2 by Pascal Quantin (pascal.quan...@gmail.com):

H223: fix a memory leak in conversation management

Bug: 14487
Change-Id: I75089ccfa2896b357f775fea67fd6b76500fc5dc
Reviewed-on: https://code.wireshark.org/review/26292
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 


Actions performed:

from  89a715e   SMB1/2: Update some FileFS fields with new flags
adds  8f81eb2   H223: fix a memory leak in conversation management


Summary of changes:
 epan/dissectors/packet-h223.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 035f49d: PCP: allocate conversation info in file scope

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=035f49d2c85ff9e0bab74e5af4c990ab2beea170
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

035f49d by Pascal Quantin (pascal.quan...@gmail.com):

PCP: allocate conversation info in file scope

Bug: 14488
Change-Id: I9bb85cfd58ace721ba8b957bc3351f6c017a8b69
Reviewed-on: https://code.wireshark.org/review/26293
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 


Actions performed:

from  8f81eb2   H223: fix a memory leak in conversation management
adds  035f49d   PCP: allocate conversation info in file scope


Summary of changes:
 epan/dissectors/packet-pcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b94d3af: failure_message.c: fix a memory leak if err is not negative

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b94d3af3039b8bdfbd4d760fda412fdfa121b732
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

b94d3af by Pascal Quantin (pascal.quan...@gmail.com):

failure_message.c: fix a memory leak if err is not negative

Bug: 14489
Change-Id: I958cfae824c50263913ba9df8128e34e9466cb67
Reviewed-on: https://code.wireshark.org/review/26294
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: ronnie sahlberg 
Reviewed-by: Anders Broman 


Actions performed:

from  035f49d   PCP: allocate conversation info in file scope
adds  b94d3af   failure_message.c: fix a memory leak if err is not negative


Summary of changes:
 ui/failure_message.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 68216fa: IEEE 802.15.4: Add expert warning for Payload IE in header

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=68216fa2da7bf608441356593a5059913c7e1a97
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

68216fa by Ed Beroset (bero...@ieee.org):

IEEE 802.15.4: Add expert warning for Payload IE in header

Change-Id: I34f4814ff0a93f9ef149241fd9899b50199955c5
Reviewed-on: https://code.wireshark.org/review/26280
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  b94d3af   failure_message.c: fix a memory leak if err is not negative
adds  68216fa   IEEE 802.15.4: Add expert warning for Payload IE in header


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 17919a8: multipart: use packet scope memory to avoid leaking in case an exception is triggered by subdissectors

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17919a807642791f707361c978bcd612fdce5b67
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

17919a8 by Pascal Quantin (pascal.quan...@gmail.com):

multipart: use packet scope memory to avoid leaking in case an exception is 
triggered by subdissectors

Bug: 14486
Change-Id: I275f8c962f126ad55fc7086012e7b67cc0dc60b3
Reviewed-on: https://code.wireshark.org/review/26291
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit 05c4705a19448646ca316ba3b1eb333a05482956)
Reviewed-on: https://code.wireshark.org/review/26313


Actions performed:

from  fd1b382   GIOP: use wmem packet scope for get_modname_from_repoid()
adds  17919a8   multipart: use packet scope memory to avoid leaking in case 
an exception is triggered by subdissectors


Summary of changes:
 epan/dissectors/packet-multipart.c | 16 +++-
 1 file changed, 11 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 046ff3a: oids.c: fix a memory leak in oid_string2subid()

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=046ff3a15c8a893d5424a512f3be7e64b83cf4e2
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

046ff3a by Pascal Quantin (pascal.quan...@gmail.com):

oids.c: fix a memory leak in oid_string2subid()

Bug: 14485
Change-Id: Ia0ccd4480808c4f5da228975c7a076cd3f5d332b
Reviewed-on: https://code.wireshark.org/review/26290
Reviewed-by: Pascal Quantin 
Reviewed-by: ronnie sahlberg 
(cherry picked from commit f46d129f21ee0c2b43545c500a8ea4dbc4d59815)
Reviewed-on: https://code.wireshark.org/review/26303


Actions performed:

from  e932ab6   TN3270: fix memory leaks in conversation management
adds  046ff3a   oids.c: fix a memory leak in oid_string2subid()


Summary of changes:
 epan/oids.c | 1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 0fbc50f: oids.c: fix a memory leak in oid_string2subid()

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0fbc50f9b9219be54d6db47f04b65af19696a7c7
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

0fbc50f by Pascal Quantin (pascal.quan...@gmail.com):

oids.c: fix a memory leak in oid_string2subid()

Bug: 14485
Change-Id: Ia0ccd4480808c4f5da228975c7a076cd3f5d332b
Reviewed-on: https://code.wireshark.org/review/26290
Reviewed-by: Pascal Quantin 
Reviewed-by: ronnie sahlberg 
(cherry picked from commit f46d129f21ee0c2b43545c500a8ea4dbc4d59815)
Reviewed-on: https://code.wireshark.org/review/26304


Actions performed:

from  b12cc58   TN3270: fix memory leaks in conversation management
adds  0fbc50f   oids.c: fix a memory leak in oid_string2subid()


Summary of changes:
 epan/oids.c | 1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 fd1b382: GIOP: use wmem packet scope for get_modname_from_repoid()

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd1b382eef17416d7eb2c9ddcd78553a1d3bd402
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

fd1b382 by Pascal Quantin (pascal.quan...@gmail.com):

GIOP: use wmem packet scope for get_modname_from_repoid()

Bug: 14484
Change-Id: Ie2a4cc179ba25a1e3e50d689e21f003001a301fa
Reviewed-on: https://code.wireshark.org/review/26289
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit 4581eb2de2e5aacfc9a2224df181010dc8e6141b)
Reviewed-on: https://code.wireshark.org/review/26311


Actions performed:

from  e62b1d3   LAPD: fix some memory leaks in conversation management
adds  fd1b382   GIOP: use wmem packet scope for get_modname_from_repoid()


Summary of changes:
 epan/dissectors/packet-giop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bf4e620: LAPD: fix some memory leaks in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf4e620e2d15689e8582425224160f39dcc8589c
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

bf4e620 by Pascal Quantin (pascal.quan...@gmail.com):

LAPD: fix some memory leaks in conversation management

Bug: 14482
Change-Id: Ia49705e13f1071a69d61ba1d6bd331e3e7734d81
Reviewed-on: https://code.wireshark.org/review/26287
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 


Actions performed:

from  4945c50   SMB2: use file scope to avoid leaking memory
adds  bf4e620   LAPD: fix some memory leaks in conversation management


Summary of changes:
 epan/dissectors/packet-lapd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4581eb2: GIOP: use wmem packet scope for get_modname_from_repoid()

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4581eb2de2e5aacfc9a2224df181010dc8e6141b
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4581eb2 by Pascal Quantin (pascal.quan...@gmail.com):

GIOP: use wmem packet scope for get_modname_from_repoid()

Bug: 14484
Change-Id: Ie2a4cc179ba25a1e3e50d689e21f003001a301fa
Reviewed-on: https://code.wireshark.org/review/26289
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 


Actions performed:

from  bf4e620   LAPD: fix some memory leaks in conversation management
adds  4581eb2   GIOP: use wmem packet scope for get_modname_from_repoid()


Summary of changes:
 epan/dissectors/packet-giop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 05c4705: multipart: use packet scope memory to avoid leaking in case an exception is triggered by subdissectors

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=05c4705a19448646ca316ba3b1eb333a05482956
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

05c4705 by Pascal Quantin (pascal.quan...@gmail.com):

multipart: use packet scope memory to avoid leaking in case an exception is 
triggered by subdissectors

Bug: 14486
Change-Id: I275f8c962f126ad55fc7086012e7b67cc0dc60b3
Reviewed-on: https://code.wireshark.org/review/26291
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 


Actions performed:

from  4581eb2   GIOP: use wmem packet scope for get_modname_from_repoid()
adds  05c4705   multipart: use packet scope memory to avoid leaking in case 
an exception is triggered by subdissectors


Summary of changes:
 epan/dissectors/packet-multipart.c | 16 +++-
 1 file changed, 11 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 8ed057f: LAPD: fix some memory leaks in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ed057f7faa709dbde34b91f0715a957837f74d9
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8ed057f by Pascal Quantin (pascal.quan...@gmail.com):

LAPD: fix some memory leaks in conversation management

Bug: 14482
Change-Id: Ia49705e13f1071a69d61ba1d6bd331e3e7734d81
Reviewed-on: https://code.wireshark.org/review/26287
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit bf4e620e2d15689e8582425224160f39dcc8589c)
Reviewed-on: https://code.wireshark.org/review/26310


Actions performed:

from  9d3714e   ISUP: plug some memory leaks
adds  8ed057f   LAPD: fix some memory leaks in conversation management


Summary of changes:
 epan/dissectors/packet-lapd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f38e895: Plug another leak for Wiretap errors.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f38e895dfc0d97bce64f73ce99df706911d9aa07
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

f38e895 by Guy Harris (g...@alum.mit.edu):

Plug another leak for Wiretap errors.

Clean up comments while we're at it.

Change-Id: I7e218ba3f998804045e3d7fab08d85d09a293d69
Reviewed-on: https://code.wireshark.org/review/26320
Reviewed-by: Guy Harris 


Actions performed:

from  68216fa   IEEE 802.15.4: Add expert warning for Payload IE in header
adds  f38e895   Plug another leak for Wiretap errors.


Summary of changes:
 ui/failure_message.c | 18 ++
 1 file changed, 10 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 ac8a807: Plug another leak for Wiretap errors.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac8a807c062c5fc85959b3baa59faac699de6763
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

ac8a807 by Guy Harris (g...@alum.mit.edu):

Plug another leak for Wiretap errors.

Clean up comments while we're at it.

Change-Id: I7e218ba3f998804045e3d7fab08d85d09a293d69
Reviewed-on: https://code.wireshark.org/review/26320
Reviewed-by: Guy Harris 
(cherry picked from commit f38e895dfc0d97bce64f73ce99df706911d9aa07)
Reviewed-on: https://code.wireshark.org/review/26321


Actions performed:

from  211845a   failure_message.c: fix a memory leak if err is not negative
adds  ac8a807   Plug another leak for Wiretap errors.


Summary of changes:
 ui/failure_message.c | 18 ++
 1 file changed, 10 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f46d129: oids.c: fix a memory leak in oid_string2subid()

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f46d129f21ee0c2b43545c500a8ea4dbc4d59815
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

f46d129 by Pascal Quantin (pascal.quan...@gmail.com):

oids.c: fix a memory leak in oid_string2subid()

Bug: 14485
Change-Id: Ia0ccd4480808c4f5da228975c7a076cd3f5d332b
Reviewed-on: https://code.wireshark.org/review/26290
Reviewed-by: Pascal Quantin 
Reviewed-by: ronnie sahlberg 


Actions performed:

from  fd62e50   Eliminate unused structure members and an unused list.
adds  f46d129   oids.c: fix a memory leak in oid_string2subid()


Summary of changes:
 epan/oids.c | 1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 e877164: H223: fix a memory leak in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e877164479432f63e1507c0034ae6222ace0a49b
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

e877164 by Pascal Quantin (pascal.quan...@gmail.com):

H223: fix a memory leak in conversation management

Bug: 14487
Change-Id: I75089ccfa2896b357f775fea67fd6b76500fc5dc
Reviewed-on: https://code.wireshark.org/review/26292
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit 8f81eb2cf671573461ccba3bde6ce5ec99016afa)
Reviewed-on: https://code.wireshark.org/review/26315


Actions performed:

from  17919a8   multipart: use packet scope memory to avoid leaking in case 
an exception is triggered by subdissectors
adds  e877164   H223: fix a memory leak in conversation management


Summary of changes:
 epan/dissectors/packet-h223.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 9d3714e: ISUP: plug some memory leaks

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d3714e767cb104dcfa1647935fa5960b16bb8e1
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

9d3714e by Pascal Quantin (pascal.quan...@gmail.com):

ISUP: plug some memory leaks

Bug: 14481
Change-Id: I940dc4c7ac197deb1f925418bbcdebb30285a775
Reviewed-on: https://code.wireshark.org/review/26286
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit 1b18b1dd0e171ec660ad1ce5d47bab80ddc3da86)
Reviewed-on: https://code.wireshark.org/review/26306


Actions performed:

from  0fbc50f   oids.c: fix a memory leak in oid_string2subid()
adds  9d3714e   ISUP: plug some memory leaks


Summary of changes:
 epan/dissectors/packet-isup.c | 2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 154fa52: ISUP: plug some memory leaks

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=154fa52bf91b012f802ee9939c8a2e99554ab2f9
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

154fa52 by Pascal Quantin (pascal.quan...@gmail.com):

ISUP: plug some memory leaks

Bug: 14481
Change-Id: I940dc4c7ac197deb1f925418bbcdebb30285a775
Reviewed-on: https://code.wireshark.org/review/26286
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit 1b18b1dd0e171ec660ad1ce5d47bab80ddc3da86)
Reviewed-on: https://code.wireshark.org/review/26305


Actions performed:

from  046ff3a   oids.c: fix a memory leak in oid_string2subid()
adds  154fa52   ISUP: plug some memory leaks


Summary of changes:
 epan/dissectors/packet-isup.c | 2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 211845a: failure_message.c: fix a memory leak if err is not negative

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=211845aba4794720ae265c782cdffddae54a3e7a
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

211845a by Pascal Quantin (pascal.quan...@gmail.com):

failure_message.c: fix a memory leak if err is not negative

Bug: 14489
Change-Id: I958cfae824c50263913ba9df8128e34e9466cb67
Reviewed-on: https://code.wireshark.org/review/26294
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: ronnie sahlberg 
Reviewed-by: Anders Broman 
(cherry picked from commit b94d3af3039b8bdfbd4d760fda412fdfa121b732)
Reviewed-on: https://code.wireshark.org/review/26319


Actions performed:

from  cdd0eb0   PCP: allocate conversation info in file scope
adds  211845a   failure_message.c: fix a memory leak if err is not negative


Summary of changes:
 ui/failure_message.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 1f8f145: PCP: allocate conversation info in file scope

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f8f1456f1e73b6c09e50a64749e43413ac12df7
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

1f8f145 by Pascal Quantin (pascal.quan...@gmail.com):

PCP: allocate conversation info in file scope

Bug: 14488
Change-Id: I9bb85cfd58ace721ba8b957bc3351f6c017a8b69
Reviewed-on: https://code.wireshark.org/review/26293
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit 035f49d2c85ff9e0bab74e5af4c990ab2beea170)
Reviewed-on: https://code.wireshark.org/review/26318


Actions performed:

from  6e3b908   H223: fix a memory leak in conversation management
adds  1f8f145   PCP: allocate conversation info in file scope


Summary of changes:
 epan/dissectors/packet-pcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4945c50: SMB2: use file scope to avoid leaking memory

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4945c50d3f8269c56d9d087d16d080144de146dc
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4945c50 by Pascal Quantin (pascal.quan...@gmail.com):

SMB2: use file scope to avoid leaking memory

Bug: 14483
Change-Id: I1532fa57cd9a847c0408db95744eb7af3a6f4ee5
Reviewed-on: https://code.wireshark.org/review/26295
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: ronnie sahlberg 


Actions performed:

from  cc764b9   Add additional dissect information in the ZCL Level Control 
Cluster.
adds  4945c50   SMB2: use file scope to avoid leaking memory


Summary of changes:
 epan/dissectors/packet-smb2.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master cc764b9: Add additional dissect information in the ZCL Level Control Cluster.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc764b92acc65f7727fc53180a09ba2088a8751b
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

cc764b9 by Paul Zander (p.j.zan...@lighting.com):

Add additional dissect information in the ZCL Level Control Cluster.

Change-Id: I46f5ee8cc0aff39a01289be5f9cea86640f0a72d
Reviewed-on: https://code.wireshark.org/review/26282
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte 


Actions performed:

from  1b18b1d   ISUP: plug some memory leaks
adds  cc764b9   Add additional dissect information in the ZCL Level Control 
Cluster.


Summary of changes:
 epan/dissectors/packet-zbee-zcl-general.c | 38 ++-
 1 file changed, 37 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1b18b1d: ISUP: plug some memory leaks

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b18b1dd0e171ec660ad1ce5d47bab80ddc3da86
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

1b18b1d by Pascal Quantin (pascal.quan...@gmail.com):

ISUP: plug some memory leaks

Bug: 14481
Change-Id: I940dc4c7ac197deb1f925418bbcdebb30285a775
Reviewed-on: https://code.wireshark.org/review/26286
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 


Actions performed:

from  f46d129   oids.c: fix a memory leak in oid_string2subid()
adds  1b18b1d   ISUP: plug some memory leaks


Summary of changes:
 epan/dissectors/packet-isup.c | 2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 e62b1d3: LAPD: fix some memory leaks in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e62b1d33b35f160eb611ea3d093823fbba841c00
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

e62b1d3 by Pascal Quantin (pascal.quan...@gmail.com):

LAPD: fix some memory leaks in conversation management

Bug: 14482
Change-Id: Ia49705e13f1071a69d61ba1d6bd331e3e7734d81
Reviewed-on: https://code.wireshark.org/review/26287
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit bf4e620e2d15689e8582425224160f39dcc8589c)
Reviewed-on: https://code.wireshark.org/review/26309


Actions performed:

from  154fa52   ISUP: plug some memory leaks
adds  e62b1d3   LAPD: fix some memory leaks in conversation management


Summary of changes:
 epan/dissectors/packet-lapd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 6e3b908: H223: fix a memory leak in conversation management

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e3b90824a82724f445a0374e99f0b76e4cf5e8b
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

6e3b908 by Pascal Quantin (pascal.quan...@gmail.com):

H223: fix a memory leak in conversation management

Bug: 14487
Change-Id: I75089ccfa2896b357f775fea67fd6b76500fc5dc
Reviewed-on: https://code.wireshark.org/review/26292
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit 8f81eb2cf671573461ccba3bde6ce5ec99016afa)
Reviewed-on: https://code.wireshark.org/review/26316


Actions performed:

from  8ed057f   LAPD: fix some memory leaks in conversation management
adds  6e3b908   H223: fix a memory leak in conversation management


Summary of changes:
 epan/dissectors/packet-h223.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 cdd0eb0: PCP: allocate conversation info in file scope

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cdd0eb0b22c0cc21d0ff81b20d00fff543f4a9a4
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

cdd0eb0 by Pascal Quantin (pascal.quan...@gmail.com):

PCP: allocate conversation info in file scope

Bug: 14488
Change-Id: I9bb85cfd58ace721ba8b957bc3351f6c017a8b69
Reviewed-on: https://code.wireshark.org/review/26293
Reviewed-by: Pascal Quantin 
Reviewed-by: Anders Broman 
(cherry picked from commit 035f49d2c85ff9e0bab74e5af4c990ab2beea170)
Reviewed-on: https://code.wireshark.org/review/26317


Actions performed:

from  e877164   H223: fix a memory leak in conversation management
adds  cdd0eb0   PCP: allocate conversation info in file scope


Summary of changes:
 epan/dissectors/packet-pcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 ae013fe: SMB2: use file scope to avoid leaking memory

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae013fe3dd6f3b192b1e184d5c436a349816d5e0
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ae013fe by Pascal Quantin (pascal.quan...@gmail.com):

SMB2: use file scope to avoid leaking memory

Bug: 14483
Change-Id: I1532fa57cd9a847c0408db95744eb7af3a6f4ee5
Reviewed-on: https://code.wireshark.org/review/26295
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: ronnie sahlberg 
(cherry picked from commit 4945c50d3f8269c56d9d087d16d080144de146dc)
Reviewed-on: https://code.wireshark.org/review/26308
Reviewed-by: Anders Broman 


Actions performed:

from  1f8f145   PCP: allocate conversation info in file scope
adds  ae013fe   SMB2: use file scope to avoid leaking memory


Summary of changes:
 epan/dissectors/packet-smb2.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1867143: dcm: Fixed crash in dissector, and other bugs Some tag descriptions which are added to the parent item (32 tags). If one of those was empty a crash occurred. Mainly

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=186714314d546c2155cb0942724e8bafb9bd879f
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

1867143 by david-aggeler (david_agge...@yahoo.com):

dcm: Fixed crash in dissector, and other bugs Some tag descriptions which 
are added to the parent item (32 tags). If one of those was empty a crash 
occurred. Mainly the RTPlan modality was affected.

Fixed length decoding for OD, OL, UC, UR Fixed hf_dcm_assoc_item_type to be 
interpreted as 1 byte
Fixed pdu_type to be interpreted as 1 byte
Fixed decoding of AT type, where value length was wrongly reported in 
capture as 2 (instead of n*4)
Removed tailing white spaces
Please merge to 2.4 once ok.

Bug: 14415
Change-Id: I7857ef107e7e599c7dd9f8d069daa5b3bfb4122f
Reviewed-on: https://code.wireshark.org/review/26268
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  0632770   Use the generic function decode_zcl_time_in_100ms instead 
of the local zcl_fmt_time_tenths.
adds  1867143   dcm: Fixed crash in dissector, and other bugs Some tag 
descriptions which are added to the parent item (32 tags). If one of those was 
empty a crash occurred. Mainly the RTPlan modality was affected.


Summary of changes:
 epan/dissectors/packet-dcm.c | 395 +--
 1 file changed, 226 insertions(+), 169 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 69ddfec: ipsec: zero memory in get_full_ipv6_addr (found by clang).

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69ddfecb7605683ddb194a9d0e19dedeffbd4a08
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

69ddfec by Dario Lombardo (lom...@gmail.com):

ipsec: zero memory in get_full_ipv6_addr (found by clang).

Change-Id: I5a1c8cccd40867b70e64c8763a56da6a77c164b2
Reviewed-on: https://code.wireshark.org/review/26116
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo 


Actions performed:

from  1867143   dcm: Fixed crash in dissector, and other bugs Some tag 
descriptions which are added to the parent item (32 tags). If one of those was 
empty a crash occurred. Mainly the RTPlan modality was affected.
adds  69ddfec   ipsec: zero memory in get_full_ipv6_addr (found by clang).


Summary of changes:
 epan/dissectors/packet-ipsec.c | 2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 7929700: VLAN: define a recursion depth limit

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7929700033eb41fc49fc637ec039ad0a262443e3
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

7929700 by Pascal Quantin (pascal.quan...@gmail.com):

VLAN: define a recursion depth limit

Altough the dissection consumes 4 bytes each time it is called, it can
trigger a stack overflow for big packets. Let's limmit the number of
allowed VLAN tags for a given packet.

Bug: 14469
Change-Id: Ieb6834ab3350dc7e8c301e6479577855a253897e
Reviewed-on: https://code.wireshark.org/review/26270
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte 
(cherry picked from commit b434e0a03be45ed796af7271972672a0b43cffa8)
Reviewed-on: https://code.wireshark.org/review/26272
Reviewed-by: Pascal Quantin 


Actions performed:

from  1c9adc6   NBAP: avoid linking a DCH-ID to itself
adds  7929700   VLAN: define a recursion depth limit


Summary of changes:
 epan/dissectors/packet-vlan.c | 18 --
 1 file changed, 16 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0632770: Use the generic function decode_zcl_time_in_100ms instead of the local zcl_fmt_time_tenths.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=063277032130721ab9513b3525b24914db41ca7a
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

0632770 by Paul Zander (p.j.zan...@lighting.com):

Use the generic function decode_zcl_time_in_100ms instead of the local 
zcl_fmt_time_tenths.

Change-Id: Id79b59c77083e6fb236d4137820182616f5b83c1
Reviewed-on: https://code.wireshark.org/review/26275
Reviewed-by: Dario Lombardo 
Petri-Dish: Dario Lombardo 
Tested-by: Dario Lombardo 
Reviewed-by: Anders Broman 


Actions performed:

from  4d3721b   [Diameter] Added extended AVPs for Gx and Rx
adds  0632770   Use the generic function decode_zcl_time_in_100ms instead 
of the local zcl_fmt_time_tenths.


Summary of changes:
 epan/dissectors/packet-zbee-zcl-general.c | 10 ++
 1 file changed, 2 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4d3721b: [Diameter] Added extended AVPs for Gx and Rx

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d3721b1db229b985d6f45b5bd0813a6ab5a63d1
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4d3721b by Joakim Karlsson (oak...@gmail.com):

[Diameter] Added extended AVPs for Gx and Rx

Change-Id: Ic795a84dfb42868a34707142ce31ec77cd855e44
Reviewed-on: https://code.wireshark.org/review/26273
Reviewed-by: Anders Broman 


Actions performed:

from  0d9d69a   [Diameter] fixed valid Diameter xml
adds  4d3721b   [Diameter] Added extended AVPs for Gx and Rx


Summary of changes:
 diameter/TGPP.xml   | 27 +++
 diameter/dictionary.xml | 23 +++
 2 files changed, 50 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0d9d69a: [Diameter] fixed valid Diameter xml

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0d9d69a1e639ece0ad3218851771d662e2528d45
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

0d9d69a by Joakim Karlsson (oak...@gmail.com):

[Diameter] fixed valid Diameter xml

Change-Id: Iac359885468e056dee3f8fa401223a38ca3c
Reviewed-on: https://code.wireshark.org/review/26271
Reviewed-by: Anders Broman 


Actions performed:

from  b434e0a   VLAN: define a recursion depth limit
adds  0d9d69a   [Diameter] fixed valid Diameter xml


Summary of changes:
 diameter/Huawei.xml |  28 +-
 diameter/Inovar.xml | 133 +++-
 diameter/Juniper.xml|   4 +-
 diameter/TGPP.xml   |   1 +
 diameter/dictionary.xml |  71 +-
 5 files changed, 140 insertions(+), 97 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 f05c3b9: VLAN: define a recursion depth limit

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f05c3b91f9571210b86576ee6284e71a3306109d
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

f05c3b9 by Pascal Quantin (pascal.quan...@gmail.com):

VLAN: define a recursion depth limit

Altough the dissection consumes 4 bytes each time it is called, it can
trigger a stack overflow for big packets. Let's limmit the number of
allowed VLAN tags for a given packet.

Bug: 14469
Change-Id: Ieb6834ab3350dc7e8c301e6479577855a253897e
Reviewed-on: https://code.wireshark.org/review/26270
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte 
(cherry picked from commit b434e0a03be45ed796af7271972672a0b43cffa8)
Conflicts:
epan/dissectors/packet-vlan.c
Reviewed-on: https://code.wireshark.org/review/26274
Reviewed-by: Pascal Quantin 


Actions performed:

from  66bc372   NBAP: avoid linking a DCH-ID to itself
adds  f05c3b9   VLAN: define a recursion depth limit


Summary of changes:
 epan/dissectors/packet-vlan.c | 18 --
 1 file changed, 16 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe