Re: [Wireshark-dev] [Wireshark-commits] rev 20442: /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

2007-01-16 Thread Joerg Mayer
On Mon, Jan 15, 2007 at 07:48:06PM +, [EMAIL PROTECTED] wrote:
 http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=20442
 
 User: lego
 Date: 2007/01/15 07:48 PM
 
 Log:
  Fix a major leakage of token minors in lemon generated parsers due to the 
 fact that lemon was not genmerating destructor code for elements in the RHS 
 of rules without C-code.
 

Can you please provide feedback to the lemon author?

 thanks
   Joerg
-- 
Joerg Mayer   [EMAIL PROTECTED]
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Gisle Vanem
--- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007
+++ epan\crypt\airpdcap.c   Tue Jan 16 11:59:58 2007
@@ -1663,7 +1663,7 @@
else
output_string = g_strdup_printf(%s:%s:%s,
STRING_KEY_TYPE_WPA_PWD,dk-key-str,
-   format_text((guchar *)dk-ssid-data, 
dk-ssid-len);
+   format_text((guchar *)dk-ssid-data, 
dk-ssid-len));
}
else if(dk-type == AIRPDCAP_KEY_TYPE_WPA_PMK)
{

---

Please test your changes (compile it) before checking in !

--gv
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Sebastien Tandel

Ouch, I don't have this one on the latest svn version ... :-/


Gisle Vanem wrote:
 --- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007
 +++ epan\crypt\airpdcap.c   Tue Jan 16 11:59:58 2007
 @@ -1663,7 +1663,7 @@
 else
 output_string = g_strdup_printf(%s:%s:%s,
 STRING_KEY_TYPE_WPA_PWD,dk-key-str,
 -   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len);
 +   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len));
 }
 else if(dk-type == AIRPDCAP_KEY_TYPE_WPA_PMK)
 {

 ---

 Please test your changes (compile it) before checking in !

 --gv
 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev
   

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Wireshark-commits] rev 20442:/trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

2007-01-16 Thread Anders Broman \(AL/EAB\)
Hi,
I have filed a bug with sqlite.
BR
Anders

-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Joerg Mayer
Sent: den 16 januari 2007 11:57
To: wireshark-dev@wireshark.org
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev
20442:/trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

On Mon, Jan 15, 2007 at 07:48:06PM +, [EMAIL PROTECTED] wrote:
 http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=20442
 
 User: lego
 Date: 2007/01/15 07:48 PM
 
 Log:
  Fix a major leakage of token minors in lemon generated parsers due to
the fact that lemon was not genmerating destructor code for elements in
the RHS of rules without C-code.
 

Can you please provide feedback to the lemon author?

 thanks
   Joerg
-- 
Joerg Mayer   [EMAIL PROTECTED]
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Sebastien Tandel
sorry you're right, part of code not compiled on my computer.

Sebastien Tandel wrote:
 Ouch, I don't have this one on the latest svn version ... :-/


 Gisle Vanem wrote:
   
 --- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007
 +++ epan\crypt\airpdcap.c   Tue Jan 16 11:59:58 2007
 @@ -1663,7 +1663,7 @@
 else
 output_string = g_strdup_printf(%s:%s:%s,
 STRING_KEY_TYPE_WPA_PWD,dk-key-str,
 -   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len);
 +   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len));
 }
 else if(dk-type == AIRPDCAP_KEY_TYPE_WPA_PMK)
 {

 ---

 Please test your changes (compile it) before checking in !

 --gv
 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev
   
 

 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev
   

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Gisle Vanem
* epan/crypt/crypt-md5.h must come after glib.h because of
  'guint8' etc.

* Include wiretap/file_util.h because of eth_fopen().

--- SVN-Latest\epan\dissectors\packet-kerberos.cWed Jan 03 17:26:35 2007
+++ epan\dissectors\packet-kerberos.c   Tue Jan 16 12:44:55 2007
@@ -71,12 +71,12 @@
 #include nettle/des.h
 #include nettle/cbc.h
 #endif
-#include epan/crypt/crypt-md5.h
 #include sys/stat.h  /* For keyfile manipulation */
 #endif

 #include glib.h

+#include epan/crypt/crypt-md5.h
 #include epan/packet.h

 #include epan/strutil.h
@@ -96,6 +96,8 @@
 #include epan/dissectors/packet-dcerpc.h

 #include epan/dissectors/packet-gssapi.h
+
+#include wiretap/file_util.h

 #define UDP_PORT_KERBEROS  88
 #define TCP_PORT_KERBEROS  88


--

PS. What's up with the mailing-list software? Every message looks like
crap; all line-endings are missing. Is the ML-software running on a Mac?

--gv
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Sebastien Tandel

 PS. What's up with the mailing-list software? Every message looks like
 crap; all line-endings are missing. Is the ML-software running on a Mac?
   
Everything's fine here ... maybe a new feature of Outlook Express? :-p



Regards,

Sebastien Tandel

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] [Patch] libwireshark.def

2007-01-16 Thread Gisle Vanem
Some missing exports (needed by airpdcap*.c):

--- SVN-Latest\epan\libwireshark.defTue Jan 16 11:07:52 2007
+++ epan\libwireshark.def   Tue Jan 16 13:08:05 2007
@@ -91,6 +91,8 @@
 convert_string_to_hex
 copy_prefs
 crc16_ccitt_tvb
+crc32_ccitt
+crc32_ccitt_table   DATA
 create_dissector_handle
 create_persconffile_dir
 data_out_file   DATA
@@ -641,6 +643,7 @@
 rtp_payload_type_vals   DATA
 rtp_payload_type_short_valsDATA
 running_in_build_directory
+sha1_hmac
 scsi_mmc_vals  DATA
 scsi_smc_vals  DATA
 scsi_sbc_vals  DATA

--gv
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Gisle Vanem
Gisle Vanem [EMAIL PROTECTED] wrote:

 I.e. double newlines are collapsed into one:
 
  line 1
 
  line 2

That message got received okay. Presumably because it contained a
Content-type: multipart/mixed;... in the header.

--gv

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Sake Blok
On Tue, Jan 16, 2007 at 01:33:00PM +0100, Gisle Vanem wrote:
 Sebastien Tandel [EMAIL PROTECTED] wrote:
 
 PS. What's up with the mailing-list software? Every message looks like 
 crap; all line-endings are missing. Is the ML-software running on a Mac? 
 Everything's fine here ... maybe a new feature of Outlook Express? :-p
 
 It's not an OE issue. I'm subscribed to ~50 MLs and wireshark-user/dev is 
 the only ML
 that does this. Look at your raw message attached.

Looks like your mailserver is messing things up. In the attached raw
message there is a line:

X-MIME-Autoconverted: from base64 to 8bit by bryggen.bgnett.no id =
l0GCELid030303

When I look at the same message in my mailbox, it is still base64
encoded. When I mannualy decode the data, I do get to see all
newlines (as does my mail-client).

Cheers,


Sake
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Sebastien Tandel
just kidding about OE ... but as said it's all right here for me.

Regards,

Sebastien Tandel
Gisle Vanem wrote:
 Sebastien Tandel [EMAIL PROTECTED] wrote:

 PS. What's up with the mailing-list software? Every message looks
 like crap; all line-endings are missing. Is the ML-software running
 on a Mac?   Everything's fine here ... maybe a new feature of
 Outlook Express? :-p

 It's not an OE issue. I'm subscribed to ~50 MLs and wireshark-user/dev
 is the only ML
 that does this. Look at your raw message attached.

 I.e. double newlines are collapsed into one:

  line 1

  line 2

 Gets received here as:

  line 1
  line 2

 --gv
 

 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev
   

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Wireshark-commits] rev 20442: /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

2007-01-16 Thread Douglas Pratley
I get a similar crash under Windows. I'm having trouble reverting back
to a good baseline without losing today's work, so it would be great
if this could be fixed... I'm afraid I can't work out quite what the
dependencies are here.

Cheers

Doug

-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Jaap Keuter
Sent: 16 January 2007 12:27
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 20442:
/trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

Hi,

Maybe not, since it seems to have broken the program completely.

(gdb) run
Starting program: /home/me/src/wireshark/trunk/.libs/lt-tshark
Failed to read a valid object file image from memory.
[Thread debugging using libthread_db enabled]
[New Thread -1233094432 (LWP 25812)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1233094432 (LWP 25812)]
0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
(gdb) bt
#0  0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
#1  0xb6b3ab31 in g_free () from /usr/lib/libglib-2.0.so.0
#2  0xb6fafa13 in yy_destructor (yymajor=value optimized out,
yypminor=0x0) at ./dtd_grammar.lemon:63
#3  0xb6fb0685 in DtdParse (yyp=0x8371f40, yymajor=6, yyminor=0x8376f00,
bd=0x837) at ./dtd_grammar.lemon:1
#4  0xb6fb163b in Dtd_Parse_lex () at ./dtd_parse.l:275
#5  0xb6fb221c in dtd_parse (s=0x8378f20) at ./dtd_parse.l:335
#6  0xb76620f5 in proto_register_xml () at packet-xml.c:1145
#7  0xb766b3b5 in register_all_protocols () at register.c:691
#8  0xb6fcd66f in proto_init (register_all_protocols=0x804e31c
[EMAIL PROTECTED],
register_all_protocol_handoffs=0x804e75c
[EMAIL PROTECTED]) at proto.c:320
#9  0xb6fb60d7 in epan_init (register_all_protocols=0x804e31c
[EMAIL PROTECTED],
register_all_handoffs=0x804e75c
[EMAIL PROTECTED], report_failure=0x8060dc0
failure_message,
report_open_failure=0x80610a0 open_failure_message,
report_read_failure=0x8061150 read_failure_message) at epan.c:97
#10 0x08062fc1 in main (argc=1, argv=0xbf80a4d4) at tshark.c:781

Thanx,
Jaap

On Tue, 16 Jan 2007, Joerg Mayer wrote:

 On Mon, Jan 15, 2007 at 07:48:06PM +, [EMAIL PROTECTED] wrote:
 
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=20442
 
  User: lego
  Date: 2007/01/15 07:48 PM
 
  Log:
   Fix a major leakage of token minors in lemon generated parsers due
to the fact that lemon was not genmerating destructor code for elements
in the RHS of rules without C-code.
 

 Can you please provide feedback to the lemon author?

  thanks
Joerg


___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev



This message should be regarded as confidential. If you have received this 
email in error please notify the sender and destroy it immediately.
Statements of intent shall only become binding when confirmed in hard copy by 
an authorised signatory.  The contents of this email may relate to dealings 
with other companies within the Detica Group plc group of companies.

Detica Limited is registered in England under No: 1337451.

Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England.


___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] [PATCH] BACnet bacapp additions

2007-01-16 Thread Steve Karg

Hi Developers,

I added some text for enumerations that were added with addenda recently 
approved for the BACnet standard.  I compiled the changes using 
Linux/GCC.  The patch is a diff made using svn diff.


Best Regards,

Steve




bacapp.patch.gz
Description: GNU Zip compressed data
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] TCP packets reassemble mechanism

2007-01-16 Thread sharon lin

Hi,
I would like to understand the TCP reassemble mechanism.
If I configured it to work on top of TCP protocol from the preferences
dialog do I guaranteed to get reassembled (Full) packets to my
packet-dissector module.

Sharon.
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Wireshark-commits] rev 20442: /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

2007-01-16 Thread Luis Ontanon
They commited what we got in rev 20447.

As this does not happen to me (I'm running with MallocBadFreeAbort) I
would need a a backtrace where the yyminor value passed to DtdParse()
shows up.

can you -DDEBUG_DTD_PARSER and send in the trace for the parser.

Thanks.

Luis

On 1/16/07, Douglas Pratley [EMAIL PROTECTED] wrote:
 I get a similar crash under Windows. I'm having trouble reverting back
 to a good baseline without losing today's work, so it would be great
 if this could be fixed... I'm afraid I can't work out quite what the
 dependencies are here.

 Cheers

 Doug

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Jaap Keuter
 Sent: 16 January 2007 12:27
 To: Developer support list for Wireshark
 Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 20442:
 /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

 Hi,

 Maybe not, since it seems to have broken the program completely.

 (gdb) run
 Starting program: /home/me/src/wireshark/trunk/.libs/lt-tshark
 Failed to read a valid object file image from memory.
 [Thread debugging using libthread_db enabled]
 [New Thread -1233094432 (LWP 25812)]

 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread -1233094432 (LWP 25812)]
 0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
 (gdb) bt
 #0  0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
 #1  0xb6b3ab31 in g_free () from /usr/lib/libglib-2.0.so.0
 #2  0xb6fafa13 in yy_destructor (yymajor=value optimized out,
 yypminor=0x0) at ./dtd_grammar.lemon:63
 #3  0xb6fb0685 in DtdParse (yyp=0x8371f40, yymajor=6, yyminor=0x8376f00,
 bd=0x837) at ./dtd_grammar.lemon:1
 #4  0xb6fb163b in Dtd_Parse_lex () at ./dtd_parse.l:275
 #5  0xb6fb221c in dtd_parse (s=0x8378f20) at ./dtd_parse.l:335
 #6  0xb76620f5 in proto_register_xml () at packet-xml.c:1145
 #7  0xb766b3b5 in register_all_protocols () at register.c:691
 #8  0xb6fcd66f in proto_init (register_all_protocols=0x804e31c
 [EMAIL PROTECTED],
 register_all_protocol_handoffs=0x804e75c
 [EMAIL PROTECTED]) at proto.c:320
 #9  0xb6fb60d7 in epan_init (register_all_protocols=0x804e31c
 [EMAIL PROTECTED],
 register_all_handoffs=0x804e75c
 [EMAIL PROTECTED], report_failure=0x8060dc0
 failure_message,
 report_open_failure=0x80610a0 open_failure_message,
 report_read_failure=0x8061150 read_failure_message) at epan.c:97
 #10 0x08062fc1 in main (argc=1, argv=0xbf80a4d4) at tshark.c:781

 Thanx,
 Jaap

 On Tue, 16 Jan 2007, Joerg Mayer wrote:

  On Mon, Jan 15, 2007 at 07:48:06PM +, [EMAIL PROTECTED] wrote:
  
 http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=20442
  
   User: lego
   Date: 2007/01/15 07:48 PM
  
   Log:
Fix a major leakage of token minors in lemon generated parsers due
 to the fact that lemon was not genmerating destructor code for elements
 in the RHS of rules without C-code.
  
 
  Can you please provide feedback to the lemon author?
 
   thanks
 Joerg
 

 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev



 This message should be regarded as confidential. If you have received this 
 email in error please notify the sender and destroy it immediately.
 Statements of intent shall only become binding when confirmed in hard copy by 
 an authorised signatory.  The contents of this email may relate to dealings 
 with other companies within the Detica Group plc group of companies.

 Detica Limited is registered in England under No: 1337451.

 Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England.


 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev



-- 
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Wireshark-commits] rev 20442: /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

2007-01-16 Thread Luis Ontanon
in order to avoid this one you just have to rename the dtds directory,
no dtds directory no dtds get parsed.

On 1/16/07, Douglas Pratley [EMAIL PROTECTED] wrote:
 I get a similar crash under Windows. I'm having trouble reverting back
 to a good baseline without losing today's work, so it would be great
 if this could be fixed... I'm afraid I can't work out quite what the
 dependencies are here.

 Cheers

 Doug

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Jaap Keuter
 Sent: 16 January 2007 12:27
 To: Developer support list for Wireshark
 Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 20442:
 /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

 Hi,

 Maybe not, since it seems to have broken the program completely.

 (gdb) run
 Starting program: /home/me/src/wireshark/trunk/.libs/lt-tshark
 Failed to read a valid object file image from memory.
 [Thread debugging using libthread_db enabled]
 [New Thread -1233094432 (LWP 25812)]

 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread -1233094432 (LWP 25812)]
 0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
 (gdb) bt
 #0  0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
 #1  0xb6b3ab31 in g_free () from /usr/lib/libglib-2.0.so.0
 #2  0xb6fafa13 in yy_destructor (yymajor=value optimized out,
 yypminor=0x0) at ./dtd_grammar.lemon:63
 #3  0xb6fb0685 in DtdParse (yyp=0x8371f40, yymajor=6, yyminor=0x8376f00,
 bd=0x837) at ./dtd_grammar.lemon:1
 #4  0xb6fb163b in Dtd_Parse_lex () at ./dtd_parse.l:275
 #5  0xb6fb221c in dtd_parse (s=0x8378f20) at ./dtd_parse.l:335
 #6  0xb76620f5 in proto_register_xml () at packet-xml.c:1145
 #7  0xb766b3b5 in register_all_protocols () at register.c:691
 #8  0xb6fcd66f in proto_init (register_all_protocols=0x804e31c
 [EMAIL PROTECTED],
 register_all_protocol_handoffs=0x804e75c
 [EMAIL PROTECTED]) at proto.c:320
 #9  0xb6fb60d7 in epan_init (register_all_protocols=0x804e31c
 [EMAIL PROTECTED],
 register_all_handoffs=0x804e75c
 [EMAIL PROTECTED], report_failure=0x8060dc0
 failure_message,
 report_open_failure=0x80610a0 open_failure_message,
 report_read_failure=0x8061150 read_failure_message) at epan.c:97
 #10 0x08062fc1 in main (argc=1, argv=0xbf80a4d4) at tshark.c:781

 Thanx,
 Jaap

 On Tue, 16 Jan 2007, Joerg Mayer wrote:

  On Mon, Jan 15, 2007 at 07:48:06PM +, [EMAIL PROTECTED] wrote:
  
 http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=20442
  
   User: lego
   Date: 2007/01/15 07:48 PM
  
   Log:
Fix a major leakage of token minors in lemon generated parsers due
 to the fact that lemon was not genmerating destructor code for elements
 in the RHS of rules without C-code.
  
 
  Can you please provide feedback to the lemon author?
 
   thanks
 Joerg
 

 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev



 This message should be regarded as confidential. If you have received this 
 email in error please notify the sender and destroy it immediately.
 Statements of intent shall only become binding when confirmed in hard copy by 
 an authorised signatory.  The contents of this email may relate to dealings 
 with other companies within the Detica Group plc group of companies.

 Detica Limited is registered in England under No: 1337451.

 Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England.


 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev



-- 
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Wireshark-commits] rev 20442: /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

2007-01-16 Thread Martin Mathieson
Is this useful?

Martin

GNU gdb 6.2.1
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type show copying to see the conditions.
There is absolutely no warranty for GDB.  Type show warranty for details.
This GDB was configured as i586-suse-linux...Using host libthread_db
library /lib/tls/libthread_db.so.1.

(gdb) run
Starting program: /users/martinm/wireshark/.libs/lt-wireshark
[Thread debugging using libthread_db enabled]
[New Thread 1103262656 (LWP 23272)]
Detaching after fork from child process 23283.
Detaching after fork from child process 23284.
*** glibc detected *** double free or corruption: 0x085761d0 ***

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1103262656 (LWP 23272)]
0x41957ec9 in free () from /lib/tls/libc.so.6
(gdb) bt
#0  0x41957ec9 in free () from /lib/tls/libc.so.6
#1  0x417b89d2 in g_free () from /opt/gnome/lib/libglib-2.0.so.0
#2  0x4037f192 in yy_destructor (yymajor=107 'k', yypminor=0x8587430)
at dtd_grammar.lemon:63
#3  0x4037f993 in DtdParse (yyp=0x85873b0, yymajor=16,
yyminor=0x6c696d6b, bd=0x6c696d6b) at dtd_grammar.lemon:216
#4  0x40380986 in Dtd_Parse_lex () at dtd_parse.l:274
#5  0x4038143c in dtd_parse (s=0x6c696d6b) at dtd_parse.l:334
#6  0x40a30056 in proto_register_xml () at packet-xml.c:1145
#7  0x40a3788e in register_all_protocols () at register.c:691
#8  0x403993ff in proto_init (register_all_protocols=0x805fe8c
register_all_protocols, register_all_protocol_handoffs=0x8060e3c
register_all_protocol_handoffs)
at proto.c:320
#9  0x40384337 in epan_init (register_all_protocols=0x6c696d6b,
register_all_handoffs=0x6c696d6b, report_failure=0x6c696d6b,
report_open_failure=0x6c696d6b,
report_read_failure=0x6c696d6b) at epan.c:97
#10 0x080826db in main (argc=1, argv=0xbfffdad4) at main.c:2367
(gdb) fr 2
#2  0x4037f192 in yy_destructor (yymajor=107 'k', yypminor=0x8587430)
at dtd_grammar.lemon:63
63  if ($$-text) g_free($$-text);
(gdb) p *yyminor
No symbol yyminor in current context.
(gdb) p *yypminor
$1 = {yy0 = 0x8583d38, yy29 = 0x8583d38, yy44 = 0x8583d38
smil8=X\b:10, yy59 = 0x8583d38, yy81 = 14568}
(gdb)

On 1/16/07, Luis Ontanon [EMAIL PROTECTED] wrote:
 They commited what we got in rev 20447.

 As this does not happen to me (I'm running with MallocBadFreeAbort) I
 would need a a backtrace where the yyminor value passed to DtdParse()
 shows up.

 can you -DDEBUG_DTD_PARSER and send in the trace for the parser.

 Thanks.

 Luis

 On 1/16/07, Douglas Pratley [EMAIL PROTECTED] wrote:
  I get a similar crash under Windows. I'm having trouble reverting back
  to a good baseline without losing today's work, so it would be great
  if this could be fixed... I'm afraid I can't work out quite what the
  dependencies are here.
 
  Cheers
 
  Doug
 
  -Original Message-
  From: [EMAIL PROTECTED]
  [mailto:[EMAIL PROTECTED] On Behalf Of Jaap Keuter
  Sent: 16 January 2007 12:27
  To: Developer support list for Wireshark
  Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 20442:
  /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c
 
  Hi,
 
  Maybe not, since it seems to have broken the program completely.
 
  (gdb) run
  Starting program: /home/me/src/wireshark/trunk/.libs/lt-tshark
  Failed to read a valid object file image from memory.
  [Thread debugging using libthread_db enabled]
  [New Thread -1233094432 (LWP 25812)]
 
  Program received signal SIGSEGV, Segmentation fault.
  [Switching to Thread -1233094432 (LWP 25812)]
  0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
  (gdb) bt
  #0  0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
  #1  0xb6b3ab31 in g_free () from /usr/lib/libglib-2.0.so.0
  #2  0xb6fafa13 in yy_destructor (yymajor=value optimized out,
  yypminor=0x0) at ./dtd_grammar.lemon:63
  #3  0xb6fb0685 in DtdParse (yyp=0x8371f40, yymajor=6, yyminor=0x8376f00,
  bd=0x837) at ./dtd_grammar.lemon:1
  #4  0xb6fb163b in Dtd_Parse_lex () at ./dtd_parse.l:275
  #5  0xb6fb221c in dtd_parse (s=0x8378f20) at ./dtd_parse.l:335
  #6  0xb76620f5 in proto_register_xml () at packet-xml.c:1145
  #7  0xb766b3b5 in register_all_protocols () at register.c:691
  #8  0xb6fcd66f in proto_init (register_all_protocols=0x804e31c
  [EMAIL PROTECTED],
  register_all_protocol_handoffs=0x804e75c
  [EMAIL PROTECTED]) at proto.c:320
  #9  0xb6fb60d7 in epan_init (register_all_protocols=0x804e31c
  [EMAIL PROTECTED],
  register_all_handoffs=0x804e75c
  [EMAIL PROTECTED], report_failure=0x8060dc0
  failure_message,
  report_open_failure=0x80610a0 open_failure_message,
  report_read_failure=0x8061150 read_failure_message) at epan.c:97
  #10 0x08062fc1 in main (argc=1, argv=0xbf80a4d4) at tshark.c:781
 
  Thanx,
  Jaap
 
  On Tue, 16 Jan 2007, Joerg Mayer wrote:
 
   On Mon, Jan 15, 2007 at 07:48:06PM +, [EMAIL PROTECTED] wrote:
   
  

Re: [Wireshark-dev] [PATCH] BACnet bacapp additions

2007-01-16 Thread Jaap Keuter
Hi,

Checked in..

Thanx,
Jaap

On Tue, 16 Jan 2007, Steve Karg wrote:

 Hi Developers,

 I added some text for enumerations that were added with addenda recently
 approved for the BACnet standard.  I compiled the changes using
 Linux/GCC.  The patch is a diff made using svn diff.

 Best Regards,

 Steve


___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Wireshark-commits] rev 20442: /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

2007-01-16 Thread Luis Ontanon
Guys,
 I checked in r20452 that reverses the changes they did to my original
fix (and I checked in later). This fix is not quite perfect (neither
was theirs) as it haves meany #line directives ponting at the wrong
place in the generated code, but it does have yy_destructor() to be
called just once for every unused element in RHS.


I'm curious so I'll keep investigating this issue...
Luis

On 1/16/07, Martin Mathieson [EMAIL PROTECTED] wrote:
 Is this useful?

 Martin

 GNU gdb 6.2.1
 Copyright 2004 Free Software Foundation, Inc.
 GDB is free software, covered by the GNU General Public License, and you are
 welcome to change it and/or distribute copies of it under certain conditions.
 Type show copying to see the conditions.
 There is absolutely no warranty for GDB.  Type show warranty for details.
 This GDB was configured as i586-suse-linux...Using host libthread_db
 library /lib/tls/libthread_db.so.1.

 (gdb) run
 Starting program: /users/martinm/wireshark/.libs/lt-wireshark
 [Thread debugging using libthread_db enabled]
 [New Thread 1103262656 (LWP 23272)]
 Detaching after fork from child process 23283.
 Detaching after fork from child process 23284.
 *** glibc detected *** double free or corruption: 0x085761d0 ***

 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread 1103262656 (LWP 23272)]
 0x41957ec9 in free () from /lib/tls/libc.so.6
 (gdb) bt
 #0  0x41957ec9 in free () from /lib/tls/libc.so.6
 #1  0x417b89d2 in g_free () from /opt/gnome/lib/libglib-2.0.so.0
 #2  0x4037f192 in yy_destructor (yymajor=107 'k', yypminor=0x8587430)
 at dtd_grammar.lemon:63
 #3  0x4037f993 in DtdParse (yyp=0x85873b0, yymajor=16,
 yyminor=0x6c696d6b, bd=0x6c696d6b) at dtd_grammar.lemon:216
 #4  0x40380986 in Dtd_Parse_lex () at dtd_parse.l:274
 #5  0x4038143c in dtd_parse (s=0x6c696d6b) at dtd_parse.l:334
 #6  0x40a30056 in proto_register_xml () at packet-xml.c:1145
 #7  0x40a3788e in register_all_protocols () at register.c:691
 #8  0x403993ff in proto_init (register_all_protocols=0x805fe8c
 register_all_protocols, register_all_protocol_handoffs=0x8060e3c
 register_all_protocol_handoffs)
 at proto.c:320
 #9  0x40384337 in epan_init (register_all_protocols=0x6c696d6b,
 register_all_handoffs=0x6c696d6b, report_failure=0x6c696d6b,
 report_open_failure=0x6c696d6b,
 report_read_failure=0x6c696d6b) at epan.c:97
 #10 0x080826db in main (argc=1, argv=0xbfffdad4) at main.c:2367
 (gdb) fr 2
 #2  0x4037f192 in yy_destructor (yymajor=107 'k', yypminor=0x8587430)
 at dtd_grammar.lemon:63
 63  if ($$-text) g_free($$-text);
 (gdb) p *yyminor
 No symbol yyminor in current context.
 (gdb) p *yypminor
 $1 = {yy0 = 0x8583d38, yy29 = 0x8583d38, yy44 = 0x8583d38
 smil8=X\b:10, yy59 = 0x8583d38, yy81 = 14568}
 (gdb)

 On 1/16/07, Luis Ontanon [EMAIL PROTECTED] wrote:
  They commited what we got in rev 20447.
 
  As this does not happen to me (I'm running with MallocBadFreeAbort) I
  would need a a backtrace where the yyminor value passed to DtdParse()
  shows up.
 
  can you -DDEBUG_DTD_PARSER and send in the trace for the parser.
 
  Thanks.
 
  Luis
 
  On 1/16/07, Douglas Pratley [EMAIL PROTECTED] wrote:
   I get a similar crash under Windows. I'm having trouble reverting back
   to a good baseline without losing today's work, so it would be great
   if this could be fixed... I'm afraid I can't work out quite what the
   dependencies are here.
  
   Cheers
  
   Doug
  
   -Original Message-
   From: [EMAIL PROTECTED]
   [mailto:[EMAIL PROTECTED] On Behalf Of Jaap Keuter
   Sent: 16 January 2007 12:27
   To: Developer support list for Wireshark
   Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 20442:
   /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c
  
   Hi,
  
   Maybe not, since it seems to have broken the program completely.
  
   (gdb) run
   Starting program: /home/me/src/wireshark/trunk/.libs/lt-tshark
   Failed to read a valid object file image from memory.
   [Thread debugging using libthread_db enabled]
   [New Thread -1233094432 (LWP 25812)]
  
   Program received signal SIGSEGV, Segmentation fault.
   [Switching to Thread -1233094432 (LWP 25812)]
   0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
   (gdb) bt
   #0  0xb69c75ad in free () from /lib/tls/i686/cmov/libc.so.6
   #1  0xb6b3ab31 in g_free () from /usr/lib/libglib-2.0.so.0
   #2  0xb6fafa13 in yy_destructor (yymajor=value optimized out,
   yypminor=0x0) at ./dtd_grammar.lemon:63
   #3  0xb6fb0685 in DtdParse (yyp=0x8371f40, yymajor=6, yyminor=0x8376f00,
   bd=0x837) at ./dtd_grammar.lemon:1
   #4  0xb6fb163b in Dtd_Parse_lex () at ./dtd_parse.l:275
   #5  0xb6fb221c in dtd_parse (s=0x8378f20) at ./dtd_parse.l:335
   #6  0xb76620f5 in proto_register_xml () at packet-xml.c:1145
   #7  0xb766b3b5 in register_all_protocols () at register.c:691
   #8  0xb6fcd66f in proto_init (register_all_protocols=0x804e31c
   [EMAIL PROTECTED],
   register_all_protocol_handoffs=0x804e75c
   [EMAIL 

[Wireshark-dev] [PATCH] strptime implicit declaration warning

2007-01-16 Thread Sebastien Tandel
Hi,


   a patch to avoid the warning implicit declaration of function
'strptime' in editcap.c
glib.h is included just after the define __USE_XOPEN and include time.h



Regards,

Sebastien Tandel
Index: editcap.c
===
--- editcap.c   (révision 20453)
+++ editcap.c   (copie de travail)
@@ -15,6 +15,14 @@
 #include stdio.h
 #include stdlib.h
 #include string.h
+
+/*
+ * Just make sure we include the prototype for strptime as well
+ * (needed for glibc 2.2)
+ */
+
+#define __USE_XOPEN
+#include time.h
 #include glib.h
 
 #ifdef HAVE_UNISTD_H
@@ -22,13 +30,7 @@
 #endif
 
 
-/*
- * Just make sure we include the prototype for strptime as well
- * (needed for glibc 2.2)
- */
-#define __USE_XOPEN
 
-#include time.h
 #ifdef HAVE_SYS_TIME_H
 #include sys/time.h
 #endif
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] Define dissector port

2007-01-16 Thread Hal Lander
I am still struggling with this.
Is there any documentation on heur_dissector_add and where/how to call it?

Also I presume from Guy's posting I have to add my protocol into some 
tables?

Hal

From: sharon lin [EMAIL PROTECTED]
Reply-To: Developer support list for Wireshark 
wireshark-dev@wireshark.org
To: Developer support list for Wireshark wireshark-dev@wireshark.org
Subject: Re: [Wireshark-dev] Define dissector port
Date: Tue, 16 Jan 2007 17:51:11 +0200

Add
heur_dissector_add(udp, dissect_fring, proto_fring);
   heur_dissector_add(tcp, dissect_fring, proto_fring);

On 1/16/07, Hal Lander [EMAIL PROTECTED] wrote:

The word 'heuristic' only appears once in 'readme.developer', and although
I
have skimmed through the whole document I seem to have missed where it
tells
you how to make a dissector heuristic.

Can you be more specific about where there is an example?
Can plugins be heuristic dissectors?

Once a dissector is heuristic will it just look on all ports?

Hal



 From: Guy Harris [EMAIL PROTECTED]
 Reply-To: Developer support list for Wireshark
 wireshark-dev@wireshark.org
 To: Developer support list for Wireshark wireshark-dev@wireshark.org
 Subject: Re: [Wireshark-dev] Define dissector port
 Date: Mon, 15 Jan 2007 10:37:39 -0800
 
 Hal Lander wrote:
   Is there a way to get a dissector to run on all ports?
 
 A dissector that runs on all ports would have to be a heuristic
 dissector (otherwise, you wouldn't be able to dissect any TCP/UDP
 traffic except for traffic for your protocol).
 
 So the way you'd do that would be to have your dissector be able to look
 at a packet and determine whether it's a packet for your protocol or
 not, and use a check for that sort in your dissector.  See
 doc/README.developer for information on how to make a heuristic
 dissector.  The name of the heuristic dissector table for TCP is tcp,
 and the table for UDP is udp.
 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev

_
Your Hotmail address already works to sign into Windows Live Messenger!
Get
it now

http://clk.atdmt.com/MSN/go/msnnkwme002001msn/direct/01/?href=http://get.live.com/messenger/overview

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev



___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

_
Fixing up the home? Live Search can help 
http://imagine-windowslive.com/search/kits/default.aspx?kit=improvelocale=en-USsource=hmemailtaglinenov06FORM=WLMTAG

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] GUI update interval

2007-01-16 Thread cskiraly-munka
Does anyone know where can I speed up the update of the GUI a little bit?
Thanks
Csaba
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [PATCH] BACnet bacapp additions

2007-01-16 Thread Steve Karg
Hi Sebastien,

   Can you share a pcap trace of BACnet?

There is a directory of unorganized BACnet captures in a directory on my 
website:
http://kargs.net/captures/

You can use them for whatever you want.

Arbitrary BACnet traces can also be generated using the BACnet VTS tool 
(vts.sourceforge.net) or by using BACnet stack demo applications 
(bacnet.sourceforge.net), or commercial tools from Polarsoft, Cimetrics, 
or SCADA Engine.

Best Regards,

Steve
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [PATCH] BACnet bacapp additions

2007-01-16 Thread Sebastien Tandel

Many thanks  :)


Regards,

Sebastien Tandel

Steve Karg wrote:
 Hi Sebastien,

   
   Can you share a pcap trace of BACnet?
 

 There is a directory of unorganized BACnet captures in a directory on my 
 website:
 http://kargs.net/captures/

 You can use them for whatever you want.

 Arbitrary BACnet traces can also be generated using the BACnet VTS tool 
 (vts.sourceforge.net) or by using BACnet stack demo applications 
 (bacnet.sourceforge.net), or commercial tools from Polarsoft, Cimetrics, 
 or SCADA Engine.

 Best Regards,

 Steve
 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev
   

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Gisle Vanem
Sake Blok [EMAIL PROTECTED] wrote:

 Looks like your mailserver is messing things up. In the attached rawmessage 
 there is a line:
 X-MIME-Autoconverted: from base64 to 8bit by bryggen.bgnett.no id 
 =l0GCELid030303
 When I look at the same message in my mailbox, it is still base64encoded. 
 When I mannualy decode the data, 
 I do get to see allnewlines (as does my mail-client).

Okay, I've resubscribed from another account. So this problem should vanish.
But what about the patch itself?

--gv
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Jaap Keuter
Hi,

Implemented the suggestion, with slight modification.
Moved glib.h inclusion up i.s.o. crypt-md5.h down because you've omitted
the conditional.

For easier handling could you attach the patches to the emails i.s.o.
pasting them?

Thanx,
Jaap

On Tue, 16 Jan 2007, Gisle Vanem wrote:

 * epan/crypt/crypt-md5.h must come after glib.h because of
   'guint8' etc.

 * Include wiretap/file_util.h because of eth_fopen().

 --- SVN-Latest\epan\dissectors\packet-kerberos.cWed Jan 03 17:26:35 
 2007
 +++ epan\dissectors\packet-kerberos.c   Tue Jan 16 12:44:55 2007
 @@ -71,12 +71,12 @@
  #include nettle/des.h
  #include nettle/cbc.h
  #endif
 -#include epan/crypt/crypt-md5.h
  #include sys/stat.h  /* For keyfile manipulation */
  #endif

  #include glib.h

 +#include epan/crypt/crypt-md5.h
  #include epan/packet.h

  #include epan/strutil.h
 @@ -96,6 +96,8 @@
  #include epan/dissectors/packet-dcerpc.h

  #include epan/dissectors/packet-gssapi.h
 +
 +#include wiretap/file_util.h

  #define UDP_PORT_KERBEROS  88
  #define TCP_PORT_KERBEROS  88


 --

 PS. What's up with the mailing-list software? Every message looks like
 crap; all line-endings are missing. Is the ML-software running on a Mac?

 --gv
 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev



___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] [PATCH] new dissector : Homeplug

2007-01-16 Thread Sebastien Tandel
Hi all,


   a re-post for the Homeplug dissector. (fuzz-tested)



Regards,

Sebastien Tandel
Index: epan/etypes.h
===
--- epan/etypes.h   (revision 20454)
+++ epan/etypes.h   (working copy)
@@ -246,6 +246,10 @@
 #define ETHERTYPE_MS_NLB_HEARTBEAT 0x886f  /* MS Network Load Balancing 
heartbeat 
http://www.microsoft.com/technet/treeview/default.asp?url=/TechNet/prodtechnol/windows2000serv/deploy/confeat/nlbovw.asp
 */
 #endif
 
+#ifndef ETHERTYPE_HOMEPLUG
+#define ETHERTYPE_HOMEPLUG0x887B  /* IEEE assigned Ethertype */
+#endif
+
 #ifndef ETHERTYPE_CDMA2000_A10_UBS
 #define ETHERTYPE_CDMA2000_A10_UBS 0x8881  /* the byte stream protocol 
that is used for IP based micro-mobility bearer interfaces (A10) in 
CDMA2000(R)-based wireless networks */
 #endif
Index: epan/dissectors/packet-homeplug.c
===
--- epan/dissectors/packet-homeplug.c   (revision 0)
+++ epan/dissectors/packet-homeplug.c   (revision 0)
@@ -0,0 +1,836 @@
+/* packet-homeplug.c
+ * Routines for homeplug dissection
+ *
+ * Copyright 2006, Sebastien Tandel [EMAIL PROTECTED]
+ *
+ * Wireshark - Network traffic analyzer
+ * By Gerald Combs [EMAIL PROTECTED]
+ * Copyright 1998 Gerald Combs
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ */
+
+#ifdef HAVE_CONFIG_H
+# include config.h
+#endif
+
+#include glib.h
+
+#include epan/packet.h
+#include epan/prefs.h
+
+#include epan/etypes.h
+
+#include epan/proto.h
+#include epan/ptvcursor.h
+
+
+
+/* METYPE Values */
+#define HOMEPLUG_MME_RCE  0x00
+#define HOMEPLUG_MME_CER  0x01
+#define HOMEPLUG_MME_RPS  0x07
+#define HOMEPLUG_MME_PSR  0x08
+#define HOMEPLUG_MME_NS  0x1A
+
+/* Bit mask Operation */
+#define HOMEPLUG_MCTRL_RSVD   0x80
+#define HOMEPLUG_MCTRL_NE 0x7F
+
+#define HOMEPLUG_MEHDR_MEV0xE0
+#define HOMEPLUG_MEHDR_METYPE 0x1F
+
+#define HOMEPLUG_NS_AC   0x80
+#define HOMEPLUG_NS_ICID  0x7F
+
+#define HOMEPLUG_RCE_CEV  0xF0
+#define HOMEPLUG_RCE_RSVD 0x0F
+
+#define HOMEPLUG_CER_CERV 0xF0
+#define HOMEPLUG_CER_RSVD 0x0FE0
+#define HOMEPLUG_CER_RXTMI0x1F
+#define HOMEPLUG_CER_RATE 0x80
+#define HOMEPLUG_CER_BP  0x40
+#define HOMEPLUG_CER_VT11 0x0F
+#define HOMEPLUG_CER_RSVD20x80
+#define HOMEPLUG_CER_NBDAS0x7F
+
+
+/* Length of Network Statistics Response defines whether it is the Basic or the
+ * Extended Response */
+#define HOMEPLUG_NS_BASIC_LEN 187
+#define HOMEPLUG_NS_EXT_LEN   199
+
+/* forward reference */
+void proto_reg_handoff_homeplug();
+
+static int proto_homeplug= -1;
+
+static int hf_homeplug_mctrl   = -1;
+  static int hf_homeplug_mctrl_reserved = -1;
+  static int hf_homeplug_mctrl_ne  = -1;
+static int hf_homeplug_mehdr   = -1;
+  static int hf_homeplug_mehdr_mev = -1;
+  static int hf_homeplug_mehdr_metype  = -1;
+static int hf_homeplug_melen   = -1;
+static int hf_homeplug_mme = -1;
+  /* Request Channel Estimation */
+  static int hf_homeplug_rce   = -1;
+static int hf_homeplug_rce_cev = -1;
+static int hf_homeplug_rce_rsvd= -1;
+  /* Channel Estimation Response */
+  static int hf_homeplug_cer   = -1;
+static int hf_homeplug_cer_cerv= -1;
+static int hf_homeplug_cer_rsvd1   = -1;
+static int hf_homeplug_cer_rxtmi   = -1;
+static int hf_homeplug_cer_vt  = -1;
+static int hf_homeplug_cer_rate= -1;
+static int hf_homeplug_cer_bp  = -1;
+static int hf_homeplug_cer_mod = -1;
+static int hf_homeplug_cer_vt11= -1;
+static int hf_homeplug_cer_rsvd2   = -1;
+static int hf_homeplug_cer_nbdas   = -1;
+static int hf_homeplug_cer_bda = -1;
+  /* Request Parameters and Statistics */
+  static int hf_homeplug_rps   = -1;
+  /* Parameters and Statistics Response */
+  static int hf_homeplug_psr   = -1;
+static int hf_homeplug_psr_txack   = -1;
+static int hf_homeplug_psr_txnack  = -1;
+static int hf_homeplug_psr_txfail  = -1;
+static int hf_homeplug_psr_txcloss = -1;
+static int hf_homeplug_psr_txcoll  = -1;
+static int hf_homeplug_psr_txca3lat= -1;
+static int 

Re: [Wireshark-dev] [PATCH] strptime implicit declaration warning

2007-01-16 Thread Stephen Fisher
On Tue, Jan 16, 2007 at 06:21:44PM +0100, Sebastien Tandel wrote:
 
a patch to avoid the warning implicit declaration of function 
 'strptime' in editcap.c glib.h is included just after the define 
 __USE_XOPEN and include time.h

This was committed by Jaap as rev 20455.


Steve

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Stephen Fisher

On Tue, Jan 16, 2007 at 12:01:17PM +0100, Gisle Vanem wrote:

 --- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007
 +++ epan\crypt\airpdcap.c   Tue Jan 16 11:59:58 2007
 @@ -1663,7 +1663,7 @@
 else
 output_string = g_strdup_printf(%s:%s:%s,
 STRING_KEY_TYPE_WPA_PWD,dk-key-str,
 -   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len);
 +   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len));
 }
 else if(dk-type == AIRPDCAP_KEY_TYPE_WPA_PMK)
 {
 
 ---

Thanks for your patch, I have applied the change as svn revision 20457.

 Please test your changes (compile it) before checking in !

It was probably missed because it is within an #ifdef HAVE_AIRPDCAP, 
that not everyone has.  Sorry for the trouble.


Steve
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] New GTK Glib Pango for Windows

2007-01-16 Thread Anders Broman
Hi,
There's been a new update to the GTK libraries do we want to bring them in
or is it to close to the release?
(The files are on our server).
BR
Anders

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] New GTK Glib Pango for Windows

2007-01-16 Thread Ulf Lamping
Anders Broman wrote:
 Hi,
 There's been a new update to the GTK libraries do we want to bring them in
 or is it to close to the release?
 (The files are on our server).
   
Couldn't find the release notes - gtk.org doesn't even list the versions 
- so it's difficult to say if somethings interesting for us changed!

Did you tried it with Wireshark, so at least things don't get worse at 
least?

Regards, ULFL
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


[Wireshark-dev] CLS column / font problem

2007-01-16 Thread Stephen Fisher
Has anyone else noticed that the CLS time column is not wide enough for 
the contents when you start a new capture when using the date+time or 
just time?  Adjusting the time precision fixes it.  Opening a new 
capture file does not have this problem.  I'm seeing this on Ethereal 
0.99.0 and Wireshark SVN on Windows and Unix.

I've traced the problem down to gtk/packet_list.c line 477:

gtk_widget_modify_font(packet_list, font);

If you place a printf before and after it to display the string 
pango_font_description_to_string(packet_list-style-font_desc), it 
remains unchanged from the GTK default of Sans 10.  Font is Monospace 10 
(proven with a similar printf statement).

This appears to be causing the width of the CLS time column to be 
calculated with the wrong font (Sans 10) instead of Monospace 10.

A work-around is to modify the font in the GtkWidget packet_list 
directly:

packet_list-style-font_desc = font;

Anyone have an idea why this is happening?  This is the closest message 
I've found in the gtk-list archives describing this issue:

http://mail.gnome.org/archives/gtk-app-devel-list/2002-July/msg00090.html


Thanks,
  Steve

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev


Re: [Wireshark-dev] New GTK Glib Pango for Windows

2007-01-16 Thread Anders Broman


-Ursprungligt meddelande-
Från: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] För Ulf Lamping
Skickat: den 17 januari 2007 00:30
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] New GTK Glib Pango for Windows

Anders Broman wrote:
 Hi,
 There's been a new update to the GTK libraries do we want to bring them
in
 or is it to close to the release?
 (The files are on our server).
   
Couldn't find the release notes - gtk.org doesn't even list the versions 
- so it's difficult to say if somethings interesting for us changed!

GTK+
=
http://mail.gnome.org/archives/gtk-devel-list/2007-January/msg00052.html

Overview of Changes from GTK+ 2.10.6 to 2.10.7
==

* GtkNotebook 
 - Tab reordering is a less intrusive
 - Rendering fixes on win32

* GtkTreeView
  - Column resizing works correctly in right-to-left languages
  - Many scrolling bugs have been fixed

* GtkTextView:
  - Improved scrolling during DND.

* GtkRecentManager is more robust against bad URIs

* Print support:
 - The cups backend works with 'BrowseShortNames Off' 
   in the cups configuration
 - Multi-valued options are properly passed to cups
 - Fix build with cups 1.3
 - A few IPP compliance issues have been fixed
 - Make the lpr backend work on BSD

* Input methods:
 - GtkEntryCompletion works with input methods
 - The Thai input method has been replace by a functional
   Thai and Lao input method based on libthai

* Accessibility support:
 - GtkMessageDialog sets accessible name role explicitly

* Theme support:
 - The semantics of the gtk-color-scheme setting has been
   slightly changed. Values from rc files are still merged
   together, but the X setting just overrides the prior table.

* GdkPixbuf:
 - gdk_pixbuf_loader_write() now closes the loader when 
   returning FALSE, as documented
 - The BMP loader supports more BMP variants, including 
   transparency and 10-bit channels.

* Bugs fixed:
 122688 modal dialog popup + drag in progress = mouse freeze
 315732 gnome-session crash on login
 335622 Click Description field causes Evolution to crash.
 357050 Crash replacing \n\n with \n or undoing after paste
 359537 printing custom page
 373466 crash in Text Editor:
 388041 crash in Open Folder: nada
 390873 crash in Text Editor: I had just opened it up ...
 367529 gtk_combo_box_set_model(combo, NULL) generates warning wh...
 381499 xdgmime requires getc_unlocked, darwin 6 lacks
 349119 GtkUIManager crashes on wrong action names in an XML file
 363437 gnome-panel crash to gtkrecentmanager code
 366782 GtkTreeView expand_all can crash if a node's children a...
 374378 Crash as GTK tries to blink cursor in defocused spinbutto...
 381236 apps crash when using a mouse cursor theme as icon theme
 320465 gtk_window_parse_geometry is almost completely broken
 355350 Page Setup, Range and Copy information ignored
 387170 Fairly large leak in gtk+
 390159 printing with BSD lpr does not work properly
  64998 GtkEntry - gtk_entry_set_text emits changed twice
  92387 unfriendly drag-n-drop in textview - scrolls too fast
 172188 io-bmp.c should sanity check the size given by the OffBit...
 304482 GtkComboBoxEntry editable entry should be centered vertic...
 315440 Problem with gtkpaned inside gtknotebook(mouse wheel over...
 317064 GtkTextBuffer signals documentation
 317080 Incorrect gtk.immodules might make GTK+ lose its translation
 330683 Changing selection by up/down does not move to top/bottom.
 335473 gtk_file_chooser_button_new_with_dialog() is too strict
 337261 about dialogue initial focus
 339752 Please use LOCALE_IFIRSTDAYOFWEEK for GtkCalendar on Windows
 339756 LANG and LC_* environment variables should affect the C r...
 349638 Cannot Compose (multi_key) polish l (or L) with stroke, ł
 350342 Alt+Left/Right reorders tabs if not swallowed by Gecko
 351678 Notebooks not with PositionType.Top drawn incorrectly
 351679 Notebooks drawn with extra line below tab in MS-Windows t...
 352276 Location of G_GNUC_INTERNAL breaks Solaris build
 352435 GtkProgressBar text rendering errors
 352738 gtk_tree_view_column_set_sort_indicator() fails to show a...
 352795 configure.in: Bug in checking Whether to write dependenc...
 353438 Add tiny extra docs to gdk_beep
 353709 GtkEntry shift-click inside selected text can behave funny
 354495 Compose key doesn't work on location entry
 357578 No grid lines are drawn
 357974 Crashes (failed assertatin)
 359231 validate_visible_area() sometimes passes mismatches (tree...
 359542 scale capability for Unix print dialog box can not be set...
 359581 GtkCellView clobbers parent's GdkWindow on style-set
 360350 leak in gtk_radio_button_focus
 362439 gtkicontheme::pixbuf_supports_svg leaks GList
 362614 gtk_widget_show does not check for NULL arg
 363191 gtk_tree_view_set_cursor() does not make row fully visible
 364514 gtk leaks GDI objects on the win32 classic look and feel
 364866 CUPS http_t type is becoming opaque
 364868 GDI resource leak