Re: [Wireshark-dev] cmake giving options the compiler does not understand
On 01/03/2014 01:31 PM, Jeff Morriss wrote: On 01/02/2014 07:42 PM, Joerg Mayer wrote: On Thu, Jan 02, 2014 at 04:30:14PM -0800, Guy Harris wrote: Are we really encountering a case where the C compiler accepts -Wshorten-64-to-32 but the C++ compiler doesn't, or *vice versa*? Or are we encountering a case where *neither* compiler accepts it, but CMake isn't detecting that? Neither compiler supports that option. It's highly unlikely that this directory was previously used with a compiler that *did* support it (unless Fedora pushed out a compiler downgrade) but I suppose it is possible. I don't know. On my (32-bit) system, both compilers correctly report that it is not supported. I'd need to see the cmake output on a system that has this problem. Unfortunately the evidence is all gone now. Maybe if I hit the problem again in the future... Ah, OK, I found a way to reproduce it (in current SVN): 1) rm -rf _cmake_build 2) mkdir _cmake_build cd _cmake_build 3) vi ../CMakeLists.txt 4) Move the -Wshorten-64-to-32 flag from where it is in the file to just after -Wshadow 5) cmake .. 6) make # just to show that it works (I stopped the build after a few C files were compiled) 7) vi ../CMakeLists.txt 8) Put -Wshorten-64-to-32 back where it was (at the end of WIRESHARK_C_ONLY_FLAGS) 9) cmake .. 10) make # now it doesn't work, complaining that -Wshorten-64-to-32 is an unknown option -- It seems cmake isn't caching the result of the test but rather the value of the variable we're storing the result in (e.g., WS_C_FLAG_VALID39). ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] cmake giving options the compiler does not understand
On Sat, Jan 04, 2014 at 12:17:35PM -0500, Jeff Morriss wrote: It's highly unlikely that this directory was previously used with a compiler that *did* support it (unless Fedora pushed out a compiler downgrade) but I suppose it is possible. I don't know. On my (32-bit) system, both compilers correctly report that it is not supported. I'd need to see the cmake output on a system that has this problem. Unfortunately the evidence is all gone now. Maybe if I hit the problem again in the future... Ah, OK, I found a way to reproduce it (in current SVN): 1) rm -rf _cmake_build 2) mkdir _cmake_build cd _cmake_build 3) vi ../CMakeLists.txt 4) Move the -Wshorten-64-to-32 flag from where it is in the file to just after -Wshadow 5) cmake .. 6) make # just to show that it works (I stopped the build after a few C files were compiled) 7) vi ../CMakeLists.txt 8) Put -Wshorten-64-to-32 back where it was (at the end of WIRESHARK_C_ONLY_FLAGS) 9) cmake .. 10) make # now it doesn't work, complaining that -Wshorten-64-to-32 is an unknown option -- It seems cmake isn't caching the result of the test but rather the value of the variable we're storing the result in (e.g., WS_C_FLAG_VALID39). OK, I still tend to regard this as a caching problem. It also looks like an unusual use case what you are doing. What prompted you to do that? Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: CMakeLists.txt Makefile.am Makefile.common QtShark.pro about_dialog.cpp about_dialog.h about_dialog.u
On Thu, Jan 02, 2014 at 07:12:27PM +0100, Joerg Mayer wrote: On Thu, Jan 02, 2014 at 05:04:10PM +, alagou...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=54557 User: alagoutte Date: 2014/01/02 05:04 PM Log: Add About window for Wireshark Qt Great! Just some nitpicks: - The plugins list is empty (maybe something wrong with my setup?) OK, while the plugin list is emptry I do see unistim in [Edit] - [Preferences] - [Protocols] - [UNISTIM] So I guess the plugins get loaded and just not displayed in the about dialog. - The authors list is not formatted - The release notes have not been updated Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] cmake giving options the compiler does not understand
On 01/04/2014 06:01 PM, Joerg Mayer wrote: On Sat, Jan 04, 2014 at 12:17:35PM -0500, Jeff Morriss wrote: It's highly unlikely that this directory was previously used with a compiler that *did* support it (unless Fedora pushed out a compiler downgrade) but I suppose it is possible. I don't know. On my (32-bit) system, both compilers correctly report that it is not supported. I'd need to see the cmake output on a system that has this problem. Unfortunately the evidence is all gone now. Maybe if I hit the problem again in the future... Ah, OK, I found a way to reproduce it (in current SVN): 1) rm -rf _cmake_build 2) mkdir _cmake_build cd _cmake_build 3) vi ../CMakeLists.txt 4) Move the -Wshorten-64-to-32 flag from where it is in the file to just after -Wshadow 5) cmake .. 6) make # just to show that it works (I stopped the build after a few C files were compiled) 7) vi ../CMakeLists.txt 8) Put -Wshorten-64-to-32 back where it was (at the end of WIRESHARK_C_ONLY_FLAGS) 9) cmake .. 10) make # now it doesn't work, complaining that -Wshorten-64-to-32 is an unknown option -- It seems cmake isn't caching the result of the test but rather the value of the variable we're storing the result in (e.g., WS_C_FLAG_VALID39). OK, I still tend to regard this as a caching problem. It also looks like an unusual use case what you are doing. What prompted you to do that? Just looking for a way to reproduce the problem. The idea it was caching the wrong thing popped into my head. I think it explains well why I hit it and why Alexis said he occasionally hits it: when we hit it it's probably because someone reordered the flags. Could the variable to store the names simply include the compiler option? It doesn't appear that the code relies on them being numbered 1,2,3,4... Well, that doesn't work because it doesn't seem to like the variable name very much:: -- Checking for flag: -Wc++-compat RegularExpression::compile(): Nested *?+. RegularExpression::compile(): Error in compile. CMake Error at /usr/share/cmake/Modules/CheckCSourceCompiles.cmake:30 (if): if given arguments: WS_C_FLAG_VALID-Wc++-compat MATCHES ^WS_C_FLAG_VALID-Wc++-compat\$ Regular expression ^WS_C_FLAG_VALID-Wc++-compat$ cannot compile Hmmm ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] cmake giving options the compiler does not understand
On Jan 4, 2014, at 9:17 AM, Jeff Morriss jeff.morriss...@gmail.com wrote: Ah, OK, I found a way to reproduce it (in current SVN): 1) rm -rf _cmake_build 2) mkdir _cmake_build cd _cmake_build 3) vi ../CMakeLists.txt 4) Move the -Wshorten-64-to-32 flag from where it is in the file to just after -Wshadow 5) cmake .. Presumably CMake then reports something such as -- Checking for flag: -Wshorten-64-to-32 -- Performing Test WS_C_FLAG_VALID44 -- Performing Test WS_C_FLAG_VALID44 - Failed in that case, meaning it thinks -Wshorten-64-to-32 isn't supported by the C compiler? 6) make # just to show that it works (I stopped the build after a few C files were compiled) 7) vi ../CMakeLists.txt 8) Put -Wshorten-64-to-32 back where it was (at the end of WIRESHARK_C_ONLY_FLAGS) 9) cmake .. Presumably CMake then reports something such as -- Checking for flag: -Wshorten-64-to-32 -- Performing Test WS_C_FLAG_VALID44 -- Performing Test WS_C_FLAG_VALID44 - Success in that case, meaning it thinks -Wshorten-64-to-32 *is* supported by the C compiler? Which version of which compiler is this? (You said Fedora, so I presume it's either GCC or Clang; which version of Fedora is it?) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] how to read the wireshark src code
fellows:can you tell me how to read the wireshark src code and the access point?(wireshark ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
