Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: CMakeLists.txt Makefile.am Makefile.common QtShark.pro about_dialog.cpp about_dialog.h about_dialog.u

2014-01-05 Thread Alexis La Goutte
Hi,

It is possible to indicate the path of Global Plugin for GTK and Qt ? (in
Folders Tab)

Regards,


On Sun, Jan 5, 2014 at 12:04 AM, Joerg Mayer jma...@loplof.de wrote:

 On Thu, Jan 02, 2014 at 07:12:27PM +0100, Joerg Mayer wrote:
  On Thu, Jan 02, 2014 at 05:04:10PM +, alagou...@wireshark.org wrote:
   http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=54557
  
   User: alagoutte
   Date: 2014/01/02 05:04 PM
  
   Log:
Add About window for Wireshark Qt
 
  Great! Just some nitpicks:
  - The plugins list is empty (maybe something wrong with my setup?)

 OK, while the plugin list is emptry I do see unistim in
 [Edit] - [Preferences] - [Protocols] - [UNISTIM]
 So I guess the plugins get loaded and just not displayed in the
 about dialog.

  - The authors list is not formatted
  - The release notes have not been updated

 Ciao
Jörg

 --
 Joerg Mayer   jma...@loplof.de
 We are stuck with technology when what we really want is just stuff that
 works. Some say that should read Microsoft instead of technology.
 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Remove update.c (and nio-ie5.[ch])

2014-01-05 Thread Alexis La Goutte
Hi,

i found by hazard this file : nio-ie5.c and check the source, the file is
used by update.c.
Check the svn log and update.c has never (really) used... may be remove
this files ?

(The check update use Spkarle in Windows and Mac OS X).

Regards,
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] cmake giving options the compiler does not understand

2014-01-05 Thread Jeff Morriss

On 01/04/2014 09:51 PM, Guy Harris wrote:


On Jan 4, 2014, at 9:17 AM, Jeff Morriss jeff.morriss...@gmail.com wrote:


Ah, OK, I found a way to reproduce it (in current SVN):

1) rm -rf _cmake_build
2) mkdir _cmake_build  cd _cmake_build
3) vi ../CMakeLists.txt
4) Move the -Wshorten-64-to-32 flag from where it is in the file to just after 
-Wshadow
5) cmake ..


Presumably CMake then reports something such as

-- Checking for flag: -Wshorten-64-to-32
-- Performing Test WS_C_FLAG_VALID44
-- Performing Test WS_C_FLAG_VALID44 - Failed

in that case, meaning it thinks -Wshorten-64-to-32 isn't supported by the C 
compiler?


Yep:

-- Checking for flag: -Wshorten-64-to-32
-- Performing Test WS_C_FLAG_VALID39
-- Performing Test WS_C_FLAG_VALID39 - Failed


6) make # just to show that it works (I stopped the build after a few C files 
were compiled)
7) vi ../CMakeLists.txt
8) Put -Wshorten-64-to-32 back where it was (at the end of 
WIRESHARK_C_ONLY_FLAGS)
9) cmake ..


Presumably CMake then reports something such as

-- Checking for flag: -Wshorten-64-to-32
-- Performing Test WS_C_FLAG_VALID44
-- Performing Test WS_C_FLAG_VALID44 - Success

in that case, meaning it thinks -Wshorten-64-to-32 *is* supported by the C 
compiler?


Well it doesn't do the full check on this (cached) pass, it just says:

-- Checking for flag: -Wjump-misses-init
-- Checking for flag: -Wshorten-64-to-32
-- C-Flags:  -Wall -W -Wextra -Wendif-labels [...]


Which version of which compiler is this?  (You said Fedora, so I presume it's 
either GCC or Clang; which version of Fedora is it?)


I first hit the problem on Fedora 18 (I'd have to check on the compiler 
version but it was gcc).  The method quoted above was reproduced on 
Fedora 19 (gcc 4.8.2).


___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] cmake giving options the compiler does not understand

2014-01-05 Thread Guy Harris

On Jan 5, 2014, at 10:00 AM, Jeff Morriss jeff.morriss...@gmail.com wrote:

 On 01/04/2014 09:51 PM, Guy Harris wrote:
 
 On Jan 4, 2014, at 9:17 AM, Jeff Morriss jeff.morriss...@gmail.com wrote:
 

 6) make # just to show that it works (I stopped the build after a few C 
 files were compiled)
 7) vi ../CMakeLists.txt
 8) Put -Wshorten-64-to-32 back where it was (at the end of 
 WIRESHARK_C_ONLY_FLAGS)
 9) cmake ..
 
 Presumably CMake then reports something such as
 
  -- Checking for flag: -Wshorten-64-to-32
  -- Performing Test WS_C_FLAG_VALID44
  -- Performing Test WS_C_FLAG_VALID44 - Success
 
 in that case, meaning it thinks -Wshorten-64-to-32 *is* supported by the C 
 compiler?
 
 Well it doesn't do the full check on this (cached) pass, it just says:
 
 -- Checking for flag: -Wjump-misses-init
 -- Checking for flag: -Wshorten-64-to-32
 -- C-Flags:  -Wall -W -Wextra -Wendif-labels [...]

So is the issue that the tests have the ordinal number of the flag, rather than 
the name of the flag, in the name of the test, with that name being used when 
caching results, so that the cache is bogus if you've reordered the flags since 
the cached results are generated?

(Presumably this also caused some flag that *does* work *not* to be added, as 
the results of the test of -Wshorten-64-to-32 were used on that flag.)

 Which version of which compiler is this?  (You said Fedora, so I presume 
 it's either GCC or Clang; which version of Fedora is it?)
 
 I first hit the problem on Fedora 18 (I'd have to check on the compiler 
 version but it was gcc).  The method quoted above was reproduced on Fedora 19 
 (gcc 4.8.2).


Apparently GNU GCC 4.8.2 doesn't support -Wshorten-64-to-32.

So maybe Apple were the first people to realize that maybe checking for 
inadvertently chopping off the upper 32 bits of a value, because your code 
wasn't 64-bit-clean, was a good idea?

Perhaps someday somebody involved with GCC will realize that maybe checking for 
*all* shortenings without an explicit cast might be a good idea (which 
Microsoft figured out a while ago, that being one of the reasons why the build 
breaks on the Windows builds - MSVC is treating such a shortening as an error).
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe