[Wireshark-dev] Thanks for the Manual

2014-10-15 Thread Emre Baris

Nice software, works great on the back of the tahr (3.13.0-24-gen)
Clear and pure manual, thanks.

Some typos
In 1.2. System Requirements, files no mor than a few hundred MB
In 4.9.2. Remote Capture Settings, an interface other then the interface 
connecting back to Wireshark


~emre
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Thanks for the Manual

2014-10-15 Thread Stig Bjørlykke
On Wed, Oct 15, 2014 at 1:35 AM, Emre Baris
emre.bar...@ceng.metu.edu.tr wrote:
 Some typos
 In 1.2. System Requirements, files no mor than a few hundred MB
 In 4.9.2. Remote Capture Settings, an interface other then the interface
 connecting back to Wireshark

Thank you for the report.

This will be fixed in the next release.


-- 
Stig Bjørlykke
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] 25 Warnings on Clang Scan Build

2014-10-15 Thread Bálint Réczey
2014-10-14 21:41 GMT+02:00 Alexis La Goutte alexis.lagou...@gmail.com:
 Hi,

 For the first time, you are under 25 warnings on Clang scan-build :-D
 ( https://www.wireshark.org/download/automated/analysis/ )

 A quick review about last warnings :
 3 coming from flex (Dead Assignement on ascend_scanner.c, k12text.c,
 ascend.c), need to fix flex on upstream...


 10 coming from lemon (sqlite), i have start to update lemon from
 upstream ( https://code.wireshark.org/review/#/c/3976/ ) but all
 warning is no fixed...

 and last warning is Dereference of null pointer not yet look all
 warning but some warning is false postive (packet-ber...)
Great news!

Cheers,
Balint
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] ARM Build

2014-10-15 Thread Alexis La Goutte
Hi,

I have try to build wireshark on ARM(v7) Machine (Using the new cloud
from Online.net[1])

I have try to build lasted trunk/master of wireshark (to test speed..)
but don't build :

ftype-pcre.c: In function 'raw_flag_needed':
ftype-pcre.c:64:13: error: comparison is always true due to limited
range of data type [-Werror=type
-limits]
 (s[i] = '\xFA'  s[i] = '\xFF'))
 ^
packet-mac-lte.c: In function 'dissect_mac_lte':
packet-mac-lte.c:5334:39: error: 'rapid_description' may be used
uninitialized in this function [-We
rror=maybe-uninitialized]
 expert_add_info_format(pinfo, ti,
   ^
cc1: all warnings being treated as errors
./wslua_internals.c: In function 'wslua_hex2bin':
./wslua_internals.c:556:9: error: comparison is always false due to
limited range of data type [-Wer
ror=type-limits]
 if (c  0) {
 ^
./wslua_internals.c:565:9: error: comparison is always false due to
limited range of data type [-Wer
ror=type-limits]
 if (d  0) break;
 ^
strutil.c: In function 'hex_str_to_bytes_encoding':
strutil.c:634:13: error: comparison is always false due to limited
range of data type [-Werror=type-
limits]
 if (c  0) {
 ^
strutil.c:641:13: error: comparison is always false due to limited
range of data type [-Werror=type-
limits]
 if (d  0) {
 ^
strutil.c:650:13: error: comparison is always true due to limited
range of data type [-Werror=type-l
imits]
 if (sep  0  *end == sep  str_to_nibble[(int)*(end+1)]  -1) {
 ^
airpcap_loader.c: In function 'airpcap_if_get_device_supported_channels_array':
airpcap_loader.c:841:17: error: case label value is less than minimum
value for type [-Werror]
 case -1:
 ^
airpcap_loader.c:870:17: error: case label value is less than minimum
value for type [-Werror]
 case -1:
 ^

The machine use Ubuntu 14.04 TLS (armhf) with standard GCC :
root@c1-10-1-10-225:~/wireshark# gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-linux-gnueabihf/4.8/lto-wrapper
Target: arm-linux-gnueabihf
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro
4.8.2-19ubuntu1'
--with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs
--enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr
--program-suffix=-4.8 --enable-shared --enable-linker-build-id
--libexecdir=/usr/lib --without-included-gettext
--enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.8
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcx(x-debug --enable-libstdcxx-time=yes
--enable-gnu-unique-object --disable-libmudflap --disable-libitm
--disable-libquadmath --enable-plugin --with-system-zlib
--disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-armhf/jre
--enable-java-home
--with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-armhf
--with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-armhf
--with-arch-directory=arm
--with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc
--enable-multiarch --enable-multilib --disable-sjlj-exceptions
--with-arch=armv7-a --with-fpu=vfpv3-d16 --with-float=hard
--with-mode=thumb --disable-werror --enable-checking=release
--build=arm-linux-gnueabihf --host=arm-linux-gnueabihf
--target=arm-linux-gnueabihf
Thread model: posix
gcc version 4.8.2 (Ubuntu/Linaro 4.8.2-19ubuntu1)


May be time to add ARM trunk buildbot ? ;-)


[1] http://labs.online.net/#/ (It is possible to try for free...)
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] ARM Build

2014-10-15 Thread Guy Harris

On Oct 15, 2014, at 11:03 AM, Alexis La Goutte alexis.lagou...@gmail.com 
wrote:

 Hi,
 
 I have try to build wireshark on ARM(v7) Machine

...which may be running a compiler in which char is unsigned; I seem to 
remember that issue coming up with some software in the past couple of months 
(possibly Wireshark, possibly libpcap or tcpdump).

 I have try to build lasted trunk/master of wireshark (to test speed..)
 but don't build :
 
 ftype-pcre.c: In function 'raw_flag_needed':
 ftype-pcre.c:64:13: error: comparison is always true due to limited
 range of data type [-Werror=type
 -limits]
 (s[i] = '\xFA'  s[i] = '\xFF'))
 ^

We should probably make s a const guchar *, and do the appropriate cast.

 cc1: all warnings being treated as errors
 ./wslua_internals.c: In function 'wslua_hex2bin':
 ./wslua_internals.c:556:9: error: comparison is always false due to
 limited range of data type [-Wer
 ror=type-limits]
 if (c  0) {
 ^
 ./wslua_internals.c:565:9: error: comparison is always false due to
 limited range of data type [-Wer
 ror=type-limits]
 if (d  0) break;
 ^

static const char str_to_nibble[] should be static const gint8 
str_to_nibble[], and char c, d should be gint8 c, d (the underlying data 
type would be signed char, but they're 8-bit signed integers, not characters, 
so gint8 is clearer).

 strutil.c: In function 'hex_str_to_bytes_encoding':
 strutil.c:634:13: error: comparison is always false due to limited
 range of data type [-Werror=type-
 limits]
 if (c  0) {
 ^
 strutil.c:641:13: error: comparison is always false due to limited
 range of data type [-Werror=type-
 limits]
 if (d  0) {
 ^

 strutil.c:650:13: error: comparison is always true due to limited
 range of data type [-Werror=type-l
 imits]
 if (sep  0  *end == sep  str_to_nibble[(int)*(end+1)]  -1) {
 ^

...and the same applies there.

 airpcap_loader.c: In function 
 'airpcap_if_get_device_supported_channels_array':
 airpcap_loader.c:841:17: error: case label value is less than minimum
 value for type [-Werror]
 case -1:
 ^
 airpcap_loader.c:870:17: error: case label value is less than minimum
 value for type [-Werror]
 case -1:
 ^

Change ExtChannel in struct _AirpcapChannelInfo in caputils/airpcap.h from 
gchar to gint8.  (And, yes, if there's a similar structure in the AirPcap SDK, 
the AirPcap developers should make sure it's not char - make it some 
appropriate guaranteed-to-be-signed 8-bit data type, whether signed char or 
something else.)

 May be time to add ARM trunk buildbot ? ;-)

Sounds good.  (Some compilers that default to signed char might have an 
option to make char unsigned, which would work also, but if we chose to check 
unsigned char on some platform where it's *not* the default, we would want to 
test with both signed *and* unsigned char on that platform - the first to 
make sure it's OK for a normal build on that platform and the second to check 
for unsigned char.)

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe