Re: [Wireshark-dev] Cannot find krb5.h

2019-02-07 Thread Graham Bloice
Hi David,

Unfortunately once CMake caches a result, then it remains until
intervention takes place.  Successive runs of CMake do NOT recheck cached
results, hence they run much quicker.

The CMakeCache.txt interventions are only required when a path to a lib
changes (or a header\DLL in a lib changes name).

On Thu, 7 Feb 2019 at 14:42,  wrote:

> Pascal, Graham,
>
>
>
> Thanks. That fixed it. It contained the wrong pointers. (still to
> kfw-3-2-2-x64-ws)
>
>
>
> My (wrong) assumption was, that following would take care of all of the
> dependency management.
>
>
>
> cmake -G "Visual Studio 15 2017 Win64" C:\Development\current\wireshark
>
>
>
> This is what I run after a pull.
>
>
>
> I’ve deleted CMakeCache.txt (or better say added it to my prep script).
> I’m not running that one that often, so the 2-3 minutes extra
>
> are well digestible for me.
>
>
>
> Regards
>
> David
>
>
>
> *From:* Wireshark-dev  *On Behalf Of
> *Graham Bloice
> *Sent:* Thursday, February 7, 2019 2:00 PM
> *To:* Developer support list for Wireshark 
> *Subject:* Re: [Wireshark-dev] Cannot find krb5.h
>
>
>
>
>
>
>
> On Thu, 7 Feb 2019 at 12:45, Pascal Quantin  wrote:
>
> Hi David,
>
>
>
> Le jeu. 7 févr. 2019 à 12:58,  a écrit :
>
>
>
> I’ve updated my machine to VS2017, Latest, Qt, Git, Python, …. And I got
> rid of cygwin and vs2015
>
> The setup should match the instruction, but apparently not quite. (win10,
> x64)
>
>
>
> Right now I fail to build latest master (a clean build does not help,
> deleting all libs neither)
>
>
>
> "C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj"
> (default target) (101) ->
>
>(ClCompile target) ->
>
>  ./asn1/kerberos/packet-kerberos-template.c(260): fatal error
> C1083: Cannot open include file: 'krb5.h': No such file or directory
> (compiling source file C:\Development\current\wireshark\epan\dissectors
>
>\packet-kerberos.c)
> [C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj]
>
>
>
> The prep downloaded and extracted ‘krb5-1.17-win64ws’.
>
>
>
> Any ideas on which component, environment variable, setting … am I
> missing?
>
>
>
> So what's the content of the CMakeCache.txt file in your build folder?
> Mine contains the following lines and I have no issue building Wireshark
> source code:
>
>
>
> //Kerberos DLL list
> KERBEROS_DLLS:FILEPATH=comerr64.dll;k5sprt64.dll;krb5_64.dll
>
> //Path to the Kerberos DLLs
>
> KERBEROS_DLL_DIR:PATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/bin
>
> //Path to a file.
>
> KERBEROS_INCLUDE_DIR:PATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/include
>
> //Path to a library.
>
> KERBEROS_LIBRARY:FILEPATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/lib/krb5_64.lib
>
>
>
> Best regards,
>
> Pascal.
>
>
>
>
>
> This is a bit of an annoyance when a package is updated that has a new
> path in the libs directory, in that you have to either delete
> CMakeCache.txt entirely and regenerate it (slow), or edit it to remove the
> old paths, not much quicker and error prone.
>
>
>
> I've been thinking about this for a while, what I think we could do is
> invalidate the CMake cache variables when a lib is updated.  How we wire
> all that up is the more difficult part.  There is the
> get_cmake_property(_var VARIABLES) command that will list all variables (it
> does say this is for debugging though), we could make a guess that all vars
> for a lib start with the lib name, iterate over the list and if a suspect
> is found unset() it.  The list of libs to unset would have to be passed
> back from the PowerShell script.
>
>
>
> --
>
> Graham Bloice
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 
Graham Bloice
Software Developer
Trihedral UK Limited
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cannot find krb5.h

2019-02-07 Thread david_aggeler
Pascal, Graham,

 

Thanks. That fixed it. It contained the wrong pointers. (still to 
kfw-3-2-2-x64-ws)

 

My (wrong) assumption was, that following would take care of all of the 
dependency management.

 

cmake -G "Visual Studio 15 2017 Win64" C:\Development\current\wireshark

 

This is what I run after a pull.

 

I’ve deleted CMakeCache.txt (or better say added it to my prep script). I’m not 
running that one that often, so the 2-3 minutes extra

are well digestible for me.

 

Regards

David

 

From: Wireshark-dev  On Behalf Of Graham 
Bloice
Sent: Thursday, February 7, 2019 2:00 PM
To: Developer support list for Wireshark 
Subject: Re: [Wireshark-dev] Cannot find krb5.h

 

 

 

On Thu, 7 Feb 2019 at 12:45, Pascal Quantin mailto:pas...@wireshark.org> > wrote:

Hi David,

 

Le jeu. 7 févr. 2019 à 12:58, mailto:david_agge...@hispeed.ch> > a écrit :

 

I’ve updated my machine to VS2017, Latest, Qt, Git, Python, …. And I got rid of 
cygwin and vs2015

The setup should match the instruction, but apparently not quite. (win10, x64)

 

Right now I fail to build latest master (a clean build does not help, deleting 
all libs neither)

 

"C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj" (default 
target) (101) ->

   (ClCompile target) ->

 ./asn1/kerberos/packet-kerberos-template.c(260): fatal error C1083: 
Cannot open include file: 'krb5.h': No such file or directory (compiling source 
file C:\Development\current\wireshark\epan\dissectors

   \packet-kerberos.c) 
[C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj]

 

The prep downloaded and extracted ‘krb5-1.17-win64ws’.

 

Any ideas on which component, environment variable, setting … am I missing? 

 

So what's the content of the CMakeCache.txt file in your build folder? Mine 
contains the following lines and I have no issue building Wireshark source code:

 

//Kerberos DLL list
KERBEROS_DLLS:FILEPATH=comerr64.dll;k5sprt64.dll;krb5_64.dll

//Path to the Kerberos DLLs
KERBEROS_DLL_DIR:PATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/bin

//Path to a file.
KERBEROS_INCLUDE_DIR:PATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/include

//Path to a library.
KERBEROS_LIBRARY:FILEPATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/lib/krb5_64.lib

 

Best regards,

Pascal.

 

 

This is a bit of an annoyance when a package is updated that has a new path in 
the libs directory, in that you have to either delete CMakeCache.txt entirely 
and regenerate it (slow), or edit it to remove the old paths, not much quicker 
and error prone.

 

I've been thinking about this for a while, what I think we could do is 
invalidate the CMake cache variables when a lib is updated.  How we wire all 
that up is the more difficult part.  There is the get_cmake_property(_var 
VARIABLES) command that will list all variables (it does say this is for 
debugging though), we could make a guess that all vars for a lib start with the 
lib name, iterate over the list and if a suspect is found unset() it.  The list 
of libs to unset would have to be passed back from the PowerShell script.

 

-- 

Graham Bloice

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cannot find krb5.h

2019-02-07 Thread Graham Bloice
On Thu, 7 Feb 2019 at 12:45, Pascal Quantin  wrote:

> Hi David,
>
> Le jeu. 7 févr. 2019 à 12:58,  a écrit :
>
>>
>>
>> I’ve updated my machine to VS2017, Latest, Qt, Git, Python, …. And I got
>> rid of cygwin and vs2015
>>
>> The setup should match the instruction, but apparently not quite. (win10,
>> x64)
>>
>>
>>
>> Right now I fail to build latest master (a clean build does not help,
>> deleting all libs neither)
>>
>>
>>
>> "C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj"
>> (default target) (101) ->
>>
>>(ClCompile target) ->
>>
>>  ./asn1/kerberos/packet-kerberos-template.c(260): fatal error
>> C1083: Cannot open include file: 'krb5.h': No such file or directory
>> (compiling source file C:\Development\current\wireshark\epan\dissectors
>>
>>\packet-kerberos.c)
>> [C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj]
>>
>>
>>
>> The prep downloaded and extracted ‘krb5-1.17-win64ws’.
>>
>>
>>
>> Any ideas on which component, environment variable, setting … am I
>> missing?
>>
>
> So what's the content of the CMakeCache.txt file in your build folder?
> Mine contains the following lines and I have no issue building Wireshark
> source code:
>
> //Kerberos DLL list
> KERBEROS_DLLS:FILEPATH=comerr64.dll;k5sprt64.dll;krb5_64.dll
>
> //Path to the Kerberos DLLs
>
> KERBEROS_DLL_DIR:PATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/bin
>
> //Path to a file.
>
> KERBEROS_INCLUDE_DIR:PATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/include
>
> //Path to a library.
>
> KERBEROS_LIBRARY:FILEPATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/lib/krb5_64.lib
>
> Best regards,
> Pascal.
>
>
This is a bit of an annoyance when a package is updated that has a new path
in the libs directory, in that you have to either delete CMakeCache.txt
entirely and regenerate it (slow), or edit it to remove the old paths, not
much quicker and error prone.

I've been thinking about this for a while, what I think we could do is
invalidate the CMake cache variables when a lib is updated.  How we wire
all that up is the more difficult part.  There is the
get_cmake_property(_var VARIABLES) command that will list all variables (it
does say this is for debugging though), we could make a guess that all vars
for a lib start with the lib name, iterate over the list and if a suspect
is found unset() it.  The list of libs to unset would have to be passed
back from the PowerShell script.

-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Wireshark on Kali linux

2019-02-07 Thread Graham Bloice
On Thu, 7 Feb 2019 at 10:34, Dario Lombardo  wrote:

> +1 from me for this as well. The warning should be there for anyone not
>> realizing that this is dangerous, but having the option to mute that
>> warning for people who know (or think they do) what they're doing makes
>> sense.
>>
>> My only concern is that if we expect the distribution people to
> deactivate it, and they don't care, we're are not moving. I'd like to have
> something that
> 1) doesn't rely on env variables, cmd line switches, preferences, any
> other stuff related to the way the software is launched, but works
> out-of-the-box. It's ok to rely on the package we distribute (Balint's
> package is not official, but he's a core-, so we're controlling it). If
> other distributions run "as root" and are based on rpm, we should cover
> that as well.
> 2) doesn't bother the users (basically no dialogs).
>

Surely it has to bother the user in some way, as otherwise there is no
point?  I'm not advocating the triple chase-the-dialog really, really
confirm type of dialog, but I do think it should be front and centre.

-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cannot find krb5.h

2019-02-07 Thread Pascal Quantin
Hi David,

Le jeu. 7 févr. 2019 à 12:58,  a écrit :

>
>
> I’ve updated my machine to VS2017, Latest, Qt, Git, Python, …. And I got
> rid of cygwin and vs2015
>
> The setup should match the instruction, but apparently not quite. (win10,
> x64)
>
>
>
> Right now I fail to build latest master (a clean build does not help,
> deleting all libs neither)
>
>
>
> "C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj"
> (default target) (101) ->
>
>(ClCompile target) ->
>
>  ./asn1/kerberos/packet-kerberos-template.c(260): fatal error
> C1083: Cannot open include file: 'krb5.h': No such file or directory
> (compiling source file C:\Development\current\wireshark\epan\dissectors
>
>\packet-kerberos.c)
> [C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj]
>
>
>
> The prep downloaded and extracted ‘krb5-1.17-win64ws’.
>
>
>
> Any ideas on which component, environment variable, setting … am I
> missing?
>

So what's the content of the CMakeCache.txt file in your build folder? Mine
contains the following lines and I have no issue building Wireshark source
code:

//Kerberos DLL list
KERBEROS_DLLS:FILEPATH=comerr64.dll;k5sprt64.dll;krb5_64.dll

//Path to the Kerberos DLLs
KERBEROS_DLL_DIR:PATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/bin

//Path to a file.
KERBEROS_INCLUDE_DIR:PATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/include

//Path to a library.
KERBEROS_LIBRARY:FILEPATH=C:/Wireshark-win64-libs/krb5-1.17-win64ws/installed/x64-windows/lib/krb5_64.lib

Best regards,
Pascal.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Cannot find krb5.h

2019-02-07 Thread david_aggeler
 

I've updated my machine to VS2017, Latest, Qt, Git, Python, .. And I got rid
of cygwin and vs2015

The setup should match the instruction, but apparently not quite. (win10,
x64)

 

Right now I fail to build latest master (a clean build does not help,
deleting all libs neither)

 

"C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj"
(default target) (101) ->

   (ClCompile target) ->

 ./asn1/kerberos/packet-kerberos-template.c(260): fatal error C1083:
Cannot open include file: 'krb5.h': No such file or directory (compiling
source file C:\Development\current\wireshark\epan\dissectors

   \packet-kerberos.c)
[C:\Development\current\wsbuild64\epan\dissectors\dissectors.vcxproj]

 

The prep downloaded and extracted 'krb5-1.17-win64ws'.

 

Any ideas on which component, environment variable, setting . am I missing? 

 

Regards

David

 

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Wireshark on Kali linux

2019-02-07 Thread Dario Lombardo
>
> +1 from me for this as well. The warning should be there for anyone not
> realizing that this is dangerous, but having the option to mute that
> warning for people who know (or think they do) what they're doing makes
> sense.
>
> My only concern is that if we expect the distribution people to deactivate
it, and they don't care, we're are not moving. I'd like to have something
that
1) doesn't rely on env variables, cmd line switches, preferences, any other
stuff related to the way the software is launched, but works
out-of-the-box. It's ok to rely on the package we distribute (Balint's
package is not official, but he's a core-, so we're controlling it). If
other distributions run "as root" and are based on rpm, we should cover
that as well.
2) doesn't bother the users (basically no dialogs).
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Wireshark on Kali linux

2019-02-07 Thread Jasper Bongertz
Title: Re: [Wireshark-dev] Wireshark on Kali linux








On Wed, 6 Feb 2019 at 17:32, Guy Harris  wrote:







So the question is whether we should print/pop up a message if TShark/Wireshark is running as root - and, if we do, whether we should have a compile or configuration option to disable that, so it can be disabled on Kali Linux or other OSes where you don't have much of a choice about whether to run them as root.




+1 for this.  I haven't entirely followed the preceding technical discussion as it's mostly about platforms I have little knowledge about, but this in general seems to be a fair approach.  Of course there will be those who have no need to run as "root", who will ignore the advice and disable the warning and continue to run as "root" on the way to ruin.  So be it, we will have tried.
 
--
Graham Bloice



+1 from me for this as well. The warning should be there for anyone not realizing that this is dangerous, but having the option to mute that warning for people who know (or think they do) what they're doing makes sense.


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Wireshark on Kali linux

2019-02-07 Thread Dario Lombardo
On Wed, Feb 6, 2019 at 11:26 PM João Valverde <
joao.valve...@tecnico.ulisboa.pt> wrote:

>
> I think a warning for "running Wireshark/tshark as root is dangerous" is
> very appropriate. There is a legitimate discussion to be had on whether
> it should be more or less forceful and what to do about Kali.
>
>
I agree, but it should not require any feedback from the user (as clicking
on a button) or it should be possible to deactivate it. But if we rely on
some action on the way it is run (like setting an option or an env var) we
could end up to nothing since it is under the control of the distribution,
not ours.
Something appearing in the toolbar, in the titlebar or in whatever bar
sounds good to me, but I guess it should be done from the core, not from
init.lua.

The 2 changes proposed by Peter sound good to me as well.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe