Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)
On Wed, Dec 13, 2006 at 10:02:57PM +0100, Stig Bj?rlykke wrote: > Den 13. des. 2006 kl. 21.24 skrev Stephen Fisher: > > > Please excuse my ignorance of this protocol, but is it different > > than what packet-s4406.c dissects? > > Yes, this one is very different. This is a very compact format used > for transmitting time-critical short X.400 messages (X.420 and STANAG > 4406) on low bandwidth channels, such as HF-radios. Thanks for your response. Could you create a new Wiki page for the DMP protocol that we just added and S4406 when you have a chance. You can create a new page by going to http://wiki.wireshark.org/[PROTONAME] and choosing Protocol Template on the left. If you could upload the sample capture you sent with the patches to implement DMP to http://wiki.wireshark.org/SampleCaptures, that would be nice too. Thanks, Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)
On Wed, Dec 13, 2006 at 05:49:58PM +0100, Stig Bj?rlykke wrote: > I have added a new dissector for DMP (STANAG 4406 Direct Message > Profile) as defined in STANAG 4406 Annex E. The DMP protocol has no > assigned UDP port number yet, so the default value in this dissector > is 0 (I suppose this is som sort of "disabled"?) until we get this > registered. Yes, port 0 is the way to leave a dissector unattached to a port. This allows the user to specify a port in the preferences or to right click and choose decode as and pick the protocol in there. > The dissector has been tested on OSX Intel/PowerPC and Solaris SPARC. I tested it on FreeBSD / x86. > Changes in this patch: > * Added DMP dissector > * Added a new CRC table and functions in crc16.c > * Made NonDeliveryReasonCode and NonDeliveryDiagnosticCode available > from X.411 > * Made NonReceiptReasonField and DiscardReasonField available from X.420 I have committed the code updates as SVN revision 20133. > * Fixed a typo in README.developer I have committed the doc update as SVN revision 20132. > Comments on the implementation are welcome :) Great work; thanks for your contribution! I changed the indentation from 2 spaces to tabs [intended to be 8 spaces wide] as that is the preferred method for new code. Did you use Emacs to write the program? That and other programs let you change the default indentation logic. Thanks, Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)
Den 13. des. 2006 kl. 21.24 skrev Stephen Fisher: > Please excuse my ignorance of this protocol, but is it different than > what packet-s4406.c dissects? Yes, this one is very different. This is a very compact format used for transmitting time-critical short X.400 messages (X.420 and STANAG 4406) on low bandwidth channels, such as HF-radios. A Military Messaging System will convert messages from s4406 to DMP when transmitting through such services. I have previous added the P_Mul dissector, which is a protocol to transfer X.400 messages in bandwidth constrained and delayed acknowledgement environments :) All these protocols are described in STANAG 4406 Annex E (DMP is a new one recently added). -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)
On Wed, Dec 13, 2006 at 05:49:58PM +0100, Stig Bj?rlykke wrote: > I have added a new dissector for DMP (STANAG 4406 Direct Message > Profile) as defined in STANAG 4406 Annex E. The DMP protocol has no > assigned UDP port number yet, so the default value in this dissector > is 0 (I suppose this is som sort of "disabled"?) until we get this > registered. Please excuse my ignorance of this protocol, but is it different than what packet-s4406.c dissects? Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
[Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)
Hi, I have added a new dissector for DMP (STANAG 4406 Direct Message Profile) as defined in STANAG 4406 Annex E. The DMP protocol has no assigned UDP port number yet, so the default value in this dissector is 0 (I suppose this is som sort of "disabled"?) until we get this registered. The dissector has been tested on OSX Intel/PowerPC and Solaris SPARC. Changes in this patch: * Added DMP dissector * Added a new CRC table and functions in crc16.c * Made NonDeliveryReasonCode and NonDeliveryDiagnosticCode available from X.411 * Made NonReceiptReasonField and DiscardReasonField available from X.420 * Fixed a typo in README.developer Comments on the implementation are welcome :) Attached is also dmp-examples.pcap with some examples of usage. Note that the examples uses port number 24209, which must be configured in the protocol page. The fuzz-test has been running on this capture for several days without errors. -- Stig Bjørlykke packet-dmp.patch.gz Description: GNU Zip compressed data dmp-examples.pcap.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
