Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
On 11/29/14 05:44, Bálint Réczey wrote: Hi Jeff, 2014-11-26 19:26 GMT+01:00 Jeff Morriss jeff.morriss...@gmail.com: On 11/26/14 13:01, Stephen Fisher wrote: Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? We could simplify it to be --with-gtk/--without-gtk and --with-qt/--without-qt and just use the latest version of GTK on the system (3.x, if available, otherwise 2.x) when requested. The default could remain to make a Qt and GTK build and if the user didn't want GTK anymore, just pass --without-gtk to the configure script. I have both Gtk3 and Gtk2 installed but build with Gtk2. The Gtk3 UI just looks horrible to me (and, no, I'm not one who really cares about how things look but, well, I have a choice). Could you please share a screenshot about what you find horrible in GTK3? I'm using the Debian package which looks quite good to me and I managed to get the OS X version to be nice as well: (I generally build on Fedora though what I push to my users is for RHEL/CentOS.) I think what really did it for me was the Decode-As window: https://www.wireshark.org/lists/wireshark-dev/201307/msg00198.html I can (still) barely tell which tab I'm on. http://balintreczey.hu/blog/beautiful-wireshark-on-os-x-using-homebrew-and-gtk3quartz/ Looking at it more I think another thing that bothers me even on the home page is that the (disabled - because in my build environment I don't have capture privs) start capture now icon is green (but with a different color background) rather than, as in the Gtk2 or Qt versions, well, not green at all. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
Hi Jeff, 2014-12-01 18:59 GMT+01:00 Jeff Morriss jeff.morriss...@gmail.com: On 11/29/14 05:44, Bálint Réczey wrote: Hi Jeff, 2014-11-26 19:26 GMT+01:00 Jeff Morriss jeff.morriss...@gmail.com: On 11/26/14 13:01, Stephen Fisher wrote: Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? We could simplify it to be --with-gtk/--without-gtk and --with-qt/--without-qt and just use the latest version of GTK on the system (3.x, if available, otherwise 2.x) when requested. The default could remain to make a Qt and GTK build and if the user didn't want GTK anymore, just pass --without-gtk to the configure script. I have both Gtk3 and Gtk2 installed but build with Gtk2. The Gtk3 UI just looks horrible to me (and, no, I'm not one who really cares about how things look but, well, I have a choice). Could you please share a screenshot about what you find horrible in GTK3? I'm using the Debian package which looks quite good to me and I managed to get the OS X version to be nice as well: (I generally build on Fedora though what I push to my users is for RHEL/CentOS.) I think what really did it for me was the Decode-As window: https://www.wireshark.org/lists/wireshark-dev/201307/msg00198.html I can (still) barely tell which tab I'm on. Yes, the active and inactive tabs look almost the same, because there is no theme installed for GTK+ and the default look was pretty ugly. Adwaita became the built-in standard theme from GTK+3.14 thus the default look should change to something similar to what I attached on every system. http://balintreczey.hu/blog/beautiful-wireshark-on-os-x-using-homebrew-and-gtk3quartz/ Looking at it more I think another thing that bothers me even on the home page is that the (disabled - because in my build environment I don't have capture privs) start capture now icon is green (but with a different color background) rather than, as in the Gtk2 or Qt versions, well, not green at all. I can hardly fix that in GTK+3, it is the the icon shipped with Wireshark. :-) Cheers, Balint ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
On 11/25/14 22:46, Guy Harris wrote:
On Nov 25, 2014, at 7:09 PM, Jeff Morriss jeff.morriss...@gmail.com wrote:
On 11/25/2014 06:09 PM, Stephen Fisher wrote:
I decided to stop building my local Wireshark with GTK3 support by
adding --without-gtk3 (or --with-gtk3=no) assuming that this would still
imply that I wanted it built with qt (--with-qt or --with-qt=yes), since
they both default to yes, but the current logic in configure.ac doesn't
account for disabling just one and I get this error:
configure: error: Neither Qt nor GTK+ 2.12.0 or later are available, so
Wireshark can't be compiled
Does anyone see a problem with me changing configure.ac to default to
--with-qt when --with-gtk3=no?
Well the default in master should be Qt=yes, Gtk3=yes.
Currently, it isn't - it's Qt=no, Gtk=GTK3.
Hmm, if I just do ./configure I get both the Qt and Gtk3 UIs. This
comment seems to confirm that intent:
#
# No GUI toolkit was explicitly specified; pick Qt and GTK+ 3.
#
with_qt=yes
with_gtk3=yes
If you use --without-gtk3 (without other options) does that mean:
1) use gtk2 instead of gtk3 (failing if gtk2 is not found)
2) (or) try to use gtk2 if it's there
3) (or) don't use gtk at all?
I'd vote for 3) - meaning, with the change I asked about, Qt=yes, Gtk=no.
Sure.
What about if you give --without-gtk2 (without other options)?
I'd vote for OK, you said don't use GTK+ 2, so I'll happily use GTK+ 3 -
meaning, with the change I asked about, Qt=yes, Gtk=GTK3.
In that case --without-gtk2 (by itself) is, in fact, meaningless since
Qt=yes, Gtk3=yes is the default behavior. That may be OK but I figured
I'd point it out.
The rules that make sense to me are:
No --with{out}-gtk{n} options, or just --with-gtk3: Gtk=GTK3
Just --with-gtk2: Gtk=GTK2
--with-gtk2 plus --with-gtk3: configure: error: Both GTK+ 2 and GTK+ 3 were
specified; choose one but not both (which is what we fail with now)
--without-gtk3 or --without-gtk2 or both: Gtk=no
Do this or do the above where --without-gtk2 implies gtk3=yes?
--without-gtk2 and --with-gtk3: Gtk=GTK3
--without-gtk3 and --with-gtk2: Gtk=GTK2
--without-gtk3 and --with-gtk3, or --without-gtk2 and --with-gtk2: live with what
autoconf does, which is believe the last --with{out}-gtk2 or --with{out}-gtk3
argument you were passed
And none of those options would affect the Qt build - that's controlled solely
by --with{out}-qt.
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? We could simplify it to be --with-gtk/--without-gtk and --with-qt/--without-qt and just use the latest version of GTK on the system (3.x, if available, otherwise 2.x) when requested. The default could remain to make a Qt and GTK build and if the user didn't want GTK anymore, just pass --without-gtk to the configure script. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
On 11/26/14 13:01, Stephen Fisher wrote: Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? We could simplify it to be --with-gtk/--without-gtk and --with-qt/--without-qt and just use the latest version of GTK on the system (3.x, if available, otherwise 2.x) when requested. The default could remain to make a Qt and GTK build and if the user didn't want GTK anymore, just pass --without-gtk to the configure script. I have both Gtk3 and Gtk2 installed but build with Gtk2. The Gtk3 UI just looks horrible to me (and, no, I'm not one who really cares about how things look but, well, I have a choice). (I do intentionally keep the Gtk3 libraries around, though, for those rare occasions when I might want/need to build it.) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
On Nov 26, 2014, at 10:01 AM, Stephen Fisher sfis...@sdf.org wrote: Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? They're a developer and want to either 1) make sure that a change they're doing won't break GTK 2 or 2) want to check a fix to a bug that only shows up with GTK 2? If the plan is to have 2.0 be Qt-only, maybe that's not important, but, if the plan is to have 2.0 be Qt-only, maybe 2.0 won't even have GTK+ code at all, including code for --with-gtk, --with-gtk2, --with-gtk3, or even --with-qt (if 2.0 is Qt-only, then don't build with Qt means don't build Wireshark, and we already have --disable-wireshark). If the plan is to have Qt be the official GUI but to leave the GTK+ code around in case anybody wants to build it, people will presumably still be filing bugs against the GTK+ 2 code if it's left around, so, unless we get rid of GTK+ 2 support, we may still want the ability to build against either version, for support purposes. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
On Wed, Nov 26, 2014 at 01:26:51PM -0500, Jeff Morriss wrote: I have both Gtk3 and Gtk2 installed but build with Gtk2. The Gtk3 UI just looks horrible to me (and, no, I'm not one who really cares about how things look but, well, I have a choice). I was hoping it was just me that had that problem. How about --with-gtk/--without-gtk and --with-qt/--without-qt and then a new option --gtk-version=2/3 or something along those lines? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] --without-gtk3 doesn't imply --with-qt
I decided to stop building my local Wireshark with GTK3 support by adding --without-gtk3 (or --with-gtk3=no) assuming that this would still imply that I wanted it built with qt (--with-qt or --with-qt=yes), since they both default to yes, but the current logic in configure.ac doesn't account for disabling just one and I get this error: configure: error: Neither Qt nor GTK+ 2.12.0 or later are available, so Wireshark can't be compiled Does anyone see a problem with me changing configure.ac to default to --with-qt when --with-gtk3=no? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
On Wed, Nov 26, 2014 at 12:09 AM, Stephen Fisher sfis...@sdf.org wrote: I decided to stop building my local Wireshark with GTK3 support by adding --without-gtk3 (or --with-gtk3=no) assuming that this would still imply that I wanted it built with qt (--with-qt or --with-qt=yes), since they both default to yes, but the current logic in configure.ac doesn't account for disabling just one and I get this error: configure: error: Neither Qt nor GTK+ 2.12.0 or later are available, so Wireshark can't be compiled Does anyone see a problem with me changing configure.ac to default to --with-qt when --with-gtk3=no? No, i have already get this problem... (May be think switch to CMake ;-)) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt
On 11/25/2014 06:09 PM, Stephen Fisher wrote: I decided to stop building my local Wireshark with GTK3 support by adding --without-gtk3 (or --with-gtk3=no) assuming that this would still imply that I wanted it built with qt (--with-qt or --with-qt=yes), since they both default to yes, but the current logic in configure.ac doesn't account for disabling just one and I get this error: configure: error: Neither Qt nor GTK+ 2.12.0 or later are available, so Wireshark can't be compiled Does anyone see a problem with me changing configure.ac to default to --with-qt when --with-gtk3=no? Well the default in master should be Qt=yes, Gtk3=yes. If you use --without-gtk3 (without other options) does that mean: 1) use gtk2 instead of gtk3 (failing if gtk2 is not found) 2) (or) try to use gtk2 if it's there 3) (or) don't use gtk at all? What about if you give --without-gtk2 (without other options)? That is to say, the current set of 3 options is kind of odd; I'm not sure there is a good way to do it. But I think it does beat having to first specify you want to use gtk (--with-gtk) and then specify which gtk to use (--with-gtk2) which would probably make it all clear (if painful to use). ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
