[Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread Bill Meier 
When building GTK3 Wireshark on my Fedora system (after not having done 
so for a while), I'm getting many warnings similar to the following:



 CC   libgtkui_a-about_dlg.o
In file included from /usr/include/gtk-3.0/gtk/gtk.h:263:0,
 from about_dlg.c:28:
/usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:454:43: error: identifier 
"and" is a special operator name in C++ [-Werror=c++-compat]

 GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_background)
   ^

[versions: Fedora 23; GCC 5.1.1; GTK3 3.18.2]

-Wc++-compat seems to have been added in March 2013 (g557df88), so I 
don't know why I'm now getting the warnings (although it's been some 
number of months since I've built GTK3 Wireshark with GCC);

 Warnings didn't show with previous versions of GCC compiler ?
 GTK changes ??
 ???


I note that configure.ac has the following code to default to build with 
GTK3 in certain cases:


#
# No GUI toolkits were explicitly specified; pick Qt
# and GTK+ 3.
#
with_qt=yes
with_gtk3=yes
elif test "x$with_gtk2" = "xunspecified" -a \
  "x$with_gtk3" = "xunspecified" -a \
  "x$with_qt" = "xno"; then
#
# Qt was explicitly disabled, and neither GTK+ 2 nor
# GTK+ 3 were explicitly specified; pick GTK+ 3.
#
with_gtk3=yes
fi

So: it seems we want to continue to support GTK3 ?

and thus it seems that the -Wc++-compat compile flag would need to be 
removed when building GTK stuff or ??


(I do note that there's been a submission in Gerritt to fix a GDK/GTK 
deprecation; Is this the only deprecation which needs to be fixed so 
that GDK/GTK DISABLE_DEPRECATED can be usued again?


Fromconfigure.ac:

CPPFLAGS="-DGDK_DISABLE_DEPRECATED $CPPFLAGS"
	if test \( $gtk_config_major_version -eq 3 -a $gtk_config_minor_version 
-ge 10 \) ; then

## Allow use of deprecated & disable deprecated warnings if Gtk 
>= 3.10;
##  The deprecations in Gtk 3.10 will not be fixed ...
CPPFLAGS="-DGDK_DISABLE_DEPRECATION_WARNINGS $CPPFLAGS"
else
CPPFLAGS="-DGTK_DISABLE_DEPRECATED $CPPFLAGS"
fi


Comments ?

Bill
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread Jeff Morriss 

On 11/11/15 12:28, Bill Meier wrote:

When building GTK3 Wireshark on my Fedora system (after not having done
so for a while), I'm getting many warnings similar to the following:


  CC   libgtkui_a-about_dlg.o
In file included from /usr/include/gtk-3.0/gtk/gtk.h:263:0,
  from about_dlg.c:28:
/usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:454:43: error: identifier
"and" is a special operator name in C++ [-Werror=c++-compat]
  GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_background)
^

[versions: Fedora 23; GCC 5.1.1; GTK3 3.18.2]

-Wc++-compat seems to have been added in March 2013 (g557df88), so I
don't know why I'm now getting the warnings (although it's been some
number of months since I've built GTK3 Wireshark with GCC);
  Warnings didn't show with previous versions of GCC compiler ?
  GTK changes ??
  ???


It looks like Balint already sent a patch to Gtk:

https://www.wireshark.org/lists/wireshark-dev/201403/msg00042.html


So: it seems we want to continue to support GTK3 ?


Yes, I think so.  At least RHEL 6 needs to continue to use the Gtk+ GUI 
(since its Qt isn't new enough).  (Though I still stick with Gtk2.)



and thus it seems that the -Wc++-compat compile flag would need to be
removed when building GTK stuff or ??


That's probably not unreasonable (as long as the rest of Wireshark still 
gets the flag).


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread Bálint Réczey 
2015-11-11 22:10 GMT+04:00 Jeff Morriss :
> On 11/11/15 12:28, Bill Meier wrote:
>>
>> When building GTK3 Wireshark on my Fedora system (after not having done
>> so for a while), I'm getting many warnings similar to the following:
>>
>>
>>   CC   libgtkui_a-about_dlg.o
>> In file included from /usr/include/gtk-3.0/gtk/gtk.h:263:0,
>>   from about_dlg.c:28:
>> /usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:454:43: error: identifier
>> "and" is a special operator name in C++ [-Werror=c++-compat]
>>   GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_background)
>> ^
>>
>> [versions: Fedora 23; GCC 5.1.1; GTK3 3.18.2]
>>
>> -Wc++-compat seems to have been added in March 2013 (g557df88), so I
>> don't know why I'm now getting the warnings (although it's been some
>> number of months since I've built GTK3 Wireshark with GCC);
>>   Warnings didn't show with previous versions of GCC compiler ?
>>   GTK changes ??
>>   ???
>
>
> It looks like Balint already sent a patch to Gtk:
>
> https://www.wireshark.org/lists/wireshark-dev/201403/msg00042.html
It seems to be a new breakage, I have to check it.

>
>> So: it seems we want to continue to support GTK3 ?
>
>
> Yes, I think so.  At least RHEL 6 needs to continue to use the Gtk+ GUI
> (since its Qt isn't new enough).  (Though I still stick with Gtk2.)
>
>> and thus it seems that the -Wc++-compat compile flag would need to be
>> removed when building GTK stuff or ??
>
>
> That's probably not unreasonable (as long as the rest of Wireshark still
> gets the flag).
As a workaround one can pass -Wno-c++-compat as an extra flag to build
local Wireshark versions without having to patch anything.

Cheers,
Balint
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread João Valverde 



On 11-11-2015 17:28, Bill Meier wrote:

When building GTK3 Wireshark on my Fedora system (after not having done
so for a while), I'm getting many warnings similar to the following:


  CC   libgtkui_a-about_dlg.o
In file included from /usr/include/gtk-3.0/gtk/gtk.h:263:0,
  from about_dlg.c:28:
/usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:454:43: error: identifier
"and" is a special operator name in C++ [-Werror=c++-compat]
  GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_background)
^

[versions: Fedora 23; GCC 5.1.1; GTK3 3.18.2]

-Wc++-compat seems to have been added in March 2013 (g557df88), so I
don't know why I'm now getting the warnings (although it's been some
number of months since I've built GTK3 Wireshark with GCC);
  Warnings didn't show with previous versions of GCC compiler ?
  GTK changes ??
  ???


I note that configure.ac has the following code to default to build with
GTK3 in certain cases:

 #
 # No GUI toolkits were explicitly specified; pick Qt
 # and GTK+ 3.
 #
 with_qt=yes
 with_gtk3=yes
 elif test "x$with_gtk2" = "xunspecified" -a \
   "x$with_gtk3" = "xunspecified" -a \
   "x$with_qt" = "xno"; then
 #
 # Qt was explicitly disabled, and neither GTK+ 2 nor
 # GTK+ 3 were explicitly specified; pick GTK+ 3.
 #
 with_gtk3=yes
 fi

So: it seems we want to continue to support GTK3 ?

and thus it seems that the -Wc++-compat compile flag would need to be
removed when building GTK stuff or ??

(I do note that there's been a submission in Gerritt to fix a GDK/GTK
deprecation; Is this the only deprecation which needs to be fixed so
that GDK/GTK DISABLE_DEPRECATED can be usued again?

Fromconfigure.ac:

 CPPFLAGS="-DGDK_DISABLE_DEPRECATED $CPPFLAGS"
 if test \( $gtk_config_major_version -eq 3 -a
$gtk_config_minor_version -ge 10 \) ; then
 ## Allow use of deprecated & disable deprecated warnings if Gtk
 >= 3.10;
 ##  The deprecations in Gtk 3.10 will not be fixed ...
 CPPFLAGS="-DGDK_DISABLE_DEPRECATION_WARNINGS $CPPFLAGS"
 else
 CPPFLAGS="-DGTK_DISABLE_DEPRECATED $CPPFLAGS"
 fi


Comments ?


IMO it's a bug in GTK 3.18.


Bill
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread Guy Harris 

On Nov 11, 2015, at 10:10 AM, Jeff Morriss  wrote:

> On 11/11/15 12:28, Bill Meier wrote:
> 
>> So: it seems we want to continue to support GTK3 ?
> 
> Yes, I think so.  At least RHEL 6 needs to continue to use the Gtk+ GUI 
> (since its Qt isn't new enough).  (Though I still stick with Gtk2.)

Will RHEL 6 even bother to pick up 2.0?  Or do you mean "people who want to 
build Wireshark 2.0 themselves on RHEL 6, without having to build and install 
Qt themselves as well, will need to continue to use the GTK+ UI"?
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread Bill Meier 

On 11/11/2015 9:57 PM, Bill Meier wrote:

On 11/11/2015 1:24 PM, Bálint Réczey wrote:

It looks like Balint already sent a patch to Gtk:

https://www.wireshark.org/lists/wireshark-dev/201403/msg00042.html

It seems to be a new breakage, I have to check it.



Yep: from the gtk 3.18 repository: gtkstyle.h commit

2015-05-14Amend deprecation warnings for GtkStyle APIEmmanuele
Bassi1-28/+28


diff --git a/gtk/deprecated/gtkstyle.h b/gtk/deprecated/gtkstyle.h
index dbe83df..55b6934 100644
--- a/gtk/deprecated/gtkstyle.h
+++ b/gtk/deprecated/gtkstyle.h
@@ -451,7 +451,7 @@ GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext)
  void  gtk_style_set_background   (GtkStyle *style,
GdkWindow*window,
GtkStateType  state_type);
-GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext)
+GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_background)
  void  gtk_style_apply_default_background (GtkStyle *style,
cairo_t  *cr,
GdkWindow*window,



I note that in the previous case the patch was to replace 'AND' with '&'



gtkstyle.h appears to be the only file in .../deprecated/*.h with problems.

grep ...

gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_render_background)

gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and a style class)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and a style class)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_icon)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_line)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_line)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_render_background)

gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_arrow)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_icon)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_frame)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_render_background)

gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_check)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_option)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_render_background)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_render_extension)

gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_focus)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_focus)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_handle)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_render_expander)

gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_layout)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_handle)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_icon)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_style_context_get_property)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_style_context_get_property)
gtkstyle.h:GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and 
gtk_style_context_get_property)


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread Bill Meier 

On 11/11/2015 1:24 PM, Bálint Réczey wrote:

It looks like Balint already sent a patch to Gtk:

https://www.wireshark.org/lists/wireshark-dev/201403/msg00042.html

It seems to be a new breakage, I have to check it.



Yep: from the gtk 3.18 repository: gtkstyle.h commit

2015-05-14	Amend deprecation warnings for GtkStyle API	Emmanuele 
Bassi	1	-28/+28



diff --git a/gtk/deprecated/gtkstyle.h b/gtk/deprecated/gtkstyle.h
index dbe83df..55b6934 100644
--- a/gtk/deprecated/gtkstyle.h
+++ b/gtk/deprecated/gtkstyle.h
@@ -451,7 +451,7 @@ GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext)
 void  gtk_style_set_background   (GtkStyle *style,
   GdkWindow*window,
   GtkStateType  state_type);
-GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext)
+GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_background)
 void  gtk_style_apply_default_background (GtkStyle *style,
   cairo_t  *cr,
   GdkWindow*window,



I note that in the previous case the patch was to replace 'AND' with '&' 




___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread Jeff Morriss 

On 11/11/15 13:22, Guy Harris wrote:


On Nov 11, 2015, at 10:10 AM, Jeff Morriss  wrote:


On 11/11/15 12:28, Bill Meier wrote:


So: it seems we want to continue to support GTK3 ?


Yes, I think so.  At least RHEL 6 needs to continue to use the Gtk+ GUI (since 
its Qt isn't new enough).  (Though I still stick with Gtk2.)


Will RHEL 6 even bother to pick up 2.0?  Or do you mean "people who want to build 
Wireshark 2.0 themselves on RHEL 6, without having to build and install Qt themselves as 
well, will need to continue to use the GTK+ UI"?


No, RHEL won't upgrade.  But those who compile-their-own (because they 
want something newer than 1.8) will have to use the Gtk+ GUI.  (I roll 
my own--including some internal dissectors--and push it out to a few 
hundred machines via an (internal) yum repository.)


Gerald did mention that we'd only need to get rid of one thing to make 
the Qt GUI compatible with RHEL 6:


https://www.wireshark.org/lists/wireshark-dev/201510/msg00058.html

But that seems unlikely.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe