[Wireshark-dev] New packet list - sorting
Hi, I think these two assertions, in packet_list_compare_records() g_assert(a-fdata-col_text[sort_id]); g_assert(b-fdata-col_text[sort_id]); are not quite correct. If you click abort while constructing columns, it'll lead to: ERROR:packet_list_store.c:955:packet_list_compare_records: assertion failed: (a-fdata-col_text[sort_id]) IMHO it should be possible to abort constructing columns - and it should not abort program. By the way, it would be nice if columns only for visible_rows will be generated sorted - not all of them :) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] New packet list - sorting
Hi, Sorting of columns in the new packet list may be a bit more complicated than anticipated. The filter model looks like it does not implement sorting http://www.daa.com.au/pipermail/pygtk/2009-February/016609.html but requires an additional TreeModelSort it then looks like TreeModelSort requires sort columns with a sort function to be set up. An additional problem is that with lazy columns we may not have the data stored when starting to sort On the other hand perhaps it's enough to sort the visible data. Anyway aditional prototyping and tests are required to find The most efficent way of doing it. Perhaps there anoter way of doing display filtering than using TreeFilterModel? Regards Anders ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
