Re: [Wireshark-dev] On MR 4428

[João Valverde via Wireshark-dev]

On 10/6/21 11:58, Jaap Keuter wrote:

Hi,

Looking at MR 4428 
 (cherry 
picked from commit 96cfaf67 
) 
it introduces a new symbol in the wiretap 11 library 
(wtap_uses_lua_filehandler). The debian symbols file contains the 
addition of "wtap_uses_lua_filehandler@Base 3.5.1", which refers to a 
later version (3.5.1) than this release is of (3.4.x). I could see 
this being a problem somewhere. Maybe we need to reconsider inclusion 
of the MR in release-3.4


Being a stable system library is nothing like what Wireshark is so I 
very much put into question if this is indeed a problem in the real 
world and moreover if it is a problem for Wireshark devs to solve.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] On MR 4428

[Stig Bjørlykke]

On Wed, Oct 6, 2021 at 12:58 PM Jaap Keuter  wrote:

> Looking at MR 4428
>  (cherry
> picked from commit 96cfaf67
> )
> it introduces a new symbol in the wiretap 11 library
> (wtap_uses_lua_filehandler). The debian symbols file contains the addition
> of "wtap_uses_lua_filehandler@Base 3.5.1", which refers to a later
> version (3.5.1) than this release is of (3.4.x). I could see this being a
> problem somewhere. Maybe we need to reconsider inclusion of the MR in
> release-3.4
>

This issue is already fixed in MR . Maybe we should add a sanity check
to the Debian builder?


-- 
Stig Bjørlykke
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] On MR 4428

[Jaap Keuter]

Hi,

Looking at MR 4428 https://gitlab.com/wireshark/wireshark/-/merge_requests/4428 
(cherry picked from commit 96cfaf67) it introduces a new symbol in the wiretap 
11 library (wtap_uses_lua_filehandler). The debian symbols file contains the 
addition of "wtap_uses_lua_filehandler@Base 3.5.1", which refers to a later 
version (3.5.1) than this release is of (3.4.x). I could see this being a 
problem somewhere. Maybe we need to reconsider inclusion of the MR in 
release-3.4

Thanks,
Jaap___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe