Re: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)

2017-09-01 Thread Kilian, Jens 
> From: Michael Mann <mman...@netscape.net>
> To: wireshark-dev@wireshark.org
> Subject: Re: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)
[...]
> Is this list of compile errors in addition to the ones you found on
> master?  If you can submit a patch for the master-2.4 branch, that would
> certainly be appreciated (and accepted).   Since the 2.4 branch is mostly
> bugfixes (the rare exception being horrific UI issues), I don't think
> additional compile errors should result going forward.

Hi Michael,
This is essentially the list of problems I first submitted a patch for (on 
master-2.4).  I was then asked to submit on master instead, and I fixed some 
additional problems.  At the time I submitted the patch, I was able to build 
both master & master-2.4.

Best regards,

Jens.

___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)

2017-08-31 Thread Michael Mann via Wireshark-dev 

Per the conversation that started with 
https://www.wireshark.org/lists/wireshark-dev/201707/msg00132.html, I would say 
that yes Qt 4 is still supported by Wireshark 2.4, but it looks like it won't 
be supported for Wireshark 2.6 release (in what is now current master branch).  
The problem is just that we don't have a Qt 4 build environment to catch build 
errors, so they go unnoticed until someone brings them up (like bug 13909 or 
what you're doing now).
 
Is this list of compile errors in addition to the ones you found on master?  If 
you can submit a patch for the master-2.4 branch, that would certainly be 
appreciated (and accepted).   Since the 2.4 branch is mostly bugfixes (the rare 
exception being horrific UI issues), I don't think additional compile errors 
should result going forward.
 
 
-Original Message-
From: Kilian, Jens <jens.kil...@advantest.com>
To: wireshark-dev <wireshark-dev@wireshark.org>
Sent: Thu, Aug 31, 2017 10:36 am
Subject: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)

Is Wireshark v2.4.1 supposed to support Qt 4 still?  I get the following 
compile errors when trying to build it in RedHat EL 7.2:

main_window.cpp:786:46:   required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member 
of 'QMetaTypeId<QToolBar*>'
 static inline int qt_metatype_id() { return 
QMetaTypeId::qt_metatype_id(); }
  ^
main_window_slots.cpp:499:62:   required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member 
of 'QMetaTypeId<QToolBar*>'
 static inline int qt_metatype_id() { return 
QMetaTypeId::qt_metatype_id(); }
 ^
rtp_player_dialog.cpp:207:104:   required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member 
of 'QMetaTypeId<RtpAudioStream*>'
 static inline int qt_metatype_id() { return 
QMetaTypeId::qt_metatype_id(); }
  ^
rtp_player_dialog.cpp:277:95:   required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member 
of 'QMetaTypeId<QCPGraph*>'

wireless_timeline.cpp: In member function 'virtual void 
WirelessTimeline::mousePressEvent(QMouseEvent*)':
wireless_timeline.cpp:118:31: error: 'class QMouseEvent' has no member named 
'localPos'
 start_x = last_x = event->localPos().x();
   ^
wireless_timeline.cpp: In member function 'virtual void 
WirelessTimeline::mouseMoveEvent(QMouseEvent*)':
wireless_timeline.cpp:127:27: error: 'class QMouseEvent' has no member named 
'localPos'
 qreal offset = event->localPos().x() - last_x;
   ^
wireless_timeline.cpp:128:21: error: 'class QMouseEvent' has no member named 
'localPos'
 last_x = event->localPos().x();
 ^
wireless_timeline.cpp: In member function 'virtual void 
WirelessTimeline::mouseReleaseEvent(QMouseEvent*)':
wireless_timeline.cpp:144:27: error: 'class QMouseEvent' has no member named 
'localPos'
 qreal offset = event->localPos().x() - start_x;
   ^
wireless_timeline.cpp:151:36: error: 'class QMouseEvent' has no member named 
'localPos'
 guint num = find_packet(event->localPos().x());
   ^
wireless_timeline.cpp: In member function 'virtual void 
WirelessTimeline::paintEvent(QPaintEvent*)':
wireless_timeline.cpp:483:31: error: 'class QPaintDevice' has no member named 
'devicePixelRatio'
 float ratio = p.device()->devicePixelRatio();
   ^
wireshark_application.cpp: In constructor 
'WiresharkApplication::WiresharkApplication(int&, char**)':
wireshark_application.cpp:850:24: error: 'QGuiApplication' has not been declared
 QPalette gui_pal = QGuiApplication::palette();
 ^

Best regards,

Jens.
___Sent 
via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>Archives:
https://www.wireshark.org/lists/wireshark-devUnsubscribe: 
https://www.wireshark.org/mailman/options/wireshark-dev 
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)

2017-08-31 Thread Kilian, Jens 
Is Wireshark v2.4.1 supposed to support Qt 4 still?  I get the following 
compile errors when trying to build it in RedHat EL 7.2:

main_window.cpp:786:46:   required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member 
of 'QMetaTypeId'
 static inline int qt_metatype_id() { return 
QMetaTypeId::qt_metatype_id(); }

^
main_window_slots.cpp:499:62:   required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member 
of 'QMetaTypeId'
 static inline int qt_metatype_id() { return 
QMetaTypeId::qt_metatype_id(); }

^
rtp_player_dialog.cpp:207:104:   required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member 
of 'QMetaTypeId'
 static inline int qt_metatype_id() { return 
QMetaTypeId::qt_metatype_id(); }

^
rtp_player_dialog.cpp:277:95:   required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member 
of 'QMetaTypeId'

wireless_timeline.cpp: In member function 'virtual void 
WirelessTimeline::mousePressEvent(QMouseEvent*)':
wireless_timeline.cpp:118:31: error: 'class QMouseEvent' has no member named 
'localPos'
 start_x = last_x = event->localPos().x();
   ^
wireless_timeline.cpp: In member function 'virtual void 
WirelessTimeline::mouseMoveEvent(QMouseEvent*)':
wireless_timeline.cpp:127:27: error: 'class QMouseEvent' has no member named 
'localPos'
 qreal offset = event->localPos().x() - last_x;
   ^
wireless_timeline.cpp:128:21: error: 'class QMouseEvent' has no member named 
'localPos'
 last_x = event->localPos().x();
 ^
wireless_timeline.cpp: In member function 'virtual void 
WirelessTimeline::mouseReleaseEvent(QMouseEvent*)':
wireless_timeline.cpp:144:27: error: 'class QMouseEvent' has no member named 
'localPos'
 qreal offset = event->localPos().x() - start_x;
   ^
wireless_timeline.cpp:151:36: error: 'class QMouseEvent' has no member named 
'localPos'
 guint num = find_packet(event->localPos().x());
^
wireless_timeline.cpp: In member function 'virtual void 
WirelessTimeline::paintEvent(QPaintEvent*)':
wireless_timeline.cpp:483:31: error: 'class QPaintDevice' has no member named 
'devicePixelRatio'
 float ratio = p.device()->devicePixelRatio();
   ^
wireshark_application.cpp: In constructor 
'WiresharkApplication::WiresharkApplication(int&, char**)':
wireshark_application.cpp:850:24: error: 'QGuiApplication' has not been declared
 QPalette gui_pal = QGuiApplication::palette();
^

Best regards,

Jens.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe