Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c
On 12/14/2013 5:30 AM, RobiOneKenobi wrote: Yes, if it didn't disturb too much people to have such long lines, I will prefer that you revert this part (hf[] entries reformatting), otherwise I will follow the majority wishses I've restored the single line per hf[] entry format in SVN #54005. Bill ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c
On 12/18/2013 11:57 AM, Bill Meier wrote: On 12/14/2013 5:30 AM, RobiOneKenobi wrote: Yes, if it didn't disturb too much people to have such long lines, I will prefer that you revert this part (hf[] entries reformatting), otherwise I will follow the majority wishses I've restored the single line per hf[] entry format in SVN #54005. Correction: The restoration was done in SVN #54226. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c
Yes, if it didn't disturb too much people to have such long lines, I will prefer that you revert this part (hf[] entries reformatting), otherwise I will follow the majority wishses -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Bill Meier Sent: Friday, December 13, 2013 7:08 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c On 12/13/2013 12:21 PM, RobiOneKenobi wrote: Reformat hf[] entries ? Why, now all seems no more aligned for me, and your reformat also left spaces between text and comma. You're right; I was sloppy about leaving spaces between the text and the comma. :) I do not agree with such reformat, as it seems less readable as the one I've put in. I made the change because, personally, I find the quite long lines quite difficult to read when they when they exceed the width of my screen (which I expect they will do on screens used by many). I like to have some parts aligned to an ease of use for to have the same length of displayed items. I understand. Are there some rules where this is described? Not really. I do think readability is relevant; I'm not really a fan of the old 72 column limit but I do think there should be some limit. The above notwithstanding, I can revert the hf[] reformatting if you desire. Bill ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c
Reformat hf[] entries ? Why, now all seems no more aligned for me, and your reformat also left spaces between text and comma. I do not agree with such reformat, as it seems less readable as the one I've put in. I like to have some parts aligned to an ease of use for to have the same length of displayed items. Are there some rules where this is described? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c
On 12/13/2013 12:21 PM, RobiOneKenobi wrote: Reformat hf[] entries ? Why, now all seems no more aligned for me, and your reformat also left spaces between text and comma. You're right; I was sloppy about leaving spaces between the text and the comma. :) I do not agree with such reformat, as it seems less readable as the one I’ve put in. I made the change because, personally, I find the quite long lines quite difficult to read when they when they exceed the width of my screen (which I expect they will do on screens used by many). I like to have some parts aligned to an ease of use for to have the same length of displayed items. I understand. Are there some rules where this is described? Not really. I do think readability is relevant; I'm not really a fan of the old 72 column limit but I do think there should be some limit. The above notwithstanding, I can revert the hf[] reformatting if you desire. Bill ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
