Re: [Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Sebastien Tandel 

Ouch, I don't have this one on the latest svn version ... :-/


Gisle Vanem wrote:
 --- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007
 +++ epan\crypt\airpdcap.c   Tue Jan 16 11:59:58 2007
 @@ -1663,7 +1663,7 @@
 else
 output_string = g_strdup_printf(%s:%s:%s,
 STRING_KEY_TYPE_WPA_PWD,dk-key-str,
 -   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len);
 +   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len));
 }
 else if(dk-type == AIRPDCAP_KEY_TYPE_WPA_PMK)
 {

 ---

 Please test your changes (compile it) before checking in !

 --gv
 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev
   

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Sebastien Tandel 
sorry you're right, part of code not compiled on my computer.

Sebastien Tandel wrote:
 Ouch, I don't have this one on the latest svn version ... :-/


 Gisle Vanem wrote:
   
 --- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007
 +++ epan\crypt\airpdcap.c   Tue Jan 16 11:59:58 2007
 @@ -1663,7 +1663,7 @@
 else
 output_string = g_strdup_printf(%s:%s:%s,
 STRING_KEY_TYPE_WPA_PWD,dk-key-str,
 -   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len);
 +   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len));
 }
 else if(dk-type == AIRPDCAP_KEY_TYPE_WPA_PMK)
 {

 ---

 Please test your changes (compile it) before checking in !

 --gv
 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev
   
 

 ___
 Wireshark-dev mailing list
 Wireshark-dev@wireshark.org
 http://www.wireshark.org/mailman/listinfo/wireshark-dev
   

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Stephen Fisher 

On Tue, Jan 16, 2007 at 12:01:17PM +0100, Gisle Vanem wrote:

 --- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007
 +++ epan\crypt\airpdcap.c   Tue Jan 16 11:59:58 2007
 @@ -1663,7 +1663,7 @@
 else
 output_string = g_strdup_printf(%s:%s:%s,
 STRING_KEY_TYPE_WPA_PWD,dk-key-str,
 -   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len);
 +   format_text((guchar *)dk-ssid-data, 
 dk-ssid-len));
 }
 else if(dk-type == AIRPDCAP_KEY_TYPE_WPA_PMK)
 {
 
 ---

Thanks for your patch, I have applied the change as svn revision 20457.

 Please test your changes (compile it) before checking in !

It was probably missed because it is within an #ifdef HAVE_AIRPDCAP, 
that not everyone has.  Sorry for the trouble.


Steve
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev