[WiX-users] msiexec.exe /qn option causes memory corruption?

2013-08-15 Thread George Fleming
I recently made some changes to installer code, and now it doesn't install 
properly.  Investigations show that if I install without /qn option at command 
line, everything works as expected.  If installed with /qn option (which also 
requires installer to run as admin), the variable INSTALLFOLDER mysteriously 
becomes null in my custom action.  In my custom action, I have:

string oldString = session[INSTALLFOLDER];
session.Log(string value = {0}, oldString);

and it's invoked right after CostInitialize (non-deferred) stage.  Log shows 
that oldString has a value of null, but log also shows that INSTALLFOLDER is 
set correctly elsewhere.

If I don't use /qn option, then oldstring has correct value.  I'm guessing that 
/qn somehow corrupts the memory, but not sure how at the moment.

I will try to back out my changes to try and isolate this, but has anyone else 
seen anything like this?

Thanks,

George

--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users


Re: [WiX-users] msiexec.exe /qn option causes memory corruption?

2013-08-15 Thread John Cooper
No, it doesn't corrupt memory, but with UI completely suppressed, only your 
execute sequence is going to run.  Also, in general you can't count on 
Directory properties being valid until after CostFinalize.  The combination 
of early scheduling and your UI sequence not running probably results in 
INSTALLFOLDER not being initialized.  When the UI runs, the InstallDir Dialog 
(or something like it--I don't know your authoring) has a chance to set this.

--
John Merryweather Cooper
Build  Install Engineer -- ESA
Jack Henry  Associates, Inc.(r)
Shawnee Mission, KS  66227
Office:  913-341-3434 x791011
jocoo...@jackhenry.com
www.jackhenry.com




-Original Message-
From: George Fleming [mailto:gef...@microsoft.com] 
Sent: Thursday, August 15, 2013 2:25 PM
To: wix-users@lists.sourceforge.net
Subject: [WiX-users] msiexec.exe /qn option causes memory corruption?

I recently made some changes to installer code, and now it doesn't install 
properly.  Investigations show that if I install without /qn option at command 
line, everything works as expected.  If installed with /qn option (which also 
requires installer to run as admin), the variable INSTALLFOLDER mysteriously 
becomes null in my custom action.  In my custom action, I have:

string oldString = session[INSTALLFOLDER]; session.Log(string value = {0}, 
oldString);

and it's invoked right after CostInitialize (non-deferred) stage.  Log shows 
that oldString has a value of null, but log also shows that INSTALLFOLDER is 
set correctly elsewhere.

If I don't use /qn option, then oldstring has correct value.  I'm guessing that 
/qn somehow corrupts the memory, but not sure how at the moment.

I will try to back out my changes to try and isolate this, but has anyone else 
seen anything like this?

Thanks,

George

--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
NOTICE: This electronic mail message and any files transmitted with it are 
intended
exclusively for the individual or entity to which it is addressed. The message, 
together with any attachment, may contain confidential and/or privileged 
information.
Any unauthorized review, use, printing, saving, copying, disclosure or 
distribution 
is strictly prohibited. If you have received this message in error, please 
immediately advise the sender by reply email and delete all copies.


--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users


Re: [WiX-users] msiexec.exe /qn option causes memory corruption?

2013-08-15 Thread George Fleming
Thanks for the tip.  Moving my CA from after CostInitialize to after 
CostFinalize seems to do the trick.  

I have no UI in my installer, so I wonder how the variable got set before, but 
not now.  

-Original Message-
From: John Cooper [mailto:jocoo...@jackhenry.com] 
Sent: Thursday, August 15, 2013 12:39 PM
To: General discussion for Windows Installer XML toolset.
Subject: Re: [WiX-users] msiexec.exe /qn option causes memory corruption?

No, it doesn't corrupt memory, but with UI completely suppressed, only your 
execute sequence is going to run.  Also, in general you can't count on 
Directory properties being valid until after CostFinalize.  The combination 
of early scheduling and your UI sequence not running probably results in 
INSTALLFOLDER not being initialized.  When the UI runs, the InstallDir Dialog 
(or something like it--I don't know your authoring) has a chance to set this.

--
John Merryweather Cooper
Build  Install Engineer -- ESA
Jack Henry  Associates, Inc.(r)
Shawnee Mission, KS  66227
Office:  913-341-3434 x791011
jocoo...@jackhenry.com
www.jackhenry.com




-Original Message-
From: George Fleming [mailto:gef...@microsoft.com]
Sent: Thursday, August 15, 2013 2:25 PM
To: wix-users@lists.sourceforge.net
Subject: [WiX-users] msiexec.exe /qn option causes memory corruption?

I recently made some changes to installer code, and now it doesn't install 
properly.  Investigations show that if I install without /qn option at command 
line, everything works as expected.  If installed with /qn option (which also 
requires installer to run as admin), the variable INSTALLFOLDER mysteriously 
becomes null in my custom action.  In my custom action, I have:

string oldString = session[INSTALLFOLDER]; session.Log(string value = {0}, 
oldString);

and it's invoked right after CostInitialize (non-deferred) stage.  Log shows 
that oldString has a value of null, but log also shows that INSTALLFOLDER is 
set correctly elsewhere.

If I don't use /qn option, then oldstring has correct value.  I'm guessing that 
/qn somehow corrupts the memory, but not sure how at the moment.

I will try to back out my changes to try and isolate this, but has anyone else 
seen anything like this?

Thanks,

George

--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
NOTICE: This electronic mail message and any files transmitted with it are 
intended exclusively for the individual or entity to which it is addressed. The 
message, together with any attachment, may contain confidential and/or 
privileged information.
Any unauthorized review, use, printing, saving, copying, disclosure or 
distribution is strictly prohibited. If you have received this message in 
error, please immediately advise the sender by reply email and delete all 
copies.


--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users


--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users


Re: [WiX-users] msiexec.exe /qn option causes memory corruption?

2013-08-15 Thread Blair Murri
Whether you have UI or not, if you didn't suppress the hi sequence table 
creation it will run. Costing occurs in both sequences (usually before most of 
the dialogs).


George Fleming gef...@microsoft.com wrote:

Thanks for the tip.  Moving my CA from after CostInitialize to after 
CostFinalize seems to do the trick.

I have no UI in my installer, so I wonder how the variable got set before, but 
not now.

-Original Message-
From: John Cooper [mailto:jocoo...@jackhenry.com]
Sent: Thursday, August 15, 2013 12:39 PM
To: General discussion for Windows Installer XML toolset.
Subject: Re: [WiX-users] msiexec.exe /qn option causes memory corruption?

No, it doesn't corrupt memory, but with UI completely suppressed, only your 
execute sequence is going to run.  Also, in general you can't count on 
Directory properties being valid until after CostFinalize.  The combination 
of early scheduling and your UI sequence not running probably results in 
INSTALLFOLDER not being initialized.  When the UI runs, the InstallDir Dialog 
(or something like it--I don't know your authoring) has a chance to set this.

--
John Merryweather Cooper
Build  Install Engineer -- ESA
Jack Henry  Associates, Inc.(r)
Shawnee Mission, KS  66227
Office:  913-341-3434 x791011
jocoo...@jackhenry.com
www.jackhenry.com




-Original Message-
From: George Fleming [mailto:gef...@microsoft.com]
Sent: Thursday, August 15, 2013 2:25 PM
To: wix-users@lists.sourceforge.net
Subject: [WiX-users] msiexec.exe /qn option causes memory corruption?

I recently made some changes to installer code, and now it doesn't install 
properly.  Investigations show that if I install without /qn option at command 
line, everything works as expected.  If installed with /qn option (which also 
requires installer to run as admin), the variable INSTALLFOLDER mysteriously 
becomes null in my custom action.  In my custom action, I have:

string oldString = session[INSTALLFOLDER]; session.Log(string value = {0}, 
oldString);

and it's invoked right after CostInitialize (non-deferred) stage.  Log shows 
that oldString has a value of null, but log also shows that INSTALLFOLDER is 
set correctly elsewhere.

If I don't use /qn option, then oldstring has correct value.  I'm guessing that 
/qn somehow corrupts the memory, but not sure how at the moment.

I will try to back out my changes to try and isolate this, but has anyone else 
seen anything like this?

Thanks,

George

--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
NOTICE: This electronic mail message and any files transmitted with it are 
intended exclusively for the individual or entity to which it is addressed. The 
message, together with any attachment, may contain confidential and/or 
privileged information.
Any unauthorized review, use, printing, saving, copying, disclosure or 
distribution is strictly prohibited. If you have received this message in 
error, please immediately advise the sender by reply email and delete all 
copies.


--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users


--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users

--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk