Re: [PATCH] WindowMaker: Class codes cleaned
The problem is at placement.c:81, probably because
wcore-descriptor.parent_type is not set (value = 0), and then the type is
WCLASS_WINDOW (value=0 too).
I will take a look.
kix
On Tue, 03 Apr 2012, Rodolfo kix Garcia escribió:
Ok
the value 0 cannot be used :-?
kix@osaka:~/src/wmaker-crm/src$ git diff
diff --git a/src/WindowMaker.h b/src/WindowMaker.h
index 31a497b..c9bfe40 100644
--- a/src/WindowMaker.h
+++ b/src/WindowMaker.h
@@ -28,14 +28,14 @@
/* class codes */
typedef enum {
-WCLASS_WINDOW = 0, /* Window contents */
-WCLASS_MENU = 1, /* Menus */
-WCLASS_APPICON = 2,/* Application Icon
+WCLASS_WINDOW = 1, /* Window contents */
+WCLASS_MENU = 2, /* Menus */
+WCLASS_APPICON = 3,/* Application Icon
* dockeable application outside
* the clip/dock */
-WCLASS_MINIWINDOW = 3, /* Application minimized */
-WCLASS_DOCK_ICON = 4, /* Dock, clip, dockeable app docked */
-WCLASS_FRAME = 5 /* Window Frame (title, border,... */
+WCLASS_MINIWINDOW = 4, /* Application minimized */
+WCLASS_DOCK_ICON = 5, /* Dock, clip, dockeable app docked */
+WCLASS_FRAME = 6 /* Window Frame (title, border,... */
} WClassType;
/*
kix@osaka:~/src/wmaker-crm/src$
But why? Yes, is zero, zero is different, but I cannot find where the problem
is.
kix
On Mon, 02 Apr 2012, Rodolfo kix Garcia escribió:
This is incredible...
one more time, don't apply this patch... incredible.
The reason, is, if you apply the patch, all works fine, but, if you make
right click on a docked application, then click in Launch when te
application is already launched, then, WindowMaker restarts.
Please, don't ask how I found the bug.
I will try to find the problem (hardcoded type in the code??).
Regards,
kix
On Mon, 02 Apr 2012, Rodolfo kix Garcia escribió:
From b4d2de26ef2588c62e976e4ceced62711bba1a7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20(kix)?=
k...@kix.es
Date: Mon, 2 Apr 2012 23:20:30 +0200
Subject: [PATCH] WindowMaker: Class codes cleaned
The class codes are used in the icon, balloon and other parts. Some class
codes are not used.
This patch identify the used codes, renumber them, delete the not used
codes and document the codes.
---
src/WindowMaker.h | 20
1 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/src/WindowMaker.h b/src/WindowMaker.h
index e10b5ab..31a497b 100644
--- a/src/WindowMaker.h
+++ b/src/WindowMaker.h
@@ -26,22 +26,18 @@
#include limits.h
#include WINGs/WINGs.h
-
/* class codes */
typedef enum {
-WCLASS_UNKNOWN = 0,
-WCLASS_WINDOW = 1, /* managed client windows */
-WCLASS_MENU = 2, /* root menus */
-WCLASS_APPICON = 3,
-WCLASS_DUMMYWINDOW = 4, /* window that holds window group
leader */
-WCLASS_MINIWINDOW = 5,
-WCLASS_DOCK_ICON = 6,
-WCLASS_PAGER = 7,
-WCLASS_TEXT_INPUT = 8,
-WCLASS_FRAME = 9
+WCLASS_WINDOW = 0, /* Window contents */
+WCLASS_MENU = 1, /* Menus */
+WCLASS_APPICON = 2, /* Application Icon
+ * dockeable application outside
+ * the clip/dock */
+WCLASS_MINIWINDOW = 3, /* Application minimized */
+WCLASS_DOCK_ICON = 4,/* Dock, clip, dockeable app docked */
+WCLASS_FRAME = 5 /* Window Frame (title, border,... */
} WClassType;
-
/*
* generic window levels (a superset of the N*XTSTEP ones)
* Applications should use levels between WMDesktopLevel and
--
1.7.9.1
--
||// //\\// Rodolfo kix Garcia
||\\// //\\ http://www.kix.es/
From b4d2de26ef2588c62e976e4ceced62711bba1a7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20(kix)?=
k...@kix.es
Date: Mon, 2 Apr 2012 23:20:30 +0200
Subject: [PATCH] WindowMaker: Class codes cleaned
The class codes are used in the icon, balloon and other parts. Some class
codes are not used.
This patch identify the used codes, renumber them, delete the not used
codes and document the codes.
---
src/WindowMaker.h | 20
1 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/src/WindowMaker.h b/src/WindowMaker.h
index e10b5ab..31a497b 100644
--- a/src/WindowMaker.h
+++ b/src/WindowMaker.h
@@ -26,22 +26,18 @@
#include limits.h
#include WINGs/WINGs.h
-
/* class codes */
typedef enum {
-WCLASS_UNKNOWN = 0,
-WCLASS_WINDOW = 1, /* managed client windows */
-
[PATCH] wmgenmenu: Add more apps to our nice menu
Hello,
I have added more apps to our menu :-)
If anyone want to have more apps in the menu, I would be lucky if you
write list or so and sent it to here or to me.
I will help so much it is possible. Than our windowmanager have to
best menu from all ;-)
Best regards
Chris
---
util/wmgenmenu.h | 44 +---
1 files changed, 41 insertions(+), 3 deletions(-)
diff --git a/util/wmgenmenu.h b/util/wmgenmenu.h
index 15675fd..8e6cd82 100644
--- a/util/wmgenmenu.h
+++ b/util/wmgenmenu.h
@@ -88,9 +88,11 @@ char *Multimedia[MAX_NR_APPS][2] = {
{ N_(OGMRip), ogmrip },
{ N_(DVBcut), dvbcut },
{ N_(AcidRip), acidrip },
+ { N_(RipperX), ripperX },
{ N_(Avidemux), avidemux2_gtk },
{ N_(GQmpeg), gqmpeg },
{ N_(SMPlayer), smplayer },
+{ N_(Linux MultiMedia Studio), lmms },
{ N_(Freeamp), freeamp },
{ N_(RealPlayer), realplay },
{ N_(Mediathek), Mediathek.sh },
@@ -152,6 +154,7 @@ char *Sound[MAX_NR_APPS][2] = {
{ N_(Krecord), krecord },
{ N_(Grecord), grecord },
{ N_(ALSA mixer), alsamixer ! },
+ { N_(VolWheel), volwheel },
{ N_(Sound configuration), sndconfig ! },
{ N_(aumix), aumix ! },
{ N_(Gmix), gmix },
@@ -164,6 +167,7 @@ char *Editors[MAX_NR_APPS][2] = {
{ N_(Emacs), emacs },
{ N_(XEmacs), xemacs },
{ N_(SciTE), scite },
+ { N_(Bluefish), bluefish },
{ N_(gVIM), gvim },
{ N_(vi), vi ! },
{ N_(VIM), vim ! },
@@ -209,15 +213,35 @@ char *Utilities[MAX_NR_APPS][2] = {
{ N_(gdict), gdict },
{ N_(gpsdrive), gpsdrive },
{ N_(Task Coach), taskcoach },
+{ N_(XSnap), xsnap },
+{ N_(Screengrab), screengrab },
+{ N_(XSane), xsane },
{ N_(wfcmgr), wfcmgr },
{ N_(switch), switch },
+ { N_(Cairo Clock), cairo-clock },
+ { N_(Conky), conky },
+ { N_(GNU Privacy Assistant), gpa },
+ { N_(Vidalia (tor)), vidalia },
{ N_(kaddressbook), kaddressbook },
{ N_(kab), kab },
+ { N_(Filezilla), filezilla },
+ { N_(Bleachbit), bleachbit },
+ { N_(Teamviewer), teamviewer },
{ N_(gUVCView), guvcview },
+{ N_(LinPopUp), linpopup },
+{ N_(Wine Configurator), winecfg },
+ { N_(NMap), nmapfe },
+ { N_(Hydra), xhydra },
+ { N_(XTeddy), xteddy },
+ { N_(XTeddy TEST), xteddy_test },
+ { N_(VNC Viewer), vncviewer },
+ { N_(Java Control Panel), ControlPanel },
{ N_(kfind), kfind },
{ N_(oclock), oclock },
{ N_(rclock), rclock },
+ { N_(Isomaster), isomaster },
{ N_(xclock), xclock },
+ { N_(HP Systray), hp-systray },
{ N_(kppp), kppp },
{ N_(Xarchiver), xarchiver },
{ NULL, NULL }
@@ -231,12 +255,15 @@ char *Chat[MAX_NR_APPS][2] = {
{ N_(Pidgin), pidgin },
{ N_(Skype), skype },
{ N_(Gizmo), gizmo },
+ { N_(Gajim), gajim },
{ N_(Kopete), kopete },
{ N_(XChat), xchat },
{ N_(Ekiga), Ekiga },
{ N_(KVIrc), kvirc },
{ N_(BitchX), BitchX ! },
{ N_(EPIC), epic ! },
+ { N_(Linphone), linphone },
+ { N_(Mumble), mumble },
{ N_(EPIC4), epic4 ! },
{ N_(Irssi), irssi ! },
{ N_(TinyIRC), tinyirc ! },
@@ -254,8 +281,9 @@ char *P2P[MAX_NR_APPS][2] = {
{ N_(Smb4K), smb4k },
{ N_(KTorrent), ktorrent },
{ N_(BitTorrent GUI), bittorrent-gui },
+ { N_(Transmission GTK), transmission-gtk },
{ N_(ftp), ftp ! },
- { N_(Deluge), deluge },
+ { N_(Deluge), deluge-gtk },
{ N_(sftp), sftp ! },
{ N_(Pavuk), pavuk },
{ N_(gtm), gtm ! },
@@ -270,8 +298,11 @@ char *Games[MAX_NR_APPS][2] = {
{ N_(Tremulous), tremulous },
{ N_(XBoard), xboard },
{ N_(GNOME Chess), gnome-chess },
+ { N_(Darkplaces (Quake 1)), darkplaces },
+ { N_(QuakeSpasm (Quake 1)), quakespasm },
{ N_(Quake 2), quake2 },
-{ N_(KM Quake 2), kmquake2 },
+{ N_(KM Quake 2 (Quake 2), kmquake2 },
+{ N_(QMax (Quake 2), quake2-qmax },
{ N_(Quake 3), quake3 },
{ N_(Quake 4), quake4 },
{ N_(Quake 4 SMP), quake4-smp },
@@ -287,8 +318,12 @@ char *Games[MAX_NR_APPS][2] = {
{ N_(GNUjump), gnujump },
{ N_(Supertransball 2), supertransball2 },
{ N_(Supertux), supertux },
- { N_(supertux 2), supertux2 },
+ { N_(Supertux 2), supertux2 },
+ { N_(Mega Mario), megamario },
+ { N_(Frogatto), frogatto },
+ { N_(Minecraft), minecraft },
{ N_(Alienarena), alienarena },
+ { N_(Nexuiz), nexuiz },
{ N_(Bomberclone), bomberclone },
{ N_(Chromium-BSU), chromium-bsu },
{ N_(Clanbomber), clanbomber },
@@ -314,6 +349,7 @@ char *Games[MAX_NR_APPS][2] = {
{ N_(Return to Castle
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.2-33-g42a78ee
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via 42a78ee73f70e70f1e3d7d8d4751846352f216be (commit)
via aab9028fc25fdd09b0e1fcc4ef72394c01db93f8 (commit)
from 1a0e665e58905c2164091012d6ffe867feac54a2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/42a78ee73f70e70f1e3d7d8d4751846352f216be
commit 42a78ee73f70e70f1e3d7d8d4751846352f216be
Author: Christoph Soehngen blacksta...@gmx.net
Date: Sun Apr 1 13:55:09 2012 +0200
wmgenmenu: Add more apps to our nice menu
diff --git a/util/wmgenmenu.h b/util/wmgenmenu.h
index 15675fd..8e6cd82 100644
--- a/util/wmgenmenu.h
+++ b/util/wmgenmenu.h
@@ -88,9 +88,11 @@ char *Multimedia[MAX_NR_APPS][2] = {
{ N_(OGMRip), ogmrip },
{ N_(DVBcut), dvbcut },
{ N_(AcidRip), acidrip },
+ { N_(RipperX), ripperX },
{ N_(Avidemux), avidemux2_gtk },
{ N_(GQmpeg), gqmpeg },
{ N_(SMPlayer), smplayer },
+{ N_(Linux MultiMedia Studio), lmms },
{ N_(Freeamp), freeamp },
{ N_(RealPlayer), realplay },
{ N_(Mediathek), Mediathek.sh },
@@ -152,6 +154,7 @@ char *Sound[MAX_NR_APPS][2] = {
{ N_(Krecord), krecord },
{ N_(Grecord), grecord },
{ N_(ALSA mixer), alsamixer ! },
+ { N_(VolWheel), volwheel },
{ N_(Sound configuration), sndconfig ! },
{ N_(aumix), aumix ! },
{ N_(Gmix), gmix },
@@ -164,6 +167,7 @@ char *Editors[MAX_NR_APPS][2] = {
{ N_(Emacs), emacs },
{ N_(XEmacs), xemacs },
{ N_(SciTE), scite },
+ { N_(Bluefish), bluefish },
{ N_(gVIM), gvim },
{ N_(vi), vi ! },
{ N_(VIM), vim ! },
@@ -209,15 +213,35 @@ char *Utilities[MAX_NR_APPS][2] = {
{ N_(gdict), gdict },
{ N_(gpsdrive), gpsdrive },
{ N_(Task Coach), taskcoach },
+{ N_(XSnap), xsnap },
+{ N_(Screengrab), screengrab },
+{ N_(XSane), xsane },
{ N_(wfcmgr), wfcmgr },
{ N_(switch), switch },
+ { N_(Cairo Clock), cairo-clock },
+ { N_(Conky), conky },
+ { N_(GNU Privacy Assistant), gpa },
+ { N_(Vidalia (tor)), vidalia },
{ N_(kaddressbook), kaddressbook },
{ N_(kab), kab },
+ { N_(Filezilla), filezilla },
+ { N_(Bleachbit), bleachbit },
+ { N_(Teamviewer), teamviewer },
{ N_(gUVCView), guvcview },
+{ N_(LinPopUp), linpopup },
+{ N_(Wine Configurator), winecfg },
+ { N_(NMap), nmapfe },
+ { N_(Hydra), xhydra },
+ { N_(XTeddy), xteddy },
+ { N_(XTeddy TEST), xteddy_test },
+ { N_(VNC Viewer), vncviewer },
+ { N_(Java Control Panel), ControlPanel },
{ N_(kfind), kfind },
{ N_(oclock), oclock },
{ N_(rclock), rclock },
+ { N_(Isomaster), isomaster },
{ N_(xclock), xclock },
+ { N_(HP Systray), hp-systray },
{ N_(kppp), kppp },
{ N_(Xarchiver), xarchiver },
{ NULL, NULL }
@@ -231,12 +255,15 @@ char *Chat[MAX_NR_APPS][2] = {
{ N_(Pidgin), pidgin },
{ N_(Skype), skype },
{ N_(Gizmo), gizmo },
+ { N_(Gajim), gajim },
{ N_(Kopete), kopete },
{ N_(XChat), xchat },
{ N_(Ekiga), Ekiga },
{ N_(KVIrc), kvirc },
{ N_(BitchX), BitchX ! },
{ N_(EPIC), epic ! },
+ { N_(Linphone), linphone },
+ { N_(Mumble), mumble },
{ N_(EPIC4), epic4 ! },
{ N_(Irssi), irssi ! },
{ N_(TinyIRC), tinyirc ! },
@@ -254,8 +281,9 @@ char *P2P[MAX_NR_APPS][2] = {
{ N_(Smb4K), smb4k },
{ N_(KTorrent), ktorrent },
{ N_(BitTorrent GUI), bittorrent-gui },
+ { N_(Transmission GTK), transmission-gtk },
{ N_(ftp), ftp ! },
- { N_(Deluge), deluge },
+ { N_(Deluge), deluge-gtk },
{ N_(sftp), sftp ! },
{ N_(Pavuk), pavuk },
{ N_(gtm), gtm ! },
@@ -270,8 +298,11 @@ char *Games[MAX_NR_APPS][2] = {
{ N_(Tremulous), tremulous },
{ N_(XBoard), xboard },
{ N_(GNOME Chess), gnome-chess },
+ { N_(Darkplaces (Quake 1)), darkplaces },
+ { N_(QuakeSpasm (Quake 1)), quakespasm },
{ N_(Quake 2), quake2 },
-{ N_(KM Quake 2), kmquake2 },
+{ N_(KM Quake 2 (Quake 2), kmquake2 },
+{ N_(QMax (Quake 2), quake2-qmax },
{ N_(Quake 3), quake3 },
{ N_(Quake 4), quake4 },
{ N_(Quake 4 SMP), quake4-smp },
@@ -287,8 +318,12 @@ char *Games[MAX_NR_APPS][2] = {
{ N_(GNUjump), gnujump },
{ N_(Supertransball 2), supertransball2 },
{ N_(Supertux), supertux },
-
