Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
See also: http://forum.doom9.org/showthread.php?p=1677018#post1677018 ff. Probably some needle in the hay task for Min Chen, the ASM expert? -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] [PATCH] vbv: log frame-average QPs for VBV; even when AQ is disabled
hello, reminder : this bug-fix is still pending. can we have this patch pushed in to fix the bug, if there is no problems with it? On Tue, Apr 8, 2014 at 8:33 PM, aar...@multicorewareinc.com wrote: # HG changeset patch # User Aarthi Thirumalai # Date 1396969086 -19800 # Tue Apr 08 20:28:06 2014 +0530 # Node ID cac0dcd5a5c2470194d58057d9decd38da3e4405 # Parent b5caca9954f36fc8e1cfb9e25f96288bf3aa18e2 vbv: log frame-average QPs for VBV; even when AQ is disabled. diff -r b5caca9954f3 -r cac0dcd5a5c2 source/encoder/ratecontrol.cpp --- a/source/encoder/ratecontrol.cppTue Apr 08 16:13:11 2014 +0530 +++ b/source/encoder/ratecontrol.cppTue Apr 08 20:28:06 2014 +0530 @@ -1027,6 +1027,8 @@ pic-m_avgQpRc /= (pic-getFrameHeightInCU() * pic-getFrameWidthInCU()); rce-qpaRc = pic-m_avgQpRc; +// copy avg RC qp to m_avgQpAq. To print out the correct qp when aq/cutree is disabled. +pic-m_avgQpAq = pic-m_avgQpRc; } if (pic-m_qpaAq) ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] [PATCH] vbv: log frame-average QPs for VBV; even when AQ is disabled
Sure. On Fri, Apr 11, 2014 at 11:41 AM, Aarthi Priya Thirumalai aar...@multicorewareinc.com wrote: hello, reminder : this bug-fix is still pending. can we have this patch pushed in to fix the bug, if there is no problems with it? On Tue, Apr 8, 2014 at 8:33 PM, aar...@multicorewareinc.com wrote: # HG changeset patch # User Aarthi Thirumalai # Date 1396969086 -19800 # Tue Apr 08 20:28:06 2014 +0530 # Node ID cac0dcd5a5c2470194d58057d9decd38da3e4405 # Parent b5caca9954f36fc8e1cfb9e25f96288bf3aa18e2 vbv: log frame-average QPs for VBV; even when AQ is disabled. diff -r b5caca9954f3 -r cac0dcd5a5c2 source/encoder/ratecontrol.cpp --- a/source/encoder/ratecontrol.cppTue Apr 08 16:13:11 2014 +0530 +++ b/source/encoder/ratecontrol.cppTue Apr 08 20:28:06 2014 +0530 @@ -1027,6 +1027,8 @@ pic-m_avgQpRc /= (pic-getFrameHeightInCU() * pic-getFrameWidthInCU()); rce-qpaRc = pic-m_avgQpRc; +// copy avg RC qp to m_avgQpAq. To print out the correct qp when aq/cutree is disabled. +pic-m_avgQpAq = pic-m_avgQpRc; } if (pic-m_qpaAq) ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
Hi, It will be really helpful if you can provide the call stack log. On Fri, Apr 11, 2014 at 11:39 AM, Mario *LigH* Rohkrämer cont...@ligh.dewrote: See also: http://forum.doom9.org/showthread.php?p=1677018#post1677018 ff. Probably some needle in the hay task for Min Chen, the ASM expert? -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
We dont have a system (having support upto SSSE3) to reproduce the issue at our end . So the call stack will be helpful. On Fri, Apr 11, 2014 at 1:49 PM, Nabajit Deka naba...@multicorewareinc.comwrote: Hi, It will be really helpful if you can provide the call stack log. On Fri, Apr 11, 2014 at 11:39 AM, Mario *LigH* Rohkrämer cont...@ligh.dewrote: See also: http://forum.doom9.org/showthread.php?p=1677018#post1677018 ff. Probably some needle in the hay task for Min Chen, the ASM expert? -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
If you can give us call stack, we can solve it soon. I did not have this issue, I report it on behalf of 'D3C0D3R': See also: http://forum.doom9.org/showthread.php?p=1677018#post1677018 ff. I may ask him to provide the call stack. But if he asks how to do that, please tell me too how he shall do that because I don't know either. I am not sure if the Microsoft crash dialog will provide enough details. -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
Thank you! For simplest way, capture windows crash window (show crash address) and his exe file, we can find more information in it. At 2014-04-11 16:35:08,Mario *LigH* Rohkrämer cont...@ligh.de wrote: If you can give us call stack, we can solve it soon. I did not have this issue, I report it on behalf of 'D3C0D3R': See also: http://forum.doom9.org/showthread.php?p=1677018#post1677018 ff. I may ask him to provide the call stack. But if he asks how to do that, please tell me too how he shall do that because I don't know either. I am not sure if the Microsoft crash dialog will provide enough details. -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
Am 11.04.2014, 10:28 Uhr, schrieb Nabajit Deka naba...@multicorewareinc.com: We dont have a system (having support upto SSSE3) to reproduce the issue at our end . So the call stack will be helpful. I wonder if it may be possible to provoke this SSSE3-only crash by using a better CPU and masking SSE4 support out with the --asm parameter. But I have only AMD CPUs available, I can't check that on my end. -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
--asm disable asm code, can't help to detect problem point At 2014-04-11 16:55:20,Mario *LigH* Rohkrämer cont...@ligh.de wrote: Am 11.04.2014, 10:28 Uhr, schrieb Nabajit Deka naba...@multicorewareinc.com: We dont have a system (having support upto SSSE3) to reproduce the issue at our end . So the call stack will be helpful. I wonder if it may be possible to provoke this SSSE3-only crash by using a better CPU and masking SSE4 support out with the --asm parameter. But I have only AMD CPUs available, I can't check that on my end. -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] [PATCH] fix build error on VS2008 + WinXP
On Thu, Apr 10, 2014 at 9:36 PM, chen chenm...@163.com wrote: At 2014-04-11 02:03:29,Steve Borho st...@borho.org wrote: On Thu, Apr 10, 2014 at 4:38 AM, Min Chen chenm...@163.com wrote: # HG changeset patch # User Min Chen chenm...@163.com # Date 1397122677 -28800 # Node ID 88365d9b50a56ff468b54b4d42f18d5644a9f79f # Parent 83ccf2f1453ffd91c9fd8b84b72e3d3daacba6c6 fix build error on VS2008 + WinXP diff -r 83ccf2f1453f -r 88365d9b50a5 source/common/winxp.cpp --- a/source/common/winxp.cpp Thu Apr 10 11:17:46 2014 +0530 +++ b/source/common/winxp.cpp Thu Apr 10 17:37:57 2014 +0800 @@ -23,7 +23,7 @@ #include threading.h -#if defined(_WIN32) (_WIN32_WINNT _WIN32_WINNT_VISTA) +#if defined(_WIN32) (_WIN32_WINNT = _WIN32_WINNT_WINXP) What is the build error you see? And what is your _WIN32_WINNT value? See 6630 (ae07405973b7) xp: fix header guards for XP support, fixes MinGW build Thanks! The VS2008 default SDK didn't define WIN32_WINNT_VISTA I guess we should use the actual value of WIN32_WINNT_VISTA there then -- Steve Borho ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
On Fri, Apr 11, 2014 at 4:04 AM, chen chenm...@163.com wrote: --asm disable asm code, can't help to detect problem point Do any of the virtual PC tools allow you to specify the SIMD architecture level? It would be really handy to be able to: valgrind --cpu=ssse3 ./test/Testbench Then we could automated testing for this problem. Does anyone know of any such tool? On our side, we very recently added [i]dct8x8 transforms marked as SSSE3; those should be reviewed. -- Steve Borho ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
I often use QEMU At 2014-04-12 03:30:46,Steve Borho st...@borho.org wrote: On Fri, Apr 11, 2014 at 4:04 AM, chen chenm...@163.com wrote: --asm disable asm code, can't help to detect problem point Do any of the virtual PC tools allow you to specify the SIMD architecture level? It would be really handy to be able to: valgrind --cpu=ssse3 ./test/Testbench Then we could automated testing for this problem. Does anyone know of any such tool? On our side, we very recently added [i]dct8x8 transforms marked as SSSE3; those should be reviewed. -- Steve Borho ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] ASM crash in r6682 on E5200: Probably SSE4 vs. SSSE3 instructions
a little more: your code is right, but when someone defined HAVE_ALIGNED_STACK and pass unalignment stack pointer into your code, mova will make crash. At 2014-04-12 05:45:15,chen chenm...@163.com wrote: @Nabajit, could you check dct8.asm, your r5 is unalignment, but use mova. At 2014-04-12 05:13:16,Mario Rohkrämer cont...@ligh.de wrote: Am 11.04.2014, 10:41 Uhr, schrieb chen chenm...@163.com: Thank you! For simplest way, capture windows crash window (show crash address) and his exe file, we can find more information in it. D3C0D3R just replied in http://forum.doom9.org/showthread.php?p=1677250#post1677250 + SIGSEGV ... in in x265_patial_butterfly_inverse_internal_pass2_ssse3 () + Unfortunately, he did not attach his debug build of ffmpeg. -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
[x265] [PATCH] fix build error on VS2008 + WinXP
# HG changeset patch
# User Min Chen chenm...@163.com
# Date 1397256800 -28800
# Node ID 065e6599bab74c34e26ad67a9b9f6ed41516856d
# Parent 850ebca2f7c88536753941736e447de475fe746f
fix build error on VS2008 + WinXP
diff -r 850ebca2f7c8 -r 065e6599bab7 source/common/winxp.h
--- a/source/common/winxp.h Fri Apr 11 14:52:11 2014 -0500
+++ b/source/common/winxp.h Sat Apr 12 06:53:20 2014 +0800
@@ -24,8 +24,16 @@
#ifndef X265_WINXP_H
#define X265_WINXP_H
+#ifndef _WIN32_WINNT_VISTA
+#define _WIN32_WINNT_VISTA 0x0600
+#endif
+
#if defined(_WIN32) (_WIN32_WINNT _WIN32_WINNT_VISTA)
+#ifdef _MSC_VER
+#include intrin.h // _InterlockedCompareExchange64
+#endif
+
namespace x265
{
@@ -83,6 +91,6 @@
#define XP_CONDITION_VAR_FREE(x)
-#endif // _WIN32_WINNT = _WIN32_WINNT_WINXP
+#endif // _WIN32_WINNT _WIN32_WINNT_VISTA
#endif // ifndef X265_WINXP_H
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] [PATCH] fix build error on VS2008 + WinXP
On Fri, Apr 11, 2014 at 5:53 PM, Min Chen chenm...@163.com wrote:
# HG changeset patch
# User Min Chen chenm...@163.com
# Date 1397256800 -28800
# Node ID 065e6599bab74c34e26ad67a9b9f6ed41516856d
# Parent 850ebca2f7c88536753941736e447de475fe746f
fix build error on VS2008 + WinXP
modified version queued
diff -r 850ebca2f7c8 -r 065e6599bab7 source/common/winxp.h
--- a/source/common/winxp.h Fri Apr 11 14:52:11 2014 -0500
+++ b/source/common/winxp.h Sat Apr 12 06:53:20 2014 +0800
@@ -24,8 +24,16 @@
#ifndef X265_WINXP_H
#define X265_WINXP_H
+#ifndef _WIN32_WINNT_VISTA
+#define _WIN32_WINNT_VISTA 0x0600
+#endif
+
#if defined(_WIN32) (_WIN32_WINNT _WIN32_WINNT_VISTA)
+#ifdef _MSC_VER
+#include intrin.h // _InterlockedCompareExchange64
+#endif
+
namespace x265
{
@@ -83,6 +91,6 @@
#define XP_CONDITION_VAR_FREE(x)
-#endif // _WIN32_WINNT = _WIN32_WINNT_WINXP
+#endif // _WIN32_WINNT _WIN32_WINNT_VISTA
#endif // ifndef X265_WINXP_H
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel
--
Steve Borho
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel
