[x265] [PATCH] csv: print the correct value for BufferFill column in csv
# HG changeset patch # User Gopi Satykrishna Akisetty # Date 1491978866 -19800 # Wed Apr 12 12:04:26 2017 +0530 # Node ID 8e1f2e00dd9d2f7af2904f1774fc87a254ee36ea # Parent 0b7d54dbb71a87a0c6514fee04a51c4b29d5d704 csv: print the correct value for BufferFill column in csv diff -r 0b7d54dbb71a -r 8e1f2e00dd9d source/encoder/ratecontrol.cpp --- a/source/encoder/ratecontrol.cppWed Apr 12 19:01:00 2017 +0530 +++ b/source/encoder/ratecontrol.cppWed Apr 12 12:04:26 2017 +0530 @@ -2550,25 +2550,25 @@ m_bufferFillFinal = X265_MAX(m_bufferFillFinal, 0); m_bufferFillFinal += m_bufferRate; -if (m_bufferFillFinal > m_bufferSize) +if (m_param->rc.bStrictCbr) { -if (m_param->rc.bStrictCbr) +if (m_bufferFillFinal > m_bufferSize) { filler = (int)(m_bufferFillFinal - m_bufferSize); filler += FILLER_OVERHEAD * 8; -m_bufferFillFinal -= filler; -bufferBits = X265_MIN(bits + filler + m_bufferExcess, m_bufferRate); -m_bufferExcess = X265_MAX(m_bufferExcess - bufferBits + bits + filler, 0); -m_bufferFillActual += bufferBits - bits - filler; } -else -{ -m_bufferFillFinal = X265_MIN(m_bufferFillFinal, m_bufferSize); -bufferBits = X265_MIN(bits + m_bufferExcess, m_bufferRate); -m_bufferExcess = X265_MAX(m_bufferExcess - bufferBits + bits, 0); -m_bufferFillActual += bufferBits - bits; -m_bufferFillActual = X265_MIN(m_bufferFillActual, m_bufferSize); -} +m_bufferFillFinal -= filler; +bufferBits = X265_MIN(bits + filler + m_bufferExcess, m_bufferRate); +m_bufferExcess = X265_MAX(m_bufferExcess - bufferBits + bits + filler, 0); +m_bufferFillActual += bufferBits - bits - filler; +} +else +{ +m_bufferFillFinal = X265_MIN(m_bufferFillFinal, m_bufferSize); +bufferBits = X265_MIN(bits + m_bufferExcess, m_bufferRate); +m_bufferExcess = X265_MAX(m_bufferExcess - bufferBits + bits, 0); +m_bufferFillActual += bufferBits - bits; +m_bufferFillActual = X265_MIN(m_bufferFillActual, m_bufferSize); } return filler; } ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] [PATCH] Improved sao implementation by limiting sao types
Thank you. Sent the patch for the issue in doc. On Wed, Apr 12, 2017 at 6:35 PM, Mario *LigH* Rohkrämer wrote: > Am 07.04.2017, 12:34 Uhr, schrieb : > > diff -r 08a05ca9fd16 -r 195ae8f499fc doc/reST/cli.rst >> --- a/doc/reST/cli.rst Mon Mar 27 12:35:20 2017 +0530 >> +++ b/doc/reST/cli.rst Mon Apr 03 16:02:07 2017 +0530 >> @@ -1690,6 +1690,12 @@ >> disabled, SAO analysis skips the right/bottom boundary areas. >> Default disabled >> +.. option:: --limit-sao, --no-limit-sao >> +Limit SAO filter computation by early terminating SAO process based >> +on inter prediction mode, CTU spatial-domain correlations, and >> relations >> +between luma and chroma. >> +Default disabled >> + >> > > > (originally reported by stax76 in the doom9 forum) > > This part of the patch causes issues in the rendered documentation > (comparing to a in HTML: as if you forgot before ): > > * definition terms and descriptions apparently need to be separated from > each other by empty lines in reST sources > * for consistency, descriptions should probably be prepended by one tab > instead of four spaces > > See: http://x265.readthedocs.io/en/latest/cli.html#cmdoption-limit-sao > > > -- > > Fun and success! > Mario *LigH* Rohkrämer > mailto:cont...@ligh.de > > > ___ > x265-devel mailing list > x265-devel@videolan.org > https://mailman.videolan.org/listinfo/x265-devel > ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
[x265] [PATCH] correct issues in the documentation
# HG changeset patch # User Ashok Kumar Mishra # Date 1492003860 -19800 # Wed Apr 12 19:01:00 2017 +0530 # Node ID 0b7d54dbb71a87a0c6514fee04a51c4b29d5d704 # Parent 1ed21871787774c08221b00fe91e824fafca4cde correct issues in the documentation diff -r 1ed218717877 -r 0b7d54dbb71a doc/reST/cli.rst --- a/doc/reST/cli.rst Tue Apr 11 03:08:00 2017 +0200 +++ b/doc/reST/cli.rst Wed Apr 12 19:01:00 2017 +0530 @@ -1689,11 +1689,13 @@ When enabled, non-deblocked pixels are used for SAO analysis. When disabled, SAO analysis skips the right/bottom boundary areas. Default disabled + .. option:: --limit-sao, --no-limit-sao -Limit SAO filter computation by early terminating SAO process based -on inter prediction mode, CTU spatial-domain correlations, and relations -between luma and chroma. -Default disabled + + Limit SAO filter computation by early terminating SAO process based + on inter prediction mode, CTU spatial-domain correlations, and relations + between luma and chroma. + Default disabled VUI (Video Usability Information) options = ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] [PATCH] Improved sao implementation by limiting sao types
Am 07.04.2017, 12:34 Uhr, schrieb : diff -r 08a05ca9fd16 -r 195ae8f499fc doc/reST/cli.rst --- a/doc/reST/cli.rst Mon Mar 27 12:35:20 2017 +0530 +++ b/doc/reST/cli.rst Mon Apr 03 16:02:07 2017 +0530 @@ -1690,6 +1690,12 @@ disabled, SAO analysis skips the right/bottom boundary areas. Default disabled +.. option:: --limit-sao, --no-limit-sao +Limit SAO filter computation by early terminating SAO process based +on inter prediction mode, CTU spatial-domain correlations, and relations +between luma and chroma. +Default disabled + (originally reported by stax76 in the doom9 forum) This part of the patch causes issues in the rendered documentation (comparing to a in HTML: as if you forgot before ): * definition terms and descriptions apparently need to be separated from each other by empty lines in reST sources * for consistency, descriptions should probably be prepended by one tab instead of four spaces See: http://x265.readthedocs.io/en/latest/cli.html#cmdoption-limit-sao -- Fun and success! Mario *LigH* Rohkrämer mailto:cont...@ligh.de ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel