date:20171122

Re: [x265] [PATCH] encoder.cpp: fix encoder crash for --analysis-reuse-level=10

2017-11-22 Thread Pradeep Ramachandran

On Wed, Nov 22, 2017 at 5:27 PM,  wrote:

> # HG changeset patch
> # User Praveen Tiwari 
> # Date 1511338280 -19800
> #  Wed Nov 22 13:41:20 2017 +0530
> # Branch stable
> # Node ID dd11aa99f40a1af59065984afa9b699d2eb1162e
> # Parent  752ed1108fce1b475e0458b70f92503d6343818b
> encoder.cpp: fix encoder crash for --analysis-reuse-level=10
>

Thanks for the fix. Pushed to stable, and merged into default


>
> diff -r 752ed1108fce -r dd11aa99f40a source/encoder/encoder.cpp
> --- a/source/encoder/encoder.cppTue Nov 21 09:50:45 2017 +0530
> +++ b/source/encoder/encoder.cppWed Nov 22 13:41:20 2017 +0530
> @@ -1155,6 +1155,8 @@
>  pic_out->analysisData.wt =
> outFrame->m_analysisData.wt;
>  pic_out->analysisData.interData =
> outFrame->m_analysisData.interData;
>  pic_out->analysisData.intraData =
> outFrame->m_analysisData.intraData;
> +pic_out->analysisData.modeFlag[0] =
> outFrame->m_analysisData.modeFlag[0];
> +pic_out->analysisData.modeFlag[1] =
> outFrame->m_analysisData.modeFlag[1];
>  if (m_param->bDisableLookahead)
>  {
>  int factor = 1;
> @@ -3067,6 +3069,7 @@
>  CHECKED_MALLOC(interData->mvpIdx[dir], uint8_t,
> analysis->numPartitions * analysis->numCUsInFrame);
>  CHECKED_MALLOC(interData->refIdx[dir], int8_t,
> analysis->numPartitions * analysis->numCUsInFrame);
>  CHECKED_MALLOC(interData->mv[dir], MV,
> analysis->numPartitions * analysis->numCUsInFrame);
> +CHECKED_MALLOC(analysis->modeFlag[dir], uint8_t,
> analysis->numPartitions * analysis->numCUsInFrame);
>  }
>
>  /* Allocate intra in inter */
> @@ -3146,7 +3149,11 @@
>  X265_FREE(((analysis_inter_
> data*)analysis->interData)->mvpIdx[dir]);
>  X265_FREE(((analysis_inter_
> data*)analysis->interData)->refIdx[dir]);
>  X265_FREE(((analysis_inter_
> data*)analysis->interData)->mv[dir]);
> -X265_FREE(analysis->modeFlag[dir]);
> +if (analysis->modeFlag[dir] != NULL)
> +{
> +X265_FREE(analysis->modeFlag[dir]);
> +analysis->modeFlag[dir] = NULL;
> +}
>  }
>  }
>  else
> ___
> x265-devel mailing list
> x265-devel@videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

[x265] [PATCH] encoder.cpp: fix encoder crash for --analysis-reuse-level=10

2017-11-22 Thread praveen

# HG changeset patch
# User Praveen Tiwari 
# Date 1511338280 -19800
#  Wed Nov 22 13:41:20 2017 +0530
# Branch stable
# Node ID dd11aa99f40a1af59065984afa9b699d2eb1162e
# Parent  752ed1108fce1b475e0458b70f92503d6343818b
encoder.cpp: fix encoder crash for --analysis-reuse-level=10

diff -r 752ed1108fce -r dd11aa99f40a source/encoder/encoder.cpp
--- a/source/encoder/encoder.cppTue Nov 21 09:50:45 2017 +0530
+++ b/source/encoder/encoder.cppWed Nov 22 13:41:20 2017 +0530
@@ -1155,6 +1155,8 @@
 pic_out->analysisData.wt = outFrame->m_analysisData.wt;
 pic_out->analysisData.interData = 
outFrame->m_analysisData.interData;
 pic_out->analysisData.intraData = 
outFrame->m_analysisData.intraData;
+pic_out->analysisData.modeFlag[0] = 
outFrame->m_analysisData.modeFlag[0];
+pic_out->analysisData.modeFlag[1] = 
outFrame->m_analysisData.modeFlag[1];
 if (m_param->bDisableLookahead)
 {
 int factor = 1;
@@ -3067,6 +3069,7 @@
 CHECKED_MALLOC(interData->mvpIdx[dir], uint8_t, 
analysis->numPartitions * analysis->numCUsInFrame);
 CHECKED_MALLOC(interData->refIdx[dir], int8_t, 
analysis->numPartitions * analysis->numCUsInFrame);
 CHECKED_MALLOC(interData->mv[dir], MV, analysis->numPartitions 
* analysis->numCUsInFrame);
+CHECKED_MALLOC(analysis->modeFlag[dir], uint8_t, 
analysis->numPartitions * analysis->numCUsInFrame);
 }
 
 /* Allocate intra in inter */
@@ -3146,7 +3149,11 @@
 
X265_FREE(((analysis_inter_data*)analysis->interData)->mvpIdx[dir]);
 
X265_FREE(((analysis_inter_data*)analysis->interData)->refIdx[dir]);
 
X265_FREE(((analysis_inter_data*)analysis->interData)->mv[dir]);
-X265_FREE(analysis->modeFlag[dir]);
+if (analysis->modeFlag[dir] != NULL)
+{
+X265_FREE(analysis->modeFlag[dir]);
+analysis->modeFlag[dir] = NULL;
+}
 }
 }
 else
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

2017-11-22 Thread Mario *LigH* Rohkrämer


Just as side note:

Quite recent MSYS packages contain quite recent NASM versions as well, I  
see no similar concerns for Windows builds.



The MSYS/MinGW packages provided by XhmikosR (+ nevcairiel) are rather  
famous, the last package with GCC 7.1.0 (June 2017) already contained NASM  
2.13.01.


http://xhmikosr.1f0.de/tools/msys/ + https://files.1f0.de/mingw/


And the MSYS2 environment of jb-alvarado's media-autobuild_suite with  
MinGW32 and MinGW64 is kept up-to-date at every launch, using pacman.


https://github.com/jb-alvarado/media-autobuild_suite/


Based on such environments, compiling GCC 7.x MinGW Windows EXE builds is  
easy enough and reliable enough.


MABS does a full-automatic build of both bitnesses, if desired;  
additionally, for a slightly customized result, I don't use the  
cross-compilation toolchain provided by Multicoreware, instead I compile  
natively in a sequence, once under MinGW32, then under MinGW64 (and if I  
ever discover how MABS manages to switch between them, I may do so as  
well).



Am 22.11.2017, 10:59 Uhr, schrieb Vignesh Vijayakumar  
:



nasm 2.13 was released in April 2017 and 2.13.01 is the latest stable
version.
Is there is any problem updating to 2.13?

Thanks
Vignesh


On Tue, Nov 21, 2017 at 5:55 PM, Sean McGovern   
wrote:



Hi,

Is this really necessary?

Ubuntu 16.04 Xenial Xerus only ships with nasm 2.11.08.

-- Sean McG.

  Original Message
From: vign...@multicorewareinc.com
Sent: November 21, 2017 12:07 AM
To: x265-devel@videolan.org
Reply-to: x265-devel@videolan.org
Subject: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

# HG changeset patch
# User Vignesh Vijayakumar
# Date 1509595841 -19800
#  Thu Nov 02 09:40:41 2017 +0530
# Node ID 16ea92bf3627c6de43d583554df294dbbfd8fa8a
# Parent  182bfd0d5af929a801a08b35ee863d79eadb2833
x86: Change assembler from YASM to NASM

Supports NASM versions 2.13 and greater

diff -r 182bfd0d5af9 -r 16ea92bf3627 source/CMakeLists.txt
--- a/source/CMakeLists.txt Thu Nov 02 09:39:58 2017 +0530
+++ b/source/CMakeLists.txt Thu Nov 02 09:40:41 2017 +0530
@@ -323,15 +323,15 @@
 execute_process(COMMAND ${CMAKE_CXX_COMPILER} -dumpversion
OUTPUT_VARIABLE CC_VERSION)
endif(GCC)

-find_package(Yasm)
+find_package(Nasm)
if(ARM OR CROSS_COMPILE_ARM)
 option(ENABLE_ASSEMBLY "Enable use of assembly coded primitives"  
ON)

-elseif(YASM_FOUND AND X86)
-if (YASM_VERSION_STRING VERSION_LESS "1.2.0")
-message(STATUS "Yasm version ${YASM_VERSION_STRING} is too old.
1.2.0 or later required")
+elseif(NASM_FOUND AND X86)
+if (NASM_VERSION_STRING VERSION_LESS "2.13.0")
+message(STATUS "Nasm version ${NASM_VERSION_STRING} is too old.
2.13.0 or later required")
 option(ENABLE_ASSEMBLY "Enable use of assembly coded  
primitives"

OFF)
 else()
-message(STATUS "Found Yasm ${YASM_VERSION_STRING} to build
assembly primitives")
+message(STATUS "Found Nasm ${NASM_VERSION_STRING} to build
assembly primitives")
 option(ENABLE_ASSEMBLY "Enable use of assembly coded  
primitives"

ON)
 endif()
else()
@@ -517,18 +517,18 @@
 list(APPEND ASM_OBJS ${ASM}.${SUFFIX})
 add_custom_command(
 OUTPUT ${ASM}.${SUFFIX}
-COMMAND ${YASM_EXECUTABLE} ARGS ${YASM_FLAGS}  
${ASM_SRC}

-o ${ASM}.${SUFFIX}
+COMMAND ${NASM_EXECUTABLE} ARGS ${NASM_FLAGS}  
${ASM_SRC}

-o ${ASM}.${SUFFIX}
 DEPENDS ${ASM_SRC})
 endforeach()
 endif()
endif()
source_group(ASM FILES ${ASM_SRCS})
if(ENABLE_HDR10_PLUS)
-add_library(x265-static STATIC $
$ $ ${ASM_OBJS}
${ASM_SRCS})
+add_library(x265-static STATIC $
$ $ ${ASM_OBJS})
 add_library(hdr10plus-static STATIC $)
 set_target_properties(hdr10plus-static PROPERTIES OUTPUT_NAME
hdr10plus)
else()
-add_library(x265-static STATIC $
$ ${ASM_OBJS} ${ASM_SRCS})
+add_library(x265-static STATIC $
$ ${ASM_OBJS})
endif()
if(NOT MSVC)
 set_target_properties(x265-static PROPERTIES OUTPUT_NAME x265)
@@ -686,11 +686,11 @@
 if(ENABLE_HDR10_PLUS)
 add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
${GETOPT}
 x265.cpp x265.h x265cli.h
-$
$ $ ${ASM_OBJS}
${ASM_SRCS})
+$
$ $ ${ASM_OBJS})
 else()
 add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
${GETOPT}
 x265.cpp x265.h x265cli.h
-$
$ ${ASM_OBJS} ${ASM_SRCS})
+$
$ ${ASM_OBJS})
 endif()
 else()
 add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
${GETOPT} ${X265_RC_FILE}
diff -r 182bfd0d5af9 -r 16ea92bf3627 source/cmake/CMakeASM_
NASMInformation.cmake
--- /dev/null   Thu Jan 01 00:00:00 1970 +
+++ b/source/cmake/CMakeASM_NASMInformation.cmake   Thu Nov 02
09:40:41 2017 +0530
@@ -0,0 +1,68 @@
+set(ASM_DIALECT "_NASM")
+set(CMAKE_ASM${ASM_DIALECT}_SOURCE_F

Re: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

2017-11-22 Thread Michael Lackner

It might not be provided by the package management system of the Linux 
distribution
mentioned by Sean.

However, I found it quite easy to compile nasm 2.13 from source on a wide 
variety of
systems and compilers (Multiple Linux distros, even older ones like CentOS 6, 
multiple
UNIX systems like Solaris 11, FreeBSD UNIX 10 & 11, OpenBSD UNIX, etc., GCC 4, 
6 & 7 and
clang 3.8 & 4.0).

Honestly, the only system were I failed to compile version 2.13 (yet where yasm 
builds
fine) was the Haiku OS in x64.

On Ubuntu 16.04, compiling nasm 2.13 from source should be trivial.

On 11/22/2017 10:59 AM, Vignesh Vijayakumar wrote:
> nasm 2.13 was released in April 2017 and 2.13.01 is the latest stable
> version.
> Is there is any problem updating to 2.13?
> 
> Thanks
> Vignesh
> 
> 
> On Tue, Nov 21, 2017 at 5:55 PM, Sean McGovern  wrote:
> 
>> Hi,
>>
>> Is this really necessary?
>>
>> Ubuntu 16.04 Xenial Xerus only ships with nasm 2.11.08.
>>
>> -- Sean McG.
>>
>>   Original Message
>> From: vign...@multicorewareinc.com
>> Sent: November 21, 2017 12:07 AM
>> To: x265-devel@videolan.org
>> Reply-to: x265-devel@videolan.org
>> Subject: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM
>>
>> # HG changeset patch
>> # User Vignesh Vijayakumar
>> # Date 1509595841 -19800
>> #  Thu Nov 02 09:40:41 2017 +0530
>> # Node ID 16ea92bf3627c6de43d583554df294dbbfd8fa8a
>> # Parent  182bfd0d5af929a801a08b35ee863d79eadb2833
>> x86: Change assembler from YASM to NASM
>>
>> Supports NASM versions 2.13 and greater
>>
>> diff -r 182bfd0d5af9 -r 16ea92bf3627 source/CMakeLists.txt
>> --- a/source/CMakeLists.txt Thu Nov 02 09:39:58 2017 +0530
>> +++ b/source/CMakeLists.txt Thu Nov 02 09:40:41 2017 +0530
>> @@ -323,15 +323,15 @@
>>  execute_process(COMMAND ${CMAKE_CXX_COMPILER} -dumpversion
>> OUTPUT_VARIABLE CC_VERSION)
>> endif(GCC)
>>
>> -find_package(Yasm)
>> +find_package(Nasm)
>> if(ARM OR CROSS_COMPILE_ARM)
>>  option(ENABLE_ASSEMBLY "Enable use of assembly coded primitives" ON)
>> -elseif(YASM_FOUND AND X86)
>> -if (YASM_VERSION_STRING VERSION_LESS "1.2.0")
>> -message(STATUS "Yasm version ${YASM_VERSION_STRING} is too old.
>> 1.2.0 or later required")
>> +elseif(NASM_FOUND AND X86)
>> +if (NASM_VERSION_STRING VERSION_LESS "2.13.0")
>> +message(STATUS "Nasm version ${NASM_VERSION_STRING} is too old.
>> 2.13.0 or later required")
>>  option(ENABLE_ASSEMBLY "Enable use of assembly coded primitives"
>> OFF)
>>  else()
>> -message(STATUS "Found Yasm ${YASM_VERSION_STRING} to build
>> assembly primitives")
>> +message(STATUS "Found Nasm ${NASM_VERSION_STRING} to build
>> assembly primitives")
>>  option(ENABLE_ASSEMBLY "Enable use of assembly coded primitives"
>> ON)
>>  endif()
>> else()
>> @@ -517,18 +517,18 @@
>>  list(APPEND ASM_OBJS ${ASM}.${SUFFIX})
>>  add_custom_command(
>>  OUTPUT ${ASM}.${SUFFIX}
>> -COMMAND ${YASM_EXECUTABLE} ARGS ${YASM_FLAGS} ${ASM_SRC}
>> -o ${ASM}.${SUFFIX}
>> +COMMAND ${NASM_EXECUTABLE} ARGS ${NASM_FLAGS} ${ASM_SRC}
>> -o ${ASM}.${SUFFIX}
>>  DEPENDS ${ASM_SRC})
>>  endforeach()
>>  endif()
>> endif()
>> source_group(ASM FILES ${ASM_SRCS})
>> if(ENABLE_HDR10_PLUS)
>> -add_library(x265-static STATIC $
>> $ $ ${ASM_OBJS}
>> ${ASM_SRCS})
>> +add_library(x265-static STATIC $
>> $ $ ${ASM_OBJS})
>>  add_library(hdr10plus-static STATIC $)
>>  set_target_properties(hdr10plus-static PROPERTIES OUTPUT_NAME
>> hdr10plus)
>> else()
>> -add_library(x265-static STATIC $
>> $ ${ASM_OBJS} ${ASM_SRCS})
>> +add_library(x265-static STATIC $
>> $ ${ASM_OBJS})
>> endif()
>> if(NOT MSVC)
>>  set_target_properties(x265-static PROPERTIES OUTPUT_NAME x265)
>> @@ -686,11 +686,11 @@
>>  if(ENABLE_HDR10_PLUS)
>>  add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
>> ${GETOPT}
>>  x265.cpp x265.h x265cli.h
>> -$
>> $ $ ${ASM_OBJS}
>> ${ASM_SRCS})
>> +$
>> $ $ ${ASM_OBJS})
>>  else()
>>  add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
>> ${GETOPT}
>>  x265.cpp x265.h x265cli.h
>> -$
>> $ ${ASM_OBJS} ${ASM_SRCS})
>> +$
>> $ ${ASM_OBJS})
>>  endif()
>>  else()
>>  add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
>> ${GETOPT} ${X265_RC_FILE}
>> diff -r 182bfd0d5af9 -r 16ea92bf3627 source/cmake/CMakeASM_
>> NASMInformation.cmake
>> --- /dev/null   Thu Jan 01 00:00:00 1970 +
>> +++ b/source/cmake/CMakeASM_NASMInformation.cmake   Thu Nov 02
>> 09:40:41 2017 +0530
>> @@ -0,0 +1,68 @@
>> +set(ASM_DIALECT "_NASM")
>> +set(CMAKE_ASM${ASM_DIALECT}_SOURCE_FILE_EXTENSIONS asm)
>> +
>> +if(X64)
>> +list(APPEND ASM_FLAGS -DARCH_X86_64=1 -I
>> ${CMAKE_CURRENT_SOURCE_DIR}/../common/x86/)
>> +

Re: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

2017-11-22 Thread Vignesh Vijayakumar

nasm 2.13 was released in April 2017 and 2.13.01 is the latest stable
version.
Is there is any problem updating to 2.13?

Thanks
Vignesh


On Tue, Nov 21, 2017 at 5:55 PM, Sean McGovern  wrote:

> Hi,
>
> Is this really necessary?
>
> Ubuntu 16.04 Xenial Xerus only ships with nasm 2.11.08.
>
> -- Sean McG.
>
>   Original Message
> From: vign...@multicorewareinc.com
> Sent: November 21, 2017 12:07 AM
> To: x265-devel@videolan.org
> Reply-to: x265-devel@videolan.org
> Subject: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM
>
> # HG changeset patch
> # User Vignesh Vijayakumar
> # Date 1509595841 -19800
> #  Thu Nov 02 09:40:41 2017 +0530
> # Node ID 16ea92bf3627c6de43d583554df294dbbfd8fa8a
> # Parent  182bfd0d5af929a801a08b35ee863d79eadb2833
> x86: Change assembler from YASM to NASM
>
> Supports NASM versions 2.13 and greater
>
> diff -r 182bfd0d5af9 -r 16ea92bf3627 source/CMakeLists.txt
> --- a/source/CMakeLists.txt Thu Nov 02 09:39:58 2017 +0530
> +++ b/source/CMakeLists.txt Thu Nov 02 09:40:41 2017 +0530
> @@ -323,15 +323,15 @@
>  execute_process(COMMAND ${CMAKE_CXX_COMPILER} -dumpversion
> OUTPUT_VARIABLE CC_VERSION)
> endif(GCC)
>
> -find_package(Yasm)
> +find_package(Nasm)
> if(ARM OR CROSS_COMPILE_ARM)
>  option(ENABLE_ASSEMBLY "Enable use of assembly coded primitives" ON)
> -elseif(YASM_FOUND AND X86)
> -if (YASM_VERSION_STRING VERSION_LESS "1.2.0")
> -message(STATUS "Yasm version ${YASM_VERSION_STRING} is too old.
> 1.2.0 or later required")
> +elseif(NASM_FOUND AND X86)
> +if (NASM_VERSION_STRING VERSION_LESS "2.13.0")
> +message(STATUS "Nasm version ${NASM_VERSION_STRING} is too old.
> 2.13.0 or later required")
>  option(ENABLE_ASSEMBLY "Enable use of assembly coded primitives"
> OFF)
>  else()
> -message(STATUS "Found Yasm ${YASM_VERSION_STRING} to build
> assembly primitives")
> +message(STATUS "Found Nasm ${NASM_VERSION_STRING} to build
> assembly primitives")
>  option(ENABLE_ASSEMBLY "Enable use of assembly coded primitives"
> ON)
>  endif()
> else()
> @@ -517,18 +517,18 @@
>  list(APPEND ASM_OBJS ${ASM}.${SUFFIX})
>  add_custom_command(
>  OUTPUT ${ASM}.${SUFFIX}
> -COMMAND ${YASM_EXECUTABLE} ARGS ${YASM_FLAGS} ${ASM_SRC}
> -o ${ASM}.${SUFFIX}
> +COMMAND ${NASM_EXECUTABLE} ARGS ${NASM_FLAGS} ${ASM_SRC}
> -o ${ASM}.${SUFFIX}
>  DEPENDS ${ASM_SRC})
>  endforeach()
>  endif()
> endif()
> source_group(ASM FILES ${ASM_SRCS})
> if(ENABLE_HDR10_PLUS)
> -add_library(x265-static STATIC $
> $ $ ${ASM_OBJS}
> ${ASM_SRCS})
> +add_library(x265-static STATIC $
> $ $ ${ASM_OBJS})
>  add_library(hdr10plus-static STATIC $)
>  set_target_properties(hdr10plus-static PROPERTIES OUTPUT_NAME
> hdr10plus)
> else()
> -add_library(x265-static STATIC $
> $ ${ASM_OBJS} ${ASM_SRCS})
> +add_library(x265-static STATIC $
> $ ${ASM_OBJS})
> endif()
> if(NOT MSVC)
>  set_target_properties(x265-static PROPERTIES OUTPUT_NAME x265)
> @@ -686,11 +686,11 @@
>  if(ENABLE_HDR10_PLUS)
>  add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
> ${GETOPT}
>  x265.cpp x265.h x265cli.h
> -$
> $ $ ${ASM_OBJS}
> ${ASM_SRCS})
> +$
> $ $ ${ASM_OBJS})
>  else()
>  add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
> ${GETOPT}
>  x265.cpp x265.h x265cli.h
> -$
> $ ${ASM_OBJS} ${ASM_SRCS})
> +$
> $ ${ASM_OBJS})
>  endif()
>  else()
>  add_executable(cli ../COPYING ${InputFiles} ${OutputFiles}
> ${GETOPT} ${X265_RC_FILE}
> diff -r 182bfd0d5af9 -r 16ea92bf3627 source/cmake/CMakeASM_
> NASMInformation.cmake
> --- /dev/null   Thu Jan 01 00:00:00 1970 +
> +++ b/source/cmake/CMakeASM_NASMInformation.cmake   Thu Nov 02
> 09:40:41 2017 +0530
> @@ -0,0 +1,68 @@
> +set(ASM_DIALECT "_NASM")
> +set(CMAKE_ASM${ASM_DIALECT}_SOURCE_FILE_EXTENSIONS asm)
> +
> +if(X64)
> +list(APPEND ASM_FLAGS -DARCH_X86_64=1 -I
> ${CMAKE_CURRENT_SOURCE_DIR}/../common/x86/)
> +if(ENABLE_PIC)
> +list(APPEND ASM_FLAGS -DPIC)
> +endif()
> +if(APPLE)
> +set(ARGS -f macho64 -DPREFIX)
> +elseif(UNIX AND NOT CYGWIN)
> +set(ARGS -f elf64)
> +else()
> +set(ARGS -f win64)
> +endif()
> +else()
> +list(APPEND ASM_FLAGS -DARCH_X86_64=0 -I
> ${CMAKE_CURRENT_SOURCE_DIR}/../common/x86/)
> +if(APPLE)
> +set(ARGS -f macho32 -DPREFIX)
> +elseif(UNIX AND NOT CYGWIN)
> +set(ARGS -f elf32)
> +else()
> +set(ARGS -f win32 -DPREFIX)
> +endif()
> +endif()
> +
> +if(GCC)
> +list(APPEND ASM_FLAGS -DHAVE_ALIGNED_STACK=1)
> +else()
> +list(APPEND ASM_FLAGS -DHAVE_ALIGNED_STACK=0)
> +endif()
> +
> +if(HIGH_BIT_DEPTH)
> +if(MAIN12)
> +list(APPEND

Re: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

2017-11-22 Thread Pradeep Ramachandran

On Tue, Nov 21, 2017 at 6:39 PM, Praveen Tiwari <
prav...@multicorewareinc.com> wrote:

> Yes, that's true looking at the future prospect we have decided to move
> the support to NASM. It comes with additional advantages as Andrey
> mentioned above,  but we understand the concern to change assembler
> support,  we will make it a smooth transition as much as possible. Thanks.
>
> Regards,
> Praveen Tiwari
>

If ubuntu 16.04 only ships with nasm 2.11, we can reduce the nasm
requirement to 2.11. But moving to nasm seems like a future-proof move for
us.
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH] encoder.cpp: fix encoder crash for --analysis-reuse-level=10

[x265] [PATCH] encoder.cpp: fix encoder crash for --analysis-reuse-level=10

Re: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

Re: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

Re: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

Re: [x265] [PATCH 2 of 2] x86: Change assembler from YASM to NASM

6 matches

Site Navigation

Mail list logo

Footer information