Re: [x265] [PATCH] Add VMAF suppport to report per frame and aggregate VMAF score

2018-04-23 Thread Mario Rohkrämer 

Thanks Indumathi.

That gives hope ... like, not excluding Windows targets per se, but rather  
checking for the availability of libvmaf in a specific (possibly  
customizable?) directory.



Am 23.04.2018, 16:58 Uhr, schrieb Indumathi Ravichandran  
:


Currently, we are not supporting VMAF in Windows, since it's not  
generating
library files. We can try using MSYS/MinGW64 to add support for Windows  
in

future.

On Mon, Apr 23, 2018 at 7:45 PM, Glenn Odagawa 
wrote:


GOOD QUESTION!






Glenn S. Odagawa & Quilo
Chicago, IL
+1 (773) 747-7546
www.TheLayeredMix.co.nf-Website hosted on Norfolk Island

-Original Message- From: Mario *LigH* Rohkrämer
Sent: Monday, April 23, 2018 7:55 AM
To: Development for x265
Subject: Re: [x265] [PATCH] Add VMAF suppport to report per frame and
aggregate VMAF score


Mario Rohkrämer schrieb am 12.04.2018 um 18:25:


Am 12.04.2018, 13:13 Uhr, schrieb :

+.. Note::

+
+When setting ENABLE_LIBVMAF cmake option to ON, it is  
recommended to

+also set ENABLE_SHARED to OFF to prevent build problems.
+We only need the static library from these builds.
+
+Binaries build with windows will not have VMAF support.




Can you explain why support for Windows builds is not (yet?) possible?

I do remember that MABS is able to compile ffmpeg including VMAF, and
also I do remember that it compiled only for x86-64 architecture due to
some specific EMMS intrinsics. But, of course, MABS pulls the whole  
libvmaf
source to do so. You will probably not want to require that. But it  
might
not be too hard in MSYS/MinGW64 if an experienced user does it  
manually?





Still curious...
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel




--

Fun and success!
Mario *LigH* Rohkrämer
mailto:cont...@ligh.de
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH] Add VMAF suppport to report per frame and aggregate VMAF score

2018-04-23 Thread Indumathi Ravichandran 
Currently, we are not supporting VMAF in Windows, since it's not generating
library files. We can try using MSYS/MinGW64 to add support for Windows in
future.

On Mon, Apr 23, 2018 at 7:45 PM, Glenn Odagawa 
wrote:

> GOOD QUESTION!
>
>
>
>
>
>
> Glenn S. Odagawa & Quilo
> Chicago, IL
> +1 (773) 747-7546
> www.TheLayeredMix.co.nf-Website hosted on Norfolk Island
>
> -Original Message- From: Mario *LigH* Rohkrämer
> Sent: Monday, April 23, 2018 7:55 AM
> To: Development for x265
> Subject: Re: [x265] [PATCH] Add VMAF suppport to report per frame and
> aggregate VMAF score
>
>
> Mario Rohkrämer schrieb am 12.04.2018 um 18:25:
>
>> Am 12.04.2018, 13:13 Uhr, schrieb :
>>
>> +.. Note::
>>> +
>>> +When setting ENABLE_LIBVMAF cmake option to ON, it is recommended to
>>> +also set ENABLE_SHARED to OFF to prevent build problems.
>>> +We only need the static library from these builds.
>>> +
>>> +Binaries build with windows will not have VMAF support.
>>>
>>
>>
>> Can you explain why support for Windows builds is not (yet?) possible?
>>
>> I do remember that MABS is able to compile ffmpeg including VMAF, and
>> also I do remember that it compiled only for x86-64 architecture due to
>> some specific EMMS intrinsics. But, of course, MABS pulls the whole libvmaf
>> source to do so. You will probably not want to require that. But it might
>> not be too hard in MSYS/MinGW64 if an experienced user does it manually?
>>
>
>
> Still curious...
> ___
> x265-devel mailing list
> x265-devel@videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
> ___
> x265-devel mailing list
> x265-devel@videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH] Add VMAF suppport to report per frame and aggregate VMAF score

2018-04-23 Thread Glenn Odagawa 

GOOD QUESTION!






Glenn S. Odagawa & Quilo
Chicago, IL
+1 (773) 747-7546
www.TheLayeredMix.co.nf-Website hosted on Norfolk Island

-Original Message- 
From: Mario *LigH* Rohkrämer

Sent: Monday, April 23, 2018 7:55 AM
To: Development for x265
Subject: Re: [x265] [PATCH] Add VMAF suppport to report per frame and 
aggregate VMAF score


Mario Rohkrämer schrieb am 12.04.2018 um 18:25:

Am 12.04.2018, 13:13 Uhr, schrieb :


+.. Note::
+
+When setting ENABLE_LIBVMAF cmake option to ON, it is recommended to
+also set ENABLE_SHARED to OFF to prevent build problems.
+We only need the static library from these builds.
+
+Binaries build with windows will not have VMAF support.



Can you explain why support for Windows builds is not (yet?) possible?

I do remember that MABS is able to compile ffmpeg including VMAF, and also 
I do remember that it compiled only for x86-64 architecture due to some 
specific EMMS intrinsics. But, of course, MABS pulls the whole libvmaf 
source to do so. You will probably not want to require that. But it might 
not be too hard in MSYS/MinGW64 if an experienced user does it manually?



Still curious...
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel 



___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH] Add VMAF suppport to report per frame and aggregate VMAF score

2018-04-23 Thread Mario *LigH* Rohkrämer 

Mario Rohkrämer schrieb am 12.04.2018 um 18:25:

Am 12.04.2018, 13:13 Uhr, schrieb :


+.. Note::
+
+    When setting ENABLE_LIBVMAF cmake option to ON, it is recommended to
+    also set ENABLE_SHARED to OFF to prevent build problems.
+    We only need the static library from these builds.
+
+    Binaries build with windows will not have VMAF support.



Can you explain why support for Windows builds is not (yet?) possible?

I do remember that MABS is able to compile ffmpeg including VMAF, and 
also I do remember that it compiled only for x86-64 architecture due to 
some specific EMMS intrinsics. But, of course, MABS pulls the whole 
libvmaf source to do so. You will probably not want to require that. But 
it might not be too hard in MSYS/MinGW64 if an experienced user does it 
manually?



Still curious...
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH] CLI: do not set AVX512 if it is not supported

2018-04-23 Thread Ashok Kumar Mishra 
On Fri, Apr 20, 2018 at 2:30 AM, Ma0  wrote:

> # HG changeset patch
> # User Ma0 
> # Date 1524171479 -7200
> #  Thu Apr 19 22:57:59 2018 +0200
> # Branch stable
> # Node ID a40d936b962fbcbfa3a48b8e0bfa10fdf7b1df81
> # Parent  aa9102400f2456584d5e41adf456510abcebec6c
> CLI: do not set AVX512 if it is not supported
>
> diff -r aa9102400f24 -r a40d936b962f source/common/param.cpp
> --- a/source/common/param.cpp   Fri Apr 13 17:12:10 2018 +0530
> +++ b/source/common/param.cpp   Thu Apr 19 22:57:59 2018 +0200
> @@ -615,20 +615,30 @@
>  if (0) ;
>  OPT("asm")
>  {
> -if (strcmp(value, "avx512")==0)
> +#if X265_ARCH_X86
> +if (!strcasecmp(value, "avx512"))
>  {
>  p->bEnableavx512 = 1;
>  benableavx512 = true;
> +p->cpuid = X265_NS::cpu_detect(benableavx512);
> +if (!(p->cpuid & X265_CPU_AVX512))
> +x265_log(p, X265_LOG_WARNING, "AVX512 is not
> supported\n");
>  }
>  else
>  {
>  p->bEnableavx512 = 0;
>  benableavx512 = false;
> +if (bValueWasNull)
> +p->cpuid = atobool(value);
> +else
> +p->cpuid = parseCpuName(value, bError);
>  }
> +#else
>  if (bValueWasNull)
>  p->cpuid = atobool(value);
>  else
>  p->cpuid = parseCpuName(value, bError);
> +#endif
>  }
>  OPT("fps")
>  {
> ___
> x265-devel mailing list
> x265-devel@videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>


Thanks. Pushed.
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH] doc: update cli.rst for vmaf

2018-04-23 Thread Ashok Kumar Mishra 
On Tue, Apr 17, 2018 at 5:17 PM,  wrote:

> # HG changeset patch
> # User induma...@multicorewareinc.com
> # Date 1523965217 -19800
> #  Tue Apr 17 17:10:17 2018 +0530
> # Node ID 2b2914134de41d9573270aa9cb95d7a5b017
> # Parent  7305220d469b0c262ef9742d90419ff85832d233
> doc: update cli.rst for vmaf
>
> diff -r 7305220d469b -r 2b2914134de4 doc/reST/api.rst
> --- a/doc/reST/api.rst  Fri Apr 13 13:51:32 2018 +0530
> +++ b/doc/reST/api.rst  Tue Apr 17 17:10:17 2018 +0530
> @@ -411,7 +411,7 @@
>  double x265_calculate_vmafscore(x265_param*, x265_vmaf_data*);
>
>  /* x265_calculate_vmaf_framelevelscore:
> - *returns VMAF score for each frame in a given input video. */
> + *returns VMAF score for each frame in a given input video. The
> frame level VMAF score does not include temporal scores. */
>  double x265_calculate_vmaf_framelevelscore(x265_vmaf_framedata*);
>
>  .. Note::
> ___
> x265-devel mailing list
> x265-devel@videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>

Pushed.
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel