Re: [x265] [PATCH 2 of 3] asm: reenable IACA support, it remove by 'inappropriate instruction...' patch
On Thu, 04 Sep 2014 18:59:48 -0700, Min Chen wrote: # HG changeset patch # User Min Chen chenm...@163.com # Date 1409882347 25200 # Node ID c6ba4d4834a73dfbc57d14f74936ab7f49a0c24d # Parent 809782d90535d2b44b97361ba9d94e5103c13138 asm: reenable IACA support, it remove by 'inappropriate instruction...' patch diff -r 809782d90535 -r c6ba4d4834a7 source/common/x86/x86inc.asm --- a/source/common/x86/x86inc.asm Thu Sep 04 18:58:30 2014 -0700 +++ b/source/common/x86/x86inc.asm Thu Sep 04 18:59:07 2014 -0700 @@ -1480,3 +1480,15 @@ %endif %endmacro %endif + + +%macro IACA_START 0 +mov ebx, 111 +db 0x64, 0x67, 0x90 +%endmacro + +%macro IACA_END 0 +mov ebx, 222 +db 0x64, 0x67, 0x90 +%endmacro + IMHO, this macros should be in x86util.asm not in x86inc.asm ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
Re: [x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled
On Wed, 25 Jun 2014 23:18:48 +0530, Deepthi Nandakumar wrote: They are. encoder.c:x264_validate_parameters if( b_open i_csp = X264_CSP_I444 i_csp X264_CSP_BGR h-param.analyse.b_psy ) h-param.analyse.i_chroma_qp_offset += 6; On Wed, Jun 25, 2014 at 11:12 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 6/25/2014 3:45 PM, Deepthi Nandakumar wrote: In a sense, psy-rd encapsulates all those r-d algorithms/tweaks/hacks that improve visual quality but may hurt objective metrics like psnr/ssim. In 444, this qp hack is likely to hurt objective metrics, hence it's turned on only if psychovisual improvement is desired. OK. Was curious, since these are not lumped in with psy-rd in x264. That is separate --psy (--no-psy) option in x264 and not --psy-rd ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
