Re: [x265] [PATCH] encoder: enable VUI; set HRD parameters in SPS

[dave]

# HG changeset patch
# User Deepthi Nandakumar deep...@multicorewareinc.com
# Date 1392883371 -19800
# Node ID 3934859d310bcc3f54ad1855dd94bd71eb0e7457
# Parent  3389061b75a486e004409ab628c46fed39d03b72
encoder: enable VUI; set HRD parameters in SPS.
You can now add a VUI on the cli.  Use --vui to get a vui will all 
default values or any vui specific options including --nal-hrd to 
generate a VUI with an HRD though currently the HRD will only have all 
default values.

This patch enables pictureTimingSEI, but enabling 
decodingUnitInfoSEI/bufferingPeriodSEI can affect
this flow. Any further info/suggestions welcomed.

diff -r 3389061b75a4 -r 3934859d310b source/encoder/encoder.cpp
--- a/source/encoder/encoder.cppWed Feb 19 17:03:21 2014 -0600
+++ b/source/encoder/encoder.cppThu Feb 20 13:32:51 2014 +0530
@@ -1459,13 +1459,13 @@
  m_bUseASR = false; // adapt search range based on temporal distances
  m_recoveryPointSEIEnabled = 0;
  m_bufferingPeriodSEIEnabled = 0;
-m_pictureTimingSEIEnabled = 0;
+m_pictureTimingSEIEnabled = 1;
  m_displayOrientationSEIAngle = 0;
  m_gradualDecodingRefreshInfoEnabled = 0;
  m_decodingUnitInfoSEIEnabled = 0;
  m_useScalingListId = 0;
  m_activeParameterSetsSEIEnabled = 0;
-m_vuiParametersPresentFlag = false;
+m_vuiParametersPresentFlag = true;
  m_minSpatialSegmentationIdc = 0;
  m_aspectRatioIdc = 0;
  m_sarWidth = 0;
diff -r 3389061b75a4 -r 3934859d310b source/encoder/frameencoder.cpp
--- a/source/encoder/frameencoder.cpp   Wed Feb 19 17:03:21 2014 -0600
+++ b/source/encoder/frameencoder.cpp   Thu Feb 20 13:32:51 2014 +0530
@@ -138,7 +138,7 @@
  m_sps.setNumLongTermRefPicSPS(0);
  if (m_cfg-getPictureTimingSEIEnabled() || 
m_cfg-getDecodingUnitInfoSEIEnabled())
  {
-m_sps.setHrdParameters(m_cfg-param.fpsNum, m_cfg-param.fpsDenom, 0, 
m_cfg-param.rc.bitrate, m_cfg-param.bframes  0);
+m_sps.setHrdParameters(m_cfg-param.fpsNum, m_cfg-param.fpsDenom, 1, 
m_cfg-param.rc.bitrate, m_cfg-param.bframes  0);
  }
  if (m_cfg-getBufferingPeriodSEIEnabled() || 
m_cfg-getPictureTimingSEIEnabled() || m_cfg-getDecodingUnitInfoSEIEnabled())
  {
___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel


___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH] encoder: enable VUI; set HRD parameters in SPS

[Deepthi Nandakumar]

This patch has been superseded by the one that enables it from the CLI. I
removed this one from patch list on patchworks.


On Fri, Feb 21, 2014 at 1:14 AM, Steve Borho st...@borho.org wrote:




 On Thu, Feb 20, 2014 at 12:17 PM, dave dtyx...@gmail.com wrote:

 # HG changeset patch
 # User Deepthi Nandakumar deep...@multicorewareinc.com
 # Date 1392883371 -19800
 # Node ID 3934859d310bcc3f54ad1855dd94bd71eb0e7457
 # Parent  3389061b75a486e004409ab628c46fed39d03b72
 encoder: enable VUI; set HRD parameters in SPS.

 You can now add a VUI on the cli.  Use --vui to get a vui will all
 default values or any vui specific options including --nal-hrd to generate
 a VUI with an HRD though currently the HRD will only have all default
 values.


 agreed, we should try to follow x264's CLI and defaults as much as
 possible for new features that come online.

 --
 Steve Borho

 ___
 x265-devel mailing list
 x265-devel@videolan.org
 https://mailman.videolan.org/listinfo/x265-devel


___
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel