Re: [Xastir] GraphicsMagick include issue on Gentoo
On Sun, Jul 14, 2019 at 02:54:31PM -0600, we recorded a bogon-computron collision of the flavor, containing: > I could slam out a 2.1.4 release real quickly tonight if we think it's > worth the good will of package maintainers. > > Here's what I see as the changes since 2.1.2: > > - Code reformatting to match new project style > - Numerous updates to decrease number of warnings from gcc8 > - Fix compiler warnings from OS X clang about use of hard-coded degree > symbols in strings. > - Removed the "--without-rtree" option: rtree is now always built into > Xastir if shapefile support is enabled. > - Removed vestigial references to gettext/libintl internationalization, > which hasn't actually been used since at least 2002 > - Fix compilation error with GraphicsMagick 1.3.32 and later. > > I will take care of this sometime tonight unless I hear a strong argument > against it. I'll post again after it's done and the news can be announced > elsewhere (linux-hams, bsd-hams, aprssig, etc.). I'll take care of the > releasing if Curt takes care of the announcing. It is done. Xastir 2.1.4 release is now available on github. You can get it via a git clone using the Release-2.1.4 tag, or as a tarball direct from github. If you are a package maintainer for a repo, please move forward as soon as possible with getting this version into your distro's package management system, as it fixes the bug that has been reported in several systems with respect to GraphicsMagick versions 1.3.32 and later. > On Sun, Jul 14, 2019 at 01:27:15PM -0700, we recorded a bogon-computron > collision of the flavor, containing: > > +1 > > > > On Sun, Jul 14, 2019 at 1:26 PM Tom Russo wrote: > > > > > > On Sun, Jul 14, 2019 at 07:23:00AM -0600, we recorded a bogon-computron > > > collision of the flavor, containing: > > > > On Sun, Jul 14, 2019 at 08:24:21PM +1000, we recorded a bogon-computron > > > > collision of the flavor, containing: > > > > > > > > > > > > > > > > On 14 Jul 2019, at 7:26 pm, Carl Makin wrote: > > > > > > Would it be worthwhile pushing this as a point release? > > > > > > > > > > Actually, don???t worry about it. I???ll add the patch manually. > > > > > > > > I was going to suggest just adding the single patch based on commit > > > > fb6ecce5. > > > > > > > > > Correction: commit 7b6ecce5 > > > > > > On the other hand, a point release to fix this wouldn't be unreasonable, > > > given > > > how many OSen are affected by this mistaken use of GraphicsMagick. Might > > > be better to get it out there as a release instead of having many > > > independent > > > patches. > > > > > > What to the rest of you all think? The code is relatively stable at the > > > moment. > > > > > > -- > > > Tom RussoKM5VY > > > Tijeras, NM > > > > > > echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] > > > [n-z][a-m] > > > > > > ___ > > > Xastir mailing list > > > Xastir@lists.xastir.org > > > http://xastir.org/mailman/listinfo/xastir > > > > > > > > -- > > Curt, WE7Uhttp://we7u.wetnet.nethttp://www.sarguydigital.com > > -- > Tom RussoKM5VY > Tijeras, NM > > echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] -- Tom RussoKM5VY Tijeras, NM echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
+1 on a 2.1.4 release. On 7/14/19 4:54 PM, km5vy Tom Russo wrote: > I could slam out a 2.1.4 release real quickly tonight if we think it's > worth the good will of package maintainers. > > Here's what I see as the changes since 2.1.2: > > - Code reformatting to match new project style > - Numerous updates to decrease number of warnings from gcc8 > - Fix compiler warnings from OS X clang about use of hard-coded degree > symbols in strings. > - Removed the "--without-rtree" option: rtree is now always built into > Xastir if shapefile support is enabled. > - Removed vestigial references to gettext/libintl internationalization, > which hasn't actually been used since at least 2002 > - Fix compilation error with GraphicsMagick 1.3.32 and later. > > I will take care of this sometime tonight unless I hear a strong argument > against it. I'll post again after it's done and the news can be announced > elsewhere (linux-hams, bsd-hams, aprssig, etc.). I'll take care of the > releasing if Curt takes care of the announcing. > > On Sun, Jul 14, 2019 at 01:27:15PM -0700, we recorded a bogon-computron > collision of the flavor, containing: >> +1 >> >> On Sun, Jul 14, 2019 at 1:26 PM Tom Russo wrote: >>> On Sun, Jul 14, 2019 at 07:23:00AM -0600, we recorded a bogon-computron >>> collision of the flavor, containing: On Sun, Jul 14, 2019 at 08:24:21PM +1000, we recorded a bogon-computron collision of the flavor, containing: > >> On 14 Jul 2019, at 7:26 pm, Carl Makin wrote: >> Would it be worthwhile pushing this as a point release? > Actually, don???t worry about it. I???ll add the patch manually. I was going to suggest just adding the single patch based on commit fb6ecce5. >>> >>> Correction: commit 7b6ecce5 >>> >>> On the other hand, a point release to fix this wouldn't be unreasonable, >>> given >>> how many OSen are affected by this mistaken use of GraphicsMagick. Might >>> be better to get it out there as a release instead of having many >>> independent >>> patches. >>> >>> What to the rest of you all think? The code is relatively stable at the >>> moment. >>> >>> -- >>> Tom RussoKM5VY >>> Tijeras, NM >>> >>> echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] >>> [n-z][a-m] >>> >>> ___ >>> Xastir mailing list >>> Xastir@lists.xastir.org >>> http://xastir.org/mailman/listinfo/xastir >> >> >> -- >> Curt, WE7Uhttp://we7u.wetnet.nethttp://www.sarguydigital.com ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
I could slam out a 2.1.4 release real quickly tonight if we think it's worth the good will of package maintainers. Here's what I see as the changes since 2.1.2: - Code reformatting to match new project style - Numerous updates to decrease number of warnings from gcc8 - Fix compiler warnings from OS X clang about use of hard-coded degree symbols in strings. - Removed the "--without-rtree" option: rtree is now always built into Xastir if shapefile support is enabled. - Removed vestigial references to gettext/libintl internationalization, which hasn't actually been used since at least 2002 - Fix compilation error with GraphicsMagick 1.3.32 and later. I will take care of this sometime tonight unless I hear a strong argument against it. I'll post again after it's done and the news can be announced elsewhere (linux-hams, bsd-hams, aprssig, etc.). I'll take care of the releasing if Curt takes care of the announcing. On Sun, Jul 14, 2019 at 01:27:15PM -0700, we recorded a bogon-computron collision of the flavor, containing: > +1 > > On Sun, Jul 14, 2019 at 1:26 PM Tom Russo wrote: > > > > On Sun, Jul 14, 2019 at 07:23:00AM -0600, we recorded a bogon-computron > > collision of the flavor, containing: > > > On Sun, Jul 14, 2019 at 08:24:21PM +1000, we recorded a bogon-computron > > > collision of the flavor, containing: > > > > > > > > > > > > > On 14 Jul 2019, at 7:26 pm, Carl Makin wrote: > > > > > Would it be worthwhile pushing this as a point release? > > > > > > > > Actually, don???t worry about it. I???ll add the patch manually. > > > > > > I was going to suggest just adding the single patch based on commit > > > fb6ecce5. > > > > > > Correction: commit 7b6ecce5 > > > > On the other hand, a point release to fix this wouldn't be unreasonable, > > given > > how many OSen are affected by this mistaken use of GraphicsMagick. Might > > be better to get it out there as a release instead of having many > > independent > > patches. > > > > What to the rest of you all think? The code is relatively stable at the > > moment. > > > > -- > > Tom RussoKM5VY > > Tijeras, NM > > > > echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] > > [n-z][a-m] > > > > ___ > > Xastir mailing list > > Xastir@lists.xastir.org > > http://xastir.org/mailman/listinfo/xastir > > > > -- > Curt, WE7Uhttp://we7u.wetnet.nethttp://www.sarguydigital.com -- Tom RussoKM5VY Tijeras, NM echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
+1 On Sun, Jul 14, 2019 at 1:26 PM Tom Russo wrote: > > On Sun, Jul 14, 2019 at 07:23:00AM -0600, we recorded a bogon-computron > collision of the flavor, containing: > > On Sun, Jul 14, 2019 at 08:24:21PM +1000, we recorded a bogon-computron > > collision of the flavor, containing: > > > > > > > > > > On 14 Jul 2019, at 7:26 pm, Carl Makin wrote: > > > > Would it be worthwhile pushing this as a point release? > > > > > > Actually, don???t worry about it. I???ll add the patch manually. > > > > I was going to suggest just adding the single patch based on commit > > fb6ecce5. > > > Correction: commit 7b6ecce5 > > On the other hand, a point release to fix this wouldn't be unreasonable, given > how many OSen are affected by this mistaken use of GraphicsMagick. Might > be better to get it out there as a release instead of having many independent > patches. > > What to the rest of you all think? The code is relatively stable at the > moment. > > -- > Tom RussoKM5VY > Tijeras, NM > > echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] > > ___ > Xastir mailing list > Xastir@lists.xastir.org > http://xastir.org/mailman/listinfo/xastir -- Curt, WE7Uhttp://we7u.wetnet.nethttp://www.sarguydigital.com ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
On Sun, Jul 14, 2019 at 07:23:00AM -0600, we recorded a bogon-computron collision of the flavor, containing: > On Sun, Jul 14, 2019 at 08:24:21PM +1000, we recorded a bogon-computron > collision of the flavor, containing: > > > > > > > On 14 Jul 2019, at 7:26 pm, Carl Makin wrote: > > > Would it be worthwhile pushing this as a point release? > > > > Actually, don???t worry about it. I???ll add the patch manually. > > I was going to suggest just adding the single patch based on commit fb6ecce5. Correction: commit 7b6ecce5 On the other hand, a point release to fix this wouldn't be unreasonable, given how many OSen are affected by this mistaken use of GraphicsMagick. Might be better to get it out there as a release instead of having many independent patches. What to the rest of you all think? The code is relatively stable at the moment. -- Tom RussoKM5VY Tijeras, NM echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
On Sun, Jul 14, 2019 at 08:24:21PM +1000, we recorded a bogon-computron collision of the flavor, containing: > > > > On 14 Jul 2019, at 7:26 pm, Carl Makin wrote: > > Would it be worthwhile pushing this as a point release? > > Actually, don???t worry about it. I???ll add the patch manually. I was going to suggest just adding the single patch based on commit fb6ecce5. -- Tom RussoKM5VY Tijeras, NM echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
> On 14 Jul 2019, at 7:26 pm, Carl Makin wrote: > Would it be worthwhile pushing this as a point release? Actually, don’t worry about it. I’ll add the patch manually. Thanks, Carl. (vk1kcm) ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
Hi Tom, > On 1 Jul 2019, at 11:22 am, Tom Russo wrote: > > Fixed in commit 7b6ecce5. > > On Sun, Jun 30, 2019 at 07:03:16PM -0600, we recorded a bogon-computron > collision of the flavor, containing: >> I am removing the function call and the kludge that made us include >> private declarations. Watch for the fix in a git push soon. I’m working on the FreeBSD port and this is biting me as well. I’m not keen on pulling a git version directly out to make the port. I also suspect as other packagers hit this version of GraphicsMagick they will have the same problem. Would it be worthwhile pushing this as a point release? Carl. (vk1kcm) ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
On Sun, 30 Jun 2019 19:22:14 -0600 Tom Russo wrote: > Fixed in commit 7b6ecce5. > Thanks Tom and everyone for all the 'Magick' you folks do to Xastir work! ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
99% of the time I just use the world map since it gives the most contrast and doesn't hide weather alerts. The other 1% I use the tiled_mapnik OSM maps. So I probably won't be the one testing the function too much. Dave KD7MYC -Original Message- From: Tom Russo [mailto:ru...@bogodyn.org] Sent: Sunday, June 30, 2019 19:48 On Sun, Jun 30, 2019 at 07:25:31PM -0700, we recorded a bogon-computron collision of the flavor, containing: > And I confirm that a git pull will now compile. Have no idea how to test > the updated function but it compiles and runs. Just make sure that if you use any non-OSM ".geo" maps, that you don't observe extreme memory bloat by repeatedly loading maps. I believe that there is zero probability of that due to the way that the image objects are destroyed, but memory cleanup was why this hack was put in, and it was just unnecessary and wrong. > -Original Message- > From: Xastir [mailto:xastir-boun...@lists.xastir.org] On Behalf Of Tom Russo > Sent: Sunday, June 30, 2019 18:22 > > Fixed in commit 7b6ecce5. > > > > ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
On Sun, Jun 30, 2019 at 07:25:31PM -0700, we recorded a bogon-computron collision of the flavor, containing: > And I confirm that a git pull will now compile. Have no idea how to test > the updated function but it compiles and runs. Just make sure that if you use any non-OSM ".geo" maps, that you don't observe extreme memory bloat by repeatedly loading maps. I believe that there is zero probability of that due to the way that the image objects are destroyed, but memory cleanup was why this hack was put in, and it was just unnecessary and wrong. > -Original Message- > From: Xastir [mailto:xastir-boun...@lists.xastir.org] On Behalf Of Tom Russo > Sent: Sunday, June 30, 2019 18:22 > To: Xastir - APRS client software discussion > Subject: Re: [Xastir] GraphicsMagick include issue on Gentoo > > Fixed in commit 7b6ecce5. > > > > -- Tom RussoKM5VY Tijeras, NM echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
And I confirm that a git pull will now compile. Have no idea how to test the updated function but it compiles and runs. KD7MYC -Original Message- From: Xastir [mailto:xastir-boun...@lists.xastir.org] On Behalf Of Tom Russo Sent: Sunday, June 30, 2019 18:22 To: Xastir - APRS client software discussion Subject: Re: [Xastir] GraphicsMagick include issue on Gentoo Fixed in commit 7b6ecce5. ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
Re: [Xastir] GraphicsMagick include issue on Gentoo
Fixed in commit 7b6ecce5. On Sun, Jun 30, 2019 at 07:03:16PM -0600, we recorded a bogon-computron collision of the flavor, containing: > It appears that the call to DestroyImagePixels, which is supposed to > deallocate memory associated with the pixel cache, was added to Xastir > as part of an effort to "release memory consistently for exit points" in > commit 4210671c3 from 2007, but it may be inappropriately used here. > > It appears it was an attempt to free any memory created by GetImagePixels, > but this does not look like it was supposed to be correct way to do that > (in fact, one is not supposed to do it directly). DestroyImagePixels > is only supposed to be called by the DestroyImage function, which is public. > > The function "draw_geo_image_map" (which is a huge function) has many, many > exit points, and it appears that almost all of them correctly call > DestroyImage on the image anyway. So this call to DestroyImagePixels > certainly improper and should never have been put where it is. > > I am removing the function call and the kludge that made us include > private declarations. Watch for the fix in a git push soon. > > On Sun, Jun 30, 2019 at 06:37:12PM -0600, we recorded a bogon-computron > collision of the flavor, containing: > > On Sun, Jun 30, 2019 at 06:32:31PM -0600, we recorded a bogon-computron > > collision of the flavor, containing: > > > Lo, and behold, on June 20th, the GraphicsMagick package on my system was > > > updated to 1.3.32, and I had last built Xastir with the previous version, > > > 1.3.31. Today, building Xastir crashes with the same error you get. > > > > > > I will look into whether it is still necessary to have > > > MAGICK_IMPLEMENTATION > > > defined. Taking it out is supposed to fix the compilation error, but I > > > have > > > no idea if it preserves the function of map_geo.c. > > > > Removing the MAGICK_IMPLEMENTATION definition does indeed allow us to > > compile, > > but reintroduces the very warning this definition was put in place to > > silence. > > > > We'll simply need to figure out why DestroyImagePixels ever needed to be > > called, > > and replace it with whatever non-private function should be called instead. > > > > In the meantime, you can probably get by by just commenting out line 136 of > > map_geo.c, which is "#define MAGICK_IMPLEMENTATION". You will get a warning > > about an implicit declaration of DestroyImagePixels, but it should at least > > let you compile. > > > > I'm googling like mad to figure out what DestroyImagePixels does and trying > > to figure out why it needs to be called by Xastir at all. > > > > > On Sun, Jun 30, 2019 at 06:26:07PM -0600, we recorded a bogon-computron > > > collision of the flavor, containing: > > > > Other OSen are experiencing this: > > > > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1722840 > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924329#18 > > > > > > > > The problem is that Xastir's map_geo.c is defining > > > > "MAGICK_IMPLEMENTATION" in > > > > order to (inappropriately) access private interfaces, which the version > > > > of > > > > Magick you have has in fact moved to a private header that is no longer > > > > installed with the package. > > > > > > > > Apparently this hack was added in 2010 to Xastir to silence warnings > > > > about > > > > misuse of private interfaces, instead of removing the use of > > > > DestroyImagePixels. > > > > > > > > Some work will have to be done to figure out *why* DestroyImagePixels > > > > was > > > > being used in map_geo.c, and to replace it with calls to public > > > > interfaces > > > > of Magick. > > > > > > > > On Sun, Jun 30, 2019 at 04:12:27PM -0700, we recorded a bogon-computron > > > > collision of the flavor, containing: > > > > > Hello All, > > > > > > > > > > I just did a git pull, bootstrap, configure, make clean, and make on > > > > > my 32 > > > > > bit Gentoo VM (and my 64 bit VM so not byte size dependent). and > > > > > now my > > > > > compiles fail with: > > > > > > > > > > CC map_geo.o > > > > > In file included from /usr/include/GraphicsMagick/magick/analyze.h:18, > > > > > from /usr/include/GraphicsMagick/magick/api.h:55, > > > > > from map_geo.c:137: > > > > > /usr/include/GraphicsMagick/magick/image.h:1108:10: fatal error: > > > > > magick/image-private.h: No such file or directory > > > > > #include "magick/image-private.h" > > > > > ^~~~ > > > > > compilation terminated. > > > > > make[3]: *** [Makefile:634: map_geo.o] Error 1 > > > > > make[3]: Leaving directory '/home/dflood/src/Xastir/src' > > > > > make[2]: *** [Makefile:656: all-recursive] Error 1 > > > > > make[2]: Leaving directory '/home/dflood/src/Xastir/src' > > > > > make[1]: *** [Makefile:744: all-recursive] Error 1 > > > > > make[1]: Leaving directory '/home/dflood/src/Xastir' > > > > > make: *** [Makefile:426: all] Error 2
Re: [Xastir] GraphicsMagick include issue on Gentoo
It appears that the call to DestroyImagePixels, which is supposed to deallocate memory associated with the pixel cache, was added to Xastir as part of an effort to "release memory consistently for exit points" in commit 4210671c3 from 2007, but it may be inappropriately used here. It appears it was an attempt to free any memory created by GetImagePixels, but this does not look like it was supposed to be correct way to do that (in fact, one is not supposed to do it directly). DestroyImagePixels is only supposed to be called by the DestroyImage function, which is public. The function "draw_geo_image_map" (which is a huge function) has many, many exit points, and it appears that almost all of them correctly call DestroyImage on the image anyway. So this call to DestroyImagePixels certainly improper and should never have been put where it is. I am removing the function call and the kludge that made us include private declarations. Watch for the fix in a git push soon. On Sun, Jun 30, 2019 at 06:37:12PM -0600, we recorded a bogon-computron collision of the flavor, containing: > On Sun, Jun 30, 2019 at 06:32:31PM -0600, we recorded a bogon-computron > collision of the flavor, containing: > > Lo, and behold, on June 20th, the GraphicsMagick package on my system was > > updated to 1.3.32, and I had last built Xastir with the previous version, > > 1.3.31. Today, building Xastir crashes with the same error you get. > > > > I will look into whether it is still necessary to have MAGICK_IMPLEMENTATION > > defined. Taking it out is supposed to fix the compilation error, but I > > have > > no idea if it preserves the function of map_geo.c. > > Removing the MAGICK_IMPLEMENTATION definition does indeed allow us to compile, > but reintroduces the very warning this definition was put in place to silence. > > We'll simply need to figure out why DestroyImagePixels ever needed to be > called, > and replace it with whatever non-private function should be called instead. > > In the meantime, you can probably get by by just commenting out line 136 of > map_geo.c, which is "#define MAGICK_IMPLEMENTATION". You will get a warning > about an implicit declaration of DestroyImagePixels, but it should at least > let you compile. > > I'm googling like mad to figure out what DestroyImagePixels does and trying > to figure out why it needs to be called by Xastir at all. > > > On Sun, Jun 30, 2019 at 06:26:07PM -0600, we recorded a bogon-computron > > collision of the flavor, containing: > > > Other OSen are experiencing this: > > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1722840 > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924329#18 > > > > > > The problem is that Xastir's map_geo.c is defining > > > "MAGICK_IMPLEMENTATION" in > > > order to (inappropriately) access private interfaces, which the version > > > of > > > Magick you have has in fact moved to a private header that is no longer > > > installed with the package. > > > > > > Apparently this hack was added in 2010 to Xastir to silence warnings about > > > misuse of private interfaces, instead of removing the use of > > > DestroyImagePixels. > > > > > > Some work will have to be done to figure out *why* DestroyImagePixels was > > > being used in map_geo.c, and to replace it with calls to public interfaces > > > of Magick. > > > > > > On Sun, Jun 30, 2019 at 04:12:27PM -0700, we recorded a bogon-computron > > > collision of the flavor, containing: > > > > Hello All, > > > > > > > > I just did a git pull, bootstrap, configure, make clean, and make on my > > > > 32 > > > > bit Gentoo VM (and my 64 bit VM so not byte size dependent). and > > > > now my > > > > compiles fail with: > > > > > > > > CC map_geo.o > > > > In file included from /usr/include/GraphicsMagick/magick/analyze.h:18, > > > > from /usr/include/GraphicsMagick/magick/api.h:55, > > > > from map_geo.c:137: > > > > /usr/include/GraphicsMagick/magick/image.h:1108:10: fatal error: > > > > magick/image-private.h: No such file or directory > > > > #include "magick/image-private.h" > > > > ^~~~ > > > > compilation terminated. > > > > make[3]: *** [Makefile:634: map_geo.o] Error 1 > > > > make[3]: Leaving directory '/home/dflood/src/Xastir/src' > > > > make[2]: *** [Makefile:656: all-recursive] Error 1 > > > > make[2]: Leaving directory '/home/dflood/src/Xastir/src' > > > > make[1]: *** [Makefile:744: all-recursive] Error 1 > > > > make[1]: Leaving directory '/home/dflood/src/Xastir' > > > > make: *** [Makefile:426: all] Error 2 > > > > > > > > Here's what ./configure tells me: > > > > > > > > xastir 2.1.3 has been configured to use the following > > > > options and external libraries: > > > > > > > > MINIMUM OPTIONS: > > > > ShapeLib (Vector maps) : yes > > > > > > > > RECOMMENDED OPTIONS: > > > > Xpm / Snapshots ... : yes > > > >
Re: [Xastir] GraphicsMagick include issue on Gentoo
On Sun, Jun 30, 2019 at 06:32:31PM -0600, we recorded a bogon-computron collision of the flavor, containing: > Lo, and behold, on June 20th, the GraphicsMagick package on my system was > updated to 1.3.32, and I had last built Xastir with the previous version, > 1.3.31. Today, building Xastir crashes with the same error you get. > > I will look into whether it is still necessary to have MAGICK_IMPLEMENTATION > defined. Taking it out is supposed to fix the compilation error, but I have > no idea if it preserves the function of map_geo.c. Removing the MAGICK_IMPLEMENTATION definition does indeed allow us to compile, but reintroduces the very warning this definition was put in place to silence. We'll simply need to figure out why DestroyImagePixels ever needed to be called, and replace it with whatever non-private function should be called instead. In the meantime, you can probably get by by just commenting out line 136 of map_geo.c, which is "#define MAGICK_IMPLEMENTATION". You will get a warning about an implicit declaration of DestroyImagePixels, but it should at least let you compile. I'm googling like mad to figure out what DestroyImagePixels does and trying to figure out why it needs to be called by Xastir at all. > On Sun, Jun 30, 2019 at 06:26:07PM -0600, we recorded a bogon-computron > collision of the flavor, containing: > > Other OSen are experiencing this: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1722840 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924329#18 > > > > The problem is that Xastir's map_geo.c is defining "MAGICK_IMPLEMENTATION" > > in > > order to (inappropriately) access private interfaces, which the version of > > Magick you have has in fact moved to a private header that is no longer > > installed with the package. > > > > Apparently this hack was added in 2010 to Xastir to silence warnings about > > misuse of private interfaces, instead of removing the use of > > DestroyImagePixels. > > > > Some work will have to be done to figure out *why* DestroyImagePixels was > > being used in map_geo.c, and to replace it with calls to public interfaces > > of Magick. > > > > On Sun, Jun 30, 2019 at 04:12:27PM -0700, we recorded a bogon-computron > > collision of the flavor, containing: > > > Hello All, > > > > > > I just did a git pull, bootstrap, configure, make clean, and make on my 32 > > > bit Gentoo VM (and my 64 bit VM so not byte size dependent). and now > > > my > > > compiles fail with: > > > > > > CC map_geo.o > > > In file included from /usr/include/GraphicsMagick/magick/analyze.h:18, > > > from /usr/include/GraphicsMagick/magick/api.h:55, > > > from map_geo.c:137: > > > /usr/include/GraphicsMagick/magick/image.h:1108:10: fatal error: > > > magick/image-private.h: No such file or directory > > > #include "magick/image-private.h" > > > ^~~~ > > > compilation terminated. > > > make[3]: *** [Makefile:634: map_geo.o] Error 1 > > > make[3]: Leaving directory '/home/dflood/src/Xastir/src' > > > make[2]: *** [Makefile:656: all-recursive] Error 1 > > > make[2]: Leaving directory '/home/dflood/src/Xastir/src' > > > make[1]: *** [Makefile:744: all-recursive] Error 1 > > > make[1]: Leaving directory '/home/dflood/src/Xastir' > > > make: *** [Makefile:426: all] Error 2 > > > > > > Here's what ./configure tells me: > > > > > > xastir 2.1.3 has been configured to use the following > > > options and external libraries: > > > > > > MINIMUM OPTIONS: > > > ShapeLib (Vector maps) : yes > > > > > > RECOMMENDED OPTIONS: > > > Xpm / Snapshots ... : yes > > > GraphicsMagick/ImageMagick (Raster maps) .. : yes (GraphicsMagick) > > > pcre (Shapefile customization) : yes > > > dbfawk (Shapefile customization) .. : yes > > > Berkeley DB map caching-Raster map speedups : yes > > > internet map retrieval : yes (libcurl) > > > > > > FOR THE ADVENTUROUS: > > > AX25 (Linux Kernel I/O Drivers) ... : no > > > libproj (USGS Topos & Aerial Photos) .. : yes > > > GeoTiff (USGS Topos & Aerial Photos) .. : yes > > > Festival (Text-to-speech) . : no > > > GPSMan/gpsmanshp (GPS downloads) .. : no > > > > > > xastir will be installed in /usr/local/bin. > > > > > > Here's my output of gm -version > > > > > > GraphicsMagick 1.3.32 2019-06-15 Q8 http://www.GraphicsMagick.org/ > > > Copyright (C) 2002-2019 GraphicsMagick Group. > > > Additional copyrights and licenses apply to this software. > > > See http://www.GraphicsMagick.org/www/Copyright.html for details. > > > > > > Feature Support: > > > Native Thread Safe no > > > Large Files (> 32 bit) yes > > > Large Memory (> 32 bit) no > > > BZIP yes > > > DPS no > > > FlashPix no > > > FreeType yes > > >
Re: [Xastir] GraphicsMagick include issue on Gentoo
Lo, and behold, on June 20th, the GraphicsMagick package on my system was updated to 1.3.32, and I had last built Xastir with the previous version, 1.3.31. Today, building Xastir crashes with the same error you get. I will look into whether it is still necessary to have MAGICK_IMPLEMENTATION defined. Taking it out is supposed to fix the compilation error, but I have no idea if it preserves the function of map_geo.c. On Sun, Jun 30, 2019 at 06:26:07PM -0600, we recorded a bogon-computron collision of the flavor, containing: > Other OSen are experiencing this: > > https://bugzilla.redhat.com/show_bug.cgi?id=1722840 > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924329#18 > > The problem is that Xastir's map_geo.c is defining "MAGICK_IMPLEMENTATION" in > order to (inappropriately) access private interfaces, which the version of > Magick you have has in fact moved to a private header that is no longer > installed with the package. > > Apparently this hack was added in 2010 to Xastir to silence warnings about > misuse of private interfaces, instead of removing the use of > DestroyImagePixels. > > Some work will have to be done to figure out *why* DestroyImagePixels was > being used in map_geo.c, and to replace it with calls to public interfaces > of Magick. > > On Sun, Jun 30, 2019 at 04:12:27PM -0700, we recorded a bogon-computron > collision of the flavor, containing: > > Hello All, > > > > I just did a git pull, bootstrap, configure, make clean, and make on my 32 > > bit Gentoo VM (and my 64 bit VM so not byte size dependent). and now my > > compiles fail with: > > > > CC map_geo.o > > In file included from /usr/include/GraphicsMagick/magick/analyze.h:18, > > from /usr/include/GraphicsMagick/magick/api.h:55, > > from map_geo.c:137: > > /usr/include/GraphicsMagick/magick/image.h:1108:10: fatal error: > > magick/image-private.h: No such file or directory > > #include "magick/image-private.h" > > ^~~~ > > compilation terminated. > > make[3]: *** [Makefile:634: map_geo.o] Error 1 > > make[3]: Leaving directory '/home/dflood/src/Xastir/src' > > make[2]: *** [Makefile:656: all-recursive] Error 1 > > make[2]: Leaving directory '/home/dflood/src/Xastir/src' > > make[1]: *** [Makefile:744: all-recursive] Error 1 > > make[1]: Leaving directory '/home/dflood/src/Xastir' > > make: *** [Makefile:426: all] Error 2 > > > > Here's what ./configure tells me: > > > > xastir 2.1.3 has been configured to use the following > > options and external libraries: > > > > MINIMUM OPTIONS: > > ShapeLib (Vector maps) : yes > > > > RECOMMENDED OPTIONS: > > Xpm / Snapshots ... : yes > > GraphicsMagick/ImageMagick (Raster maps) .. : yes (GraphicsMagick) > > pcre (Shapefile customization) : yes > > dbfawk (Shapefile customization) .. : yes > > Berkeley DB map caching-Raster map speedups : yes > > internet map retrieval : yes (libcurl) > > > > FOR THE ADVENTUROUS: > > AX25 (Linux Kernel I/O Drivers) ... : no > > libproj (USGS Topos & Aerial Photos) .. : yes > > GeoTiff (USGS Topos & Aerial Photos) .. : yes > > Festival (Text-to-speech) . : no > > GPSMan/gpsmanshp (GPS downloads) .. : no > > > > xastir will be installed in /usr/local/bin. > > > > Here's my output of gm -version > > > > GraphicsMagick 1.3.32 2019-06-15 Q8 http://www.GraphicsMagick.org/ > > Copyright (C) 2002-2019 GraphicsMagick Group. > > Additional copyrights and licenses apply to this software. > > See http://www.GraphicsMagick.org/www/Copyright.html for details. > > > > Feature Support: > > Native Thread Safe no > > Large Files (> 32 bit) yes > > Large Memory (> 32 bit) no > > BZIP yes > > DPS no > > FlashPix no > > FreeType yes > > Ghostscript (Library)no > > JBIG no > > JPEG-2000no > > JPEG yes > > Little CMS yes > > Loadable Modules no > > Solaris mtmalloc no > > OpenMP yes (201511 "4.5") > > PNG yes > > TIFF yes > > TRIO no > > Solaris umem no > > WebP no > > WMF no > > X11 yes > > XML yes > > ZLIB yes > > > > Host type: i686-pc-linux-gnu > > > > Configured using the command: > > ./configure '--prefix=/usr' '--build=i686-pc-linux-gnu' > > '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' > > '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' > > '--localstatedir=/var/lib' '--disable-dependency-tracking' > > '--disable-silent-rules' '--docdir=/usr/share/doc/graphicsmagick-1.3.32'
Re: [Xastir] GraphicsMagick include issue on Gentoo
Other OSen are experiencing this: https://bugzilla.redhat.com/show_bug.cgi?id=1722840 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924329#18 The problem is that Xastir's map_geo.c is defining "MAGICK_IMPLEMENTATION" in order to (inappropriately) access private interfaces, which the version of Magick you have has in fact moved to a private header that is no longer installed with the package. Apparently this hack was added in 2010 to Xastir to silence warnings about misuse of private interfaces, instead of removing the use of DestroyImagePixels. Some work will have to be done to figure out *why* DestroyImagePixels was being used in map_geo.c, and to replace it with calls to public interfaces of Magick. On Sun, Jun 30, 2019 at 04:12:27PM -0700, we recorded a bogon-computron collision of the flavor, containing: > Hello All, > > I just did a git pull, bootstrap, configure, make clean, and make on my 32 > bit Gentoo VM (and my 64 bit VM so not byte size dependent). and now my > compiles fail with: > > CC map_geo.o > In file included from /usr/include/GraphicsMagick/magick/analyze.h:18, > from /usr/include/GraphicsMagick/magick/api.h:55, > from map_geo.c:137: > /usr/include/GraphicsMagick/magick/image.h:1108:10: fatal error: > magick/image-private.h: No such file or directory > #include "magick/image-private.h" > ^~~~ > compilation terminated. > make[3]: *** [Makefile:634: map_geo.o] Error 1 > make[3]: Leaving directory '/home/dflood/src/Xastir/src' > make[2]: *** [Makefile:656: all-recursive] Error 1 > make[2]: Leaving directory '/home/dflood/src/Xastir/src' > make[1]: *** [Makefile:744: all-recursive] Error 1 > make[1]: Leaving directory '/home/dflood/src/Xastir' > make: *** [Makefile:426: all] Error 2 > > Here's what ./configure tells me: > > xastir 2.1.3 has been configured to use the following > options and external libraries: > > MINIMUM OPTIONS: > ShapeLib (Vector maps) : yes > > RECOMMENDED OPTIONS: > Xpm / Snapshots ... : yes > GraphicsMagick/ImageMagick (Raster maps) .. : yes (GraphicsMagick) > pcre (Shapefile customization) : yes > dbfawk (Shapefile customization) .. : yes > Berkeley DB map caching-Raster map speedups : yes > internet map retrieval : yes (libcurl) > > FOR THE ADVENTUROUS: > AX25 (Linux Kernel I/O Drivers) ... : no > libproj (USGS Topos & Aerial Photos) .. : yes > GeoTiff (USGS Topos & Aerial Photos) .. : yes > Festival (Text-to-speech) . : no > GPSMan/gpsmanshp (GPS downloads) .. : no > > xastir will be installed in /usr/local/bin. > > Here's my output of gm -version > > GraphicsMagick 1.3.32 2019-06-15 Q8 http://www.GraphicsMagick.org/ > Copyright (C) 2002-2019 GraphicsMagick Group. > Additional copyrights and licenses apply to this software. > See http://www.GraphicsMagick.org/www/Copyright.html for details. > > Feature Support: > Native Thread Safe no > Large Files (> 32 bit) yes > Large Memory (> 32 bit) no > BZIP yes > DPS no > FlashPix no > FreeType yes > Ghostscript (Library)no > JBIG no > JPEG-2000no > JPEG yes > Little CMS yes > Loadable Modules no > Solaris mtmalloc no > OpenMP yes (201511 "4.5") > PNG yes > TIFF yes > TRIO no > Solaris umem no > WebP no > WMF no > X11 yes > XML yes > ZLIB yes > > Host type: i686-pc-linux-gnu > > Configured using the command: > ./configure '--prefix=/usr' '--build=i686-pc-linux-gnu' > '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' > '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' > '--localstatedir=/var/lib' '--disable-dependency-tracking' > '--disable-silent-rules' '--docdir=/usr/share/doc/graphicsmagick-1.3.32' > '--htmldir=/usr/share/doc/graphicsmagick-1.3.32/html' '--with-sysroot=/' > '--libdir=/usr/lib' '--enable-openmp' '--enable-largefile' '--enable-shared' > '--disable-static' '--disable-prof' '--disable-gcov' > '--disable-magick-compat' '--without-threads' '--without-modules' > '--with-quantum-depth=8' '--without-frozenpaths' '--with-magick-plus-plus' > '--with-perl' '--with-perl-options=INSTALLDIRS=vendor' '--with-bzlib' > '--without-dps' '--without-fpx' '--without-jbig' '--without-webp' > '--with-jpeg' '--without-jp2' '--with-lcms2' '--without-lzma' '--with-png' > '--with-tiff' '--with-ttf' '--without-wmf' > '--with-fontpath=/usr/share/fonts' > '--with-gs-font-dir=/usr/share/fonts/urw-fonts' > '--with-windows-font-dir=/usr/ > > Final Build
[Xastir] GraphicsMagick include issue on Gentoo
Hello All, I just did a git pull, bootstrap, configure, make clean, and make on my 32 bit Gentoo VM (and my 64 bit VM so not byte size dependent). and now my compiles fail with: CC map_geo.o In file included from /usr/include/GraphicsMagick/magick/analyze.h:18, from /usr/include/GraphicsMagick/magick/api.h:55, from map_geo.c:137: /usr/include/GraphicsMagick/magick/image.h:1108:10: fatal error: magick/image-private.h: No such file or directory #include "magick/image-private.h" ^~~~ compilation terminated. make[3]: *** [Makefile:634: map_geo.o] Error 1 make[3]: Leaving directory '/home/dflood/src/Xastir/src' make[2]: *** [Makefile:656: all-recursive] Error 1 make[2]: Leaving directory '/home/dflood/src/Xastir/src' make[1]: *** [Makefile:744: all-recursive] Error 1 make[1]: Leaving directory '/home/dflood/src/Xastir' make: *** [Makefile:426: all] Error 2 Here's what ./configure tells me: xastir 2.1.3 has been configured to use the following options and external libraries: MINIMUM OPTIONS: ShapeLib (Vector maps) : yes RECOMMENDED OPTIONS: Xpm / Snapshots ... : yes GraphicsMagick/ImageMagick (Raster maps) .. : yes (GraphicsMagick) pcre (Shapefile customization) : yes dbfawk (Shapefile customization) .. : yes Berkeley DB map caching-Raster map speedups : yes internet map retrieval : yes (libcurl) FOR THE ADVENTUROUS: AX25 (Linux Kernel I/O Drivers) ... : no libproj (USGS Topos & Aerial Photos) .. : yes GeoTiff (USGS Topos & Aerial Photos) .. : yes Festival (Text-to-speech) . : no GPSMan/gpsmanshp (GPS downloads) .. : no xastir will be installed in /usr/local/bin. Here's my output of gm -version GraphicsMagick 1.3.32 2019-06-15 Q8 http://www.GraphicsMagick.org/ Copyright (C) 2002-2019 GraphicsMagick Group. Additional copyrights and licenses apply to this software. See http://www.GraphicsMagick.org/www/Copyright.html for details. Feature Support: Native Thread Safe no Large Files (> 32 bit) yes Large Memory (> 32 bit) no BZIP yes DPS no FlashPix no FreeType yes Ghostscript (Library)no JBIG no JPEG-2000no JPEG yes Little CMS yes Loadable Modules no Solaris mtmalloc no OpenMP yes (201511 "4.5") PNG yes TIFF yes TRIO no Solaris umem no WebP no WMF no X11 yes XML yes ZLIB yes Host type: i686-pc-linux-gnu Configured using the command: ./configure '--prefix=/usr' '--build=i686-pc-linux-gnu' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--disable-dependency-tracking' '--disable-silent-rules' '--docdir=/usr/share/doc/graphicsmagick-1.3.32' '--htmldir=/usr/share/doc/graphicsmagick-1.3.32/html' '--with-sysroot=/' '--libdir=/usr/lib' '--enable-openmp' '--enable-largefile' '--enable-shared' '--disable-static' '--disable-prof' '--disable-gcov' '--disable-magick-compat' '--without-threads' '--without-modules' '--with-quantum-depth=8' '--without-frozenpaths' '--with-magick-plus-plus' '--with-perl' '--with-perl-options=INSTALLDIRS=vendor' '--with-bzlib' '--without-dps' '--without-fpx' '--without-jbig' '--without-webp' '--with-jpeg' '--without-jp2' '--with-lcms2' '--without-lzma' '--with-png' '--with-tiff' '--with-ttf' '--without-wmf' '--with-fontpath=/usr/share/fonts' '--with-gs-font-dir=/usr/share/fonts/urw-fonts' '--with-windows-font-dir=/usr/ Final Build Parameters: CC = i686-pc-linux-gnu-gcc CFLAGS = -fopenmp -O2 -march=i686 -pipe -Wall CPPFLAGS = -I/usr/include/freetype2 -I/usr/include/libxml2 CXX = i686-pc-linux-gnu-g++ CXXFLAGS = -O2 -march=i686 -pipe LDFLAGS = -Wl,-O1 -Wl,--as-needed LIBS = -llcms2 -ltiff -lfreetype -ljpeg -lpng16 -lXext -lSM -lICE -lX11 -lbz2 -lxml2 -lz -lm I did find a ref to this error and Xastir in one of the Debian email lists from March... http://debian.2.n7.nabble.com/Re-Bug-924329-xastir-FTBFS-magick-image-privat e-h-No-such-file-or-directory-td4492878.html David Flood KD7MYC ___ Xastir mailing list Xastir@lists.xastir.org http://xastir.org/mailman/listinfo/xastir
