[Xen-devel] [qemu-mainline test] 65766: trouble: broken/fail/pass

2015-12-13 Thread osstest service owner
flight 65766 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/65766/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-arndale   3 host-install(3) broken REGR. vs. 65664

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds 11 guest-start   fail REGR. vs. 65664

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-pvh-intel 11 guest-start  fail  never pass
 test-armhf-armhf-xl-vhd   9 debian-di-installfail   never pass
 test-amd64-amd64-xl-pvh-amd  11 guest-start  fail   never pass
 test-amd64-amd64-libvirt 12 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-raw  9 debian-di-installfail   never pass
 test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt 14 guest-saverestorefail   never pass
 test-armhf-armhf-libvirt 12 migrate-support-checkfail   never pass
 test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail never pass
 test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail  never pass
 test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail  never pass
 test-armhf-armhf-libvirt-qcow2  9 debian-di-installfail never pass
 test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass
 test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass
 test-armhf-armhf-xl-credit2  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  13 saverestore-support-checkfail   never pass
 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop  fail never pass
 test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-xsm 14 guest-saverestorefail   never pass
 test-armhf-armhf-xl  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl  12 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt-xsm  12 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-armhf-armhf-xl-xsm  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  12 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-vhd  9 debian-di-installfail   never pass

version targeted for testing:
 qemuuf05b42d3fd30bb9673cc1ac1ee8c2af8f669964e
baseline version:
 qemuua3154ccabcb21ac4e42877c965df60976832dbc5

Last test of basis65664  2015-12-10 11:37:40 Z2 days
Testing same since65766  2015-12-12 01:46:56 Z1 days1 attempts


People who touched revisions under test:
  Alex Zuepke 
  Dr. David Alan Gilbert 
  Kevin Wolf 
  Markus Armbruster 
  Max Reitz 
  Peter Maydell 

jobs:
 build-amd64-xsm  pass
 build-armhf-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-armhf  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-armhf-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-pvopspass
 build-armhf-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-xl  pass
 test-armhf-armhf-xl  pass
 test-amd64-i386-xl   pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm   pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsmpass
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsmpass
 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm pass
 test-amd64-amd64-libvirt-xsm pass
 test-armhf-armhf-libvirt-xsm fail
 

[Xen-devel] how to obtain the context of nested xen?

2015-12-13 Thread quizyjones
In a multiple cpus machine where each vcpu is pinned at the corresponding 
physical cpu, a VM's context can be obtained through the cr3 of the 
corresponding vcpu. However, what if a nested xen is presented? Does the nested 
xen shared vcpus with the VMs on it or occupy a separate one? How can I know 
which vcpu/vcpu the nested xen is using? There is no document in detailing the 
cpu allocation strategy for xen itself, all I can find it about vcpu allocation 
and configuration for dom0 and domUs.   ___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [libvirt test] 65789: regressions - FAIL

2015-12-13 Thread osstest service owner
flight 65789 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/65789/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-libvirt5 libvirt-build fail REGR. vs. 63340
 build-amd64-libvirt   5 libvirt-build fail REGR. vs. 63340
 build-armhf-libvirt   5 libvirt-build fail REGR. vs. 63340

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw  1 build-check(1)   blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)   blocked  n/a
 test-armhf-armhf-libvirt-xsm  1 build-check(1)   blocked  n/a
 test-armhf-armhf-libvirt  1 build-check(1)   blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)   blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)   blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)   blocked  n/a
 test-amd64-amd64-libvirt  1 build-check(1)   blocked  n/a
 test-amd64-i386-libvirt   1 build-check(1)   blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)   blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)   blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a

version targeted for testing:
 libvirt  034e47c338b13a95cf02106a3af912c1c5f818d7
baseline version:
 libvirt  3c7590e0a435d833895fc7b5be489e53e223ad95

Last test of basis63340  2015-10-28 04:19:47 Z   46 days
Failing since 63352  2015-10-29 04:20:29 Z   45 days   40 attempts
Testing same since65789  2015-12-12 22:56:27 Z1 days1 attempts


People who touched revisions under test:
  Andrea Bolognani 
  Boris Fiuczynski 
  Chen Hanxiao 
  Christian Loehle 
  Cole Robinson 
  Daniel P. Berrange 
  Daniel Veillard 
  Dmitry Andreev 
  Eric Blake 
  Erik Skultety 
  Guido Günther 
  Ian Campbell 
  Jim Fehlig 
  Jiri Denemark 
  Joao Martins 
  John Ferlan 
  Ján Tomko 
  Laine Stump 
  Luyao Huang 
  Marc-André Lureau 
  Martin Kletzander 
  Maxim Perevedentsev 
  Michal Privoznik 
  Michel Normand 
  Mikhail Feoktistov 
  Nikolay Shirokovskiy 
  Pavel Hrdina 
  Peter Krempa 
  Richard Weinberger 
  Roman Bogorodskiy 
  Stefan Berger 
  Stefan Berger 
  Wang Yufei 
  Wei Jiangang 

jobs:
 build-amd64-xsm  pass
 build-armhf-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-armhf  pass
 build-i386   pass
 build-amd64-libvirt  fail
 build-armhf-libvirt  fail
 build-i386-libvirt   fail
 build-amd64-pvopspass
 build-armhf-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm   blocked
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsmblocked
 test-amd64-amd64-libvirt-xsm blocked
 test-armhf-armhf-libvirt-xsm blocked
 test-amd64-i386-libvirt-xsm  blocked
 test-amd64-amd64-libvirt blocked
 test-armhf-armhf-libvirt blocked
 test-amd64-i386-libvirt  blocked
 test-amd64-amd64-libvirt-pairblocked
 test-amd64-i386-libvirt-pair blocked
 test-armhf-armhf-libvirt-qcow2   blocked
 test-armhf-armhf-libvirt-raw blocked
 

[Xen-devel] [distros-debian-stretch test] 38505: regressions - FAIL

2015-12-13 Thread Platform Team regression test user
flight 38505 distros-debian-stretch real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/38505/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-armhf-stretch-netboot-pygrub 9 debian-di-install fail REGR. 
vs. 38450
 test-amd64-i386-i386-stretch-netboot-pvgrub 9 debian-di-install fail REGR. vs. 
38450
 test-amd64-amd64-amd64-stretch-netboot-pvgrub 9 debian-di-install fail REGR. 
vs. 38450
 test-amd64-i386-amd64-stretch-netboot-pygrub 9 debian-di-install fail REGR. 
vs. 38450
 test-amd64-amd64-i386-stretch-netboot-pygrub 9 debian-di-install fail REGR. 
vs. 38450

baseline version:
 flight   38450

jobs:
 build-amd64  pass
 build-armhf  pass
 build-i386   pass
 build-amd64-pvopspass
 build-armhf-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-amd64-stretch-netboot-pvgrubfail
 test-amd64-i386-i386-stretch-netboot-pvgrub  fail
 test-amd64-i386-amd64-stretch-netboot-pygrub fail
 test-armhf-armhf-armhf-stretch-netboot-pygrubfail
 test-amd64-amd64-i386-stretch-netboot-pygrub fail



sg-report-flight on osstest.xs.citrite.net
logs: /home/osstest/logs
images: /home/osstest/images

Logs, config files, etc. are available at
http://osstest.xs.citrite.net/~osstest/testlogs/logs

Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary


Push not applicable.


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [ovmf test] 65773: trouble: broken/pass

2015-12-13 Thread osstest service owner
flight 65773 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/65773/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-ovmf-amd64  2 hosts-allocate  broken REGR. vs. 65543

version targeted for testing:
 ovmf 4754f80b8159f0391300ab0de8a24c9635e1ae28
baseline version:
 ovmf 5ac96e3a28dd26eabee421919f67fa7c443a47f1

Last test of basis65543  2015-12-08 08:45:15 Z5 days
Failing since 65593  2015-12-08 23:44:51 Z4 days4 attempts
Testing same since65773  2015-12-12 07:57:22 Z1 days1 attempts


People who touched revisions under test:
  Ard Biesheuvel 
  Chao Zhang 
  Dandan Bi 
  Eric Dong 
  Eugene Cohen 
  Hao Wu 
  Heyi Guo 
  Jaben Carsey 
  Jeff Fan 
  Jiaxin Wu 
  Jordan Justen 
  Leekha Shaveta 
  Qin Long 
  Ruiyu Ni 

jobs:
 build-amd64-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-pvopspass
 build-i386-pvops pass
 test-amd64-amd64-xl-qemuu-ovmf-amd64 broken  
 test-amd64-i386-xl-qemuu-ovmf-amd64  pass



sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-step test-amd64-amd64-xl-qemuu-ovmf-amd64 hosts-allocate

Not pushing.

(No revision log; it would be 433 lines long.)

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [PATCH] xen/tools/get-fields.sh: Use printf for POSIX compat

2015-12-13 Thread Alex Xu
xen/tools/get-fields.sh used echo -n which is not POSIX compatible and
breaks with dash. Change it to use printf "%s" which is usable
everywhere.

Signed-off-by: Alex Xu 
---
 xen/tools/get-fields.sh | 30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/xen/tools/get-fields.sh b/xen/tools/get-fields.sh
index 4547dc2..9c0b286 100644
--- a/xen/tools/get-fields.sh
+++ b/xen/tools/get-fields.sh
@@ -130,9 +130,9 @@ handle_field ()
echo " \\"
if [ -z "$4" ]
then
-   echo -n "$1(_d_)->$3 = (_s_)->$3;"
+   printf "%s" "$1(_d_)->$3 = (_s_)->$3;"
else
-   echo -n "$1XLAT_${2}_HNDL_$(echo $3 | $SED 
's,\.,_,g')(_d_, _s_);"
+   printf "%s" "$1XLAT_${2}_HNDL_$(echo $3 | $SED 
's,\.,_,g')(_d_, _s_);"
fi
elif [ -z "$(echo "$5" | $SED 's,[^{}],,g')" ]
then
@@ -142,7 +142,7 @@ for line in sys.stdin.readlines():
 print re.subn(r"\s*(struct|union)\s+(compat_)?(\w+)\s.*", r"\3", 
line)[0].rstrip()
 ')
echo " \\"
-   echo -n "${1}XLAT_$tag(&(_d_)->$3, &(_s_)->$3);"
+   printf "%s" "${1}XLAT_$tag(&(_d_)->$3, &(_s_)->$3);"
else
local level=1 kind= fields= id= array= arrlvl=1 array_type= 
type= token
for token in $5
@@ -156,7 +156,7 @@ for line in sys.stdin.readlines():
if [ $kind = union ]
then
echo " \\"
-   echo -n "${1}switch ($(echo $3 
| $SED 's,\.,_,g')) {"
+   printf "%s" "${1}switch ($(echo 
$3 | $SED 's,\.,_,g')) {"
fi
fi
;;
@@ -168,7 +168,7 @@ for line in sys.stdin.readlines():
if [ $level = 1 -a $kind = union ]
then
echo " \\"
-   echo -n "$1}"
+   printf "%s" "$1}"
fi
;;
"[")
@@ -223,7 +223,7 @@ for line in sys.stdin.readlines():
if [ $kind = union ]
then
echo " \\"
-   echo -n "${1}case 
XLAT_${2}_$(echo $3.$id | $SED 's,\.,_,g'):"
+   printf "%s" "${1}case 
XLAT_${2}_$(echo $3.$id | $SED 's,\.,_,g'):"
handle_field "$1" $2 $3.$id 
"$type" "$fields"
elif [ -z "$array" -a -z "$array_type" ]
then
@@ -239,7 +239,7 @@ for line in sys.stdin.readlines():
if [ $kind = union ]
then
echo " \\"
-   echo -n "$1break;"
+   printf "%s" "$1break;"
fi
fi
;;
@@ -259,7 +259,7 @@ copy_array ()
 {
echo " \\"
echo "${1}if ((_d_)->$2 != (_s_)->$2) \\"
-   echo -n "$1memcpy((_d_)->$2, (_s_)->$2, sizeof((_d_)->$2));"
+   printf "%s" "$1memcpy((_d_)->$2, (_s_)->$2, sizeof((_d_)->$2));"
 }
 
 handle_array ()
@@ -268,7 +268,7 @@ handle_array ()
echo " \\"
echo "$1{ \\"
echo "$1unsigned int $i; \\"
-   echo -n "$1for ($i = 0; $i < "${4%%;*}"; ++$i) {"
+   printf "%s" "$1for ($i = 0; $i < "${4%%;*}"; ++$i) {"
if [ "$4" = "${4#*;}" ]
then
handle_field "$1" $2 $3[$i] "$5" "$6"
@@ -277,13 +277,13 @@ handle_array ()
fi
echo " \\"
echo "$1} \\"
-   echo -n "$1}"
+   printf "%s" "$1}"
 }
 
 build_body ()
 {
echo
-   echo -n "#define XLAT_$1(_d_, _s_) do {"
+   printf "%s" "#define XLAT_$1(_d_, _s_) do {"
local level=1 fields= id= array= arrlvl=1 array_type= type= token
for token in $2
do
@@ -389,7 +389,7 @@ check_field ()
struct|union)
;;
[a-zA-Z_]*)
-   echo -n "CHECK_${n#xen_}"
+   printf "%s" "CHECK_${n#xen_}"
break
;;
 

[Xen-devel] [xen-4.4-testing baseline-only test] 38504: tolerable FAIL

2015-12-13 Thread Platform Team regression test user
This run is configured for baseline tests only.

flight 38504 xen-4.4-testing real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/38504/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-libvirt  6 xen-boot  fail REGR. vs. 38317
 test-amd64-amd64-xl  21 guest-start/debian.repeatfail   like 38317
 test-amd64-amd64-xl-qemuu-winxpsp3 16 guest-localmigrate/x10   fail like 38317

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-rumpuserxen-amd64  1 build-check(1)   blocked n/a
 test-amd64-i386-rumpuserxen-i386  1 build-check(1)   blocked  n/a
 build-i386-rumpuserxen6 xen-buildfail   never pass
 test-armhf-armhf-xl-vhd   9 debian-di-installfail   never pass
 test-armhf-armhf-libvirt-qcow2  9 debian-di-installfail never pass
 test-armhf-armhf-libvirt-raw  9 debian-di-installfail   never pass
 test-armhf-armhf-libvirt 11 guest-start  fail   never pass
 build-amd64-rumpuserxen   6 xen-buildfail   never pass
 test-armhf-armhf-xl-credit2  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-midway   12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-midway   13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl  12 migrate-support-checkfail   never pass
 test-amd64-amd64-qemuu-nested 16 debian-hvm-install/l1/l2 fail  never pass
 test-amd64-i386-libvirt  12 migrate-support-checkfail   never pass
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop  fail never pass
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass
 test-amd64-amd64-libvirt-vhd 11 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail  never pass
 test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail  never pass
 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop  fail never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass
 test-amd64-i386-xend-qemut-winxpsp3 21 leak-check/checkfail never pass

version targeted for testing:
 xen  8fc45c1ce8ee883a9422ac471256c7c6125cef25
baseline version:
 xen  602506b3efa8ddeae2976ec9f15d91366f823919

Last test of basis38317  2015-11-20 16:21:25 Z   22 days
Testing same since38504  2015-12-12 05:24:44 Z1 days1 attempts


People who touched revisions under test:
  George Dunlap 
  Ian Campbell 
  Ian Jackson 
  Jan Beulich 
  Prasad J Pandit 

jobs:
 build-amd64-xend pass
 build-i386-xend  pass
 build-amd64  pass
 build-armhf  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-armhf-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-prev pass
 build-i386-prev  pass
 build-amd64-pvopspass
 build-armhf-pvopspass
 build-i386-pvops pass
 build-amd64-rumpuserxen  fail
 build-i386-rumpuserxen   fail
 test-amd64-amd64-xl  fail
 test-armhf-armhf-xl  pass
 test-amd64-i386-xl   pass
 test-amd64-i386-qemut-rhel6hvm-amd   pass
 test-amd64-i386-qemuu-rhel6hvm-amd   pass
 test-amd64-amd64-xl-qemut-debianhvm-amd64pass
 test-amd64-i386-xl-qemut-debianhvm-amd64 pass
 test-amd64-amd64-xl-qemuu-debianhvm-amd64pass
 test-amd64-i386-xl-qemuu-debianhvm-amd64 pass
 test-amd64-i386-freebsd10-amd64  pass
 test-amd64-amd64-xl-qemuu-ovmf-amd64 pass
 test-amd64-i386-xl-qemuu-ovmf-amd64  pass
 

[Xen-devel] [linux-3.10 test] 65778: regressions - FAIL

2015-12-13 Thread osstest service owner
flight 65778 linux-3.10 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/65778/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-rumpuserxen-i386 10 guest-start   fail REGR. vs. 64456

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-libvirt-vhd  9 debian-di-install fail REGR. vs. 64456
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-localmigrate/x10 
fail blocked in 64456
 test-amd64-amd64-rumpuserxen-amd64 15 
rumpuserxen-demo-xenstorels/xenstorels.repeat fail like 64456
 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop  fail like 64456
 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 64456

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-pvh-intel 11 guest-start  fail  never pass
 test-amd64-amd64-xl-pvh-amd  11 guest-start  fail   never pass
 test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt-xsm  12 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt 12 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  12 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop  fail never pass
 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass

version targeted for testing:
 linux03ed106ff4c200d01f3c72f71fa9c5b18da07d9b
baseline version:
 linuxbdf8cfb859e9cd265ec1696d9e007fac66e7aea7

Last test of basis64456  2015-11-16 13:37:17 Z   27 days
Testing same since65634  2015-12-09 19:33:01 Z3 days3 attempts


People who touched revisions under test:
  Aleksander Morgado 
  Amitkumar Karwar 
  Andrew Cooper 
  Ani Sinha 
  Bjørn Mork 
  Borislav Petkov 
  Carol L Soto 
  Catalin Marinas 
  Clemens Ladisch 
  Dan Carpenter 
  David Herrmann 
  David S. Miller 
  Eric Dumazet 
  Felipe Balbi 
  Florian Fainelli 
  Greg Kroah-Hartman 
  Gregory CLEMENT 
  Guillaume Nault 
  Jack Morgenstein 
  Jason Wang 
  Jiri Slaby 
  Johan Hovold 
  Johannes Berg 
  Kalle Valo 
  Krzysztof Mazur 
  Larry Finger 
  Marc Kleine-Budde 
  Marcel Holtmann 
  Marek Szyprowski 
  Matt Fleming 
  Maxime Ripard 
  Michael S. Tsirkin 
  Mirza Krak 
  Or Gerlitz 
  Paolo Bonzini 
  Pete Zaitcev 
  Phil Reid 
  Richard Cochran 
  Robin Murphy 
  Russell King 
  Rusty Russell 
  Santosh Shilimkar 
  Sasha Levin 
  Sowmini Varadhan 
  Takashi Iwai 
  Thomas Gleixner 
  Uwe Kleine-König 
  Will Deacon 

jobs:
 build-amd64-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-i386   pass
 build-amd64-libvirt  pass
 build-i386-libvirt   pass
 build-amd64-pvopspass
 build-i386-pvops pass
 build-amd64-rumpuserxen  pass
 build-i386-rumpuserxen   pass
 test-amd64-amd64-xl  pass
 test-amd64-i386-xl   pass
 test-amd64-amd64-xl-qemut-debianhvm-amd64-xsmpass
 

[Xen-devel] [linux-4.1 test] 65781: regressions - FAIL

2015-12-13 Thread osstest service owner
flight 65781 linux-4.1 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/65781/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-rumpuserxen-i386 10 guest-start   fail REGR. vs. 63996

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-libvirt-vhd  9 debian-di-install fail REGR. vs. 63996
 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 63996
 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail like 63996

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-pvh-intel 14 guest-saverestorefail  never pass
 test-amd64-amd64-xl-pvh-amd  11 guest-start  fail   never pass
 test-armhf-armhf-xl-vhd   9 debian-di-installfail   never pass
 test-armhf-armhf-libvirt-qcow2  9 debian-di-installfail never pass
 test-armhf-armhf-libvirt-raw  9 debian-di-installfail   never pass
 test-armhf-armhf-libvirt 14 guest-saverestorefail   never pass
 test-armhf-armhf-libvirt 12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail   never pass
 test-armhf-armhf-libvirt-xsm 14 guest-saverestorefail   never pass
 test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-rtds 15 guest-start/debian.repeatfail   never pass
 test-amd64-amd64-libvirt 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail  never pass
 test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail  never pass
 test-amd64-i386-libvirt  12 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail   never pass
 test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-armhf-armhf-xl-arndale  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-arndale  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl  13 saverestore-support-checkfail   never pass
 test-amd64-i386-libvirt-xsm  12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  12 migrate-support-checkfail   never pass
 test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop  fail never pass
 test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass
 test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass
 test-armhf-armhf-xl-credit2  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-credit2  12 migrate-support-checkfail   never pass
 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop  fail never pass

version targeted for testing:
 linuxcb371265c2f1a0dd0cee03bd7fff413d671c53f0
baseline version:
 linux1f2ce4a2e7aea3a2123b17aff62a80553df31e21

Last test of basis63996  2015-11-09 23:07:34 Z   33 days
Testing same since65632  2015-12-09 19:33:02 Z4 days3 attempts


People who touched revisions under test:
  Alan Stern 
  Aleksander Morgado 
  Alexander Duyck 
  Alexandre Belloni 
  Alexandre Courbot 
  Amitkumar Karwar 
  Andrei Otcheretianski 
  Andrew Cooper 
  Ani Sinha 
  Ard Biesheuvel 
  Arik Nemtsov 
  Arik Nemtsov 
  Arnd Bergmann 
  Ben McCauley 
  Bjørn Mork 
  Borislav Petkov 
  Carol L Soto 
  Catalin Marinas 
  Christian Borntraeger 
  Christophe Ricard 
  Christophe Ricard 
  Clemens Ladisch 
  Cong Wang 
  Cornelia Huck 
  Dan Carpenter 
  David Herrmann 
  David Hildenbrand 
  David S. Miller 
  David Woodhouse 
  David Woodhouse 
  Dmitry Osipenko 

Re: [Xen-devel] [linux-3.14 test] 65633: regressions - FAIL

2015-12-13 Thread Robert Hu
On Fri, 2015-12-11 at 12:01 +, Ian Campbell wrote:
> On Fri, 2015-12-11 at 11:48 +0800, Robert Hu wrote:
> > On Fri, 2015-12-11 at 01:16 +, osstest service owner wrote:
> > > flight 65633 linux-3.14 real [real]
> > > http://logs.test-lab.xenproject.org/osstest/logs/65633/
> > > 
> > > Regressions :-(
> > > 
> > > Tests which did not succeed and are blocking,
> > > including tests which could not be run:
> > >  test-amd64-i386-rumpuserxen-i386 10 guest-start   fail REGR.
> > > vs. 64562
> > [trim...]
> > Hi Ian,
> > 
> > Why does it still fails there and even marked 'never pass' now?
> 
> This is the test of the linux-3.14 branch, not the xen-unstable branch
> which was failing before.
> 
> Once the revert passes through the xen-unstable push gate then the linux-
> 3.14 branch (and most other branches) will pick up that change.
> 
> I don't know why the nested test case has never passed on the 3.14 branch,
> someone would have to investigate if they think that is a problem.

I think better to use linux-stable tree, which I have always for the
test development.
I remember at very beginning, I tried to use the linux-pvops tree but
failed. Result seems aligned with your side.

> 
> Ian.



___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [linux-3.14 test] 65787: regressions - FAIL

2015-12-13 Thread osstest service owner
flight 65787 linux-3.14 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/65787/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-rumpuserxen-i386 10 guest-start   fail REGR. vs. 64562

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-amd64 9 debian-hvm-install fail pass in 
65709

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-libvirt-vhd  9 debian-di-install fail REGR. vs. 64562
 test-amd64-amd64-qemuu-nested-intel 16 debian-hvm-install/l1/l2 fail in 65709 
baseline untested
 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail in 
65709 like 64178
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 13 guest-localmigrate 
fail like 64562
 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail like 64562
 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 64562
 test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop  fail like 64562

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-pvh-intel 11 guest-start  fail  never pass
 test-amd64-amd64-xl-pvh-amd  11 guest-start  fail   never pass
 test-amd64-i386-libvirt-xsm  12 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  12 migrate-support-checkfail   never pass
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail 
never pass
 test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop  fail never pass
 test-amd64-amd64-libvirt 12 migrate-support-checkfail   never pass

version targeted for testing:
 linux5d7b0fcc26d66db767a477574effc764022c19ac
baseline version:
 linux769b79eb206ad5b0249a08665fefb913c3d1998e

Last test of basis64562  2015-11-17 09:53:45 Z   26 days
Testing same since65633  2015-12-09 19:33:10 Z4 days3 attempts


People who touched revisions under test:
  Aleksander Morgado 
  Amitkumar Karwar 
  Andrew Cooper 
  Ani Sinha 
  Bjørn Mork 
  Borislav Petkov 
  Carol L Soto 
  Catalin Marinas 
  Clemens Ladisch 
  Dan Carpenter 
  David Herrmann 
  David S. Miller 
  David Woodhouse 
  David Woodhouse 
  Dmitry Tunin 
  Eric Dumazet 
  Felipe Balbi 
  Florian Fainelli 
  Francesco Ruggeri 
  Francesco Ruggeri 
  Greg Kroah-Hartman 
  Gregory CLEMENT 
  Guillaume Nault 
  Jack Morgenstein 
  Jason Wang 
  Jiri Slaby 
  Johan Hovold 
  Johannes Berg 
  Kalle Valo 
  Krzysztof Mazur 
  Larry Finger 
  Marc Kleine-Budde 
  Marcel Holtmann 
  Marek Szyprowski 
  Matt Fleming 
  Maxime Ripard 
  Michael S. Tsirkin 
  Mirza Krak 
  Or Gerlitz 
  Paolo Bonzini 
  Pete Zaitcev 
  Peter Ujfalusi 
  Phil Reid 
  Richard Cochran 
  Robin Murphy 
  Russell King 
  Rusty Russell 
  Santosh Shilimkar 
  Sasha Levin 
  Sowmini Varadhan 
  Takashi Iwai 
  Thomas Gleixner 
  Uwe Kleine-König 
  Vinod Koul 
  Will Deacon 

jobs:
 build-amd64-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-i386   pass
 

[Xen-devel] [xen-unstable test] 65791: regressions - FAIL

2015-12-13 Thread osstest service owner
flight 65791 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/65791/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf   5 xen-build fail REGR. vs. 65635

Regressions which are regarded as allowable (not blocking):
 test-amd64-i386-rumpuserxen-i386 10 guest-startfail like 65635
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 13 guest-localmigrate 
fail like 65635
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 13 guest-localmigrate 
fail like 65635
 test-amd64-amd64-libvirt-vhd  9 debian-di-installfail   like 65635
 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop  fail like 65635
 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail like 65635

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd   1 build-check(1)   blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)   blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)   blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)   blocked  n/a
 test-armhf-armhf-libvirt-xsm  1 build-check(1)   blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)   blocked  n/a
 test-armhf-armhf-libvirt  1 build-check(1)   blocked  n/a
 test-armhf-armhf-xl-rtds  1 build-check(1)   blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)   blocked  n/a
 test-armhf-armhf-xl   1 build-check(1)   blocked  n/a
 build-armhf-libvirt   1 build-check(1)   blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)   blocked  n/a
 test-amd64-amd64-xl-pvh-amd  11 guest-start  fail   never pass
 test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2  fail never pass
 test-amd64-i386-libvirt-xsm  12 migrate-support-checkfail   never pass
 test-amd64-amd64-xl-pvh-intel 11 guest-start  fail  never pass
 test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  13 saverestore-support-checkfail   never pass
 test-armhf-armhf-xl-xsm  12 migrate-support-checkfail   never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail never pass
 test-amd64-amd64-libvirt 12 migrate-support-checkfail   never pass
 test-amd64-i386-libvirt  12 migrate-support-checkfail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check 
fail never pass
 test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop  fail never pass

version targeted for testing:
 xen  e6f0e099d2c17de47fd86e817b1998db903cab61
baseline version:
 xen  a841b1b1286d122fd472b43db3c423b9876262e5

Last test of basis65635  2015-12-09 19:47:20 Z4 days
Testing same since65748  2015-12-11 12:34:13 Z2 days2 attempts


People who touched revisions under test:
  
  Andrew Cooper 
  Boris Ostrovsky 
  Dario Faggioli 
  David Scott 
  Feng Wu 
  Ian Campbell 
  Ian Jackson 
  Jan Beulich 
  Jim Fehlig 
  Kevin Tian 
  Roger Pau Monné 
  Ross Lagerwall 
  Wei Liu 

jobs:
 build-amd64-xsm  pass
 build-armhf-xsm  pass
 build-i386-xsm   pass
 build-amd64  pass
 build-armhf  fail
 build-i386   pass
 build-amd64-libvirt  pass
 build-armhf-libvirt  blocked
 build-i386-libvirt   pass
 build-amd64-oldkern  pass
 build-i386-oldkern   pass
 build-amd64-prev pass
 build-i386-prev  pass
 build-amd64-pvopspass
 build-armhf-pvopspass
 build-i386-pvops pass
 build-amd64-rumpuserxen  pass
 build-i386-rumpuserxen   

Re: [Xen-devel] [PATCH] x86/HVM: Merge HVM and PVH hypercall tables

2015-12-13 Thread Jan Beulich
>>> On 11.12.15 at 17:50,  wrote:
> On 12/10/2015 11:53 AM, Boris Ostrovsky wrote:
>> Especially given that PVH dom0 is not booting for me, as I just found 
>> out:
>>
>> ...
>> (XEN) d0v0 EPT violation 0x1aa (-w-/r-x) gpa 0x00c0008116 mfn 
>> 0xc0008 type 5
>> (XEN) d0v0 Walking EPT tables for GFN c0008:
>> (XEN) d0v0  epte 80082bf50007
>> (XEN) d0v0  epte 80082bf19007
>> (XEN) d0v0  epte 80043c6f9007
>> (XEN) d0v0  epte 8050c0008805
>> (XEN) d0v0  --- GLA 0xc90020008116
>> (XEN) domain_crash called from vmx.c:2816
>> (XEN) Domain 0 (vcpu#0) crashed on cpu#0:
>> (XEN) [ Xen-4.7-unstable  x86_64  debug=y  Tainted:C ]
>> (XEN) CPU:0
>> (XEN) RIP:0010:[]
>> (XEN) RFLAGS: 00010046   CONTEXT: hvm guest (d0v0)
>> (XEN) rax: 001d   rbx:    rcx: 
>> 88014700f9b8
>> (XEN) rdx: 00ff   rsi:    rdi: 
>> 
>> (XEN) rbp: 88014700fa18   rsp: 88014700f9e8   r8: 
>> 88014700f9c0
>> (XEN) r9:  001d   r10: 8189c7f0   r11: 
>> 
>> (XEN) r12: c90020008000   r13: c90020008116   r14: 
>> 0002
>> (XEN) r15: 001d   cr0: 80050033   cr4: 
>> 000406f0
>> (XEN) cr3: 01c0e000   cr2: 
>> (XEN) ds:    es:    fs:    gs:    ss:    cs: 0010
>> (XEN) Guest stack trace from rsp=88014700f9e8:
>> (XEN)   Fault while accessing guest memory.
>> (XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds.
>>
>>
>> We haven't been running regression tests for PVH dom0 so I don't know 
>> how long this has been broken.
> 
> 
> This is broken by 9256f66c1606 ("x86/PCI: intercept all PV Dom0 MMCFG 
> writes").

Well, I can't find any hookup of the write emulation logic for PVH
at all in ept_handle_violation() or hvm_hap_nested_page_fault(),
i.e. it looks to me as if this was broken already before, just that
for the limited set of devices that had their MMCFG space marked
r/o this went unnoticed (iow perhaps a missing FIXME annotation).
I'll see to find time to look into this, but I can't really predict when
I might get around to it.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH v10 3/5] libxl: add pvusb API

2015-12-13 Thread Chun Yan Liu


>>> On 12/10/2015 at 08:08 PM, in message <56696b4b.7060...@citrix.com>, George
Dunlap  wrote: 
> On 10/12/15 12:05, George Dunlap wrote: 
> > From: Chunyan Liu  
> >  
> > Add pvusb APIs, including: 
> >  - attach/detach (create/destroy) virtual usb controller. 
> >  - attach/detach usb device 
> >  - list usb controller and usb devices 
> >  - some other helper functions 
> >  
> > Signed-off-by: Chunyan Liu  
> > Signed-off-by: Simon Cao  
> > Signed-off-by: George Dunlap  
>  
> Attached is a diff of v9 -> v10 for convenience. 

Thanks very much, George!
I've applied your new patch and tested, there are a couple of changes needed to
get tests PASSED. A small extra patch is written on top of your new patch, as in
attachment, please have a look.

Otherwise, I agreed with all your other changes. It's great improvement.
Thanks a lot!  

>  
> One remaining question I had regarding this patch... 

For the question, see below.

>  
> > +static int usbdev_get_all_interfaces(libxl__gc *gc, const char *busid, 
> > + char ***intfs, int *num) 
> > +{ 
> > +DIR *dir; 
> > +char *buf; 
> > +int rc; 
> > + 
> > +*intfs = NULL; 
> > +*num = 0; 
> > + 
> > +buf = GCSPRINTF("%s:", busid); 
> > + 
> > +dir = opendir(SYSFS_USB_DEV); 
> > +if (!dir) { 
> > +LOGE(ERROR, "opendir failed: '%s'", SYSFS_USB_DEV); 
> > +return ERROR_FAIL; 
> > +} 
> > + 
> > +size_t need = offsetof(struct dirent, d_name) + 
> > +pathconf(SYSFS_USB_DEV, _PC_NAME_MAX) + 1; 
> > +struct dirent *de_buf = libxl__zalloc(gc, need); 
>  
> Is this thing with manually calculating the size of the structure really 
> necessary?  Could we not just declare "struct dirent de_buf" on the stack?

Calculating in above way is to allocate enough space for d_name, whereas
"struct dirent de_buf" won't allocate space for d_name (which is char *).

Codes for calling read_dir_r are often done like above.

- Chunyan

>  
> If it is necessary, it would be better to have it inside a function or 
> macro called "alloc_dirent" or something like that. 
>  
>  -George 
>  
>  


>From 771c99218a4704eb6a4850dfafb1cafad0798b9d Mon Sep 17 00:00:00 2001
From: Chunyan Liu 
Date: Mon, 14 Dec 2015 15:00:50 +0800
Subject: [PATCH 4/6] libxl pvusb API changes

* format fix: extra white space, line > 80, etc.
* return ERROR_FAILED instead of errno (>0) in sysfs_write_intf
* fix an error in libxl_ctrlport_to_device_usbdev

Signed-off-by: Chunyan Liu 
---
 tools/libxl/libxl_pvusb.c | 34 +-
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c
index cb25fa8..5f189d6 100644
--- a/tools/libxl/libxl_pvusb.c
+++ b/tools/libxl/libxl_pvusb.c
@@ -287,14 +287,15 @@ out:
 return;
 }
 
-static const char * vusb_be_from_xs_fe(libxl__gc *gc, const char *fe_path,
-   uint32_t tgt_domid) {
+static const char *vusb_be_from_xs_fe(libxl__gc *gc, const char *fe_path,
+  uint32_t tgt_domid)
+{
 const char *be_path;
 int r;
 uint32_t be_domid, fe_domid;
-
+
 r = libxl__xs_read_checked(gc, XBT_NULL, GCSPRINTF("%s/backend", fe_path),
- _path);
+   _path);
 if (r || !be_path) return NULL;
 
 /* Check to see that it has the proper form, and that fe_domid ==
@@ -302,11 +303,11 @@ static const char * vusb_be_from_xs_fe(libxl__gc *gc, 
const char *fe_path,
 r = sscanf(be_path, "/local/domain/%d/backend/vusb/%d",
_domid, _domid);
 
-if ( r != 2 || fe_domid != tgt_domid ) {
+if (r != 2 || fe_domid != tgt_domid) {
 LOG(ERROR, "Malformed backend, refusing to use");
 return NULL;
 }
-
+
 return be_path;
 }
 
@@ -810,7 +811,7 @@ static int libxl__device_usbdev_setdefault(libxl__gc *gc,
 } else {
 /* A controller was specified; look it up */
 const char *fe_path, *be_path, *tmp;
-
+
 fe_path = GCSPRINTF("%s/device/vusb/%d",
 libxl__xs_get_dompath(gc, domid),
 usbdev->ctrl);
@@ -828,7 +829,7 @@ static int libxl__device_usbdev_setdefault(libxl__gc *gc,
   be_path, usbdev->port),
 );
 if (rc) goto out;
-
+
 if (tmp && strcmp(tmp, "")) {
 LOG(ERROR, "The controller port isn't available");
 rc = ERROR_FAIL;
@@ -837,7 +838,7 @@ static int libxl__device_usbdev_setdefault(libxl__gc *gc,
 } else {
 /* No port was requested. Choose free port. */
 int i, ports;
-
+
 rc =