Re: [Xen-devel] Sub page Grant Table mappings
> On Tue, Dec 22, 2015 at 21:59 +0100, Mike Belopuhov wrote:
> > Hi,
> >
> > I'm trying to get grant table sub page mappings working on Xen 4.5.
> > I know there have been some changes in the trunk regarding moving src/
> > dst checks closer together, but I can't test this easily atm. Please
> > bear with me for a moment. Or tell me that it might have been broken
> > previously.
> >
> > What I'm trying to do is to map in a 2k cluster from the networking
> > stack (we call it an mbuf cluster, you might call it skb something)
> > onto the Netfront Rx ring. 2 clusters fit one page. Therefore for
> > one frame address which is a (PA >> 12) I might have 2 entries one
> > after the other, both with sub_page.length = 2048 but one with a
> > sub_page.page_off = 2048 and the other with a 0 offset. Both come
> > with (GTF_permit_access | GTF_sub_page) flags.
> >
> > When I do that, Xen stops liking me and says:
> >
> > (XEN) grant_table.c:2162:d0v1 copy dest out of bounds: 0 < 2048 || 90 > 2048
> > (XEN) grant_table.c:2162:d0v1 copy dest out of bounds: 0 < 2048 || 119 >
> > 2048
> > (XEN) grant_table.c:2162:d0v2 copy dest out of bounds: 0 < 2048 || 70 > 2048
> > (XEN) grant_table.c:2162:d0v2 copy dest out of bounds: 0 < 2048 || 119 >
> > 2048
> > (XEN) grant_table.c:2162:d0v2 copy dest out of bounds: 0 < 2048 || 119 >
> > 2048
> > ...
> >
> > The relevant code does this:
> >
> > if ( dest_is_gref )
> > {
> > unsigned dest_off, dest_len;
> > rc = __acquire_grant_for_copy(dd, op->dest.u.ref,
> > current->domain->domain_id, 0,
> > &d_frame, &d_pg, &dest_off,
> > &dest_len, 1);
> > if ( rc != GNTST_okay )
> > goto error_out;
> > have_d_grant = 1;
> > if ( op->dest.offset < dest_off ||
> > op->len > dest_len )
> > PIN_FAIL(error_out, GNTST_general_error,
> > "copy dest out of bounds: %d < %d || %d > %d\n",
> > op->dest.offset, dest_off,
> > op->len, dest_len);
> > }
> >
> > I fail to understand what am I doing wrong in this case. Any clues
> > will be greatly appreciated.
> >
> > 4k clusters mapped in as full_page mappings work as expected.
> >
> > Cheers,
> > Mike
Hi Andrew!
I'm sorry I have to fake up this reply. I'm not subscribe to the list
and either greylisting services or what not prevents me from receiving
your mail verbatim.
Thanks for your prompt response!
> I presume you are on x86 here.
>
Ack.
> Architecturally, a 4k page is the minimum granularity which permissions
> can be applied to. It is not possible to make a 2k block accessible,
> but an adjacent 2k block inaccessible.
>
Sure.
What I probably didn't realise is that this sub page mapping exists for
situations when one region of the page needs to be granted access to,
but not the whole page. I'm clearly trying to grant different regions
of the same page twice.
I would have figured this quickly out if I was dealing with different
page protections, but in this case page protections are supposed to be
the same.
> As a result, grant mapping of a subpage grant is prohibited, but you are
> (or at least should be) able to grant copy it.
>
> Can you describe precisely which domains are doing what in your example?
>
Just a domU trying to configure its Netfront's Rx ring.
> ~Andrew
Thanks a lot for your comments!
Cheers,
Mike
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
[Xen-devel] Sub page Grant Table mappings
Hi,
I'm trying to get grant table sub page mappings working on Xen 4.5.
I know there have been some changes in the trunk regarding moving src/
dst checks closer together, but I can't test this easily atm. Please
bear with me for a moment. Or tell me that it might have been broken
previously.
What I'm trying to do is to map in a 2k cluster from the networking
stack (we call it an mbuf cluster, you might call it skb something)
onto the Netfront Rx ring. 2 clusters fit one page. Therefore for
one frame address which is a (PA >> 12) I might have 2 entries one
after the other, both with sub_page.length = 2048 but one with a
sub_page.page_off = 2048 and the other with a 0 offset. Both come
with (GTF_permit_access | GTF_sub_page) flags.
When I do that, Xen stops liking me and says:
(XEN) grant_table.c:2162:d0v1 copy dest out of bounds: 0 < 2048 || 90 > 2048
(XEN) grant_table.c:2162:d0v1 copy dest out of bounds: 0 < 2048 || 119 > 2048
(XEN) grant_table.c:2162:d0v2 copy dest out of bounds: 0 < 2048 || 70 > 2048
(XEN) grant_table.c:2162:d0v2 copy dest out of bounds: 0 < 2048 || 119 > 2048
(XEN) grant_table.c:2162:d0v2 copy dest out of bounds: 0 < 2048 || 119 > 2048
...
The relevant code does this:
if ( dest_is_gref )
{
unsigned dest_off, dest_len;
rc = __acquire_grant_for_copy(dd, op->dest.u.ref,
current->domain->domain_id, 0,
&d_frame, &d_pg, &dest_off, &dest_len, 1);
if ( rc != GNTST_okay )
goto error_out;
have_d_grant = 1;
if ( op->dest.offset < dest_off ||
op->len > dest_len )
PIN_FAIL(error_out, GNTST_general_error,
"copy dest out of bounds: %d < %d || %d > %d\n",
op->dest.offset, dest_off,
op->len, dest_len);
}
I fail to understand what am I doing wrong in this case. Any clues
will be greatly appreciated.
4k clusters mapped in as full_page mappings work as expected.
Cheers,
Mike
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.
On Tue, Sep 29, 2015 at 13:23 +0100, Andrew Cooper wrote: > On 29/09/15 13:03, Mike Belopuhov wrote: > > On Mon, Sep 28, 2015 at 11:24 +0200, Mike Belopuhov wrote: > >> On Fri, Sep 25, 2015 at 01:12 -0600, Jan Beulich wrote: > >>>>>> On 22.09.15 at 16:02, wrote: > >>>> --- xen/include/public/arch-x86/pmu.h > >>>> +++ xen/include/public/arch-x86/pmu.h > >>> I fixed this up for you this time, but in the future please make sure > >>> you send patches in conventional format (applicable with patch's -p1 > >>> or whatever tool's equivalent). > >>> > >>> Thanks, Jan > >>> > >> Thanks, Jan. I'll keep that in mind. > > Hi Guys, > > > > Are we waiting for others to Ack the diff or is there anything > > I should do? > > > > With best regards, > > Mike > > This has been committed (staging and staging-4.6) > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=8d6ff9ef259e296e6aee32ad8840cc5081280e0d > > In both cases, they have not yet passed the automatic test gate, which > is why they have not appeared in master and stable-4.6 > > ~Andrew Oh, pardon my impatience then! And thanks a lot! ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.
On Mon, Sep 28, 2015 at 11:24 +0200, Mike Belopuhov wrote: > On Fri, Sep 25, 2015 at 01:12 -0600, Jan Beulich wrote: > > >>> On 22.09.15 at 16:02, wrote: > > > --- xen/include/public/arch-x86/pmu.h > > > +++ xen/include/public/arch-x86/pmu.h > > > > I fixed this up for you this time, but in the future please make sure > > you send patches in conventional format (applicable with patch's -p1 > > or whatever tool's equivalent). > > > > Thanks, Jan > > > > Thanks, Jan. I'll keep that in mind. Hi Guys, Are we waiting for others to Ack the diff or is there anything I should do? With best regards, Mike ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.
On Fri, Sep 25, 2015 at 01:12 -0600, Jan Beulich wrote: > >>> On 22.09.15 at 16:02, wrote: > > --- xen/include/public/arch-x86/pmu.h > > +++ xen/include/public/arch-x86/pmu.h > > I fixed this up for you this time, but in the future please make sure > you send patches in conventional format (applicable with patch's -p1 > or whatever tool's equivalent). > > Thanks, Jan > Thanks, Jan. I'll keep that in mind. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.
On Tue, Sep 22, 2015 at 09:00 -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 22, 2015 at 01:42:14PM +0200, Mike Belopuhov wrote: > > On Fri, Sep 18, 2015 at 10:13 -0400, Konrad Rzeszutek Wilk wrote: > > > On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote: > > > > > > > > > > > > On 09/18/2015 04:44 AM, Ian Campbell wrote: > > > > >On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote: > > > > > > > > > >A few words here about the methodology you used to determine the names > > > > >to > > > > >use would be useful to people looking back on this stuff in the future. > > > > > > > > > >Also it would be sensible to CC everyone whose name you are adding. > > > > >I've > > > > >added Keir since you already Ccd Boris and I didn't see any other names > > > > >after a quick glance. > > > > > > > > For changes that include my name (pmu files) > > > > Reviewed-by: Boris Ostrovsky > > > > > > Nack. Sorry Boris. > > > > > > Let me send an email to legal to make sure I am not spouting > > > nonsense. But in the meantime my understanding is that: > > > > > > Copyright (c) 2015 X,Y > > > > > > means that the copyright (ownership of intellectual property) > > > is owned by both X and Y. > > > > > > However we (Boris, and me) both signed this fancy document saying > > > that any work we do is owned by Oracle. It is OK to state > > > the authorship, but the ownership is Oracle's. > > > > > > If it was > > > > > > Copyright (c) 2015 X > > > > > > Author: Y > > > > > > Then that is OK. > > > > Hi Konrad, > > > > Any luck getting this sorted out? > > > Yes. > > Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved. > > > And no authorship. Thank you very much for clearing this up! > > > > Regards, > > Mike > > > > > > > > > > Not sure about format --- files in public directory largely use the same > > > > format as what Mike is suggesting here but most of newer files do what > > > > Konrad said (i.e. "Author" on a separate line). > > > > > > > > We will also want to apply similar patch to Linux tree (once this is > > > > done). > > > > Mike, do you mind doing it too? > > > > > > > > -boris > > > > ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.
The copyright line indicates a person, a group of people and/or a company granting rights stated in the license text and is a required part of the license. The year of the copyright is chosen to be the same as when the license has been applied to the file or when the file has been created in case there was no license. It is possible to update or add additional years if major changes have been done to the the file, but is generally not a requirement. Signed-off-by: Mike Belopuhov --- xen/include/public/arch-x86/pmu.h | 22 ++ xen/include/public/hvm/e820.h | 3 ++- xen/include/public/hvm/hvm_info_table.h | 2 ++ xen/include/public/hvm/hvm_op.h | 2 ++ xen/include/public/hvm/hvm_xs_strings.h | 2 ++ xen/include/public/hvm/params.h | 2 ++ xen/include/public/io/protocols.h | 2 ++ xen/include/public/physdev.h| 2 ++ xen/include/public/pmu.h| 22 ++ 9 files changed, 58 insertions(+), 1 deletion(-) diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch-x86/pmu.h index 1a53888..68ebf12 100644 --- xen/include/public/arch-x86/pmu.h +++ xen/include/public/arch-x86/pmu.h @@ -1,5 +1,27 @@ +/* + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved. + */ + #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__ #define __XEN_PUBLIC_ARCH_X86_PMU_H__ /* x86-specific PMU definitions */ diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h index 5bdc227..6c58a37 100644 --- xen/include/public/hvm/e820.h +++ xen/include/public/hvm/e820.h @@ -1,6 +1,5 @@ - /* * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or @@ -15,10 +14,12 @@ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER * DEALINGS IN THE SOFTWARE. + * + * Copyright (c) 2006, Keir Fraser */ #ifndef __XEN_PUBLIC_HVM_E820_H__ #define __XEN_PUBLIC_HVM_E820_H__ diff --git xen/include/public/hvm/hvm_info_table.h xen/include/public/hvm/hvm_info_table.h index 36085fa..9e3f807 100644 --- xen/include/public/hvm/hvm_info_table.h +++ xen/include/public/hvm/hvm_info_table.h @@ -18,10 +18,12 @@ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER * DEALINGS IN THE SOFTWARE. + * + * Copyright (c) 2006, Keir Fraser */ #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__ #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__ diff --git xen/include/public/hvm/hvm_op.h xen/include/public/hvm/hvm_op.h index 014546a..1606185 100644 --- xen/include/public/hvm/hvm_op.h +++ xen/include/public/hvm/hvm_op.h @@ -14,10 +14,12 @@ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER * DEALINGS IN THE SOFTWARE. + * + * Copyright (c) 2007, Keir Fraser */ #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__ #define __XEN_PUBLIC_HVM_HVM_OP_H__ diff --git xen/include/public/hvm/hvm_xs_strings.h xen/include/public/hvm/hvm_xs_strings.h index 8aec935..
Re: [Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.
On Fri, Sep 18, 2015 at 10:13 -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote: > > > > > > On 09/18/2015 04:44 AM, Ian Campbell wrote: > > >On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote: > > > > > >A few words here about the methodology you used to determine the names to > > >use would be useful to people looking back on this stuff in the future. > > > > > >Also it would be sensible to CC everyone whose name you are adding. I've > > >added Keir since you already Ccd Boris and I didn't see any other names > > >after a quick glance. > > > > For changes that include my name (pmu files) > > Reviewed-by: Boris Ostrovsky > > Nack. Sorry Boris. > > Let me send an email to legal to make sure I am not spouting > nonsense. But in the meantime my understanding is that: > > Copyright (c) 2015 X,Y > > means that the copyright (ownership of intellectual property) > is owned by both X and Y. > > However we (Boris, and me) both signed this fancy document saying > that any work we do is owned by Oracle. It is OK to state > the authorship, but the ownership is Oracle's. > > If it was > > Copyright (c) 2015 X > > Author: Y > > Then that is OK. Hi Konrad, Any luck getting this sorted out? Regards, Mike > > > > Not sure about format --- files in public directory largely use the same > > format as what Mike is suggesting here but most of newer files do what > > Konrad said (i.e. "Author" on a separate line). > > > > We will also want to apply similar patch to Linux tree (once this is done). > > Mike, do you mind doing it too? > > > > -boris > > ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.
Signed-off-by: Mike Belopuhov --- xen/include/public/arch-x86/pmu.h | 22 ++ xen/include/public/hvm/e820.h | 3 ++- xen/include/public/hvm/hvm_info_table.h | 2 ++ xen/include/public/hvm/hvm_op.h | 2 ++ xen/include/public/hvm/hvm_xs_strings.h | 2 ++ xen/include/public/hvm/params.h | 2 ++ xen/include/public/io/protocols.h | 2 ++ xen/include/public/physdev.h| 2 ++ xen/include/public/pmu.h| 22 ++ 9 files changed, 58 insertions(+), 1 deletion(-) diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch-x86/pmu.h index 1a53888..cb05121 100644 --- xen/include/public/arch-x86/pmu.h +++ xen/include/public/arch-x86/pmu.h @@ -1,5 +1,27 @@ +/* + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp. + */ + #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__ #define __XEN_PUBLIC_ARCH_X86_PMU_H__ /* x86-specific PMU definitions */ diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h index 5bdc227..6c58a37 100644 --- xen/include/public/hvm/e820.h +++ xen/include/public/hvm/e820.h @@ -1,6 +1,5 @@ - /* * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or @@ -15,10 +14,12 @@ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER * DEALINGS IN THE SOFTWARE. + * + * Copyright (c) 2006, Keir Fraser */ #ifndef __XEN_PUBLIC_HVM_E820_H__ #define __XEN_PUBLIC_HVM_E820_H__ diff --git xen/include/public/hvm/hvm_info_table.h xen/include/public/hvm/hvm_info_table.h index 36085fa..9e3f807 100644 --- xen/include/public/hvm/hvm_info_table.h +++ xen/include/public/hvm/hvm_info_table.h @@ -18,10 +18,12 @@ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER * DEALINGS IN THE SOFTWARE. + * + * Copyright (c) 2006, Keir Fraser */ #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__ #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__ diff --git xen/include/public/hvm/hvm_op.h xen/include/public/hvm/hvm_op.h index 014546a..1606185 100644 --- xen/include/public/hvm/hvm_op.h +++ xen/include/public/hvm/hvm_op.h @@ -14,10 +14,12 @@ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER * DEALINGS IN THE SOFTWARE. + * + * Copyright (c) 2007, Keir Fraser */ #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__ #define __XEN_PUBLIC_HVM_HVM_OP_H__ diff --git xen/include/public/hvm/hvm_xs_strings.h xen/include/public/hvm/hvm_xs_strings.h index 8aec935..146b0b0 100644 --- xen/include/public/hvm/hvm_xs_strings.h +++ xen/include/public/hvm/hvm_xs_strings.h @@ -18,10 +18,12 @@ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER * DEALINGS IN THE SOFTWARE. + * + * Copy
Re: [Xen-devel] Missing copyright in the Xen header files
On Thu, Sep 10, 2015 at 17:05 +, Lars Kurth wrote: > > > On 10/09/2015 17:26, "Roger Pau Monné" wrote: > > >CCing Lars (the community manager). > > > >El 09/09/15 a les 14.11, Mike Belopuhov ha escrit: > >> Hi, > >> > >> We're in the process of porting Xen PVHVM drivers to OpenBSD > >> and have come across missing copyright lines on some of Xen > >> interface header files, for instance: > >> > >> > >>https://svnweb.freebsd.org/base/head/sys/xen/interface/hvm/hvm_op.h?revis > >>ion=251767&view=markup > >> > >>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/incl > >>ude/xen/interface/hvm/hvm_op.h > >> > >> This is not common and we have some concerns whether it is > >> valid to release source code w/o stating who has granted those > >> rights that are stated in the license. > >> > >> Would it be possible to amend the license and add a Copyright > >> line mentioning Xen project or an individual contributor like > >> it's done it othe places in the Xen source code? > Hi Lars, > I don't think this should be an issue. The (c) holders are all the people > who contributed to a specific file and can be retrieved from the git > history for the file. Each contributor explicitly agrees to the DCO, which > means he/she retains the (c) to the file. But copying the file, does imply > the loss of the change-history, so it makes sense in such situations to > update the license statement. > Precisely. > The work just needs to be done by someone. > If we could use a stub that you'd be fine with -- it will be superb, more than we could ask for. Otherwise I have to pick the Xen committer and year based on the git history, i.e. for the hvm_op.h this would be[1]: "Copyright (c) 2007 Keir Fraser" But having this in my repo and then in, say, OpenBSD, but not in Xen git, FreeBSD or Linux seems kinda silly. > Best Regards > Lars > [1] http://xenbits.xen.org/gitweb/?p=xen.git;a=history;f=xen/include/public/hvm/hvm_op.h With kind regards, Mike ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] Missing copyright in the Xen header files
Hi, We're in the process of porting Xen PVHVM drivers to OpenBSD and have come across missing copyright lines on some of Xen interface header files, for instance: https://svnweb.freebsd.org/base/head/sys/xen/interface/hvm/hvm_op.h?revision=251767&view=markup https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/xen/interface/hvm/hvm_op.h This is not common and we have some concerns whether it is valid to release source code w/o stating who has granted those rights that are stated in the license. Would it be possible to amend the license and add a Copyright line mentioning Xen project or an individual contributor like it's done it othe places in the Xen source code? With kind regards, Mike ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
