Re: [Xen-devel] [PATCH] stubdom: remove EXTRA_CFLAGS meant for building tools
Wei Liu, on Tue 08 Nov 2016 10:47:18 +, wrote: > On Tue, Nov 08, 2016 at 10:09:41AM +0100, Juergen Gross wrote: > > When building stubdoms EXTRA_CFLAGS_XEN_TOOLS and > > EXTRA_CFLAGS_QEMU_TRADITIONAL should be cleared as they might contain > > flags not suitable for all stubdom builds (e.g. "-m64" often to be > > found in $RPM_OPT_FLAGS will break building 32 bit stubdoms). > > > > Signed-off-by: Juergen Gross> > --- > > stubdom/Makefile | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/stubdom/Makefile b/stubdom/Makefile > > index 2921f30..c89e353 100644 > > --- a/stubdom/Makefile > > +++ b/stubdom/Makefile > > @@ -4,6 +4,10 @@ MINI_OS = $(XEN_ROOT)/extras/mini-os > > export XEN_ROOT > > export XEN_OS=MiniOS > > > > +# Remove flags which are meant for tools, e.g. "-m64" > > +export EXTRA_CFLAGS_XEN_TOOLS= > > +export EXTRA_CFLAGS_QEMU_TRADITIONAL= > > + > > I can't think of a better way to deal with this. This is in line with > how it is done in firmware build, so > > Acked-by: Wei Liu Acked-by: Samuel Thibault > > export stubdom=y > > export debug=y > > # Moved from config/StdGNU.mk > > -- > > 2.6.6 > > > -- Samuel * D a decide de peter un cable dans son rapport de pfp et il a bien raison ;-) tu vas dire quoi ? j'ai mis les paroles de "le coq est mort" en en-tete -+- #ens-mim et la peufeupeu -+- ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] stubdom: remove EXTRA_CFLAGS meant for building tools
On Tue, Nov 08, 2016 at 10:09:41AM +0100, Juergen Gross wrote: > When building stubdoms EXTRA_CFLAGS_XEN_TOOLS and > EXTRA_CFLAGS_QEMU_TRADITIONAL should be cleared as they might contain > flags not suitable for all stubdom builds (e.g. "-m64" often to be > found in $RPM_OPT_FLAGS will break building 32 bit stubdoms). > > Signed-off-by: Juergen Gross> --- > stubdom/Makefile | 4 > 1 file changed, 4 insertions(+) > > diff --git a/stubdom/Makefile b/stubdom/Makefile > index 2921f30..c89e353 100644 > --- a/stubdom/Makefile > +++ b/stubdom/Makefile > @@ -4,6 +4,10 @@ MINI_OS = $(XEN_ROOT)/extras/mini-os > export XEN_ROOT > export XEN_OS=MiniOS > > +# Remove flags which are meant for tools, e.g. "-m64" > +export EXTRA_CFLAGS_XEN_TOOLS= > +export EXTRA_CFLAGS_QEMU_TRADITIONAL= > + I can't think of a better way to deal with this. This is in line with how it is done in firmware build, so Acked-by: Wei Liu > export stubdom=y > export debug=y > # Moved from config/StdGNU.mk > -- > 2.6.6 > ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [PATCH] stubdom: remove EXTRA_CFLAGS meant for building tools
When building stubdoms EXTRA_CFLAGS_XEN_TOOLS and EXTRA_CFLAGS_QEMU_TRADITIONAL should be cleared as they might contain flags not suitable for all stubdom builds (e.g. "-m64" often to be found in $RPM_OPT_FLAGS will break building 32 bit stubdoms). Signed-off-by: Juergen Gross--- stubdom/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/stubdom/Makefile b/stubdom/Makefile index 2921f30..c89e353 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -4,6 +4,10 @@ MINI_OS = $(XEN_ROOT)/extras/mini-os export XEN_ROOT export XEN_OS=MiniOS +# Remove flags which are meant for tools, e.g. "-m64" +export EXTRA_CFLAGS_XEN_TOOLS= +export EXTRA_CFLAGS_QEMU_TRADITIONAL= + export stubdom=y export debug=y # Moved from config/StdGNU.mk -- 2.6.6 ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel