Re: [Xen-devel] [PATCH] toolcore: Build in rumprun environment too

2017-10-16 Thread Julien Grall 



On 16/10/17 11:30, Wei Liu wrote:

On Mon, Oct 16, 2017 at 11:17:12AM +0100, Ian Jackson wrote:

Otherwise,
   f942a9b4a12081d5f9a4679d06e88cb5d503396e
   xentoolcore_restrict_all: "Implement" for xenstore
breaks the build of the tools inside rumprun.

Signed-off-by: Ian Jackson 


Acked-by: Wei Liu 


Release-acked-by: Julien Grall 

Cheers,



___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel



--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] toolcore: Build in rumprun environment too

2017-10-16 Thread Ian Jackson 
Otherwise,
  f942a9b4a12081d5f9a4679d06e88cb5d503396e
  xentoolcore_restrict_all: "Implement" for xenstore
breaks the build of the tools inside rumprun.

toolcore is in libs, so we need to add the CONFIG_RUMP special case to
tools/libs/Makefile and add toolcore there.

Signed-off-by: Ian Jackson 
CC: Wei Liu 
---
v2: toolcore is in libs
---
 tools/Makefile  | 2 +-
 tools/libs/Makefile | 4 
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/Makefile b/tools/Makefile
index 03d326a..84d6e3b 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -49,7 +49,7 @@ SUBDIRS-$(OCAML_TOOLS) += ocaml
 endif
 
 ifeq ($(CONFIG_RUMP),y)
-SUBDIRS-y := libxc xenstore
+SUBDIRS-y := libs libxc xenstore
 endif
 
 # For the sake of linking, set the sys-root
diff --git a/tools/libs/Makefile b/tools/libs/Makefile
index ea9a64d..88901e7 100644
--- a/tools/libs/Makefile
+++ b/tools/libs/Makefile
@@ -10,4 +10,8 @@ SUBDIRS-y += call
 SUBDIRS-y += foreignmemory
 SUBDIRS-y += devicemodel
 
+ifeq ($(CONFIG_RUMP),y)
+SUBDIRS-y := toolcore
+endif
+
 all clean install distclean uninstall: %: subdirs-%
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] toolcore: Build in rumprun environment too

2017-10-16 Thread Wei Liu 
On Mon, Oct 16, 2017 at 12:23:12PM +0100, Ian Jackson wrote:
> Otherwise,
>   f942a9b4a12081d5f9a4679d06e88cb5d503396e
>   xentoolcore_restrict_all: "Implement" for xenstore
> breaks the build of the tools inside rumprun.
> 
> toolcore is in libs, so we need to add the CONFIG_RUMP special case to
> tools/libs/Makefile and add toolcore there.
> 
> Signed-off-by: Ian Jackson 

Acked-by: Wei Liu 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] toolcore: Build in rumprun environment too

2017-10-16 Thread Wei Liu 
On Mon, Oct 16, 2017 at 11:17:12AM +0100, Ian Jackson wrote:
> Otherwise,
>   f942a9b4a12081d5f9a4679d06e88cb5d503396e
>   xentoolcore_restrict_all: "Implement" for xenstore
> breaks the build of the tools inside rumprun.
> 
> Signed-off-by: Ian Jackson 

Acked-by: Wei Liu 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] toolcore: Build in rumprun environment too

2017-10-16 Thread Ian Jackson 
Otherwise,
  f942a9b4a12081d5f9a4679d06e88cb5d503396e
  xentoolcore_restrict_all: "Implement" for xenstore
breaks the build of the tools inside rumprun.

Signed-off-by: Ian Jackson 
CC: Wei Liu 
---
 tools/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/Makefile b/tools/Makefile
index 03d326a..59d1c04 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -49,7 +49,7 @@ SUBDIRS-$(OCAML_TOOLS) += ocaml
 endif
 
 ifeq ($(CONFIG_RUMP),y)
-SUBDIRS-y := libxc xenstore
+SUBDIRS-y := toolcore libxc xenstore
 endif
 
 # For the sake of linking, set the sys-root
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel