Re: [Xen-devel] [PATCH] x86/iommu: add missing break

[Andrew Cooper]

On 09/02/17 17:55, Roger Pau Monne wrote:
> Ccing the maintainers...
>
> On Thu, Feb 09, 2017 at 05:53:28PM +, Roger Pau Monne wrote:
>> 50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still 
>> not
>> adding IOMMU entries for p2m_mmio_direct regions.

Spotted by Coverity

>>
>> Reported-by: Andrew Cooper 
>> Signed-off-by: Roger Pau Monné 

Reviewed-by: Andrew Cooper 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] x86/iommu: add missing break

[Roger Pau Monne]

Ccing the maintainers...

On Thu, Feb 09, 2017 at 05:53:28PM +, Roger Pau Monne wrote:
> 50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not
> adding IOMMU entries for p2m_mmio_direct regions.
> 
> Reported-by: Andrew Cooper 
> Signed-off-by: Roger Pau Monné 
> ---
> ---
>  xen/include/asm-x86/p2m.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
> index 173a6f8..c68ff58 100644
> --- a/xen/include/asm-x86/p2m.h
> +++ b/xen/include/asm-x86/p2m.h
> @@ -819,6 +819,7 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t 
> p2mt, mfn_t mfn)
>  flags = IOMMUF_readable;
>  if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) )
>  flags |= IOMMUF_writable;
> +break;
>  default:
>  flags = 0;
>  break;
> -- 
> 2.10.1 (Apple Git-78)
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] x86/iommu: add missing break

[Roger Pau Monne]

50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not
adding IOMMU entries for p2m_mmio_direct regions.

Reported-by: Andrew Cooper 
Signed-off-by: Roger Pau Monné 
---
---
 xen/include/asm-x86/p2m.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
index 173a6f8..c68ff58 100644
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -819,6 +819,7 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t 
p2mt, mfn_t mfn)
 flags = IOMMUF_readable;
 if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) )
 flags |= IOMMUF_writable;
+break;
 default:
 flags = 0;
 break;
-- 
2.10.1 (Apple Git-78)


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel