Re: [Xen-devel] [PATCH 0/6] mce: fix coding style

2017-09-13 Thread Andrew Cooper 
On 13/09/17 11:58, Wei Liu wrote:
> On Mon, Sep 11, 2017 at 03:57:52PM +0800, Haozhong Zhang wrote:
>> Some files in xen/arch/x86/cpu/mcheck use mixed coding styles. Unify
>> them to Xen hypervisor coding style. For mctelem.c which is entirely
>> in one coding style, only remove extra blanks.
>>
>> No functional change is introduced.
>>
>> Haozhong Zhang (6):
>>   x86/mce: adapt mce.{c,h} to Xen hypervisor coding style
>>   x86/vmce: adapt vmce.c to Xen hypervisor coding style
>>   x86/mce: adapt mcation.c to Xen hypervisor coding style
>>   x86/mce: adapt mce_intel.c to Xen hypervisor coding style
>>   x86/mce: add emacs block to mctelem.c
>>   x86/mce: remove trailing spaces in mctelem.c
> mce*.[ch] seem to have been imported from 2.6.x Linux more than 10 years
> ago. I'm not sure if we care enough to stay close to Linux at this
> stage.
>
> Code-wise:
>
> Reviewed-by: Wei Liu 

Acked-by: Andrew Cooper 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 0/6] mce: fix coding style

2017-09-13 Thread Wei Liu 
On Mon, Sep 11, 2017 at 03:57:52PM +0800, Haozhong Zhang wrote:
> Some files in xen/arch/x86/cpu/mcheck use mixed coding styles. Unify
> them to Xen hypervisor coding style. For mctelem.c which is entirely
> in one coding style, only remove extra blanks.
> 
> No functional change is introduced.
> 
> Haozhong Zhang (6):
>   x86/mce: adapt mce.{c,h} to Xen hypervisor coding style
>   x86/vmce: adapt vmce.c to Xen hypervisor coding style
>   x86/mce: adapt mcation.c to Xen hypervisor coding style
>   x86/mce: adapt mce_intel.c to Xen hypervisor coding style
>   x86/mce: add emacs block to mctelem.c
>   x86/mce: remove trailing spaces in mctelem.c

mce*.[ch] seem to have been imported from 2.6.x Linux more than 10 years
ago. I'm not sure if we care enough to stay close to Linux at this
stage.

Code-wise:

Reviewed-by: Wei Liu 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 0/6] mce: fix coding style

2017-09-11 Thread Haozhong Zhang 
Some files in xen/arch/x86/cpu/mcheck use mixed coding styles. Unify
them to Xen hypervisor coding style. For mctelem.c which is entirely
in one coding style, only remove extra blanks.

No functional change is introduced.

Haozhong Zhang (6):
  x86/mce: adapt mce.{c,h} to Xen hypervisor coding style
  x86/vmce: adapt vmce.c to Xen hypervisor coding style
  x86/mce: adapt mcation.c to Xen hypervisor coding style
  x86/mce: adapt mce_intel.c to Xen hypervisor coding style
  x86/mce: add emacs block to mctelem.c
  x86/mce: remove trailing spaces in mctelem.c

 xen/arch/x86/cpu/mcheck/mcaction.c  |  74 ++---
 xen/arch/x86/cpu/mcheck/mce.c   | 536 
 xen/arch/x86/cpu/mcheck/mce.h   |  21 +-
 xen/arch/x86/cpu/mcheck/mce_intel.c | 262 ++
 xen/arch/x86/cpu/mcheck/mctelem.c   |  14 +-
 xen/arch/x86/cpu/mcheck/vmce.c  |   5 +-
 6 files changed, 509 insertions(+), 403 deletions(-)

-- 
2.11.0


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel