Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
On Thu, Feb 09, 2017 at 09:51:48AM +0800, Zhang Chen wrote: > > > On 02/09/2017 12:54 AM, Wei Liu wrote: > > And CC Zhangchen > > Thanks, I will apply this patch set before test my patch. > This is not yet the final form. Please need to wait until this work gets applied. Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
On 02/09/2017 12:54 AM, Wei Liu wrote: And CC Zhangchen Thanks, I will apply this patch set before test my patch. Zhang Chen On Wed, Feb 08, 2017 at 02:35:27PM +, Wei Liu wrote: Cc Yi Sun as well. Haozhong and Yi: This is just a heads-up -- Juergen from SuSE took the time to split libxl.c so things are better organised. It's likely this series will go in before yours, so you will then need to rebase your series. I don't expect there to be much breakage because it is all mechanical, but rebasing is still work for you. Let us know if you have any concern so that we can coordinate this. Wei. On Wed, Feb 08, 2017 at 02:13:37PM +0100, Juergen Gross wrote: libxl.c has become rather large. Split it up into multiple files. Code movement only. No functional change intended. Juergen Gross (9): libxl: adjust copyright comment of libxl.c libxl: carve out cpupool specific functions from libxl.c libxl: carve out scheduler specific functions from libxl.c libxl: carve out disk specific functions from libxl.c libxl: carve out console specific functions from libxl.c libxl: carve out memory specific functions from libxl.c libxl: move device specific functions out of libxl.c libxl: carve out tmem specific functions from libxl.c libxl: carve out domain specific functions from libxl.c tools/libxl/Makefile |4 +- tools/libxl/libxl.c | 6252 +- tools/libxl/libxl_console.c | 862 ++ tools/libxl/libxl_cpupool.c | 443 +++ tools/libxl/libxl_device.c | 435 ++- tools/libxl/libxl_disk.c | 1258 + tools/libxl/libxl_domain.c | 1744 tools/libxl/libxl_internal.h |8 +- tools/libxl/libxl_mem.c | 601 tools/libxl/libxl_sched.c| 915 +++ tools/libxl/libxl_tmem.c | 167 ++ 11 files changed, 6424 insertions(+), 6265 deletions(-) create mode 100644 tools/libxl/libxl_console.c create mode 100644 tools/libxl/libxl_cpupool.c create mode 100644 tools/libxl/libxl_disk.c create mode 100644 tools/libxl/libxl_domain.c create mode 100644 tools/libxl/libxl_mem.c create mode 100644 tools/libxl/libxl_sched.c create mode 100644 tools/libxl/libxl_tmem.c -- 2.10.2 . -- Thanks Zhang Chen ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
On 02/08/17 14:35 +, Wei Liu wrote: Cc Yi Sun as well. Haozhong and Yi: This is just a heads-up -- Juergen from SuSE took the time to split libxl.c so things are better organised. It's likely this series will go in before yours, so you will then need to rebase your series. I don't expect there to be much breakage because it is all mechanical, but rebasing is still work for you. Thank you for the remind. As this series does not introduce functional changes and most of libxl changes for NVDIMM already went into a separate libxl_nvdimm.c in my patches, the rebase should be trivial for me. Haozhong Let us know if you have any concern so that we can coordinate this. Wei. On Wed, Feb 08, 2017 at 02:13:37PM +0100, Juergen Gross wrote: libxl.c has become rather large. Split it up into multiple files. Code movement only. No functional change intended. Juergen Gross (9): libxl: adjust copyright comment of libxl.c libxl: carve out cpupool specific functions from libxl.c libxl: carve out scheduler specific functions from libxl.c libxl: carve out disk specific functions from libxl.c libxl: carve out console specific functions from libxl.c libxl: carve out memory specific functions from libxl.c libxl: move device specific functions out of libxl.c libxl: carve out tmem specific functions from libxl.c libxl: carve out domain specific functions from libxl.c tools/libxl/Makefile |4 +- tools/libxl/libxl.c | 6252 +- tools/libxl/libxl_console.c | 862 ++ tools/libxl/libxl_cpupool.c | 443 +++ tools/libxl/libxl_device.c | 435 ++- tools/libxl/libxl_disk.c | 1258 + tools/libxl/libxl_domain.c | 1744 tools/libxl/libxl_internal.h |8 +- tools/libxl/libxl_mem.c | 601 tools/libxl/libxl_sched.c| 915 +++ tools/libxl/libxl_tmem.c | 167 ++ 11 files changed, 6424 insertions(+), 6265 deletions(-) create mode 100644 tools/libxl/libxl_console.c create mode 100644 tools/libxl/libxl_cpupool.c create mode 100644 tools/libxl/libxl_disk.c create mode 100644 tools/libxl/libxl_domain.c create mode 100644 tools/libxl/libxl_mem.c create mode 100644 tools/libxl/libxl_sched.c create mode 100644 tools/libxl/libxl_tmem.c -- 2.10.2 ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
And CC Zhangchen On Wed, Feb 08, 2017 at 02:35:27PM +, Wei Liu wrote: > Cc Yi Sun as well. > > Haozhong and Yi: This is just a heads-up -- Juergen from SuSE took the > time to split libxl.c so things are better organised. It's likely this > series will go in before yours, so you will then need to rebase your > series. I don't expect there to be much breakage because it is all > mechanical, but rebasing is still work for you. > > Let us know if you have any concern so that we can coordinate this. > > Wei. > > On Wed, Feb 08, 2017 at 02:13:37PM +0100, Juergen Gross wrote: > > libxl.c has become rather large. Split it up into multiple files. > > > > Code movement only. No functional change intended. > > > > Juergen Gross (9): > > libxl: adjust copyright comment of libxl.c > > libxl: carve out cpupool specific functions from libxl.c > > libxl: carve out scheduler specific functions from libxl.c > > libxl: carve out disk specific functions from libxl.c > > libxl: carve out console specific functions from libxl.c > > libxl: carve out memory specific functions from libxl.c > > libxl: move device specific functions out of libxl.c > > libxl: carve out tmem specific functions from libxl.c > > libxl: carve out domain specific functions from libxl.c > > > > tools/libxl/Makefile |4 +- > > tools/libxl/libxl.c | 6252 > > +- > > tools/libxl/libxl_console.c | 862 ++ > > tools/libxl/libxl_cpupool.c | 443 +++ > > tools/libxl/libxl_device.c | 435 ++- > > tools/libxl/libxl_disk.c | 1258 + > > tools/libxl/libxl_domain.c | 1744 > > tools/libxl/libxl_internal.h |8 +- > > tools/libxl/libxl_mem.c | 601 > > tools/libxl/libxl_sched.c| 915 +++ > > tools/libxl/libxl_tmem.c | 167 ++ > > 11 files changed, 6424 insertions(+), 6265 deletions(-) > > create mode 100644 tools/libxl/libxl_console.c > > create mode 100644 tools/libxl/libxl_cpupool.c > > create mode 100644 tools/libxl/libxl_disk.c > > create mode 100644 tools/libxl/libxl_domain.c > > create mode 100644 tools/libxl/libxl_mem.c > > create mode 100644 tools/libxl/libxl_sched.c > > create mode 100644 tools/libxl/libxl_tmem.c > > > > -- > > 2.10.2 > > ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
On 08/02/17 17:12, Ian Jackson wrote:
> Juergen Gross writes ("Re: [PATCH 0/9] libxl: spolit up libxl.c"):
>> Okay, more precise wording:
>
> Thanks.
>
>> Changes are:
>> - moving functions into new or existing sources
>> - modification of Copyright comment
>
>> - made two functions non-static: libxl__get_memory_target(),
>> xcinfo2xlinfo()
>> - made one function static: libxl__device_frontend_path()
>
> Can you split these out into their own patch(es) ?
>
>> - removed some trailing spaces in moved code
>
> And split this one out too ?
>
> Sorry to be pernickety, but this will make it much easier to check
> what you have done automatically, without trying read the whole thing
> by eye !
Okay.
Juergen
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
Juergen Gross writes ("Re: [PATCH 0/9] libxl: spolit up libxl.c"):
> Okay, more precise wording:
Thanks.
> Changes are:
> - moving functions into new or existing sources
> - modification of Copyright comment
> - made two functions non-static: libxl__get_memory_target(),
> xcinfo2xlinfo()
> - made one function static: libxl__device_frontend_path()
Can you split these out into their own patch(es) ?
> - removed some trailing spaces in moved code
And split this one out too ?
Sorry to be pernickety, but this will make it much easier to check
what you have done automatically, without trying read the whole thing
by eye !
Thanks,
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
On 08/02/17 15:33, Ian Jackson wrote:
> Juergen Gross writes ("[PATCH 0/9] libxl: spolit up libxl.c"):
>> Code movement only. No functional change intended.
>
> This statement is not true because
>
>> Juergen Gross (9):
>> libxl: adjust copyright comment of libxl.c
>
> ... that patch is not just code motion.
Okay, more precise wording:
Changes are:
- moving functions into new or existing sources
- modification of Copyright comment
- made two functions non-static: libxl__get_memory_target(),
xcinfo2xlinfo()
- made one function static: libxl__device_frontend_path()
- modified Makefile to include new source files
- removed some trailing spaces in moved code
- reordered some functions in new sources to get rid of some local
prototypes
> Can you please double-check, and explicitly enumerate the other
> intentional changes ? Obviously there is an intentional change to the
> Makefile, and the copyright header is duplicated in each case.
>
> Are there any other changes which are not precisely moving a block of
> lines from libxl.c into other file(s), completely unchanged ?
>
> Did you have to make any functions non-static ?
Juergen
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
Cc Yi Sun as well. Haozhong and Yi: This is just a heads-up -- Juergen from SuSE took the time to split libxl.c so things are better organised. It's likely this series will go in before yours, so you will then need to rebase your series. I don't expect there to be much breakage because it is all mechanical, but rebasing is still work for you. Let us know if you have any concern so that we can coordinate this. Wei. On Wed, Feb 08, 2017 at 02:13:37PM +0100, Juergen Gross wrote: > libxl.c has become rather large. Split it up into multiple files. > > Code movement only. No functional change intended. > > Juergen Gross (9): > libxl: adjust copyright comment of libxl.c > libxl: carve out cpupool specific functions from libxl.c > libxl: carve out scheduler specific functions from libxl.c > libxl: carve out disk specific functions from libxl.c > libxl: carve out console specific functions from libxl.c > libxl: carve out memory specific functions from libxl.c > libxl: move device specific functions out of libxl.c > libxl: carve out tmem specific functions from libxl.c > libxl: carve out domain specific functions from libxl.c > > tools/libxl/Makefile |4 +- > tools/libxl/libxl.c | 6252 > +- > tools/libxl/libxl_console.c | 862 ++ > tools/libxl/libxl_cpupool.c | 443 +++ > tools/libxl/libxl_device.c | 435 ++- > tools/libxl/libxl_disk.c | 1258 + > tools/libxl/libxl_domain.c | 1744 > tools/libxl/libxl_internal.h |8 +- > tools/libxl/libxl_mem.c | 601 > tools/libxl/libxl_sched.c| 915 +++ > tools/libxl/libxl_tmem.c | 167 ++ > 11 files changed, 6424 insertions(+), 6265 deletions(-) > create mode 100644 tools/libxl/libxl_console.c > create mode 100644 tools/libxl/libxl_cpupool.c > create mode 100644 tools/libxl/libxl_disk.c > create mode 100644 tools/libxl/libxl_domain.c > create mode 100644 tools/libxl/libxl_mem.c > create mode 100644 tools/libxl/libxl_sched.c > create mode 100644 tools/libxl/libxl_tmem.c > > -- > 2.10.2 > ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
Juergen Gross writes ("[PATCH 0/9] libxl: spolit up libxl.c"):
> Code movement only. No functional change intended.
This statement is not true because
> Juergen Gross (9):
> libxl: adjust copyright comment of libxl.c
... that patch is not just code motion.
Can you please double-check, and explicitly enumerate the other
intentional changes ? Obviously there is an intentional change to the
Makefile, and the copyright header is duplicated in each case.
Are there any other changes which are not precisely moving a block of
lines from libxl.c into other file(s), completely unchanged ?
Did you have to make any functions non-static ?
Thanks,
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
[Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c
libxl.c has become rather large. Split it up into multiple files. Code movement only. No functional change intended. Juergen Gross (9): libxl: adjust copyright comment of libxl.c libxl: carve out cpupool specific functions from libxl.c libxl: carve out scheduler specific functions from libxl.c libxl: carve out disk specific functions from libxl.c libxl: carve out console specific functions from libxl.c libxl: carve out memory specific functions from libxl.c libxl: move device specific functions out of libxl.c libxl: carve out tmem specific functions from libxl.c libxl: carve out domain specific functions from libxl.c tools/libxl/Makefile |4 +- tools/libxl/libxl.c | 6252 +- tools/libxl/libxl_console.c | 862 ++ tools/libxl/libxl_cpupool.c | 443 +++ tools/libxl/libxl_device.c | 435 ++- tools/libxl/libxl_disk.c | 1258 + tools/libxl/libxl_domain.c | 1744 tools/libxl/libxl_internal.h |8 +- tools/libxl/libxl_mem.c | 601 tools/libxl/libxl_sched.c| 915 +++ tools/libxl/libxl_tmem.c | 167 ++ 11 files changed, 6424 insertions(+), 6265 deletions(-) create mode 100644 tools/libxl/libxl_console.c create mode 100644 tools/libxl/libxl_cpupool.c create mode 100644 tools/libxl/libxl_disk.c create mode 100644 tools/libxl/libxl_domain.c create mode 100644 tools/libxl/libxl_mem.c create mode 100644 tools/libxl/libxl_sched.c create mode 100644 tools/libxl/libxl_tmem.c -- 2.10.2 ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
