Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Razvan Cojocaru 
On 01/27/2016 10:06 PM, Tamas K Lengyel wrote:
> The altp2m subsystem in its current form uses its own HVMOP hypercall to set
> mem_access permissions, duplicating some of the code already present for
> setting regular mem_access permissions. In this patch we consolidate the two,
> deprecate the HVMOP hypercall and update the corresponding tools.
> 
> Signed-off-by: Tamas K Lengyel 
> Cc: Ian Jackson 
> Cc: Stefano Stabellini 
> Cc: Ian Campbell 
> Cc: Wei Liu 
> Cc: Razvan Cojocaru 
> Cc: Stefano Stabellini 
> Cc: Keir Fraser 
> Cc: Jan Beulich 
> Cc: Andrew Cooper 
> Cc: George Dunlap 
> ---
>  tools/libxc/include/xenctrl.h   |   5 +-
>  tools/libxc/xc_altp2m.c |  25 --
>  tools/libxc/xc_mem_access.c |  14 +--
>  tools/tests/xen-access/xen-access.c |  53 ---
>  xen/arch/arm/p2m.c  |   9 +-
>  xen/arch/x86/hvm/hvm.c  |   9 --
>  xen/arch/x86/mm/p2m.c   | 169 
> 
>  xen/common/mem_access.c |   2 +-
>  xen/include/asm-x86/p2m.h   |   4 -
>  xen/include/public/hvm/hvm_op.h |  15 +---
>  xen/include/public/memory.h |   3 +
>  xen/include/xen/p2m-common.h|   3 +-
>  12 files changed, 115 insertions(+), 196 deletions(-)

For the part of the code in the files we're maintaining:

Acked-by: Razvan Cojocaru 

Thanks for doing this, as also discussed in private I think something
along these lines is a much needed change here.


Thanks,
Razvan

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Jan Beulich 
>>> On 27.01.16 at 21:06,  wrote:
> --- a/xen/include/public/hvm/hvm_op.h
> +++ b/xen/include/public/hvm/hvm_op.h
> @@ -431,18 +431,6 @@ struct xen_hvm_altp2m_view {
>  typedef struct xen_hvm_altp2m_view xen_hvm_altp2m_view_t;
>  DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_view_t);
>  
> -struct xen_hvm_altp2m_set_mem_access {
> -/* view */
> -uint16_t view;
> -/* Memory type */
> -uint16_t hvmmem_access; /* xenmem_access_t */
> -uint32_t pad;
> -/* gfn */
> -uint64_t gfn;
> -};
> -typedef struct xen_hvm_altp2m_set_mem_access xen_hvm_altp2m_set_mem_access_t;
> -DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_set_mem_access_t);

This is a guest visible interface, and hence can't be removed (nor
be replaced by a tools only one).

> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -423,11 +423,14 @@ struct xen_mem_access_op {
>  /* xenmem_access_t */
>  uint8_t access;
>  domid_t domid;
> +uint16_t altp2m_idx;

So this is a tools only interface, yes. But it's not versioned (other
than e.g. domctl and sysctl), so altering the interface structure is
at least fragile.

And then, with this ...

> --- a/xen/include/xen/p2m-common.h
> +++ b/xen/include/xen/p2m-common.h
> @@ -49,7 +49,8 @@ int unmap_mmio_regions(struct domain *d,
>   * If gfn == INVALID_GFN, sets the default access type.
>   */
>  long p2m_set_mem_access(struct domain *d, gfn_t gfn, uint32_t nr,
> -uint32_t start, uint32_t mask, xenmem_access_t 
> access);
> +uint32_t start, uint32_t mask, xenmem_access_t 
> access,
> +unsigned long altp2m_idx);

... why "unsigned long" instead of e.g. "unsigned int" here?

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Ian Campbell 
--- a/tools/libxc/include/xenctrl.h
> > +++ b/tools/libxc/include/xenctrl.h
> > @@ -2027,9 +2027,6 @@ int xc_altp2m_destroy_view(xc_interface *handle,
> > domid_t domid,
> >  /* Switch all vCPUs of the domain to the specified altp2m view */
> >  int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid,
> >   uint16_t view_id);
> > -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
> > - uint16_t view_id, xen_pfn_t gfn,
> > - xenmem_access_t access);
> 
> What is the support status of these APIs in libxc? Are they supposed to
> be stable now? Do you have opinion on making them stable interfaces?

Nothing in libxc is ever a stable interface. It is always completely fine
to change them if that is what is needed.

Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Wei Liu 
On Wed, Jan 27, 2016 at 01:06:40PM -0700, Tamas K Lengyel wrote:
> The altp2m subsystem in its current form uses its own HVMOP hypercall to set
> mem_access permissions, duplicating some of the code already present for
> setting regular mem_access permissions. In this patch we consolidate the two,
> deprecate the HVMOP hypercall and update the corresponding tools.
> 
> Signed-off-by: Tamas K Lengyel 
> Cc: Ian Jackson 
> Cc: Stefano Stabellini 
> Cc: Ian Campbell 
> Cc: Wei Liu 
> Cc: Razvan Cojocaru 
> Cc: Stefano Stabellini 
> Cc: Keir Fraser 
> Cc: Jan Beulich 
> Cc: Andrew Cooper 
> Cc: George Dunlap 
> ---
>  tools/libxc/include/xenctrl.h   |   5 +-
>  tools/libxc/xc_altp2m.c |  25 --
>  tools/libxc/xc_mem_access.c |  14 +--
>  tools/tests/xen-access/xen-access.c |  53 ---
>  xen/arch/arm/p2m.c  |   9 +-
>  xen/arch/x86/hvm/hvm.c  |   9 --
>  xen/arch/x86/mm/p2m.c   | 169 
> 
>  xen/common/mem_access.c |   2 +-
>  xen/include/asm-x86/p2m.h   |   4 -
>  xen/include/public/hvm/hvm_op.h |  15 +---
>  xen/include/public/memory.h |   3 +
>  xen/include/xen/p2m-common.h|   3 +-
>  12 files changed, 115 insertions(+), 196 deletions(-)
> 
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index e632b1e..b4e57d8 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -2027,9 +2027,6 @@ int xc_altp2m_destroy_view(xc_interface *handle, 
> domid_t domid,
>  /* Switch all vCPUs of the domain to the specified altp2m view */
>  int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid,
>   uint16_t view_id);
> -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
> - uint16_t view_id, xen_pfn_t gfn,
> - xenmem_access_t access);

What is the support status of these APIs in libxc? Are they supposed to
be stable now? Do you have opinion on making them stable interfaces?

If you consider them stable, you can't just remove it. Presumably you
can reimplement it as a wrapper to xc_set_mem_access if we decide to
keep it around.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Wei Liu 
On Thu, Jan 28, 2016 at 10:55:36AM +, Ian Campbell wrote:
> --- a/tools/libxc/include/xenctrl.h
> > > +++ b/tools/libxc/include/xenctrl.h
> > > @@ -2027,9 +2027,6 @@ int xc_altp2m_destroy_view(xc_interface *handle,
> > > domid_t domid,
> > >  /* Switch all vCPUs of the domain to the specified altp2m view */
> > >  int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid,
> > >   uint16_t view_id);
> > > -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
> > > - uint16_t view_id, xen_pfn_t gfn,
> > > - xenmem_access_t access);
> > 
> > What is the support status of these APIs in libxc? Are they supposed to
> > be stable now? Do you have opinion on making them stable interfaces?
> 
> Nothing in libxc is ever a stable interface. It is always completely fine
> to change them if that is what is needed.
> 

Right. Ignore the first question and this patch is ready to go in when
those nits are fixed.

It would still be nice if we can get a libmemaccess or some sort so that
people can build on top of it. Just curious if that's feasible.

Wei.

> Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Lengyel, Tamas 
On Jan 28, 2016 6:18 AM, "Jan Beulich"  wrote:
>
> >>> On 27.01.16 at 21:06,  wrote:
> > --- a/xen/include/public/hvm/hvm_op.h
> > +++ b/xen/include/public/hvm/hvm_op.h
> > @@ -431,18 +431,6 @@ struct xen_hvm_altp2m_view {
> >  typedef struct xen_hvm_altp2m_view xen_hvm_altp2m_view_t;
> >  DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_view_t);
> >
> > -struct xen_hvm_altp2m_set_mem_access {
> > -/* view */
> > -uint16_t view;
> > -/* Memory type */
> > -uint16_t hvmmem_access; /* xenmem_access_t */
> > -uint32_t pad;
> > -/* gfn */
> > -uint64_t gfn;
> > -};
> > -typedef struct xen_hvm_altp2m_set_mem_access
xen_hvm_altp2m_set_mem_access_t;
> > -DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_set_mem_access_t);
>
> This is a guest visible interface, and hence can't be removed (nor
> be replaced by a tools only one).

What is your suggestion?

>
> > --- a/xen/include/public/memory.h
> > +++ b/xen/include/public/memory.h
> > @@ -423,11 +423,14 @@ struct xen_mem_access_op {
> >  /* xenmem_access_t */
> >  uint8_t access;
> >  domid_t domid;
> > +uint16_t altp2m_idx;
>
> So this is a tools only interface, yes. But it's not versioned (other
> than e.g. domctl and sysctl), so altering the interface structure is
> at least fragile.
>
> And then, with this ...
>
> > --- a/xen/include/xen/p2m-common.h
> > +++ b/xen/include/xen/p2m-common.h
> > @@ -49,7 +49,8 @@ int unmap_mmio_regions(struct domain *d,
> >   * If gfn == INVALID_GFN, sets the default access type.
> >   */
> >  long p2m_set_mem_access(struct domain *d, gfn_t gfn, uint32_t nr,
> > -uint32_t start, uint32_t mask, xenmem_access_t
access);
> > +uint32_t start, uint32_t mask, xenmem_access_t
access,
> > +unsigned long altp2m_idx);
>
> ... why "unsigned long" instead of e.g. "unsigned int" here?
>

These were used interchangebly in the code, I've just picked on. The max
value it can legitimetly have is 10 so there is not much difference in
going with int instead of long.

Tamas
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Wei Liu 
On Thu, Jan 28, 2016 at 07:30:31AM -0700, Lengyel, Tamas wrote:
> On Jan 28, 2016 4:00 AM, "Wei Liu"  wrote:
> >
> > On Thu, Jan 28, 2016 at 10:55:36AM +, Ian Campbell wrote:
> > > --- a/tools/libxc/include/xenctrl.h
> > > > > +++ b/tools/libxc/include/xenctrl.h
> > > > > @@ -2027,9 +2027,6 @@ int xc_altp2m_destroy_view(xc_interface
> *handle,
> > > > > domid_t domid,
> > > > >  /* Switch all vCPUs of the domain to the specified altp2m view */
> > > > >  int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid,
> > > > >   uint16_t view_id);
> > > > > -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
> > > > > - uint16_t view_id, xen_pfn_t gfn,
> > > > > - xenmem_access_t access);
> > > >
> > > > What is the support status of these APIs in libxc? Are they supposed
> to
> > > > be stable now? Do you have opinion on making them stable interfaces?
> > >
> > > Nothing in libxc is ever a stable interface. It is always completely
> fine
> > > to change them if that is what is needed.
> > >
> >
> > Right. Ignore the first question and this patch is ready to go in when
> > those nits are fixed.
> >
> > It would still be nice if we can get a libmemaccess or some sort so that
> > people can build on top of it. Just curious if that's feasible.
> >
> > Wei.
> 
> There is LibVMI and Bitdefender also released its library so there are
> choices if folks find libxc too volatile.

Thanks, this makes sense.

Wei.

> 
> Tamas

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Jan Beulich 
>>> On 28.01.16 at 15:34,  wrote:
> On Jan 28, 2016 6:18 AM, "Jan Beulich"  wrote:
>>
>> >>> On 27.01.16 at 21:06,  wrote:
>> > --- a/xen/include/public/hvm/hvm_op.h
>> > +++ b/xen/include/public/hvm/hvm_op.h
>> > @@ -431,18 +431,6 @@ struct xen_hvm_altp2m_view {
>> >  typedef struct xen_hvm_altp2m_view xen_hvm_altp2m_view_t;
>> >  DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_view_t);
>> >
>> > -struct xen_hvm_altp2m_set_mem_access {
>> > -/* view */
>> > -uint16_t view;
>> > -/* Memory type */
>> > -uint16_t hvmmem_access; /* xenmem_access_t */
>> > -uint32_t pad;
>> > -/* gfn */
>> > -uint64_t gfn;
>> > -};
>> > -typedef struct xen_hvm_altp2m_set_mem_access 
>> > xen_hvm_altp2m_set_mem_access_t;
>> > -DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_set_mem_access_t);
>>
>> This is a guest visible interface, and hence can't be removed (nor
>> be replaced by a tools only one).
> 
> What is your suggestion?

At the very least keep the old interface, perhaps backed by the
new implementation.

>> > --- a/xen/include/public/memory.h
>> > +++ b/xen/include/public/memory.h
>> > @@ -423,11 +423,14 @@ struct xen_mem_access_op {
>> >  /* xenmem_access_t */
>> >  uint8_t access;
>> >  domid_t domid;
>> > +uint16_t altp2m_idx;
>>
>> So this is a tools only interface, yes. But it's not versioned (other
>> than e.g. domctl and sysctl), so altering the interface structure is
>> at least fragile.
>>
>> And then, with this ...
>>
>> > --- a/xen/include/xen/p2m-common.h
>> > +++ b/xen/include/xen/p2m-common.h
>> > @@ -49,7 +49,8 @@ int unmap_mmio_regions(struct domain *d,
>> >   * If gfn == INVALID_GFN, sets the default access type.
>> >   */
>> >  long p2m_set_mem_access(struct domain *d, gfn_t gfn, uint32_t nr,
>> > -uint32_t start, uint32_t mask, xenmem_access_t 
>> > access);
>> > +uint32_t start, uint32_t mask, xenmem_access_t 
>> > access,
>> > +unsigned long altp2m_idx);
>>
>> ... why "unsigned long" instead of e.g. "unsigned int" here?
> 
> These were used interchangebly in the code, I've just picked on. The max
> value it can legitimetly have is 10 so there is not much difference in
> going with int instead of long.

Since "int" is slightly less expensive to operate on, please use it
whenever possible.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-28 Thread Lengyel, Tamas 
On Jan 28, 2016 4:00 AM, "Wei Liu"  wrote:
>
> On Thu, Jan 28, 2016 at 10:55:36AM +, Ian Campbell wrote:
> > --- a/tools/libxc/include/xenctrl.h
> > > > +++ b/tools/libxc/include/xenctrl.h
> > > > @@ -2027,9 +2027,6 @@ int xc_altp2m_destroy_view(xc_interface
*handle,
> > > > domid_t domid,
> > > >  /* Switch all vCPUs of the domain to the specified altp2m view */
> > > >  int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid,
> > > >   uint16_t view_id);
> > > > -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
> > > > - uint16_t view_id, xen_pfn_t gfn,
> > > > - xenmem_access_t access);
> > >
> > > What is the support status of these APIs in libxc? Are they supposed
to
> > > be stable now? Do you have opinion on making them stable interfaces?
> >
> > Nothing in libxc is ever a stable interface. It is always completely
fine
> > to change them if that is what is needed.
> >
>
> Right. Ignore the first question and this patch is ready to go in when
> those nits are fixed.
>
> It would still be nice if we can get a libmemaccess or some sort so that
> people can build on top of it. Just curious if that's feasible.
>
> Wei.

There is LibVMI and Bitdefender also released its library so there are
choices if folks find libxc too volatile.

Tamas
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

2016-01-27 Thread Tamas K Lengyel 
The altp2m subsystem in its current form uses its own HVMOP hypercall to set
mem_access permissions, duplicating some of the code already present for
setting regular mem_access permissions. In this patch we consolidate the two,
deprecate the HVMOP hypercall and update the corresponding tools.

Signed-off-by: Tamas K Lengyel 
Cc: Ian Jackson 
Cc: Stefano Stabellini 
Cc: Ian Campbell 
Cc: Wei Liu 
Cc: Razvan Cojocaru 
Cc: Stefano Stabellini 
Cc: Keir Fraser 
Cc: Jan Beulich 
Cc: Andrew Cooper 
Cc: George Dunlap 
---
 tools/libxc/include/xenctrl.h   |   5 +-
 tools/libxc/xc_altp2m.c |  25 --
 tools/libxc/xc_mem_access.c |  14 +--
 tools/tests/xen-access/xen-access.c |  53 ---
 xen/arch/arm/p2m.c  |   9 +-
 xen/arch/x86/hvm/hvm.c  |   9 --
 xen/arch/x86/mm/p2m.c   | 169 
 xen/common/mem_access.c |   2 +-
 xen/include/asm-x86/p2m.h   |   4 -
 xen/include/public/hvm/hvm_op.h |  15 +---
 xen/include/public/memory.h |   3 +
 xen/include/xen/p2m-common.h|   3 +-
 12 files changed, 115 insertions(+), 196 deletions(-)

diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
index e632b1e..b4e57d8 100644
--- a/tools/libxc/include/xenctrl.h
+++ b/tools/libxc/include/xenctrl.h
@@ -2027,9 +2027,6 @@ int xc_altp2m_destroy_view(xc_interface *handle, domid_t 
domid,
 /* Switch all vCPUs of the domain to the specified altp2m view */
 int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid,
  uint16_t view_id);
-int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
- uint16_t view_id, xen_pfn_t gfn,
- xenmem_access_t access);
 int xc_altp2m_change_gfn(xc_interface *handle, domid_t domid,
  uint16_t view_id, xen_pfn_t old_gfn,
  xen_pfn_t new_gfn);
@@ -2062,7 +2059,7 @@ int xc_mem_paging_load(xc_interface *xch, domid_t 
domain_id,
  */
 int xc_set_mem_access(xc_interface *xch, domid_t domain_id,
   xenmem_access_t access, uint64_t first_pfn,
-  uint32_t nr);
+  uint32_t nr, uint16_t altp2m_idx);
 
 /*
  * Gets the mem access for the given page (returned in access on success)
diff --git a/tools/libxc/xc_altp2m.c b/tools/libxc/xc_altp2m.c
index 0639632..4f44a7b 100644
--- a/tools/libxc/xc_altp2m.c
+++ b/tools/libxc/xc_altp2m.c
@@ -163,31 +163,6 @@ int xc_altp2m_switch_to_view(xc_interface *handle, domid_t 
domid,
 return rc;
 }
 
-int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
- uint16_t view_id, xen_pfn_t gfn,
- xenmem_access_t access)
-{
-int rc;
-DECLARE_HYPERCALL_BUFFER(xen_hvm_altp2m_op_t, arg);
-
-arg = xc_hypercall_buffer_alloc(handle, arg, sizeof(*arg));
-if ( arg == NULL )
-return -1;
-
-arg->version = HVMOP_ALTP2M_INTERFACE_VERSION;
-arg->cmd = HVMOP_altp2m_set_mem_access;
-arg->domain = domid;
-arg->u.set_mem_access.view = view_id;
-arg->u.set_mem_access.hvmmem_access = access;
-arg->u.set_mem_access.gfn = gfn;
-
-rc = xencall2(handle->xcall, __HYPERVISOR_hvm_op, HVMOP_altp2m,
- HYPERCALL_BUFFER_AS_ARG(arg));
-
-xc_hypercall_buffer_free(handle, arg);
-return rc;
-}
-
 int xc_altp2m_change_gfn(xc_interface *handle, domid_t domid,
  uint16_t view_id, xen_pfn_t old_gfn,
  xen_pfn_t new_gfn)
diff --git a/tools/libxc/xc_mem_access.c b/tools/libxc/xc_mem_access.c
index 3634c39..d6fb409 100644
--- a/tools/libxc/xc_mem_access.c
+++ b/tools/libxc/xc_mem_access.c
@@ -27,15 +27,17 @@ int xc_set_mem_access(xc_interface *xch,
   domid_t domain_id,
   xenmem_access_t access,
   uint64_t first_pfn,
-  uint32_t nr)
+  uint32_t nr,
+  uint16_t altp2m_idx)
 {
 xen_mem_access_op_t mao =
 {
-.op = XENMEM_access_op_set_access,
-.domid  = domain_id,
-.access = access,
-.pfn= first_pfn,
-.nr = nr
+.op = XENMEM_access_op_set_access,
+.domid  = domain_id,
+.access = access,
+.pfn= first_pfn,
+.nr = nr,
+.altp2m_idx = altp2m_idx
 };
 
 return do_memory_op(xch, XENMEM_access_op, , sizeof(mao));
diff --git a/tools/tests/xen-access/xen-access.c 
b/tools/tests/xen-access/xen-access.c
index 7993947..2300e9a 100644
---