Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

[Ian Jackson]

Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of 
usbdev_busaddr_to_busid"):
> On 4/8/2016 at 01:04 AM, in message
> <22278.37677.975595.101...@mariner.uk.xensource.com>, Ian Jackson
>  wrote: 
> > Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of  
> > usbdev_busaddr_to_busid"): 
> > > Thanks, Ian! 
> >  
> > Should I take that as a Reviewed-by ? 
> 
> Ah, yes. Acked. :-)

Thanks, queued.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

[Chun Yan Liu]

>>> On 4/8/2016 at 01:04 AM, in message
<22278.37677.975595.101...@mariner.uk.xensource.com>, Ian Jackson
 wrote: 
> Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of  
> usbdev_busaddr_to_busid"): 
> > Thanks, Ian! 
>  
> Should I take that as a Reviewed-by ? 

Ah, yes. Acked. :-)

Chunyan

>  
> Thanks, 
> Ian. 
>  
>  



___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

[Ian Jackson]

Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of 
usbdev_busaddr_to_busid"):
> Thanks, Ian!

Should I take that as a Reviewed-by ?

Thanks,
Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

[Chun Yan Liu]

Thanks, Ian!

>>> On 4/4/2016 at 11:09 PM, in message
<1459782600-16073-1-git-send-email-ian.jack...@eu.citrix.com>, Ian Jackson
 wrote: 
> We must set rc before using `goto out'. 
>  
> Bug introduced in bf7628f0 "libxl: add pvusb API". 
>  
> CID: 1358113 
> Signed-off-by: Ian Jackson  
> CC: cover...@xenproject.org 
> CC: Simon Cao  
> CC: George Dunlap  
> CC: Chunyan Liu  
> --- 
>  tools/libxl/libxl_pvusb.c |1 + 
>  1 file changed, 1 insertion(+) 
>  
> diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c 
> index 5f92628..6f53317 100644 
> --- a/tools/libxl/libxl_pvusb.c 
> +++ b/tools/libxl/libxl_pvusb.c 
> @@ -905,6 +905,7 @@ static int libxl__device_usbdev_add_xenstore(libxl__gc  
> *gc, uint32_t domid, 
>  usbdev->u.hostdev.hostaddr); 
>  if (!busid) { 
>  LOG(DEBUG, "Fail to get busid of usb device"); 
> +rc = ERROR_FAIL; 
>  goto out; 
>  } 
>   
 



___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

[Ian Jackson]

We must set rc before using `goto out'.

Bug introduced in bf7628f0 "libxl: add pvusb API".

CID: 1358113
Signed-off-by: Ian Jackson 
CC: cover...@xenproject.org
CC: Simon Cao 
CC: George Dunlap 
CC: Chunyan Liu 
---
 tools/libxl/libxl_pvusb.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c
index 5f92628..6f53317 100644
--- a/tools/libxl/libxl_pvusb.c
+++ b/tools/libxl/libxl_pvusb.c
@@ -905,6 +905,7 @@ static int libxl__device_usbdev_add_xenstore(libxl__gc *gc, 
uint32_t domid,
 usbdev->u.hostdev.hostaddr);
 if (!busid) {
 LOG(DEBUG, "Fail to get busid of usb device");
+rc = ERROR_FAIL;
 goto out;
 }
 
-- 
1.7.10.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel