Re: [Xen-devel] [PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[Doug Goldstein]

On 8/19/16 11:54 AM, Andrew Cooper wrote:
> Most of the comments are duplicated from the help text, and those without help
> provide no useful additional input.
> 
> Signed-off-by: Andrew Cooper 
> ---
> CC: Doug Goldstein 
> CC: Jan Beulich 
> CC: Stefano Stabellini 
> CC: Julien Grall 

Reviewed-by: Doug Goldstein 


-- 
Doug Goldstein



signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[Julien Grall]

Hi,

On 19/08/16 16:54, Andrew Cooper wrote:

Most of the comments are duplicated from the help text, and those without help
provide no useful additional input.

Signed-off-by: Andrew Cooper 
---
CC: Doug Goldstein 
CC: Jan Beulich 
CC: Stefano Stabellini 
CC: Julien Grall 


For ARM bits:

Acked-by: Julien Grall 

Regards,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[Jan Beulich]

>>> On 19.08.16 at 17:54,  wrote:
> Most of the comments are duplicated from the help text, and those without help
> provide no useful additional input.
> 
> Signed-off-by: Andrew Cooper 

Non-ARM parts
Acked-by: Jan Beulich 

albeit being known to rather comment too little I think that shouldn't
be taken to count too much, i.e. waiting for some further one would
probably not be a bad idea.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[Andrew Cooper]

Most of the comments are duplicated from the help text, and those without help
provide no useful additional input.

Signed-off-by: Andrew Cooper 
---
CC: Doug Goldstein 
CC: Jan Beulich 
CC: Stefano Stabellini 
CC: Julien Grall 
---
 xen/arch/arm/Kconfig|  3 ---
 xen/common/Kconfig  | 14 --
 xen/drivers/acpi/Kconfig|  1 -
 xen/drivers/char/Kconfig|  7 ---
 xen/drivers/cpufreq/Kconfig |  1 -
 xen/drivers/passthrough/Kconfig |  1 -
 xen/drivers/pci/Kconfig |  1 -
 xen/drivers/video/Kconfig   |  3 ---
 8 files changed, 31 deletions(-)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 871c243..797c91f 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -1,4 +1,3 @@
-# Select 32 or 64 bit
 config 64BIT
bool
default ARCH != "arm32"
@@ -43,11 +42,9 @@ config ACPI
  Advanced Configuration and Power Interface (ACPI) support for Xen is
  an alternative to device tree on ARM64.
 
-# Select HAS_GICV3 if GICv3 is supported
 config HAS_GICV3
bool
 
-# Select ALTERNATIVE if the architecture supports runtime patching
 config ALTERNATIVE
bool
 
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index befa30e..b2d3d61 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -11,31 +11,24 @@ config COMPAT
 config CORE_PARKING
bool
 
-# Select HAS_DEVICE_TREE if device tree is supported
 config HAS_DEVICE_TREE
bool
 
-# Select HAS_MEM_ACCESS if mem access is supported
 config HAS_MEM_ACCESS
bool
 
-# Select HAS_MEM_PAGING if mem paging is supported
 config HAS_MEM_PAGING
bool
 
-# Select HAS_MEM_SHARING if mem sharing is supported
 config HAS_MEM_SHARING
bool
 
-# Select HAS_PDX if PDX is supported
 config HAS_PDX
bool
 
-# Select HAS_KEXEC if kexec is supported
 config HAS_KEXEC
bool
 
-# Select HAS_GDBSX if GDBSX is supported
 config HAS_GDBSX
bool
 
@@ -50,7 +43,6 @@ config HAS_CHECKPOLICY
string
option env="XEN_HAS_CHECKPOLICY"
 
-# Enable/Disable kexec support
 config KEXEC
bool "kexec support"
default y
@@ -62,7 +54,6 @@ config KEXEC
 
  If unsure, say Y.
 
-# Allows "late" initialization of the hardware domain
 config LATE_HWDOM
bool "dedicated hardware domain"
default n
@@ -83,7 +74,6 @@ config LATE_HWDOM
 
  If unsure, say N.
 
-# Enables transcendent memory support
 config TMEM
def_bool y
prompt "Transcendent Memory Support" if EXPERT = "y"
@@ -97,7 +87,6 @@ config TMEM
 
  If unsure, say Y.
 
-# Adds support for Xenoprof
 config XENOPROF
def_bool y
prompt "Xen Oprofile Support" if EXPERT = "y"
@@ -110,7 +99,6 @@ config XENOPROF
 
  If unsure, say Y.
 
-# Enable/Disable XSM support
 config XSM
bool "Xen Security Modules support"
default n
@@ -163,7 +151,6 @@ config XSM_POLICY
 
  If unsure, say Y.
 
-# Enable schedulers
 menu "Schedulers"
visible if EXPERT = "y"
 
@@ -221,7 +208,6 @@ endmenu
 config CRYPTO
bool
 
-# Enable/Disable live patching support
 config LIVEPATCH
bool "Live patching support (TECH PREVIEW)"
default n
diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig
index 1074dbf..b64d373 100644
--- a/xen/drivers/acpi/Kconfig
+++ b/xen/drivers/acpi/Kconfig
@@ -1,5 +1,4 @@
 
-# Select ACPI if ACPI is supported
 config ACPI
bool
 
diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index 08973cf..51343d0 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -1,11 +1,9 @@
-#  16550-series UART support
 config HAS_NS16550
bool
default y
help
  This selects the 16550-series UART support. For most systems, say Y.
 
-# Xilinx Zynq Cadence UART support
 config HAS_CADENCE_UART
bool
default y
@@ -14,7 +12,6 @@ config HAS_CADENCE_UART
  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
  based board, say Y.
 
-# ARM AMBA PL011 UART support
 config HAS_PL011
bool
default y
@@ -23,7 +20,6 @@ config HAS_PL011
  This selects the ARM(R) AMBA(R) PrimeCell PL011 UART. If you have
  an Integrator/PP2, Integrator/CP or Versatile platform, say Y.
 
-# Samsung Exynos 4210 UART support
 config HAS_EXYNOS4210
bool
default y
@@ -32,7 +28,6 @@ config HAS_EXYNOS4210
  This selects the Samsung Exynos 4210 UART. If you have a Samsung
  Exynos based board, say Y.
 
-# OMAP UART support
 config HAS_OMAP
bool
default y
@@ -41,7 +36,6 @@ config HAS_OMAP
  This selects the Texas Instruments OMAP UART. If you have a Texas
  Instruments based CPU, say Y.
 
-# SuperH SCI(F) UART support
 config HAS_SCIF
bool
default